[security] Introducing signing support to MySensors

Anticimex

@alexsh1 the log still looks like you sometimes don't get the nonce you requested so signing times out and fails. I am still quite sure that if you looked in the log on the other side, it would show NACKs on some nonce transmissions. Signing won't work when those fail.

alexsh1

@Anticimex This is what we discussed before, this is not a signing issue. Guess what? I did notice that RF is much better with non-amplified nrf24l01+. Given my experience in the past with nrf24l01+ pa+lna, I have just soldered out and replaced AMS1117-3.3V (Mega 2560 works on 5V so I need a stable 3.3V source, which I cannot take from Mega's 3.3V pin for a hungry nrf24l01+pa+lna) and signing started working!

0 MCO:BGN:INIT NODE,CP=RNNNAS-,VER=2.1.1
4 TSM:INIT
4 TSF:WUR:MS=0
12 TSM:INIT:TSP OK
14 TSM:INIT:STATID=15
16 TSF:SID:OK,ID=15
18 TSM:FPAR
20 Will not sign message for destination 255 as it does not require it
63 TSF:MSG:SEND,15-15-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
1026 TSF:MSG:READ,0-0-15,s=255,c=3,t=8,pt=1,l=1,sg=0:0
1032 Skipping security for command 3 type 8
1038 TSF:MSG:FPAR OK,ID=0,D=1
2070 TSM:FPAR:OK
2070 TSM:ID
2072 TSM:ID:OK
2074 TSM:UPL
2076 Skipping security for command 3 type 24
2082 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=24,pt=1,l=1,sg=0,ft=0,st=OK:1
2111 TSF:MSG:READ,0-0-15,s=255,c=3,t=25,pt=1,l=1,sg=0:1
2117 Skipping security for command 3 type 25
2121 TSF:MSG:PONG RECV,HP=1
2123 TSM:UPL:OK
2125 TSM:READY:ID=15,PAR=0,DIS=1
2129 Signing required
2131 Skipping security for command 3 type 15
2140 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=15,pt=6,l=2,sg=0,ft=0,st=OK:0101
2148 Waiting for GW to send signing preferences...
2181 TSF:MSG:READ,0-0-15,s=255,c=3,t=15,pt=6,l=2,sg=0:0101
2187 Skipping security for command 3 type 15
2191 Mark node 0 as one that require signed messages
2197 Mark node 0 as one that do not require whitelisting
2203 Skipping security for command 3 type 16
2211 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=16,pt=0,l=0,sg=0,ft=0,st=OK:
2220 Nonce requested from 0. Waiting...
2275 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=0:BC9F06296E185623C02C586CECB3CBA37A7AD097699C918CB1
2287 Skipping security for command 3 type 17
2291 Nonce received from 0.
2295 Proceeding with signing...
Message to process: 0F002E0011FF322E312E31
Current nonce: BC9F06296E185623C02C586CECB3CBA37A7AD097699C918CB1AAAAAAAAAAAAAA
HMAC: D96C3B9964666D36495BBAF4E6C4E414088A553065E8CCA764CD8DF65D6353CA
Signature in message: 016C3B9964666D36495BBAF4E6C4E414088A5530
2469 Message signed
2478 Message to send has been signed
2486 TSF:MSG:SEND,15-15-0-0,s=255,c=0,t=17,pt=0,l=5,sg=1,ft=0,st=OK:2.1.1
2494 Skipping security for command 3 type 16
2502 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
2510 Nonce requested from 0. Waiting...
2643 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:556C16AFC48CBCC8758A6D0BA0CA9920BAAFB13290AC599CC1
2656 Skipping security for command 3 type 17
2660 Nonce received from 0.
2662 Proceeding with signing...
Message to process: 0F000E2306FF00
Current nonce: 556C16AFC48CBCC8758A6D0BA0CA9920BAAFB13290AC599CC1AAAAAAAAAAAAAA
HMAC: 598965B2F76BF9805E79A23C9CDBEA71A5F0B5749D4E2FA44C3DEDDAD21B3238
Signature in message: 018965B2F76BF9805E79A23C9CDBEA71A5F0B5749D4E2FA4
2838 Message signed
2844 Message to send has been signed
2854 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=6,pt=1,l=1,sg=1,ft=0,st=OK:0
3801 TSF:MSG:READ,0-0-15,s=255,c=3,t=16,pt=0,l=0,sg=1:
3807 Skipping security for command 3 type 16
SHA256: 46DEE622257BDFA07B804BA9C02440CC083DC010C7A609123900000000000000
3842 Skipping security for command 3 type 17
3858 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=17,pt=6,l=25,sg=1,ft=0,st=OK:46DEE622257BDFA07B804BA9C02440CC083DC010C7A6091239
3870 Transmitted nonce
4012 TSF:MSG:READ,0-0-15,s=255,c=3,t=6,pt=0,l=1,sg=1:M
Signature in message: 018AF802A7325E4D37B322FA8B0F4BA61CA5DF6548CEE589
Message to process: 000F0E0306FF4D
Current nonce: 46DEE622257BDFA07B804BA9C02440CC083DC010C7A6091239AAAAAAAAAAAAAA
HMAC: DA8AF802A7325E4D37B322FA8B0F4BA61CA5DF6548CEE58953ADF17286D22669
4190 Skipping security for command 3 type 16
4202 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
4208 Nonce requested from 0. Waiting...
4255 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:90818AAA44B6AFD7880153E7AA7E981981744CC98028809A09
4265 Skipping security for command 3 type 17
4272 Nonce received from 0.
4274 Proceeding with signing...
Message to process: 0F00B6030BFF424D503238302050726573737572652053656E736F72
Current nonce: 90818AAA44B6AFD7880153E7AA7E981981744CC98028809A09AAAAAAAAAAAAAA
HMAC: 486FAFD76801F66D900E883F2C012B7104EE043ABC68E0AE894D0026E9D7A8AB
Signature in message: 016FAF
4448 Message signed
4456 Message to send has been signed
4466 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=11,pt=0,l=22,sg=1,ft=0,st=OK:BMP280 Pressure Sensor
4476 Skipping security for command 3 type 16
4483 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
4491 Nonce requested from 0. Waiting...
4642 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:A3B017C2562256E455C640C28667B9BB3D3062687A5C49160C
4655 Skipping security for command 3 type 17
4659 Nonce received from 0.
4661 Proceeding with signing...
Message to process: 0F001E030CFF312E31
Current nonce: A3B017C2562256E455C640C28667B9BB3D3062687A5C49160CAAAAAAAAAAAAAA
HMAC: F27274FF114AE80AE6217C1B2B80A322AB82697AF3BFBE59BC53069948AA234A
Signature in message: 017274FF114AE80AE6217C1B2B80A322AB82697AF3BF
4837 Message signed
4843 Message to send has been signed
4853 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=12,pt=0,l=3,sg=1,ft=0,st=OK:1.1
4861 Skipping security for command 3 type 16
4868 TSF:MSG:SEND,15-15-0-0,s=0,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
4876 Nonce requested from 0. Waiting...
9881 Timeout waiting for nonce!
9883 !TSF:MSG:SIGN FAIL
9885 Skipping security for command 3 type 16
9895 TSF:MSG:SEND,15-15-0-0,s=1,c=3,t=16,pt=0,l=0,sg=1,ft=1,st=OK:
9904 Nonce requested from 0. Waiting...
9957 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:B91AB74E50528ACC3F64B480A47D6CEB269E2EA48004C57A7F
9967 Skipping security for command 3 type 17
9971 Nonce received from 0.
9975 Proceeding with signing...
Message to process: 0F0006000601
Current nonce: B91AB74E50528ACC3F64B480A47D6CEB269E2EA48004C57A7FAAAAAAAAAAAAAA
HMAC: A95DB25F392535043F3DEA960F6C2136115A29AF51F6B11D4E0BFFB7ABE9946E
Signature in message: 015DB25F392535043F3DEA960F6C2136115A29AF51F6B11D4E
10149 Message signed
10158 Message to send has been signed
10168 TSF:MSG:SEND,15-15-0-0,s=1,c=0,t=6,pt=0,l=0,sg=1,ft=0,st=OK:
10174 Skipping security for command 3 type 16
10182 TSF:MSG:SEND,15-15-0-0,s=2,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
10188 Nonce requested from 0. Waiting...
15194 Message to send could not be signed!
15198 !TSF:MSG:SIGN FAIL
15200 MCO:REG:REQ
15202 Skipping security for command 3 type 26
15212 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=26,pt=1,l=1,sg=1,ft=1,st=OK:2
15230 TSF:MSG:READ,0-0-15,s=255,c=3,t=16,pt=0,l=0,sg=1:
15237 Skipping security for command 3 type 16
SHA256: 6F1E9148E2B8755A2B5019D803BBE9E531F1B5507406B58820AAAAAAAAAAAAAA
15271 Skipping security for command 3 type 17
15286 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=17,pt=6,l=25,sg=1,ft=0,st=OK:6F1E9148E2B8755A2B5019D803BBE9E531F1B5507406B58820
15298 Transmitted nonce
15429 TSF:MSG:READ,0-0-15,s=255,c=3,t=27,pt=1,l=1,sg=1:1
Signature in message: 01B4B105F62283F53943B57B3B2B034B44DA23B4D71C97A1
Message to process: 000F0E231BFF01
Current nonce: 6F1E9148E2B8755A2B5019D803BBE9E531F1B5507406B58820AAAAAAAAAAAAAA
HMAC: B3B4B105F62283F53943B57B3B2B034B44DA23B4D71C97A14CE49895135B98FA
15607 MCO:PIM:NODE REG=1
15613 MCO:BGN:STP
Pressure Sensor BMP280 1.1
isMetric: 1
15628 Skipping security for command 3 type 16
15638 TSF:MSG:SEND,15-15-0-0,s=2,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
15646 Nonce requested from 0. Waiting...
15683 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:4EDBAA807BB751EFD72E54A450E8B76C3B45D503270FF3C9C6
15693 Skipping security for command 3 type 17
15699 Nonce received from 0.
15702 Proceeding with signing...
Message to process: 0F002EE1260285EB514002
Current nonce: 4EDBAA807BB751EFD72E54A450E8B76C3B45D503270FF3C9C6AAAAAAAAAAAAAA
HMAC: 66D0E5314979BE6AC80387B12A6A8CF79AAB4C325F64A6762176D35C4E36C369
Signature in message: 01D0E5314979BE6AC80387B12A6A8CF79AAB4C32
15878 Message signed
15884 Message to send has been signed
15894 TSF:MSG:SEND,15-15-0-0,s=2,c=1,t=38,pt=7,l=5,sg=1,ft=0,st=OK:3.28
15902 Skipping security for command 3 type 16
15910 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
15919 Nonce requested from 0. Waiting...
16048 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:7E290F0590861636DF52F69D21796856F958F03E7956953C8D
16060 Skipping security for command 3 type 17
16064 Nonce received from 0.
16068 Proceeding with signing...
Message to process: 0F000E2300FF69
Current nonce: 7E290F0590861636DF52F69D21796856F958F03E7956953C8DAAAAAAAAAAAAAA
HMAC: 164ABE25D777EE3EA65F536ADE147D60B404561D07A26CA156E25EBB234507E0
Signature in message: 014ABE25D777EE3EA65F536ADE147D60B404561D07A26CA1
16242 Message signed
16250 Message to send has been signed
16261 TSF:MSG:SEND,15-15-0-0,s=255,c=3,t=0,pt=1,l=1,sg=1,ft=0,st=OK:105
16269 MCO:BGN:INIT OK,TSP=1
Temperature = 24.96 *C
Pressure = 997.80 mBar
Forecast = unknown
16277 Skipping security for command 3 type 16
16287 TSF:MSG:SEND,15-15-0-0,s=1,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
16295 Nonce requested from 0. Waiting...
16410 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:E4C3BDA88C3EFFD0A435849C1199E79C9D2B215FA1D05A7E76
16422 Skipping security for command 3 type 17
16427 Nonce received from 0.
16431 Proceeding with signing...
Message to process: 0F002EE1000114AEC74101
Current nonce: E4C3BDA88C3EFFD0A435849C1199E79C9D2B215FA1D05A7E76AAAAAAAAAAAAAA
HMAC: 144BFD3C6A7CBE0DC1CCEEC102FDA3E3A15C1A5A22BA604A5F5CAEE2F682BE37
Signature in message: 014BFD3C6A7CBE0DC1CCEEC102FDA3E3A15C1A5A
16605 Message signed
16613 Message to send has been signed
16623 TSF:MSG:SEND,15-15-0-0,s=1,c=1,t=0,pt=7,l=5,sg=1,ft=0,st=OK:25.0
16631 Skipping security for command 3 type 16
16637 TSF:MSG:SEND,15-15-0-0,s=0,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
16646 Nonce requested from 0. Waiting...
16766 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:0E091DD4985125377E63651907B9830D4D7265831F17FD65FE
16779 Skipping security for command 3 type 17
16783 Nonce received from 0.
16787 Proceeding with signing...
Message to process: 0F002EE104002973794400
Current nonce: 0E091DD4985125377E63651907B9830D4D7265831F17FD65FEAAAAAAAAAAAAAA
HMAC: A157ECB56A03D70529E1F9A26D972AF3EB1332FB20E2A3CDD909D5A8B9F7A8C4
Signature in message: 0157ECB56A03D70529E1F9A26D972AF3EB1332FB
16961 Message signed
16969 Message to send has been signed
16975 TSF:MSG:SEND,15-15-0-0,s=0,c=1,t=4,pt=7,l=5,sg=1,ft=0,st=OK:998
16984 Skipping security for command 3 type 16
16992 TSF:MSG:SEND,15-15-0-0,s=0,c=3,t=16,pt=0,l=0,sg=1,ft=0,st=OK:
16998 Nonce requested from 0. Waiting...
17129 TSF:MSG:READ,0-0-15,s=255,c=3,t=17,pt=6,l=25,sg=1:E7504291BD4FE363A66BD9A571064AFEB381F5282651DB1040
17141 Skipping security for command 3 type 17
17145 Nonce received from 0.
17149 Proceeding with signing...
Message to process: 0F003E010500756E6B6E6F776E
Current nonce: E7504291BD4FE363A66BD9A571064AFEB381F5282651DB1040AAAAAAAAAAAAAA
HMAC: 9E56ED49FE4589E4F61D7A954CF433334527DB1D8BC515183834201570327BF5
Signature in message: 0156ED49FE4589E4F61D7A954CF433334527
17324 Message signed
17332 Message to send has been signed
17342 TSF:MSG:SEND,15-15-0-0,s=0,c=1,t=5,pt=0,l=7,sg=1,ft=0,st=OK:unknown
17448 MCO:SLP:MS=300000,SMS=0,I1=255,M1=255,I2=255,M2=255
17455 MCO:SLP:TPD

This is the second time I change AMS1117 in one year. Very odd
Anyway, very much appreciate your help on signing! Very helpful

Anticimex

@alexsh1 glad you got it working again :)

alexsh1

@Anticimex Last time, I took me moths to resolve it. AMS1117 has not failed completely, but was working intermittently. This had a major impact on how nrf24l01+pa+lna was working. Unfortunately, range and signing were affected.
My theory is that it is getting probably 45-50C in my GW - there are many wires and it is a very tight fit. This may contribute in such AMS1117 behavior. Or probably just a bad batch.

Anticimex

@alexsh1 sounds like it. I've always considered the AMS1117 to be a trustworthy part.

alexsh1

@Anticimex it seems that replacing AMS1117 has resolved the issue.

I have a poor reception in one particular place and was thinking about a repeater node. Is signing working fine with the repeater node (both the node and the repeater are going to force signing by "MY_SIGNING_REQUEST_SIGNATURES"? Just curious

Anticimex

@alexsh1 repeaters support signing even if it isn't enabled on the repeater. It simply forwards the message and signature (and nonce).
Glad you resolved the issue :+1:

alexsh1

@Anticimex so no need to enable signing if this is just a repeater node? (No sleeping just waiting)

Yeah, every time it takes me quicker and quicker to troubleshoot mysensors ;-)
Obviously, thanks to your excellent support

Anticimex

@alexsh1 it never hurts to enable signing. It is not the same as requiring signatures. But no, you should not have to. I am just glad to help :)

alexsh1

I have been playing with 2.2.0 beta
Security personalisation went fine for sensebender GW (serial), but signing is not working. Any ideas please?

0;255;3;0;9;4840 MCO:BGN:INIT GW,CP=RNNGSA--,VER=2.2.0-beta
0;255;3;0;9;4964 Could not read ATSHA204A lock config, refusing to use backend```

Anticimex

@alexsh1 only that you have the atsha pin misconfigured in your gw sketch.

alexsh1

@Anticimex This is a standard GW sketch:
atsha204 pin is A3 (17). Cannot understand whats wrong...

/**
* The MySensors Arduino library handles the wireless radio link and protocol
* between your home built sensors/actuators and HA controller of choice.
* The sensors forms a self healing radio network with optional repeaters. Each
* repeater and gateway builds a routing tables in EEPROM which keeps track of the
* network topology allowing messages to be routed to nodes.
*
* Created by Henrik Ekblad <henrik.ekblad@mysensors.org>
* Copyright (C) 2013-2015 Sensnology AB
* Full contributor list: https://github.com/mysensors/Arduino/graphs/contributors
*
* Documentation: http://www.mysensors.org
* Support Forum: http://forum.mysensors.org
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* version 2 as published by the Free Software Foundation.
*
*******************************
*
* DESCRIPTION
* The ArduinoGateway prints data received from sensors on the serial link.
* The gateway accepts input on seral which will be sent out on radio network.
*
* The GW code is designed for Arduino Nano 328p / 16MHz
*
* Wire connections (OPTIONAL):
* - Inclusion button should be connected between digital pin 3 and GND
* - RX/TX/ERR leds need to be connected between +5V (anode) and digital pin 6/5/4 with resistor 270-330R in a series
*
* LEDs (OPTIONAL):
* - To use the feature, uncomment any of the MY_DEFAULT_xx_LED_PINs
* - RX (green) - blink fast on radio message recieved. In inclusion mode will blink fast only on presentation recieved
* - TX (yellow) - blink fast on radio message transmitted. In inclusion mode will blink slowly
* - ERR (red) - fast blink on error during transmission error or recieve crc error
*
*/
#define MY_DEBUG
#define MY_DEBUG_VERBOSE_SIGNING
#define MY_SPECIAL_DEBUG

#define MY_SIGNING_ATSHA204
#define MY_SIGNING_REQUEST_SIGNATURES
#define MY_SIGNING_ATSHA204_PIN 17


// Enable and select radio type attached
#define MY_RADIO_NRF24
#define MY_NODE_ID 18
//#define MY_PARENT_NODE_ID 0
//#define MY_RADIO_RFM69

// Enabled repeater feature for this node
#define MY_REPEATER_FEATURE

// Set LOW transmit power level as default, if you have an amplified NRF-module and
// power your radio separately with a good regulator you can turn up PA level.
#define MY_RF24_PA_LEVEL RF24_PA_LOW

// Enable serial gateway
#define MY_GATEWAY_SERIAL

// Define a lower baud rate for Arduino's running on 8 MHz (Arduino Pro Mini 3.3V & SenseBender)
#if F_CPU == 8000000L
#define MY_BAUD_RATE 38400
#endif

// Enable inclusion mode
#define MY_INCLUSION_MODE_FEATURE
// Enable Inclusion mode button on gateway
//#define MY_INCLUSION_BUTTON_FEATURE

// Inverses behavior of inclusion button (if using external pullup)
//#define MY_INCLUSION_BUTTON_EXTERNAL_PULLUP

// Set inclusion mode duration (in seconds)
#define MY_INCLUSION_MODE_DURATION 60
// Digital pin used for inclusion mode button
//#define MY_INCLUSION_MODE_BUTTON_PIN  3

// Set blinking period
#define MY_DEFAULT_LED_BLINK_PERIOD 300

// Inverses the behavior of leds
//#define MY_WITH_LEDS_BLINKING_INVERSE

// Flash leds on rx/tx/err
// Uncomment to override default HW configurations
//#define MY_DEFAULT_ERR_LED_PIN 4  // Error led pin
//#define MY_DEFAULT_RX_LED_PIN  6  // Receive led pin
//#define MY_DEFAULT_TX_LED_PIN  5  // the PCB, on board LED

#include <MySensors.h>

void setup()
{
	// Setup locally attached sensors
}

void presentation()
{
	// Present locally attached sensors
}

void loop()
{
	// Send locally attached sensor data here
}

Anticimex

@alexsh1 I don't think A3 is valid for samd targets.

Anticimex

@alexsh1 there is a special gw sketch for the SenseBender gw. Are you using that? SensebenderGatewaySerial.ino

Anticimex

@alexsh1 I think the SenseBender automatically assigns the appropriate atsha pin so if you run the SenseBender gw sketch you should not need to configure it.

alexsh1

@Anticimex No, I was using a standard GW Serial sketch. I cannot compile the sensebenderserial.ino under 2.2.0 dev:

........................

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:6:16: error: redefinition of 'uint8_t device_pin'

 static uint8_t device_pin;

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:6:16: error: 'uint8_t device_pin' previously declared here

 static uint8_t device_pin;

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void swi_set_signal_pin(uint8_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:23:13: error: redefinition of 'void swi_set_signal_pin(uint8_t)'

 static void swi_set_signal_pin(uint8_t is_high)

             ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:23:13: error: 'void swi_set_signal_pin(uint8_t)' previously defined here

 static void swi_set_signal_pin(uint8_t is_high)

             ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t swi_send_bytes(uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:34:16: error: redefinition of 'uint8_t swi_send_bytes(uint8_t, uint8_t*)'

 static uint8_t swi_send_bytes(uint8_t count, uint8_t *buffer)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:34:16: error: 'uint8_t swi_send_bytes(uint8_t, uint8_t*)' previously defined here

 static uint8_t swi_send_bytes(uint8_t count, uint8_t *buffer)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t swi_send_byte(uint8_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:73:16: error: redefinition of 'uint8_t swi_send_byte(uint8_t)'

 static uint8_t swi_send_byte(uint8_t value)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:73:16: error: 'uint8_t swi_send_byte(uint8_t)' previously defined here

 static uint8_t swi_send_byte(uint8_t value)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t swi_receive_bytes(uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:78:16: error: redefinition of 'uint8_t swi_receive_bytes(uint8_t, uint8_t*)'

 static uint8_t swi_receive_bytes(uint8_t count, uint8_t *buffer)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:78:16: error: 'uint8_t swi_receive_bytes(uint8_t, uint8_t*)' previously defined here

 static uint8_t swi_receive_bytes(uint8_t count, uint8_t *buffer)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t sha204p_receive_response(uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:177:16: error: redefinition of 'uint8_t sha204p_receive_response(uint8_t, uint8_t*)'

 static uint8_t sha204p_receive_response(uint8_t size, uint8_t *response)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:177:16: error: 'uint8_t sha204p_receive_response(uint8_t, uint8_t*)' previously defined here

 static uint8_t sha204p_receive_response(uint8_t size, uint8_t *response)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t sha204c_resync(uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:211:16: error: redefinition of 'uint8_t sha204c_resync(uint8_t, uint8_t*)'

 static uint8_t sha204c_resync(uint8_t size, uint8_t *response)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:211:16: error: 'uint8_t sha204c_resync(uint8_t, uint8_t*)' previously defined here

 static uint8_t sha204c_resync(uint8_t size, uint8_t *response)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t sha204c_send_and_receive(uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:233:16: error: redefinition of 'uint8_t sha204c_send_and_receive(uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t)'

 static uint8_t sha204c_send_and_receive(uint8_t *tx_buffer, uint8_t rx_size, uint8_t *rx_buffer,

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:233:16: error: 'uint8_t sha204c_send_and_receive(uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t)' previously defined here

 static uint8_t sha204c_send_and_receive(uint8_t *tx_buffer, uint8_t rx_size, uint8_t *rx_buffer,

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void sha204c_calculate_crc(uint8_t, uint8_t*, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:377:13: error: redefinition of 'void sha204c_calculate_crc(uint8_t, uint8_t*, uint8_t*)'

 static void sha204c_calculate_crc(uint8_t length, uint8_t *data, uint8_t *crc)

             ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:377:13: error: 'void sha204c_calculate_crc(uint8_t, uint8_t*, uint8_t*)' previously defined here

 static void sha204c_calculate_crc(uint8_t length, uint8_t *data, uint8_t *crc)

             ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t sha204c_check_crc(uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:402:16: error: redefinition of 'uint8_t sha204c_check_crc(uint8_t*)'

 static uint8_t sha204c_check_crc(uint8_t *response)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:402:16: error: 'uint8_t sha204c_check_crc(uint8_t*)' previously defined here

 static uint8_t sha204c_check_crc(uint8_t *response)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void atsha204_init(uint8_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:416:6: error: redefinition of 'void atsha204_init(uint8_t)'

 void atsha204_init(uint8_t pin)

      ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:416:6: error: 'void atsha204_init(uint8_t)' previously defined here

 void atsha204_init(uint8_t pin)

      ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void atsha204_idle()':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:433:6: error: redefinition of 'void atsha204_idle()'

 void atsha204_idle(void)

      ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:433:6: error: 'void atsha204_idle()' previously defined here

 void atsha204_idle(void)

      ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void atsha204_sleep()':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:438:6: error: redefinition of 'void atsha204_sleep()'

 void atsha204_sleep(void)

      ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:438:6: error: 'void atsha204_sleep()' previously defined here

 void atsha204_sleep(void)

      ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t atsha204_wakeup(uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:443:9: error: redefinition of 'uint8_t atsha204_wakeup(uint8_t*)'

 uint8_t atsha204_wakeup(uint8_t *response)

         ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:443:9: error: 'uint8_t atsha204_wakeup(uint8_t*)' previously defined here

 uint8_t atsha204_wakeup(uint8_t *response)

         ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t atsha204_execute(uint8_t, uint8_t, uint16_t, uint8_t, uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:473:9: error: redefinition of 'uint8_t atsha204_execute(uint8_t, uint8_t, uint16_t, uint8_t, uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t*)'

 uint8_t atsha204_execute(uint8_t op_code, uint8_t param1, uint16_t param2,

         ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:473:9: error: 'uint8_t atsha204_execute(uint8_t, uint8_t, uint16_t, uint8_t, uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t*)' previously defined here

 uint8_t atsha204_execute(uint8_t op_code, uint8_t param1, uint16_t param2,

         ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t atsha204_getSerialNumber(uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:549:9: error: redefinition of 'uint8_t atsha204_getSerialNumber(uint8_t*)'

 uint8_t atsha204_getSerialNumber(uint8_t * response)

         ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:549:9: error: 'uint8_t atsha204_getSerialNumber(uint8_t*)' previously defined here

 uint8_t atsha204_getSerialNumber(uint8_t * response)

         ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t atsha204_read(uint8_t*, uint8_t*, uint8_t, uint16_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:578:9: error: redefinition of 'uint8_t atsha204_read(uint8_t*, uint8_t*, uint8_t, uint16_t)'

 uint8_t atsha204_read(uint8_t *tx_buffer, uint8_t *rx_buffer, uint8_t zone, uint16_t address)

         ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_501069\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:578:9: error: 'uint8_t atsha204_read(uint8_t*, uint8_t*, uint8_t, uint16_t)' previously defined here

 uint8_t atsha204_read(uint8_t *tx_buffer, uint8_t *rx_buffer, uint8_t zone, uint16_t address)

         ^

Multiple libraries were found for "SD.h"
 Used: C:\Users\Alex\Documents\Arduino\libraries\SD
 Not used: C:\Program Files (x86)\Arduino\libraries\SD
Using library MySensors at version 2.2.0-beta in folder: C:\Users\Alex\Documents\Arduino\libraries\MySensors 
Using library Wire at version 1.0 in folder: C:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\libraries\Wire 
Using library SPI at version 1.0 in folder: C:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\libraries\SPI 
Using library SD at version 1.1.1 in folder: C:\Users\Alex\Documents\Arduino\libraries\SD 
exit status 1
Error compiling for board Sensebender Gateway.

Anticimex

@alexsh1 Well, you need to use the sensebenderserial.ino if you want to run a serial gw on the sensebender board.
Why have you modified the sketch? You should not touch HW configurations for the sensebender sketch as it is a predefined board unless you have a customized sensebender board or made your own PCB.

alexsh1

@Anticimex All I modified was adding this for signing:

#define MY_SIGNING_ATSHA204
#define MY_SIGNING_REQUEST_SIGNATURES
#define MY_SIGNING_ATSHA204_PIN 17

Is signing working without these lines on SAMD?

Anticimex

@alexsh1 Yes but why? The sensebender is not a AVR board. How do you know that "pin 17" is valid pin for ATSHA in a sensebender board? I can almost guarantee that it is not, and if you have picked the board in the board manager as your target board, the appropriate ATSHA pin will be configured for you. You do not need to (and in fact you should not) define a pin for the ATSHA on a sensebender board, as it is natively supported by the board.
So what you have done here is to actually override the default for the board to something that is wrong, so communication with the atsha will fail, as it uses the wrong pin.
Edit: And no, signing will not work if you have not enabled it. You have to enable MY_SIGNING_ATSHA204 (or MY_SIGNING_SOFT) to support signing in all cases. Requesting signatures is depending on your personal preference. The pin should only be defined if you know what it is supposed to be for your target HW. Usually it is automatically assigned if the board is "known".

alexsh1

@Anticimex You are right - I am looking into the sensebender GW docs and I think it is PA11 pin where pin 3 of atsha204 is connected. Apologies - my experience with SAMD is still very limited. I deleted the three lines above with signing and the sketch does compile. However, as soon as I add:

#define MY_SIGNING_ATSHA204

Compiling breaks

[security] Introducing signing support to MySensors

23

11.7k

11.2k

113.1k