[security] Introducing signing support to MySensors

[Anticimex]

@alexsh1 Well, you need to use the sensebenderserial.ino if you want to run a serial gw on the sensebender board.
Why have you modified the sketch? You should not touch HW configurations for the sensebender sketch as it is a predefined board unless you have a customized sensebender board or made your own PCB.

[alexsh1]

@Anticimex All I modified was adding this for signing:

#define MY_SIGNING_ATSHA204
#define MY_SIGNING_REQUEST_SIGNATURES
#define MY_SIGNING_ATSHA204_PIN 17

Is signing working without these lines on SAMD?

[Anticimex]

@alexsh1 Yes but why? The sensebender is not a AVR board. How do you know that "pin 17" is valid pin for ATSHA in a sensebender board? I can almost guarantee that it is not, and if you have picked the board in the board manager as your target board, the appropriate ATSHA pin will be configured for you. You do not need to (and in fact you should not) define a pin for the ATSHA on a sensebender board, as it is natively supported by the board.
So what you have done here is to actually override the default for the board to something that is wrong, so communication with the atsha will fail, as it uses the wrong pin.
Edit: And no, signing will not work if you have not enabled it. You have to enable MY_SIGNING_ATSHA204 (or MY_SIGNING_SOFT) to support signing in all cases. Requesting signatures is depending on your personal preference. The pin should only be defined if you know what it is supposed to be for your target HW. Usually it is automatically assigned if the board is "known".

[alexsh1]

@Anticimex You are right - I am looking into the sensebender GW docs and I think it is PA11 pin where pin 3 of atsha204 is connected. Apologies - my experience with SAMD is still very limited. I deleted the three lines above with signing and the sketch does compile. However, as soon as I add:

#define MY_SIGNING_ATSHA204

Compiling breaks

[Anticimex]

@alexsh1 Can you please be a bit more elaborate on what "Compiling breaks" mean? @tbowmo a known issue?

[alexsh1]

@Anticimex @tbowmo OK, I take a default sensebenderserial.ino sketch and add one line for signing "#define MY_SIGNING_ATSHA204" and have the following errors (2.2.0-dev):

Generating function prototypes...
"C:\Users\Alex\AppData\Local\Arduino15\packages\arduino\tools\arm-none-eabi-gcc\4.8.3-2014q1/bin/arm-none-eabi-g++" -mcpu=cortex-m0plus -mthumb -c -g -Os -w -std=gnu++11 -ffunction-sections -fdata-sections -fno-threadsafe-statics -nostdlib --param max-inline-insns-single=500 -fno-rtti -fno-exceptions  -w -x c++ -E -CC -DF_CPU=48000000L -DARDUINO=10801 -DARDUINO_SAMD_ZERO -DARDUINO_ARCH_SAMD  -D__SAMD21G18A__ -DUSB_VID=0x1209 -DUSB_PID=0x6949 -DUSBCON '-DUSB_MANUFACTURER="MySensors.org"' '-DUSB_PRODUCT="Sensebender GW"' "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\tools\CMSIS\4.5.0/CMSIS/Include/" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\tools\CMSIS-Atmel\1.1.0/CMSIS/Device/ATMEL/" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\cores\arduino" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\MySensors\hardware\samd\1.0.5\variants\mysensors_gw" "-IC:\Users\Alex\Documents\Arduino\libraries\MySensors" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\libraries\Wire" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\libraries\SPI" "-IC:\Users\Alex\Documents\Arduino\libraries\SD\src" "C:\Users\Alex\AppData\Local\Temp\arduino_build_980458\sketch\SensebenderGatewaySerial.ino.cpp" -o "C:\Users\Alex\AppData\Local\Temp\arduino_build_980458\preproc\ctags_target_for_gcc_minus_e.cpp"
"C:\Program Files (x86)\Arduino\tools-builder\ctags\5.8-arduino11/ctags" -u --language-force=c++ -f - --c++-kinds=svpf --fields=KSTtzns --line-directives "C:\Users\Alex\AppData\Local\Temp\arduino_build_980458\preproc\ctags_target_for_gcc_minus_e.cpp"
Compiling sketch...
"C:\Users\Alex\AppData\Local\Arduino15\packages\arduino\tools\arm-none-eabi-gcc\4.8.3-2014q1/bin/arm-none-eabi-g++" -mcpu=cortex-m0plus -mthumb -c -g -Os -w -std=gnu++11 -ffunction-sections -fdata-sections -fno-threadsafe-statics -nostdlib --param max-inline-insns-single=500 -fno-rtti -fno-exceptions -MMD -DF_CPU=48000000L -DARDUINO=10801 -DARDUINO_SAMD_ZERO -DARDUINO_ARCH_SAMD  -D__SAMD21G18A__ -DUSB_VID=0x1209 -DUSB_PID=0x6949 -DUSBCON '-DUSB_MANUFACTURER="MySensors.org"' '-DUSB_PRODUCT="Sensebender GW"' "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\tools\CMSIS\4.5.0/CMSIS/Include/" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\tools\CMSIS-Atmel\1.1.0/CMSIS/Device/ATMEL/" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\cores\arduino" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\MySensors\hardware\samd\1.0.5\variants\mysensors_gw" "-IC:\Users\Alex\Documents\Arduino\libraries\MySensors" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\libraries\Wire" "-IC:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\libraries\SPI" "-IC:\Users\Alex\Documents\Arduino\libraries\SD\src" "C:\Users\Alex\AppData\Local\Temp\arduino_build_980458\sketch\SensebenderGatewaySerial.ino.cpp" -o "C:\Users\Alex\AppData\Local\Temp\arduino_build_980458\sketch\SensebenderGatewaySerial.ino.cpp.o"
In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:6:16: error: redefinition of 'uint8_t device_pin'

 static uint8_t device_pin;

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:6:16: error: 'uint8_t device_pin' previously declared here

 static uint8_t device_pin;

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void swi_set_signal_pin(uint8_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:23:13: error: redefinition of 'void swi_set_signal_pin(uint8_t)'

 static void swi_set_signal_pin(uint8_t is_high)

             ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:23:13: error: 'void swi_set_signal_pin(uint8_t)' previously defined here

 static void swi_set_signal_pin(uint8_t is_high)

             ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t swi_send_bytes(uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:34:16: error: redefinition of 'uint8_t swi_send_bytes(uint8_t, uint8_t*)'

 static uint8_t swi_send_bytes(uint8_t count, uint8_t *buffer)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:34:16: error: 'uint8_t swi_send_bytes(uint8_t, uint8_t*)' previously defined here

 static uint8_t swi_send_bytes(uint8_t count, uint8_t *buffer)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t swi_send_byte(uint8_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:73:16: error: redefinition of 'uint8_t swi_send_byte(uint8_t)'

 static uint8_t swi_send_byte(uint8_t value)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:73:16: error: 'uint8_t swi_send_byte(uint8_t)' previously defined here

 static uint8_t swi_send_byte(uint8_t value)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t swi_receive_bytes(uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:78:16: error: redefinition of 'uint8_t swi_receive_bytes(uint8_t, uint8_t*)'

 static uint8_t swi_receive_bytes(uint8_t count, uint8_t *buffer)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:78:16: error: 'uint8_t swi_receive_bytes(uint8_t, uint8_t*)' previously defined here

 static uint8_t swi_receive_bytes(uint8_t count, uint8_t *buffer)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t sha204p_receive_response(uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:177:16: error: redefinition of 'uint8_t sha204p_receive_response(uint8_t, uint8_t*)'

 static uint8_t sha204p_receive_response(uint8_t size, uint8_t *response)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:177:16: error: 'uint8_t sha204p_receive_response(uint8_t, uint8_t*)' previously defined here

 static uint8_t sha204p_receive_response(uint8_t size, uint8_t *response)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t sha204c_resync(uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:211:16: error: redefinition of 'uint8_t sha204c_resync(uint8_t, uint8_t*)'

 static uint8_t sha204c_resync(uint8_t size, uint8_t *response)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:211:16: error: 'uint8_t sha204c_resync(uint8_t, uint8_t*)' previously defined here

 static uint8_t sha204c_resync(uint8_t size, uint8_t *response)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t sha204c_send_and_receive(uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:233:16: error: redefinition of 'uint8_t sha204c_send_and_receive(uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t)'

 static uint8_t sha204c_send_and_receive(uint8_t *tx_buffer, uint8_t rx_size, uint8_t *rx_buffer,

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:233:16: error: 'uint8_t sha204c_send_and_receive(uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t)' previously defined here

 static uint8_t sha204c_send_and_receive(uint8_t *tx_buffer, uint8_t rx_size, uint8_t *rx_buffer,

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void sha204c_calculate_crc(uint8_t, uint8_t*, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:377:13: error: redefinition of 'void sha204c_calculate_crc(uint8_t, uint8_t*, uint8_t*)'

 static void sha204c_calculate_crc(uint8_t length, uint8_t *data, uint8_t *crc)

             ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:377:13: error: 'void sha204c_calculate_crc(uint8_t, uint8_t*, uint8_t*)' previously defined here

 static void sha204c_calculate_crc(uint8_t length, uint8_t *data, uint8_t *crc)

             ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t sha204c_check_crc(uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:402:16: error: redefinition of 'uint8_t sha204c_check_crc(uint8_t*)'

 static uint8_t sha204c_check_crc(uint8_t *response)

                ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:402:16: error: 'uint8_t sha204c_check_crc(uint8_t*)' previously defined here

 static uint8_t sha204c_check_crc(uint8_t *response)

                ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void atsha204_init(uint8_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:416:6: error: redefinition of 'void atsha204_init(uint8_t)'

 void atsha204_init(uint8_t pin)

      ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:416:6: error: 'void atsha204_init(uint8_t)' previously defined here

 void atsha204_init(uint8_t pin)

      ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void atsha204_idle()':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:433:6: error: redefinition of 'void atsha204_idle()'

 void atsha204_idle(void)

      ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:433:6: error: 'void atsha204_idle()' previously defined here

 void atsha204_idle(void)

      ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'void atsha204_sleep()':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:438:6: error: redefinition of 'void atsha204_sleep()'

 void atsha204_sleep(void)

      ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:438:6: error: 'void atsha204_sleep()' previously defined here

 void atsha204_sleep(void)

      ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t atsha204_wakeup(uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:443:9: error: redefinition of 'uint8_t atsha204_wakeup(uint8_t*)'

 uint8_t atsha204_wakeup(uint8_t *response)

         ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:443:9: error: 'uint8_t atsha204_wakeup(uint8_t*)' previously defined here

 uint8_t atsha204_wakeup(uint8_t *response)

         ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t atsha204_execute(uint8_t, uint8_t, uint16_t, uint8_t, uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:473:9: error: redefinition of 'uint8_t atsha204_execute(uint8_t, uint8_t, uint16_t, uint8_t, uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t*)'

 uint8_t atsha204_execute(uint8_t op_code, uint8_t param1, uint16_t param2,

         ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:473:9: error: 'uint8_t atsha204_execute(uint8_t, uint8_t, uint16_t, uint8_t, uint8_t*, uint8_t, uint8_t*, uint8_t, uint8_t*)' previously defined here

 uint8_t atsha204_execute(uint8_t op_code, uint8_t param1, uint16_t param2,

         ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t atsha204_getSerialNumber(uint8_t*)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:549:9: error: redefinition of 'uint8_t atsha204_getSerialNumber(uint8_t*)'

 uint8_t atsha204_getSerialNumber(uint8_t * response)

         ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:549:9: error: 'uint8_t atsha204_getSerialNumber(uint8_t*)' previously defined here

 uint8_t atsha204_getSerialNumber(uint8_t * response)

         ^

In file included from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:96:0:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp: In function 'uint8_t atsha204_read(uint8_t*, uint8_t*, uint8_t, uint16_t)':

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:578:9: error: redefinition of 'uint8_t atsha204_read(uint8_t*, uint8_t*, uint8_t, uint16_t)'

 uint8_t atsha204_read(uint8_t *tx_buffer, uint8_t *rx_buffer, uint8_t zone, uint16_t address)

         ^

In file included from C:\Users\Alex\Documents\Arduino\libraries\MySensors/MySensors.h:155:0,

                 from C:\Users\Alex\AppData\Local\Temp\arduino_modified_sketch_105629\SensebenderGatewaySerial.ino:94:

C:\Users\Alex\Documents\Arduino\libraries\MySensors/drivers/ATSHA204/ATSHA204.cpp:578:9: error: 'uint8_t atsha204_read(uint8_t*, uint8_t*, uint8_t, uint16_t)' previously defined here

 uint8_t atsha204_read(uint8_t *tx_buffer, uint8_t *rx_buffer, uint8_t zone, uint16_t address)

         ^

Multiple libraries were found for "SD.h"
 Used: C:\Users\Alex\Documents\Arduino\libraries\SD
 Not used: C:\Program Files (x86)\Arduino\libraries\SD
Using library MySensors at version 2.2.0-beta in folder: C:\Users\Alex\Documents\Arduino\libraries\MySensors 
Using library Wire at version 1.0 in folder: C:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\libraries\Wire 
Using library SPI at version 1.0 in folder: C:\Users\Alex\AppData\Local\Arduino15\packages\arduino\hardware\samd\1.6.12\libraries\SPI 
Using library SD at version 1.1.1 in folder: C:\Users\Alex\Documents\Arduino\libraries\SD 
exit status 1
Error compiling for board Sensebender Gateway.

[Anticimex]

@alexsh1 Try to comment this line.
If it still fails to compile, also comment out this block and this block.

[alexsh1]

@Anticimex Commenting #include <drivers/ATSHA204/ATSHA204.cpp> did help, I can compile the sketch.

However, have a different issue now:

0;255;3;0;9;28181 Signing backend: ATSHA204
0;255;3;0;9;28234 SHA256: 19332EC2AF4F753F8D2ED9F9B3039897BDD3D5B847D7C3DB01907B97F80B064C
0;255;3;0;9;28245 Will not sign message for destination 4 as it does not require it
0;255;3;0;9;28303 !TSF:MSG:SEND,0-0-4-4,s=255,c=3,t=17,pt=6,l=25,sg=0,ft=0,st=NACK:19332EC2AF4F753F8D2ED9F9B3039897BDD3D5B847D7C3DB01
0;255;3;0;9;28313 Failed to transmit nonce!
0;255;3;0;9;29922 TSF:MSG:READ,4-4-0,s=2,c=1,t=1,pt=2,l=2,sg=1:46
4;2;1;0;1;46

[Anticimex]

@alexsh1 That is a radio issue. You have NACK on !TSF:MSG:SEND.

[Anticimex]

@tbowmo We probably should conditionally include drivers/ATSHA204/ATSHA204.cpp based on the MY_SIGNING_ATSHA204 flag. Otherwise the ATSHA204.cpp file will be included in multiple places if ATSHA204 signing is enabled in the gw.

[alexsh1]

@Anticimex it says

0;255;3;0;9;156987 TSF:MSG:READ,4-4-0,s=2,c=1,t=1,pt=2,l=2,sg=1:45
4;2;1;0;1;45
0;255;3;0;9;169466 Verification timeout

Shall I try to increase timeout?

[Anticimex]

@alexsh1 First you have to resolve the NACKs. It will not help to increase the timeout if messages never arrive.

[alexsh1]

@Anticimex I think I have resolved it by changing this:

#define MY_RF24_PA_LEVEL RF24_PA_HIGH

to

#define MY_RF24_PA_LEVEL RF24_PA_LOW

0;255;3;0;9;44594 Signing backend: ATSHA204
0;255;3;0;9;44647 SHA256: CF003C2C5580A69303207910E37DA55E6A4B0C78B671218C3BEF40B895658B9D
0;255;3;0;9;44658 Will not sign message for destination 6 as it does not require it
0;255;3;0;9;44671 TSF:MSG:SEND,0-0-6-6,s=255,c=3,t=17,pt=6,l=25,sg=0,ft=0,st=OK:CF003C2C5580A69303207910E37DA55E6A4B0C78B671218C3B
0;255;3;0;9;44681 Transmitted nonce
0;255;3;0;9;44951 TSF:MSG:READ,6-6-0,s=2,c=1,t=1,pt=7,l=5,sg=1:55.2

One node is still bad - I'll change the radio and test it again.

[Anticimex]

@alexsh1 :+1:

[alexsh1]

@Anticimex

Do you think that I may have verification timeout due to having a mixture 2.1.1 and 2.2.0?

0;255;3;0;9;124541 Signing backend: ATSHA204
0;255;3;0;9;124594 SHA256: 9CEF656D53F4C3722D72AE17346E310BD300161FAB992261DD5216C08D0D7950
0;255;3;0;9;124605 Will not sign message for destination 16 as it does not require it
0;255;3;0;9;124618 TSF:MSG:SEND,0-0-16-16,s=255,c=3,t=17,pt=6,l=25,sg=0,ft=0,st=OK:9CEF656D53F4C3722D72AE17346E310BD300161FAB992261DD
0;255;3;0;9;124628 Transmitted nonce
0;255;3;0;9;124799 TSF:MSG:READ,16-16-0,s=255,c=3,t=0,pt=1,l=1,sg=1:76
16;255;3;0;0;76
0;255;3;0;9;124809 TSF:MSG:READ,16-16-0,s=0,c=3,t=16,pt=0,l=0,sg=1:
0;255;3;0;9;124819 Signing backend: ATSHA204
0;255;3;0;9;124872 SHA256: 326EB7828E5F02AB2F9FCE645FC5B7D2628DDD70FED64C78275AC1FA0D1C1AF5
0;255;3;0;9;124883 Will not sign message for destination 16 as it does not require it
0;255;3;0;9;124896 TSF:MSG:SEND,0-0-16-16,s=255,c=3,t=17,pt=6,l=25,sg=0,ft=0,st=OK:326EB7828E5F02AB2F9FCE645FC5B7D2628DDD70FED64C7827
0;255;3;0;9;124906 Transmitted nonce
0;255;3;0;9;125176 TSF:MSG:READ,16-16-0,s=0,c=1,t=38,pt=7,l=5,sg=1:2.9
16;0;1;0;38;2.9
0;255;3;0;9;137796 Verification timeout

[Anticimex]

@alexsh1 Hm, it should not be a problem. Assuming your log snippet is from the GW, it basically says that it successfully transmit the nonce to your node as requested to, and then it expects the node to provide a signed message to the GW within a certain timeout. The node fails to do this within that time so the GW times out and will not accept the message if it arrives later on.
So there are two options;

1. The node takes too long to process the received nonce, sign the message and send it back (perhaps many repeater hops between node and gw, this can be resolved by increasing the signing timeout at the GW side).
2. The node does transmit the signed message but fails with a NACK. The GW will never see this message and therefore assumes the node did not send it and correctly times out.

[alexsh1]

@Anticimex On the node, changing nrf24l01+ orientation (I have two nrf24l01+ sockets) 90 degrees changed signing from

0;255;3;0;9;120620 Transmitted nonce
0;255;3;0;9;120630 TSF:MSG:READ,4-4-0,s=1,c=1,t=0,pt=7,l=5,sg=1:24.0
0;255;3;0;9;120644 Current nonce: 415DAB5FF6170E67F5B180ADC827C062D35CBF2DCE1B6B0264AAAAAAAAAAAAAA
0;255;3;0;9;120745 HMAC: 759A77B66BAC8F0AEA542685F4EA12DEB66B27FE15F57788F1D1022508984896
0;255;3;0;9;120756 Signature bad
0;255;3;0;9;120766 Signature verification failed!
0;255;3;0;9;120776 !TSF:MSG:SIGN VERIFY FAIL
0;255;3;0;9;120981 TSF:MSG:READ,4-4-0,s=2,c=1,t=1,pt=2,l=2,sg=1:70
0;255;3;0;9;120991 No active verification session
0;255;3;0;9;121001 Signature verification failed!
0;255;3;0;9;121011 !TSF:MSG:SIGN VERIFY FAIL

0;255;3;0;9;165728 Transmitted nonce
0;255;3;0;9;165944 TSF:MSG:READ,4-4-0,s=1,c=1,t=0,pt=7,l=5,sg=1:24.4
0;255;3;0;9;165958 Current nonce: BAC8828FEAAFB3A0C65DE6F8D4993E4D3D93F190B58AA3C737AAAAAAAAAAAAAA
0;255;3;0;9;166059 HMAC: 122222A7C324B3688BD98EC8EF9AD9557350B874CAB38F250A246EBB069805D3
0;255;3;0;9;166070 Signature OK

[Anticimex]

@alexsh1 Looks like RF performance was significantly improved by that change.

[alexsh1]

@Anticimex It seems to me that 90% of all issues is actually RF.
Very annoying!

Thanks for your help!

[alexsh1]

I am using latest beta (2.2.0b). Does anyone know what this means in the log:

!SGN:NCE:GEN

I think this is related to signing