Best posts made by kasparsd

@chey said in Where did everyone go?:

Personally when I look at the MySensors github and see Issues and PRs being created but no one is doing anything with them, that's a bit of a turn off.

When I look through the PRs I see a lot of "good stuff" there yet there is no movement.

I had the same observation and was wondering if we could do anything about this.

I maintain a dozen of open source projects and I know how unpredictable the contributions can be with life getting in the way and priorities changing. However, MySensors appears to be a project with relatively active user base and many people willing to contribute.

The latest commit to the development branch was more than 100 days ago (on July 27) and there are a bunch of pull requests that could be merge as they have had code reviews and they are very limited in scope and have little potential for introducing regressions.

Is there a way that members of the core team (or people with commit access) could give commit access to new members that have shown interest in contributing? There is always a chance that new contributors will have different approach to deciding on what features go in and how the project is maintained (and potentially introduce regressions or bugs) but that's at the cost of moving the project along and having it live.

Turns out that the RFM69 arduino library was missing two additional bytes from the packet header -- rfm69_header_t.version and rfm69_header_t.sequenceNumber in RFM69::sendFrame() (see the diff).

  select();
  SPI.transfer(REG_FIFO | 0x80); // Select the FIFO write register.

  SPI.transfer(bufferSize + 5); // rfm69_header_t.packetLen
  SPI.transfer(toAddress); // rfm69_header_t.recipient
  SPI.transfer(1); // RFM69_PACKET_HEADER_VERSION = (1u) rfm69_header_t.version header version (20180128tk: >=3.0.0 fused with controlFlags)
  SPI.transfer(_address); // rfm69_header_t.sender
  SPI.transfer(CTLbyte); // rfm69_header_t.controlFlags
  SPI.transfer(0); // rfm69_header_t.sequenceNumber

  for (uint8_t i = 0; i < bufferSize; i++)
    SPI.transfer(((uint8_t*) buffer)[i]);
  unselect();

So after adding SPI.transfer(1); as rfm69_header_t.version and SPI.transfer(0); as rfm69_header_t.sequenceNumber the packets are now being parsed correctly:

DEBUG TSF:MSG:READ,1-1-255,s=3,c=1,t=16,pt=1,l=1,sg=0:1
DEBUG TSF:MSG:BC