Navigation

    • Register
    • Login
    • OpenHardware.io
    • Categories
    • Recent
    • Tags
    • Popular
    1. Home
    2. moffen666
    • Profile
    • Following
    • Followers
    • Topics
    • Posts
    • Best
    • Groups

    moffen666

    @moffen666

    1
    Reputation
    14
    Posts
    508
    Profile views
    0
    Followers
    0
    Following
    Joined Last Online

    moffen666 Follow

    Best posts made by moffen666

    • RE: Irrigation Controller (up to 16 valves with Shift Registers)

      Thx Bulldog for all the help, everything seems to be working as it should now.

      Keep up the good work 👍

      Updated code for Domoticz.

      /*
      MySprinkler for MySensors
      
      Arduino Multi-Zone Sprinkler Control
      
      May 31, 2015
      
      *** Version 2.0
      
      *** Upgraded to http://MySensors.org version 1.4.1
      *** Expanded for up to 16 Valves
      *** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
      *** Switch to bitshift method vs byte arrays
      *** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
      *** Added optional LCD display featuring remaining time, date last ran & current time
      *** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively
      *** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone)
      *** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names)
      
      Utilizing your Vera home automation controller and the MySensors.org gateway you can
      control up to a sixteen zone irrigation system with only three digital pins.  This sketch
      will create NUMBER_OF_VALVES + 1 devices on your Vera controller
      
      This sketch features the following:
      
      * Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.
      * Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n)
        using Variable1 as the "ON" time in minutes in each of the vera devices created.
      * Use the individual zone controller to activate a single zone.  This feature uses
        Variable2 as the "ON" time for each individual device/zone.
      * Connect according to pinout below and uses Shift Registers as to allow the MySensors
        standard radio configuration and still leave available digital pins
      * Turning on any zone will stop the current process and begin that particular process.
      * Turning off any zone will stop the current process and turn off all zones.
      * To push your new time intervals for your zones, simply change the variable on your Vera and
        your arduino will call to Vera once a minute and update accordingly.  Variables will also be
        requested when the device is first powered on.
      * Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program
      * LED status indicator
      
      PARTS LIST:
      Available from the MySensors store - http://www.mysensors.org/store/
      * Relays (8 channel)
      * Female Pin Header Connector Strip
      * Prototype Universal Printed Circuit Boards (PCB)
      * NRF24L01 Radio
      * Arduino (I used a Pro Mini)
      * FTDI USB to TTL Serial Adapter
      * Capacitors (10uf and .1uf)
      * 3.3v voltage regulator
      * Resistors (270 & 10K)
      * Female Dupont Cables
      * 1602 LCD (with I2C Interface)
      * LED
      * Push button
      * Shift Register (SN74HC595)
      * 2 Pole 5mm Pitch PCB Mount Screw Terminal Block
      * 3 Pole 5mm Pitch PCB Mount Screw Terminal Block
      * 22-24 gauge wire or similar (I used Cat5/Cat6 cable)
      * 18 gauge wire (for relay)
      * Irrigation Power Supply (24-Volt/750 mA Transformer)
      
      
      INSTRUCTIONS:
      
      * A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI
      * After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to
        A4 and A5) and relays, and load the sketch.
      * Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
      * Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
        the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
        you may use the defaulet zone names by leaving Variable3 blank.
      * Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
      * Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
        on the serial monitor.
      * Your arduino should slow-flash, indicating that it is in ready mode.
      * There are multiple debug serial prints that can be monitored to assure that it is operating properly.
      * ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours
      
      Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain
      */
      //
      #include <Wire.h>
      #include <Time.h>
      #include <MySensor.h>
      #include <SPI.h>
      #include <LiquidCrystal.h>
      #include <LiquidCrystal_I2C.h>
      
      
      //
      #define NUMBER_OF_VALVES 4  // Change this to set your valve count up to 16.
      #define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
      #define RADIO_ID AUTO  // Change this to fix your Radio ID or use Auto
      
      #define SKETCH_NAME "MySprinkler Domoticz"
      #define SKETCH_VERSION "2.0"
      //
      #define CHILD_ID_SPRINKLER 0
      //
      //#define ACTIVE_LOW // comment out this line if your relays are active high
      //
      #define DEBUG_ON   // comment out to supress serial monitor output
      //
      #ifdef ACTIVE_LOW
      #define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
      #define ALL_VALVES_OFF 0xFFFF
      #else
      #define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
      #define ALL_VALVES_OFF 0U
      #endif
      //
      #ifdef DEBUG_ON
      #define DEBUG_PRINT(x)   Serial.print(x)
      #define DEBUG_PRINTLN(x) Serial.println(x)
      #define SERIAL_START(x)  Serial.begin(x)
      #else
      #define DEBUG_PRINT(x)
      #define DEBUG_PRINTLN(x)
      #define SERIAL_START(x)
      #endif
      //
      typedef enum {
        STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
      }
      SprinklerStates;
      //
      SprinklerStates state = STAND_BY_ALL_OFF;
      SprinklerStates lastState;
      byte menuState = 0;
      unsigned long menuTimer;
      byte countDownTime = 10;
      //
      int allZoneTime [NUMBER_OF_VALVES + 1]= {0, 1, 1, 1, 1};     // Insert values in min, 0 = all zone (always 0) this is a 4 chan relay
      int valveSoloTime [NUMBER_OF_VALVES + 1]= {0, 1, 1, 1, 1};   // Insert values in min, 0 = all zone (always 0) this is a 4 chan relay
      int valveNumber;
      int lastValve;
      unsigned long startMillis;
      const int ledPin = 5;
      const int waterButtonPin = 3;
      boolean buttonPushed = false;
      boolean showTime = true;
      boolean clockUpdating = false;
      boolean recentUpdate = true;
      const char *dayOfWeek[] = {
        "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
      };
      // Name your Zones here or use Vera to edit them by adding a name in Variable3...
      String valveNickName[17] = {
        "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
      };
      //
      time_t lastTimeRun = 0;
      //Setup Shift Register...
      const int latchPin = 8;
      const int clockPin = 4;
      const int dataPin  = 7;
      //
      byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
      byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
      // Set the pins on the I2C chip used for LCD connections:
      //                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
      LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27
      MySensor gw;
      //
      MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
      MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
      MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);
      //
      void setup()
      {
        SERIAL_START(115200);
        DEBUG_PRINTLN(F("Initialising..."));
        pinMode(latchPin, OUTPUT);
        pinMode(clockPin, OUTPUT);
        pinMode(dataPin, OUTPUT);
        pinMode(ledPin, OUTPUT);
        pinMode(waterButtonPin, INPUT_PULLUP);
        //pinMode(waterButtonPin, INPUT);
        attachInterrupt(1, PushButton, RISING); //May need to change for your Arduino model
        digitalWrite (ledPin, HIGH);
        DEBUG_PRINTLN(F("Turning All Valves Off..."));
        updateRelays(ALL_VALVES_OFF);
        //delay(5000);
        lcd.begin(16, 2); //(16 characters and 2 line display)
        lcd.clear();
        lcd.backlight();
        lcd.createChar(0, clock);
        lcd.createChar(1, raindrop);
        //
        //check for saved date in EEPROM
        DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
        delay(500);
        if (gw.loadState(0) == 0xFF); // EEPROM flag
        {
          DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
          for (int i = 0; i < 4 ; i++)
          {
            lastTimeRun = lastTimeRun << 8;
            lastTimeRun = lastTimeRun | gw.loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
          }
        }
        gw.begin(getVariables, RADIO_ID, false); // Change 'false' to 'true' to create a Radio repeating node
        gw.sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          gw.present(i, S_LIGHT);
        }
        DEBUG_PRINTLN(F("Sensor Presentation Complete"));
        //
        digitalWrite (ledPin, LOW);
        DEBUG_PRINTLN(F("Ready..."));
        //
        lcd.setCursor(0, 0);
        lcd.print(F(" Syncing Time  "));
        lcd.setCursor(15, 0);
        lcd.write(byte(0));
        lcd.setCursor(0, 1);
        int clockCounter = 0;
        while (timeStatus() == timeNotSet && clockCounter < 21)
        {
          gw.process();
          gw.requestTime(receiveTime);
          DEBUG_PRINTLN(F("Requesting time from Gateway:"));
          delay(1000);
          lcd.print(".");
          clockCounter++;
          if (clockCounter > 16)
          {
            DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
            lcd.clear();
            lcd.print(F("  Failed Clock  "));
            lcd.setCursor(0, 1);
            lcd.print(F(" Syncronization "));
            delay(2000);
            break;
          }
        }
        //
        lcd.clear();
      
        /*
        //Update valve data when first powered on
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          lcd.print(F(" Updating  "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Valve Data: "));
          lcd.print(i);
          boolean flashIcon = false;
          DEBUG_PRINT(F("Calling for Valve "));
          DEBUG_PRINT(i);
          DEBUG_PRINTLN(F(" Data..."));
          while (gw.process() == false)
          {
            lcd.setCursor(15, 0);
            flashIcon = !flashIcon;
            flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
            gw.request(i, V_VAR1);
            delay(100);
          }
          while (gw.process() == false)
          {
            lcd.setCursor(15, 0);
            flashIcon = !flashIcon;
            flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
            gw.request(i, V_VAR2);
            delay(100);
          }
          while (gw.process() == false)
          {
            lcd.setCursor(15, 0);
            flashIcon = !flashIcon;
            flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
            gw.request(i, V_VAR3);
            delay(100);
          }
        }
        */
        lcd.clear();
      }
      //
      void loop()
      {
        gw.process();
        updateClock();
        updateDisplay();
        //goGetValveTimes();
        //
        if (buttonPushed)
        {
          menuTimer = millis();
          DEBUG_PRINTLN(F("Button Pressed"));
          if (state == STAND_BY_ALL_OFF)
          {
            state = ZONE_SELECT_MENU;
            menuState = 0;
          }
          else if (state == ZONE_SELECT_MENU)
          {
            menuState++;
            if (menuState > NUMBER_OF_VALVES)
            {
              menuState = 0;
            }
          }
          else
          {
            state = STAND_BY_ALL_OFF;
          }
          buttonPushed = false;
        }
        if (state == STAND_BY_ALL_OFF)
        {
          slowToggleLED ();
          if (state != lastState)
          {
            updateRelays(ALL_VALVES_OFF);
            DEBUG_PRINTLN(F("State Changed... all Zones off"));
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              delay(50);
              gw.send(msg1valve.setSensor(i).set(false), false);
            }
            lcd.clear();
            lcd.setCursor(0,0);
            lcd.print(F("** Irrigation **"));
            lcd.setCursor(0,1);
            lcd.print(F("**   Halted   **"));
            delay(2000);
            lastValve = -1;
          }
        }
        //
        else if (state == RUN_ALL_ZONES)
        {
          if (lastValve != valveNumber)
          {
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              if (i == 0 || i == valveNumber)
              {
                gw.send(msg1valve.setSensor(i).set(true), false);
              }
              else
              {
                gw.send(msg1valve.setSensor(i).set(false), false);
              }
            }
          }
          lastValve = valveNumber;
          fastToggleLed();
          if (state != lastState)
          {
            valveNumber = 1;
            updateRelays(ALL_VALVES_OFF);
            DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
          }
          unsigned long nowMillis = millis();
          if (nowMillis - startMillis < VALVE_RESET_TIME)
          {
            updateRelays(ALL_VALVES_OFF);
          }
          else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
          {
            updateRelays(BITSHIFT_VALVE_NUMBER);
          }
          else
          {
            DEBUG_PRINTLN(F("Changing Valves..."));
            updateRelays(ALL_VALVES_OFF);
            startMillis = millis();
            valveNumber++;
            if (valveNumber > NUMBER_OF_VALVES)
            {
              state = CYCLE_COMPLETE;
              startMillis = millis();
              lastValve = -1;
              lastTimeRun = now();
              saveDateToEEPROM(lastTimeRun);
              for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
              {
                gw.send(msg1valve.setSensor(i).set(false), false);
              }
              DEBUG_PRINT(F("State = "));
              DEBUG_PRINTLN(state);
            }
          }
        }
        //
        else if (state == RUN_SINGLE_ZONE)
        {
          fastToggleLed();
          if (state != lastState)
          {
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              if (i == 0 || i == valveNumber)
              {
                gw.send(msg1valve.setSensor(i).set(true), false);
              }
              else
              {
                gw.send(msg1valve.setSensor(i).set(false), false);
              }
            }
            DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
            DEBUG_PRINT(F("Zone: "));
            DEBUG_PRINTLN(valveNumber);
          }
          unsigned long nowMillis = millis();
          if (nowMillis - startMillis < VALVE_RESET_TIME)
          {
            updateRelays(ALL_VALVES_OFF);
          }
          else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
          {
            updateRelays(BITSHIFT_VALVE_NUMBER);
          }
          else
          {
            updateRelays(ALL_VALVES_OFF);
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              gw.send(msg1valve.setSensor(i).set(false), false);
            }
            state = CYCLE_COMPLETE;
            startMillis = millis();
            DEBUG_PRINT(F("State = "));
            DEBUG_PRINTLN(state);
          }
          lastTimeRun = now();
        }
        else if (state == CYCLE_COMPLETE)
        {
          if (millis() - startMillis < 30000UL)
          {
            fastToggleLed();
          }
          else
          {
            state = STAND_BY_ALL_OFF;
          }
        }
        else if (state = ZONE_SELECT_MENU)
        {
          displayMenu();
        }
        lastState = state;
      }
      //
      void displayMenu(void)
      {
        static byte lastMenuState = -1;
        static int lastSecond;
        if (menuState != lastMenuState)
        {
          lcd.clear();
          lcd.setCursor(0, 0);
          lcd.print(valveNickName[menuState]);
          lcd.setCursor(0, 1);
          lcd.print(F("Starting"));
          DEBUG_PRINT(valveNickName[menuState]);
          Serial.print(F(" Starting Shortly"));
        }
        int thisSecond = (millis() - menuTimer) / 1000UL;
        if (thisSecond != lastSecond && thisSecond < 8)
        {
          lcd.print(F("."));
          Serial.print(".");
        }
        lastSecond = thisSecond;
        if (millis() - menuTimer > 10000UL)
        {
          startMillis = millis();
          if (menuState == 0)
          {
            valveNumber = 1;
            state = RUN_ALL_ZONES;
          }
          else
          {
            valveNumber = menuState;
            state = RUN_SINGLE_ZONE;
          }
        }
        else
        {
      
        }
        lastMenuState = menuState;
      }
      //
      void updateRelays(int value)
      {
        digitalWrite(latchPin, LOW);
        shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
        shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
        digitalWrite(latchPin, HIGH);
      }
      //
      void PushButton() //interrupt with debounce
      {
        static unsigned long last_interrupt_time = 0;
        unsigned long interrupt_time = millis();
        if (interrupt_time - last_interrupt_time > 200)
        {
          buttonPushed = true;
        }
        last_interrupt_time = interrupt_time;
      }
      //
      void fastToggleLed()
      {
        static unsigned long fastLedTimer;
        if (millis() - fastLedTimer >= 100UL)
        {
          digitalWrite(ledPin, !digitalRead(ledPin));
          fastLedTimer = millis ();
        }
      }
      //
      void slowToggleLED ()
      {
        static unsigned long slowLedTimer;
        if (millis() - slowLedTimer >= 1250UL)
        {
          digitalWrite(ledPin, !digitalRead(ledPin));
          slowLedTimer = millis ();
        }
      }
      //
      void getVariables(const MyMessage &message)
      {
        boolean zoneTimeUpdate = false;
        if (message.isAck())
        {
          DEBUG_PRINTLN(F("This is an ack from gateway"));
        }
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          if (message.sensor == i)
          {
            if (message.type == V_LIGHT)
            {
              int switchState = atoi(message.data);
              if (switchState == 0)
              {
                state = STAND_BY_ALL_OFF;
                DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
              }
              else
              {
                if (i == 0)
                {
                  state = RUN_ALL_ZONES;
                  valveNumber = 1;
                  DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
                }
                else
                {
                  state = RUN_SINGLE_ZONE;
                  valveNumber = i;
                  DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
                  DEBUG_PRINTLN(i);
                }
              }
              startMillis = millis();
            }
            else if (message.type == V_VAR1)
            {
              int variable1 = atoi(message.data);// RUN_ALL_ZONES time
              DEBUG_PRINT(F("Recieved variable1 valve:"));
              DEBUG_PRINT(i);
              DEBUG_PRINT(F(" = "));
              DEBUG_PRINTLN(variable1);
              if (variable1 != allZoneTime[i])
              {
                allZoneTime[i] = variable1;
      
                zoneTimeUpdate = true;
              }
            }
            else if (message.type == V_VAR2)
            {
              int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
              DEBUG_PRINT(F("Recieved variable2 valve:"));
              DEBUG_PRINT(i);
              DEBUG_PRINT(F(" = "));
              DEBUG_PRINTLN(variable2);
              if (variable2 != valveSoloTime[i])
              {
                valveSoloTime[i] = variable2;
                zoneTimeUpdate = true;
              }
            }
            else if (message.type == V_VAR3)
            {
              String newMessage = String(message.data);
              if (newMessage.length() == 0) 
              {
                DEBUG_PRINT(F("No Name Recieved for zone "));
                DEBUG_PRINTLN(i);
                break;
              }
              if (newMessage.length() > 16)
              {
                newMessage.substring(0, 16);
              }
              valveNickName[i] = "";
              valveNickName[i] += newMessage;
              DEBUG_PRINT(F("Recieved new name for zone "));
              DEBUG_PRINT(i);
              DEBUG_PRINT(F(" and it is now called: "));
              DEBUG_PRINTLN(valveNickName[i]);
            }
          }
        }
        if (zoneTimeUpdate)
        {
          //
          DEBUG_PRINTLN(F("New Zone Times Recieved..."));
          for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
          {
            if (i != 0)
            {
              DEBUG_PRINT(F("Zone "));
              DEBUG_PRINT(i);
              DEBUG_PRINT(F(" individual time: "));
              DEBUG_PRINT(valveSoloTime[i]);
              DEBUG_PRINT(F(" group time: "));
              DEBUG_PRINTLN(allZoneTime[i]);
              recentUpdate = true;
            }
          }
        }
        else
        {
          recentUpdate = false;
        }
      }
      //
      void updateDisplay()
      {
        static unsigned long lastUpdateTime;
        static boolean displayToggle = false;
        //static byte toggleCounter = 0;
        static SprinklerStates lastDisplayState;
        if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
        {
          displayToggle = !displayToggle;
          switch (state) {
            case STAND_BY_ALL_OFF:
              //
              fastClear();
              lcd.setCursor(0, 0);
              if (displayToggle)
              {
                lcd.print(F("  System Ready "));
                if (clockUpdating)
                {
                  lcd.setCursor(15, 0);
                  lcd.write(byte(0));
                }
                lcd.setCursor(0, 1);
                lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
                lcd.print(hourFormat12());
                lcd.print(minute() < 10 ? F(":0") : F(":"));
                lcd.print(minute());
                lcd.print(isAM() ? F("am") : F("pm"));
                lcd.print(month() < 10 ? F(" 0") : F(" "));
                lcd.print(month());
                lcd.print(day() < 10 ? F("/0") : F("/"));
                lcd.print(day());
                lcd.print(F("/"));
                lcd.print(year() % 100);
              }
              else
              {
                lcd.print(F("  Last Watered "));
                if (clockUpdating)
                {
                  lcd.setCursor(15, 0);
                  lcd.write(byte(0));
                }
                lcd.setCursor(0, 1);
                lcd.print(dayOfWeek[weekday(lastTimeRun)]);
                lcd.setCursor(11, 1);
                lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
                lcd.print(month(lastTimeRun));
                lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/"));
                lcd.print(day(lastTimeRun));
              }
              break;
            case RUN_SINGLE_ZONE:
              //
              fastClear();
              lcd.setCursor(0, 0);
              if (displayToggle)
              {
                lcd.print(F("Single Zone Mode"));
                lcd.setCursor(0, 1);
                lcd.print(F(" Zone:"));
                if (valveNumber < 10) lcd.print(F("0"));
                lcd.print(valveNumber);
                lcd.print(F(" Active"));
              }
              else
              {
                lcd.print(F(" Time Remaining "));
                lcd.setCursor(0, 1);
                if (valveSoloTime[valveNumber] == 0)
                {
                  lcd.print(F(" No Valve Time "));
                }
                else
                {
                  unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
                  lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
                  lcd.print(timeRemaining / 60);
                  lcd.print("min");
                  lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
                  lcd.print(timeRemaining % 60);
                  lcd.print("sec  ");
                }
              }
              break;
            case RUN_ALL_ZONES:
              //
              fastClear();
              lcd.setCursor(0, 0);
              if (displayToggle)
              {
                lcd.print(F(" All-Zone  Mode "));
                lcd.setCursor(0, 1);
                lcd.print(F(" Zone:"));
                if (valveNumber < 10) lcd.print(F("0"));
                lcd.print(valveNumber);
                lcd.print(F(" Active "));
              }
              else
              {
                lcd.print(F(" Time Remaining "));
                lcd.setCursor(0, 1);
                int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
                lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
                lcd.print(timeRemaining / 60);
                lcd.print("min");
                lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
                lcd.print(timeRemaining % 60);
                lcd.print("sec  ");
              }
              break;
            case CYCLE_COMPLETE:
              //
              if (displayToggle)
              {
                lcd.setCursor(0, 0);
                lcd.print(F(" Watering Cycle "));
                lcd.setCursor(0, 1);
                lcd.print(F("    Complete    "));
              }
              else
              {
                int totalTimeRan = 0;
                for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
                {
                  totalTimeRan += allZoneTime[i];
                }
                lcd.setCursor(0, 0);
                lcd.print(F(" Total Time Run "));
                lcd.setCursor(0, 1);
                lcd.print(totalTimeRan < 10 ? "   0" : "   ");
                lcd.print(totalTimeRan);
                lcd.print(" Minutes   ");
              }
          }
          lastUpdateTime = millis();
        }
        lastDisplayState = state;
      }
      void receiveTime(time_t newTime)
      {
        DEBUG_PRINTLN(F("Time value received and updated..."));
        int lastSecond = second();
        int lastMinute = minute();
        int lastHour = hour();
        setTime(newTime);
        if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
        {
          DEBUG_PRINTLN(F("Clock updated...."));
          DEBUG_PRINT(F("Sensor's time currently set to:"));
          DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
          DEBUG_PRINT(hourFormat12());
          DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
          DEBUG_PRINT(minute());
          DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
          DEBUG_PRINT(month());
          DEBUG_PRINT(F("/"));
          DEBUG_PRINT(day());
          DEBUG_PRINT(F("/"));
          DEBUG_PRINTLN(year());
          DEBUG_PRINTLN(dayOfWeek[weekday()]);
          showTime = false;
        }
        else
        {
          DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
        }
        clockUpdating = false;
      }
      void fastClear()
      {
        lcd.setCursor(0, 0);
        lcd.print(F("                "));
        lcd.setCursor(0, 1);
        lcd.print(F("                "));
      }
      //
      void updateClock()
      {
        static unsigned long lastVeraGetTime;
        if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
        {
          DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
          lcd.setCursor(15, 0);
          lcd.write(byte(0));
          clockUpdating = true;
          gw.requestTime(receiveTime);
          lastVeraGetTime = millis();
        }
      }
      //
      void saveDateToEEPROM(unsigned long theDate)
      {
        DEBUG_PRINTLN(F("Saving Last Run date"));
        if (gw.loadState(0) != 0xFF)
        {
          gw.saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
        }
        //
        for (int i = 1; i < 5; i++)
        {
          gw.saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
        }
      }
      //
      void goGetValveTimes()
      {
        static unsigned long valveUpdateTime;
        static byte valveIndex = 1;
        if (millis() - valveUpdateTime >= 300000UL / NUMBER_OF_VALVES)// update each valve once every 5 mins (distributes the traffic)
        {
          DEBUG_PRINTLN(F("Calling for Valve Data..."));
          lcd.setCursor(15, 0);
          lcd.write(byte(1)); //lcd.write(1);
          gw.request(valveIndex, V_VAR1);
          gw.request(valveIndex, V_VAR2);
          gw.request(valveIndex, V_VAR3);
          valveUpdateTime = millis();
          valveIndex++;
          if (valveIndex > NUMBER_OF_VALVES + 1)
          {
            valveIndex = 1;
          }
        }
      }```
      posted in My Project
      moffen666
      moffen666

    Latest posts made by moffen666

    • RE: Adjust time?

      Amazing, what a great community here and over at Domoticz....

      Thank you all so much, just makes me glad!

      Regards

      posted in Troubleshooting
      moffen666
      moffen666
    • RE: Adjust time?

      Thx tekka

      Im way in over my head here, but do I adjust the callback function in my Irrigation controller sketch.

      The time reported from my sensors in the webUI is correct its only the time on my LCD in the irrigation controller that's off -2h.

      Regards

      posted in Troubleshooting
      moffen666
      moffen666
    • RE: Adjust time?

      This is from the Domoticz forum:

      At the moment this is used:
      
      case I_TIME:
      //send time in seconds from 1970 with timezone offset
      {
      time_t atime = mytime(NULL);
      struct tm ltime;
      localtime_r(&atime, &ltime);
      sstr << mktime(&ltime);
      SendCommand(node_id, child_sensor_id, message_type, I_TIME, sstr.str());
      }
      
      I would expect it to be local time now
      
      If your gateway system set to the correct timezone ?
      
      

      Does the serial gateway modify the time before sending it to the nodes/sensors?

      posted in Troubleshooting
      moffen666
      moffen666
    • RE: Adjust time?

      thx, dunno how to solve that tho, maybe someone else had the same problem?

      posted in Troubleshooting
      moffen666
      moffen666
    • RE: Adjust time?

      Dident find any similar line, but could this be the problem?

      https://www.domoticz.com/forum/viewtopic.php?f=6&t=6391

      posted in Troubleshooting
      moffen666
      moffen666
    • RE: Adjust time?

      I checked the time on my Raspberry with Putty and it seems correct.

      @hek: How do you mean, should I use TimeAwareSensor.ino Im seeing this problem on 'IrrigationController.ino' atm

      http://www.mysensors.org/build/irrigation

      posted in Troubleshooting
      moffen666
      moffen666
    • Adjust time?

      Hello

      My controller is Domoticz and it set up to show local time so that works, but the time in my sensors/node is off by 2h.

      My time 20:00
      Sensor shows 18:00

      Where do I correct this, can't seem to find any config file?

      Any idea?

      Regards

      posted in Troubleshooting
      moffen666
      moffen666
    • RE: Irrigation Controller (up to 16 valves with Shift Registers)

      Thx Bulldog for all the help, everything seems to be working as it should now.

      Keep up the good work 👍

      Updated code for Domoticz.

      /*
      MySprinkler for MySensors
      
      Arduino Multi-Zone Sprinkler Control
      
      May 31, 2015
      
      *** Version 2.0
      
      *** Upgraded to http://MySensors.org version 1.4.1
      *** Expanded for up to 16 Valves
      *** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
      *** Switch to bitshift method vs byte arrays
      *** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
      *** Added optional LCD display featuring remaining time, date last ran & current time
      *** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively
      *** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone)
      *** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names)
      
      Utilizing your Vera home automation controller and the MySensors.org gateway you can
      control up to a sixteen zone irrigation system with only three digital pins.  This sketch
      will create NUMBER_OF_VALVES + 1 devices on your Vera controller
      
      This sketch features the following:
      
      * Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.
      * Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n)
        using Variable1 as the "ON" time in minutes in each of the vera devices created.
      * Use the individual zone controller to activate a single zone.  This feature uses
        Variable2 as the "ON" time for each individual device/zone.
      * Connect according to pinout below and uses Shift Registers as to allow the MySensors
        standard radio configuration and still leave available digital pins
      * Turning on any zone will stop the current process and begin that particular process.
      * Turning off any zone will stop the current process and turn off all zones.
      * To push your new time intervals for your zones, simply change the variable on your Vera and
        your arduino will call to Vera once a minute and update accordingly.  Variables will also be
        requested when the device is first powered on.
      * Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program
      * LED status indicator
      
      PARTS LIST:
      Available from the MySensors store - http://www.mysensors.org/store/
      * Relays (8 channel)
      * Female Pin Header Connector Strip
      * Prototype Universal Printed Circuit Boards (PCB)
      * NRF24L01 Radio
      * Arduino (I used a Pro Mini)
      * FTDI USB to TTL Serial Adapter
      * Capacitors (10uf and .1uf)
      * 3.3v voltage regulator
      * Resistors (270 & 10K)
      * Female Dupont Cables
      * 1602 LCD (with I2C Interface)
      * LED
      * Push button
      * Shift Register (SN74HC595)
      * 2 Pole 5mm Pitch PCB Mount Screw Terminal Block
      * 3 Pole 5mm Pitch PCB Mount Screw Terminal Block
      * 22-24 gauge wire or similar (I used Cat5/Cat6 cable)
      * 18 gauge wire (for relay)
      * Irrigation Power Supply (24-Volt/750 mA Transformer)
      
      
      INSTRUCTIONS:
      
      * A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI
      * After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to
        A4 and A5) and relays, and load the sketch.
      * Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
      * Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
        the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
        you may use the defaulet zone names by leaving Variable3 blank.
      * Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
      * Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
        on the serial monitor.
      * Your arduino should slow-flash, indicating that it is in ready mode.
      * There are multiple debug serial prints that can be monitored to assure that it is operating properly.
      * ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours
      
      Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain
      */
      //
      #include <Wire.h>
      #include <Time.h>
      #include <MySensor.h>
      #include <SPI.h>
      #include <LiquidCrystal.h>
      #include <LiquidCrystal_I2C.h>
      
      
      //
      #define NUMBER_OF_VALVES 4  // Change this to set your valve count up to 16.
      #define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
      #define RADIO_ID AUTO  // Change this to fix your Radio ID or use Auto
      
      #define SKETCH_NAME "MySprinkler Domoticz"
      #define SKETCH_VERSION "2.0"
      //
      #define CHILD_ID_SPRINKLER 0
      //
      //#define ACTIVE_LOW // comment out this line if your relays are active high
      //
      #define DEBUG_ON   // comment out to supress serial monitor output
      //
      #ifdef ACTIVE_LOW
      #define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
      #define ALL_VALVES_OFF 0xFFFF
      #else
      #define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
      #define ALL_VALVES_OFF 0U
      #endif
      //
      #ifdef DEBUG_ON
      #define DEBUG_PRINT(x)   Serial.print(x)
      #define DEBUG_PRINTLN(x) Serial.println(x)
      #define SERIAL_START(x)  Serial.begin(x)
      #else
      #define DEBUG_PRINT(x)
      #define DEBUG_PRINTLN(x)
      #define SERIAL_START(x)
      #endif
      //
      typedef enum {
        STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
      }
      SprinklerStates;
      //
      SprinklerStates state = STAND_BY_ALL_OFF;
      SprinklerStates lastState;
      byte menuState = 0;
      unsigned long menuTimer;
      byte countDownTime = 10;
      //
      int allZoneTime [NUMBER_OF_VALVES + 1]= {0, 1, 1, 1, 1};     // Insert values in min, 0 = all zone (always 0) this is a 4 chan relay
      int valveSoloTime [NUMBER_OF_VALVES + 1]= {0, 1, 1, 1, 1};   // Insert values in min, 0 = all zone (always 0) this is a 4 chan relay
      int valveNumber;
      int lastValve;
      unsigned long startMillis;
      const int ledPin = 5;
      const int waterButtonPin = 3;
      boolean buttonPushed = false;
      boolean showTime = true;
      boolean clockUpdating = false;
      boolean recentUpdate = true;
      const char *dayOfWeek[] = {
        "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
      };
      // Name your Zones here or use Vera to edit them by adding a name in Variable3...
      String valveNickName[17] = {
        "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
      };
      //
      time_t lastTimeRun = 0;
      //Setup Shift Register...
      const int latchPin = 8;
      const int clockPin = 4;
      const int dataPin  = 7;
      //
      byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
      byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
      // Set the pins on the I2C chip used for LCD connections:
      //                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
      LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27
      MySensor gw;
      //
      MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
      MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
      MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);
      //
      void setup()
      {
        SERIAL_START(115200);
        DEBUG_PRINTLN(F("Initialising..."));
        pinMode(latchPin, OUTPUT);
        pinMode(clockPin, OUTPUT);
        pinMode(dataPin, OUTPUT);
        pinMode(ledPin, OUTPUT);
        pinMode(waterButtonPin, INPUT_PULLUP);
        //pinMode(waterButtonPin, INPUT);
        attachInterrupt(1, PushButton, RISING); //May need to change for your Arduino model
        digitalWrite (ledPin, HIGH);
        DEBUG_PRINTLN(F("Turning All Valves Off..."));
        updateRelays(ALL_VALVES_OFF);
        //delay(5000);
        lcd.begin(16, 2); //(16 characters and 2 line display)
        lcd.clear();
        lcd.backlight();
        lcd.createChar(0, clock);
        lcd.createChar(1, raindrop);
        //
        //check for saved date in EEPROM
        DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
        delay(500);
        if (gw.loadState(0) == 0xFF); // EEPROM flag
        {
          DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
          for (int i = 0; i < 4 ; i++)
          {
            lastTimeRun = lastTimeRun << 8;
            lastTimeRun = lastTimeRun | gw.loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
          }
        }
        gw.begin(getVariables, RADIO_ID, false); // Change 'false' to 'true' to create a Radio repeating node
        gw.sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          gw.present(i, S_LIGHT);
        }
        DEBUG_PRINTLN(F("Sensor Presentation Complete"));
        //
        digitalWrite (ledPin, LOW);
        DEBUG_PRINTLN(F("Ready..."));
        //
        lcd.setCursor(0, 0);
        lcd.print(F(" Syncing Time  "));
        lcd.setCursor(15, 0);
        lcd.write(byte(0));
        lcd.setCursor(0, 1);
        int clockCounter = 0;
        while (timeStatus() == timeNotSet && clockCounter < 21)
        {
          gw.process();
          gw.requestTime(receiveTime);
          DEBUG_PRINTLN(F("Requesting time from Gateway:"));
          delay(1000);
          lcd.print(".");
          clockCounter++;
          if (clockCounter > 16)
          {
            DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
            lcd.clear();
            lcd.print(F("  Failed Clock  "));
            lcd.setCursor(0, 1);
            lcd.print(F(" Syncronization "));
            delay(2000);
            break;
          }
        }
        //
        lcd.clear();
      
        /*
        //Update valve data when first powered on
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          lcd.print(F(" Updating  "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Valve Data: "));
          lcd.print(i);
          boolean flashIcon = false;
          DEBUG_PRINT(F("Calling for Valve "));
          DEBUG_PRINT(i);
          DEBUG_PRINTLN(F(" Data..."));
          while (gw.process() == false)
          {
            lcd.setCursor(15, 0);
            flashIcon = !flashIcon;
            flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
            gw.request(i, V_VAR1);
            delay(100);
          }
          while (gw.process() == false)
          {
            lcd.setCursor(15, 0);
            flashIcon = !flashIcon;
            flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
            gw.request(i, V_VAR2);
            delay(100);
          }
          while (gw.process() == false)
          {
            lcd.setCursor(15, 0);
            flashIcon = !flashIcon;
            flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
            gw.request(i, V_VAR3);
            delay(100);
          }
        }
        */
        lcd.clear();
      }
      //
      void loop()
      {
        gw.process();
        updateClock();
        updateDisplay();
        //goGetValveTimes();
        //
        if (buttonPushed)
        {
          menuTimer = millis();
          DEBUG_PRINTLN(F("Button Pressed"));
          if (state == STAND_BY_ALL_OFF)
          {
            state = ZONE_SELECT_MENU;
            menuState = 0;
          }
          else if (state == ZONE_SELECT_MENU)
          {
            menuState++;
            if (menuState > NUMBER_OF_VALVES)
            {
              menuState = 0;
            }
          }
          else
          {
            state = STAND_BY_ALL_OFF;
          }
          buttonPushed = false;
        }
        if (state == STAND_BY_ALL_OFF)
        {
          slowToggleLED ();
          if (state != lastState)
          {
            updateRelays(ALL_VALVES_OFF);
            DEBUG_PRINTLN(F("State Changed... all Zones off"));
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              delay(50);
              gw.send(msg1valve.setSensor(i).set(false), false);
            }
            lcd.clear();
            lcd.setCursor(0,0);
            lcd.print(F("** Irrigation **"));
            lcd.setCursor(0,1);
            lcd.print(F("**   Halted   **"));
            delay(2000);
            lastValve = -1;
          }
        }
        //
        else if (state == RUN_ALL_ZONES)
        {
          if (lastValve != valveNumber)
          {
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              if (i == 0 || i == valveNumber)
              {
                gw.send(msg1valve.setSensor(i).set(true), false);
              }
              else
              {
                gw.send(msg1valve.setSensor(i).set(false), false);
              }
            }
          }
          lastValve = valveNumber;
          fastToggleLed();
          if (state != lastState)
          {
            valveNumber = 1;
            updateRelays(ALL_VALVES_OFF);
            DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
          }
          unsigned long nowMillis = millis();
          if (nowMillis - startMillis < VALVE_RESET_TIME)
          {
            updateRelays(ALL_VALVES_OFF);
          }
          else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
          {
            updateRelays(BITSHIFT_VALVE_NUMBER);
          }
          else
          {
            DEBUG_PRINTLN(F("Changing Valves..."));
            updateRelays(ALL_VALVES_OFF);
            startMillis = millis();
            valveNumber++;
            if (valveNumber > NUMBER_OF_VALVES)
            {
              state = CYCLE_COMPLETE;
              startMillis = millis();
              lastValve = -1;
              lastTimeRun = now();
              saveDateToEEPROM(lastTimeRun);
              for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
              {
                gw.send(msg1valve.setSensor(i).set(false), false);
              }
              DEBUG_PRINT(F("State = "));
              DEBUG_PRINTLN(state);
            }
          }
        }
        //
        else if (state == RUN_SINGLE_ZONE)
        {
          fastToggleLed();
          if (state != lastState)
          {
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              if (i == 0 || i == valveNumber)
              {
                gw.send(msg1valve.setSensor(i).set(true), false);
              }
              else
              {
                gw.send(msg1valve.setSensor(i).set(false), false);
              }
            }
            DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
            DEBUG_PRINT(F("Zone: "));
            DEBUG_PRINTLN(valveNumber);
          }
          unsigned long nowMillis = millis();
          if (nowMillis - startMillis < VALVE_RESET_TIME)
          {
            updateRelays(ALL_VALVES_OFF);
          }
          else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
          {
            updateRelays(BITSHIFT_VALVE_NUMBER);
          }
          else
          {
            updateRelays(ALL_VALVES_OFF);
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              gw.send(msg1valve.setSensor(i).set(false), false);
            }
            state = CYCLE_COMPLETE;
            startMillis = millis();
            DEBUG_PRINT(F("State = "));
            DEBUG_PRINTLN(state);
          }
          lastTimeRun = now();
        }
        else if (state == CYCLE_COMPLETE)
        {
          if (millis() - startMillis < 30000UL)
          {
            fastToggleLed();
          }
          else
          {
            state = STAND_BY_ALL_OFF;
          }
        }
        else if (state = ZONE_SELECT_MENU)
        {
          displayMenu();
        }
        lastState = state;
      }
      //
      void displayMenu(void)
      {
        static byte lastMenuState = -1;
        static int lastSecond;
        if (menuState != lastMenuState)
        {
          lcd.clear();
          lcd.setCursor(0, 0);
          lcd.print(valveNickName[menuState]);
          lcd.setCursor(0, 1);
          lcd.print(F("Starting"));
          DEBUG_PRINT(valveNickName[menuState]);
          Serial.print(F(" Starting Shortly"));
        }
        int thisSecond = (millis() - menuTimer) / 1000UL;
        if (thisSecond != lastSecond && thisSecond < 8)
        {
          lcd.print(F("."));
          Serial.print(".");
        }
        lastSecond = thisSecond;
        if (millis() - menuTimer > 10000UL)
        {
          startMillis = millis();
          if (menuState == 0)
          {
            valveNumber = 1;
            state = RUN_ALL_ZONES;
          }
          else
          {
            valveNumber = menuState;
            state = RUN_SINGLE_ZONE;
          }
        }
        else
        {
      
        }
        lastMenuState = menuState;
      }
      //
      void updateRelays(int value)
      {
        digitalWrite(latchPin, LOW);
        shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
        shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
        digitalWrite(latchPin, HIGH);
      }
      //
      void PushButton() //interrupt with debounce
      {
        static unsigned long last_interrupt_time = 0;
        unsigned long interrupt_time = millis();
        if (interrupt_time - last_interrupt_time > 200)
        {
          buttonPushed = true;
        }
        last_interrupt_time = interrupt_time;
      }
      //
      void fastToggleLed()
      {
        static unsigned long fastLedTimer;
        if (millis() - fastLedTimer >= 100UL)
        {
          digitalWrite(ledPin, !digitalRead(ledPin));
          fastLedTimer = millis ();
        }
      }
      //
      void slowToggleLED ()
      {
        static unsigned long slowLedTimer;
        if (millis() - slowLedTimer >= 1250UL)
        {
          digitalWrite(ledPin, !digitalRead(ledPin));
          slowLedTimer = millis ();
        }
      }
      //
      void getVariables(const MyMessage &message)
      {
        boolean zoneTimeUpdate = false;
        if (message.isAck())
        {
          DEBUG_PRINTLN(F("This is an ack from gateway"));
        }
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          if (message.sensor == i)
          {
            if (message.type == V_LIGHT)
            {
              int switchState = atoi(message.data);
              if (switchState == 0)
              {
                state = STAND_BY_ALL_OFF;
                DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
              }
              else
              {
                if (i == 0)
                {
                  state = RUN_ALL_ZONES;
                  valveNumber = 1;
                  DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
                }
                else
                {
                  state = RUN_SINGLE_ZONE;
                  valveNumber = i;
                  DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
                  DEBUG_PRINTLN(i);
                }
              }
              startMillis = millis();
            }
            else if (message.type == V_VAR1)
            {
              int variable1 = atoi(message.data);// RUN_ALL_ZONES time
              DEBUG_PRINT(F("Recieved variable1 valve:"));
              DEBUG_PRINT(i);
              DEBUG_PRINT(F(" = "));
              DEBUG_PRINTLN(variable1);
              if (variable1 != allZoneTime[i])
              {
                allZoneTime[i] = variable1;
      
                zoneTimeUpdate = true;
              }
            }
            else if (message.type == V_VAR2)
            {
              int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
              DEBUG_PRINT(F("Recieved variable2 valve:"));
              DEBUG_PRINT(i);
              DEBUG_PRINT(F(" = "));
              DEBUG_PRINTLN(variable2);
              if (variable2 != valveSoloTime[i])
              {
                valveSoloTime[i] = variable2;
                zoneTimeUpdate = true;
              }
            }
            else if (message.type == V_VAR3)
            {
              String newMessage = String(message.data);
              if (newMessage.length() == 0) 
              {
                DEBUG_PRINT(F("No Name Recieved for zone "));
                DEBUG_PRINTLN(i);
                break;
              }
              if (newMessage.length() > 16)
              {
                newMessage.substring(0, 16);
              }
              valveNickName[i] = "";
              valveNickName[i] += newMessage;
              DEBUG_PRINT(F("Recieved new name for zone "));
              DEBUG_PRINT(i);
              DEBUG_PRINT(F(" and it is now called: "));
              DEBUG_PRINTLN(valveNickName[i]);
            }
          }
        }
        if (zoneTimeUpdate)
        {
          //
          DEBUG_PRINTLN(F("New Zone Times Recieved..."));
          for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
          {
            if (i != 0)
            {
              DEBUG_PRINT(F("Zone "));
              DEBUG_PRINT(i);
              DEBUG_PRINT(F(" individual time: "));
              DEBUG_PRINT(valveSoloTime[i]);
              DEBUG_PRINT(F(" group time: "));
              DEBUG_PRINTLN(allZoneTime[i]);
              recentUpdate = true;
            }
          }
        }
        else
        {
          recentUpdate = false;
        }
      }
      //
      void updateDisplay()
      {
        static unsigned long lastUpdateTime;
        static boolean displayToggle = false;
        //static byte toggleCounter = 0;
        static SprinklerStates lastDisplayState;
        if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
        {
          displayToggle = !displayToggle;
          switch (state) {
            case STAND_BY_ALL_OFF:
              //
              fastClear();
              lcd.setCursor(0, 0);
              if (displayToggle)
              {
                lcd.print(F("  System Ready "));
                if (clockUpdating)
                {
                  lcd.setCursor(15, 0);
                  lcd.write(byte(0));
                }
                lcd.setCursor(0, 1);
                lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
                lcd.print(hourFormat12());
                lcd.print(minute() < 10 ? F(":0") : F(":"));
                lcd.print(minute());
                lcd.print(isAM() ? F("am") : F("pm"));
                lcd.print(month() < 10 ? F(" 0") : F(" "));
                lcd.print(month());
                lcd.print(day() < 10 ? F("/0") : F("/"));
                lcd.print(day());
                lcd.print(F("/"));
                lcd.print(year() % 100);
              }
              else
              {
                lcd.print(F("  Last Watered "));
                if (clockUpdating)
                {
                  lcd.setCursor(15, 0);
                  lcd.write(byte(0));
                }
                lcd.setCursor(0, 1);
                lcd.print(dayOfWeek[weekday(lastTimeRun)]);
                lcd.setCursor(11, 1);
                lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
                lcd.print(month(lastTimeRun));
                lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/"));
                lcd.print(day(lastTimeRun));
              }
              break;
            case RUN_SINGLE_ZONE:
              //
              fastClear();
              lcd.setCursor(0, 0);
              if (displayToggle)
              {
                lcd.print(F("Single Zone Mode"));
                lcd.setCursor(0, 1);
                lcd.print(F(" Zone:"));
                if (valveNumber < 10) lcd.print(F("0"));
                lcd.print(valveNumber);
                lcd.print(F(" Active"));
              }
              else
              {
                lcd.print(F(" Time Remaining "));
                lcd.setCursor(0, 1);
                if (valveSoloTime[valveNumber] == 0)
                {
                  lcd.print(F(" No Valve Time "));
                }
                else
                {
                  unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
                  lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
                  lcd.print(timeRemaining / 60);
                  lcd.print("min");
                  lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
                  lcd.print(timeRemaining % 60);
                  lcd.print("sec  ");
                }
              }
              break;
            case RUN_ALL_ZONES:
              //
              fastClear();
              lcd.setCursor(0, 0);
              if (displayToggle)
              {
                lcd.print(F(" All-Zone  Mode "));
                lcd.setCursor(0, 1);
                lcd.print(F(" Zone:"));
                if (valveNumber < 10) lcd.print(F("0"));
                lcd.print(valveNumber);
                lcd.print(F(" Active "));
              }
              else
              {
                lcd.print(F(" Time Remaining "));
                lcd.setCursor(0, 1);
                int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
                lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
                lcd.print(timeRemaining / 60);
                lcd.print("min");
                lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
                lcd.print(timeRemaining % 60);
                lcd.print("sec  ");
              }
              break;
            case CYCLE_COMPLETE:
              //
              if (displayToggle)
              {
                lcd.setCursor(0, 0);
                lcd.print(F(" Watering Cycle "));
                lcd.setCursor(0, 1);
                lcd.print(F("    Complete    "));
              }
              else
              {
                int totalTimeRan = 0;
                for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
                {
                  totalTimeRan += allZoneTime[i];
                }
                lcd.setCursor(0, 0);
                lcd.print(F(" Total Time Run "));
                lcd.setCursor(0, 1);
                lcd.print(totalTimeRan < 10 ? "   0" : "   ");
                lcd.print(totalTimeRan);
                lcd.print(" Minutes   ");
              }
          }
          lastUpdateTime = millis();
        }
        lastDisplayState = state;
      }
      void receiveTime(time_t newTime)
      {
        DEBUG_PRINTLN(F("Time value received and updated..."));
        int lastSecond = second();
        int lastMinute = minute();
        int lastHour = hour();
        setTime(newTime);
        if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
        {
          DEBUG_PRINTLN(F("Clock updated...."));
          DEBUG_PRINT(F("Sensor's time currently set to:"));
          DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
          DEBUG_PRINT(hourFormat12());
          DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
          DEBUG_PRINT(minute());
          DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
          DEBUG_PRINT(month());
          DEBUG_PRINT(F("/"));
          DEBUG_PRINT(day());
          DEBUG_PRINT(F("/"));
          DEBUG_PRINTLN(year());
          DEBUG_PRINTLN(dayOfWeek[weekday()]);
          showTime = false;
        }
        else
        {
          DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
        }
        clockUpdating = false;
      }
      void fastClear()
      {
        lcd.setCursor(0, 0);
        lcd.print(F("                "));
        lcd.setCursor(0, 1);
        lcd.print(F("                "));
      }
      //
      void updateClock()
      {
        static unsigned long lastVeraGetTime;
        if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
        {
          DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
          lcd.setCursor(15, 0);
          lcd.write(byte(0));
          clockUpdating = true;
          gw.requestTime(receiveTime);
          lastVeraGetTime = millis();
        }
      }
      //
      void saveDateToEEPROM(unsigned long theDate)
      {
        DEBUG_PRINTLN(F("Saving Last Run date"));
        if (gw.loadState(0) != 0xFF)
        {
          gw.saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
        }
        //
        for (int i = 1; i < 5; i++)
        {
          gw.saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
        }
      }
      //
      void goGetValveTimes()
      {
        static unsigned long valveUpdateTime;
        static byte valveIndex = 1;
        if (millis() - valveUpdateTime >= 300000UL / NUMBER_OF_VALVES)// update each valve once every 5 mins (distributes the traffic)
        {
          DEBUG_PRINTLN(F("Calling for Valve Data..."));
          lcd.setCursor(15, 0);
          lcd.write(byte(1)); //lcd.write(1);
          gw.request(valveIndex, V_VAR1);
          gw.request(valveIndex, V_VAR2);
          gw.request(valveIndex, V_VAR3);
          valveUpdateTime = millis();
          valveIndex++;
          if (valveIndex > NUMBER_OF_VALVES + 1)
          {
            valveIndex = 1;
          }
        }
      }```
      posted in My Project
      moffen666
      moffen666
    • RE: Irrigation Controller (up to 16 valves with Shift Registers)

      The inserted values in the array works from start, but it looks like the irrigation controller immediately starts to request valve data from the controller for variable1 and 2. As we cant set variable1 and 2 in Domoticz I guess it returns 0 and overwrite the inserted values in the arrays...or is it anything else happening?

      Initialising...
      Turning All Valves Off...
      Unable to sync with the RTC
      Checking EEPROM for stored date:
      Retreiving last run time from EEPROM...
      send: 7-7-0-0 s=255,c=0,t=17,pt=0,l=3,sg=0,st=ok:1.5
      send: 7-7-0-0 s=255,c=3,t=6,pt=1,l=1,sg=0,st=ok:0
      read: 0-0-7 s=255,c=3,t=6,pt=0,l=1,sg=0:M
      sensor started, id=7, parent=0, distance=1
      send: 7-7-0-0 s=255,c=3,t=11,pt=0,l=11,sg=0,st=ok:MySprinkler
      send: 7-7-0-0 s=255,c=3,t=12,pt=0,l=6,sg=0,st=ok:2.0nsr
      send: 7-7-0-0 s=0,c=0,t=3,pt=0,l=0,sg=0,st=ok:
      send: 7-7-0-0 s=1,c=0,t=3,pt=0,l=0,sg=0,st=ok:
      send: 7-7-0-0 s=2,c=0,t=3,pt=0,l=0,sg=0,st=ok:
      send: 7-7-0-0 s=3,c=0,t=3,pt=0,l=0,sg=0,st=ok:
      send: 7-7-0-0 s=4,c=0,t=3,pt=0,l=0,sg=0,st=ok:
      Sensor Presentation Complete
      Ready...
      Calling for Valve 0 Data...
      send: 7-7-0-0 s=0,c=2,t=24,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=0,c=2,t=24,pt=0,l=0,sg=0:
      Recieved variable1 valve:0 = 0
      send: 7-7-0-0 s=0,c=2,t=25,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=0,c=2,t=25,pt=0,l=0,sg=0:
      Recieved variable2 valve:0 = 0
      send: 7-7-0-0 s=0,c=2,t=26,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=0,c=2,t=26,pt=0,l=0,sg=0:
      No Name Recieved for zone 0
      Calling for Valve 1 Data...
      send: 7-7-0-0 s=1,c=2,t=24,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=1,c=2,t=24,pt=0,l=0,sg=0:
      Recieved variable1 valve:1 = 0
      New Zone Times Recieved...
      Zone 1 individual time: 1 group time: 0
      Zone 2 individual time: 1 group time: 1
      Zone 3 individual time: 1 group time: 1
      Zone 4 individual time: 1 group time: 1
      send: 7-7-0-0 s=1,c=2,t=25,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=1,c=2,t=25,pt=0,l=0,sg=0:
      Recieved variable2 valve:1 = 0
      New Zone Times Recieved...
      Zone 1 individual time: 0 group time: 0
      Zone 2 individual time: 1 group time: 1
      Zone 3 individual time: 1 group time: 1
      Zone 4 individual time: 1 group time: 1
      send: 7-7-0-0 s=1,c=2,t=26,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=1,c=2,t=26,pt=0,l=0,sg=0:
      No Name Recieved for zone 1
      Calling for Valve 2 Data...
      send: 7-7-0-0 s=2,c=2,t=24,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=2,c=2,t=24,pt=0,l=0,sg=0:
      Recieved variable1 valve:2 = 0
      New Zone Times Recieved...
      Zone 1 individual time: 0 group time: 0
      Zone 2 individual time: 1 group time: 0
      Zone 3 individual time: 1 group time: 1
      Zone 4 individual time: 1 group time: 1
      send: 7-7-0-0 s=2,c=2,t=25,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=2,c=2,t=25,pt=0,l=0,sg=0:
      Recieved variable2 valve:2 = 0
      New Zone Times Recieved...
      Zone 1 individual time: 0 group time: 0
      Zone 2 individual time: 0 group time: 0
      Zone 3 individual time: 1 group time: 1
      Zone 4 individual time: 1 group time: 1
      send: 7-7-0-0 s=2,c=2,t=26,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=2,c=2,t=26,pt=0,l=0,sg=0:
      No Name Recieved for zone 2
      Calling for Valve 3 Data...
      send: 7-7-0-0 s=3,c=2,t=24,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=3,c=2,t=24,pt=0,l=0,sg=0:
      Recieved variable1 valve:3 = 0
      New Zone Times Recieved...
      Zone 1 individual time: 0 group time: 0
      Zone 2 individual time: 0 group time: 0
      Zone 3 individual time: 1 group time: 0
      Zone 4 individual time: 1 group time: 1
      send: 7-7-0-0 s=3,c=2,t=25,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=3,c=2,t=25,pt=0,l=0,sg=0:
      Recieved variable2 valve:3 = 0
      New Zone Times Recieved...
      Zone 1 individual time: 0 group time: 0
      Zone 2 individual time: 0 group time: 0
      Zone 3 individual time: 0 group time: 0
      Zone 4 individual time: 1 group time: 1
      send: 7-7-0-0 s=3,c=2,t=26,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=3,c=2,t=26,pt=0,l=0,sg=0:
      No Name Recieved for zone 3
      Calling for Valve 4 Data...
      send: 7-7-0-0 s=4,c=2,t=24,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=4,c=2,t=24,pt=0,l=0,sg=0:
      Recieved variable1 valve:4 = 0
      New Zone Times Recieved...
      Zone 1 individual time: 0 group time: 0
      Zone 2 individual time: 0 group time: 0
      Zone 3 individual time: 0 group time: 0
      Zone 4 individual time: 1 group time: 0
      send: 7-7-0-0 s=4,c=2,t=25,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=4,c=2,t=25,pt=0,l=0,sg=0:
      Recieved variable2 valve:4 = 0
      New Zone Times Recieved...
      Zone 1 individual time: 0 group time: 0
      Zone 2 individual time: 0 group time: 0
      Zone 3 individual time: 0 group time: 0
      Zone 4 individual time: 0 group time: 0
      send: 7-7-0-0 s=4,c=2,t=26,pt=0,l=0,sg=0,st=ok:
      read: 0-0-7 s=4,c=2,t=26,pt=0,l=0,sg=0:
      No Name Recieved for zone 4
      
      posted in My Project
      moffen666
      moffen666
    • RE: Irrigation Controller (up to 16 valves with Shift Registers)

      Thx for the quick answer

      I use 4 valves atm, I tried your suggestion but it seems it wont work for me.

      upload-edb305b1-3dc3-4afd-ae02-e2e779452d18

      Regards

      posted in My Project
      moffen666
      moffen666