Dallas Temp failure to compile

[tbowmo]

@tlpeter

Ok, so you are using a newer version of the DallasTemperature library, than the one that we have supplied in our MySensorsArduinoExamples. And yes, it seems that they have made millisToWaitForConversion() a private function there. Or someone has changed the library we included in our repository at some point in time, so it is made public.

There are 2 options, as I see it :)

1. Use the library that we have supplied in MySensorsArduinoExamples
2. Make a PR against the original library, found here, and make the millisToWaitForConversion() public, and get them to release a new version of the library.

:)

[mfalkvidd]

The millisToWaitForConversion has always been private in milesburton's library, so the answer is the latter: someone has changed the library we included in our repository at some point in time.

I found the answer in git:

commit e47e596075282b122ac5d266ec6ad5c60ca8c978
Author: Robo Print <roboprint@users.noreply.github.com>
Date:   Sat Jun 27 23:00:37 2015 +0200

    Make DallasTemperature::millisToWaitForConversion() publicly available

I agree with tbowmo's options.

[robosensor]

It's my code :scream:

I changed this method from private to public, this function is used to determine wait time needed for right non-blocking wait call. Seems like I should make PR to original library instead of modifying MYS copy.