Skip to content
  • MySensors
  • OpenHardware.io
  • Categories
  • Recent
  • Tags
  • Popular
Skins
  • Light
  • Brite
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Brand Logo
  1. Home
  2. Development
  3. Multi Button Relay Sketch

Multi Button Relay Sketch

Scheduled Pinned Locked Moved Development
69 Posts 12 Posters 25.3k Views 18 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • pepsonP pepson

    @rayan
    Hi
    I do this eeprom clear and after that when i upload sketch for relay with buttons , this not working. Any communication with Gateway. Upload sketch successful write.

    I need changes in code to button monostable. Now if i want enable RELAY i must still connect pin to GND by button. I want only give impuls GND and relay should have enable. Again give impuls GND should disable relay. The same as working Fibaro relay switch by Z-Wave.

    In code should be add option to select buttons:
    -Monostable
    -Bistable

    rayanR Offline
    rayanR Offline
    rayan
    wrote on last edited by
    #31

    @pepson
    i am beginner and i hope some one help to you

    1 Reply Last reply
    0
    • pepsonP Offline
      pepsonP Offline
      pepson
      wrote on last edited by
      #32

      Maybe @Boots33 or @SGi help us please

      1 Reply Last reply
      0
      • korttomaK Offline
        korttomaK Offline
        korttoma
        Hero Member
        wrote on last edited by
        #33

        Here is an example that I'm using with 4 relays and 4 monostable buttons:

        // Enable debug prints to serial monitor
        #define MY_DEBUG
        
        // Enable and select radio type attached
        #define MY_RADIO_NRF24
        
        #define SN "RelayButtonArray"
        #define SV "1.0"
        
        #include <MySensors.h>
        #include <SPI.h>
        #include <Bounce2.h>
        #define RELAY_ON 0                      // switch around for ACTIVE LOW / ACTIVE HIGH relay
        #define RELAY_OFF 1
        //
        
        #define noRelays 4                     //2-4
        const int relayPin[] = {14, 15, 16, 17};       //  switch around pins to your desire
        const int buttonPin[] = {6, 7, 4, 5};   //  switch around pins to your desire
        
        class Relay             // relay class, store all relevant data (equivalent to struct)
        {
          public:
            int buttonPin;                   // physical pin number of button
            int relayPin;             // physical pin number of relay
            boolean relayState;               // relay status (also stored in EEPROM)
        };
        
        Relay Relays[noRelays];
        Bounce debouncer[noRelays];
        MyMessage msg[noRelays];
        
        /*
          void before() {
          for (int sensor=1, pin=RELAY_1; sensor<=NUMBER_OF_RELAYS;sensor++, pin++) {
            // Then set relay pins in output mode
            pinMode(pin, OUTPUT);
            // Set relay to last known state (using eeprom storage)
            digitalWrite(pin, loadState(sensor)?RELAY_ON:RELAY_OFF);
          }
          }*/
        
        void setup() {
          wait(100);
          // Initialize Relays with corresponding buttons
          for (int i = 0; i < noRelays; i++) {
            Relays[i].buttonPin = buttonPin[i];              // assign physical pins
            Relays[i].relayPin = relayPin[i];
            msg[i].sensor = i;                                   // initialize messages
            msg[i].type = V_LIGHT;
            pinMode(Relays[i].buttonPin, INPUT_PULLUP);
            wait(100);
            pinMode(Relays[i].relayPin, OUTPUT);
            Relays[i].relayState = loadState(i);                               // retrieve last values from EEPROM
            digitalWrite(Relays[i].relayPin, Relays[i].relayState ? RELAY_ON : RELAY_OFF); // and set relays accordingly
            send(msg[i].set(Relays[i].relayState ? true : false));                 // make controller aware of last status
            wait(50);
            debouncer[i] = Bounce();                        // initialize debouncer
            debouncer[i].attach(buttonPin[i]);
            debouncer[i].interval(30);
            wait(50);
          }
        }
        
        void presentation()
        {
          // Send the sketch version information to the gateway and Controller
          sendSketchInfo(SN, SV);
        
          wait(100);
        
          for (int i = 0; i < noRelays; i++)
            present(i, S_LIGHT);                               // present sensor to gateway
        
          wait(100);
        }
        
        
        void loop()
        {
          for (byte i = 0; i < noRelays; i++) {
            if (debouncer[i].update()) {
              
              int value = debouncer[i].read();
              
              if ( value == LOW) {
                Relays[i].relayState = !Relays[i].relayState;
                digitalWrite(Relays[i].relayPin, Relays[i].relayState ? RELAY_ON : RELAY_OFF);
                send(msg[i].set(Relays[i].relayState ? true : false));
                // save sensor state in EEPROM (location == sensor number)
                saveState( i, Relays[i].relayState );
        
              }
        
            }
          }
          //wait(20);
        }
        
        void receive(const MyMessage &message) {
          if (message.type == V_LIGHT) {
            if (message.sensor < noRelays) {          // check if message is valid for relays..... previous line  [[[ if (message.sensor <=noRelays){ ]]]
              Relays[message.sensor].relayState = message.getBool();
              digitalWrite(Relays[message.sensor].relayPin, Relays[message.sensor].relayState ? RELAY_ON : RELAY_OFF); // and set relays accordingly
              saveState( message.sensor, Relays[message.sensor].relayState ); // save sensor state in EEPROM (location == sensor number)
            }
          }
          wait(20);
        }
        
        • Tomas
        breimannB N T 3 Replies Last reply
        1
        • pepsonP pepson

          @Boots33 said:

          @rayan maybe trying to send the off message before the presentation stops it from sending

          try this , have moved the messages to the main loop where they will only be sent once in the first loop

          #define MY_DEBUG
          #define MY_RADIO_NRF24
          #define MY_REPEATER_FEATURE
          
          #include <SPI.h>
          #include <MySensors.h>
          #include <Bounce2.h>
          
          #define RELAY_ON 1
          #define RELAY_OFF 0
          
          #define SSR_A_ID 1   // Id of the sensor child
          #define SSR_B_ID 2   // Id of the sensor child
          
          const int buttonPinA = 18;
          const int buttonPinB = 19;
          const int relayPinA = 5;
          const int relayPinB = 6;
          int oldValueA = 0;
          int oldValueB = 0;
          bool stateA = false;
          bool stateB = false;
          int trigger = 0;
          
          
          Bounce debouncerA = Bounce();
          Bounce debouncerB = Bounce();
          
          MyMessage msgA(SSR_A_ID, V_STATUS);
          MyMessage msgB(SSR_B_ID, V_STATUS);
          
          void setup()
          {
          
            pinMode(buttonPinA, INPUT_PULLUP); // Setup the button Activate internal pull-up
            pinMode(buttonPinB, INPUT_PULLUP); // Setup the button Activate internal pull-up
          
          
            // After setting up the buttons, setup debouncer
            debouncerA.attach(buttonPinA);
            debouncerA.interval(5);
            debouncerB.attach(buttonPinB);
            debouncerB.interval(5);
          
            // Make sure relays are off when starting up
            digitalWrite(relayPinA, RELAY_OFF);
            digitalWrite(relayPinB, RELAY_OFF);
            // Then set relay pins in output mode
            pinMode(relayPinA, OUTPUT);
            pinMode(relayPinB, OUTPUT);
          
              /*--------------------- Added these lines for toggle switch-------------------------*/
            oldValueA = digitalRead(buttonPinA);  // set oldValueA to the current status of the toggle switch
            oldValueB = digitalRead(buttonPinB);  // set oldValueB to the current status of the toggle switch
           // send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
           // send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
            
          }
          
          void presentation()  {
            // Send the sketch version information to the gateway and Controller
            sendSketchInfo("Mains Controller", "1.0");
          
            // Register all sensors to gw (they will be created as child devices)
            present(SSR_A_ID, S_LIGHT);
            present(SSR_B_ID, S_LIGHT);
          
          }
          
          /*
             Example on how to asynchronously check for new messages from gw
          */
          void loop()
          {
          if (trigger == 0){
            send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
            send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
            trigger = 1;
          }
          
          
            debouncerA.update();
            // Get the update value
            int valueA = debouncerA.read();
            if (valueA != oldValueA) {
              send(msgA.set(stateA ? false : true), true); // Send new state and request ack back
            oldValueA = valueA;
            }
           
          
            debouncerB.update();
            // Get the update value
            int valueB = debouncerB.read();
            if (valueB != oldValueB) {
              send(msgB.set(stateB ? false : true), true); // Send new state and request ack back
            oldValueB = valueB;
            }
          }
          
          void receive(const MyMessage &message) {
            // We only expect one type of message from controller. But we better check anyway.
            if (message.type == V_STATUS) {
                
              switch (message.sensor) {
                case 1:
                  stateA = message.getBool();
                  digitalWrite(message.sensor + 4, stateA ? RELAY_ON : RELAY_OFF);
                  
                  break;
                case 2:
                  stateB = message.getBool();
                  digitalWrite(message.sensor + 4, stateB ? RELAY_ON : RELAY_OFF);
                  
                  break;
                
              }
             
                // Write some debug info
              Serial.print("Incoming change for sensor:");
              Serial.println(message.sensor);
              Serial.print("from node:");
              Serial.println(message.sender);
              Serial.print(", New status: ");
              Serial.println(message.getBool());
            }
          }
          

          Thanks this code works ok. But by switch i must still connect to GND to keep change status. Is possible to change it to give only impuls GND to change status Relay ? I want use switch monostable.

          And anybody tell me how i can clear all eeprom in my Arduino Mini Pro. I want clear eeprom before upload sketch.

          Boots33B Offline
          Boots33B Offline
          Boots33
          Hero Member
          wrote on last edited by
          #34

          @pepson The sketch i have in my first post at the top of the page will work for a push button. the one you are using has been modified for use with a toggle switch.

          1 Reply Last reply
          0
          • pepsonP Offline
            pepsonP Offline
            pepson
            wrote on last edited by
            #35

            ok i test your first sketch. But maybe you can create sketch where we can setvin sketch what button we want use ?

            1 Reply Last reply
            0
            • korttomaK Offline
              korttomaK Offline
              korttoma
              Hero Member
              wrote on last edited by
              #36

              I'm the sketch I'm using you can freely define what pins you want to use:

              const int relayPin[] = {14, 15, 16, 17};       //  switch around pins to your desire
              const int buttonPin[] = {6, 7, 4, 5};   //  switch around pins to your desire
              
              • Tomas
              1 Reply Last reply
              0
              • rayanR rayan

                @Boots33 this your code is good, but there is a small issue .button work just when the connection is ok (radio with gateway) ! and when radio is disconnect or controller is off, so button dont work handy . do you have any idea for this ? that when controller is off the button work handy

                Boots33B Offline
                Boots33B Offline
                Boots33
                Hero Member
                wrote on last edited by Boots33
                #37

                @rayan said:

                this your code is good, but there is a small issue .button work just when the connection is ok (radio with gateway) ! and when radio is disconnect or controller is off, so button dont work handy . do you have any idea for this ? that when controller is off the button work handy

                As far as I know that is the way Mysensors works at the moment, if the node boots up and cannot find the gateway then it wont run the loop part of the sketch.
                If the gateway drops out after the node has booted then the loop part of the sketch will still run while the node tries to re-establish the connection. Because the sketch relies on an ACK back from the gateway to toggle the relay it still wont work if the gateway is down.

                You could modify the sketch so it does not rely on the ACK. This would at least allow it to work if the gateway goes down after the node has booted.
                Another way to ensure the switch will operate would be to add some circuit to override the node, like discussed Here

                Have made a quick change to the sketch so it does not need the ACK. I have not tried it but give it a go and see if it works

                #define MY_DEBUG
                #define MY_RADIO_NRF24
                #define MY_REPEATER_FEATURE
                
                #include <SPI.h>
                #include <MySensors.h>
                #include <Bounce2.h>
                
                #define RELAY_ON 1
                #define RELAY_OFF 0
                
                #define SSR_A_ID 1   // Id of the sensor child
                #define SSR_B_ID 2   // Id of the sensor child
                
                const int buttonPinA = 18;
                const int buttonPinB = 19;
                const int relayPinA = 5;
                const int relayPinB = 6;
                int oldValueA = 0;
                int oldValueB = 0;
                bool stateA = false;
                bool stateB = false;
                int trigger = 0;
                
                
                Bounce debouncerA = Bounce();
                Bounce debouncerB = Bounce();
                
                MyMessage msgA(SSR_A_ID, V_STATUS);
                MyMessage msgB(SSR_B_ID, V_STATUS);
                
                void setup()
                {
                
                  pinMode(buttonPinA, INPUT_PULLUP); // Setup the button Activate internal pull-up
                  pinMode(buttonPinB, INPUT_PULLUP); // Setup the button Activate internal pull-up
                // Then set relay pins in output mode
                  pinMode(relayPinA, OUTPUT);
                  pinMode(relayPinB, OUTPUT);
                
                  // After setting up the buttons, setup debouncer
                  debouncerA.attach(buttonPinA);
                  debouncerA.interval(5);
                  debouncerB.attach(buttonPinB);
                  debouncerB.interval(5);
                
                  // Make sure relays are off when starting up
                  digitalWrite(relayPinA, RELAY_OFF);
                  digitalWrite(relayPinB, RELAY_OFF);
                  
                
                    /*--------------------- Added these lines for toggle switch-------------------------*/
                  oldValueA = digitalRead(buttonPinA);  // set oldValueA to the current status of the toggle switch
                  oldValueB = digitalRead(buttonPinB);  // set oldValueB to the current status of the toggle switch
                 // send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                 // send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                  
                }
                
                void presentation()  {
                  // Send the sketch version information to the gateway and Controller
                  sendSketchInfo("Mains Controller", "1.0");
                
                  // Register all sensors to gw (they will be created as child devices)
                  present(SSR_A_ID, S_LIGHT);
                  present(SSR_B_ID, S_LIGHT);
                
                }
                
                /*
                   Example on how to asynchronously check for new messages from gw
                */
                void loop()
                {
                if (trigger == 0){
                  send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                  send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                  trigger = 1;
                }
                
                
                  debouncerA.update();
                  // Get the update value
                  int valueA = debouncerA.read();
                  if (valueA != oldValueA) {
                   // send(msgA.set(stateA ? false : true), true); // Send new state and request ack back
                    send(msgA.set(stateA ? false : true), false); // Send new state with no request for ack
                    stateA = stateA ? false : true;               // invert the state
                     digitalWrite(relayPinA, stateA ? RELAY_ON : RELAY_OFF);  // toggle the relay
                  oldValueA = valueA;
                  }
                 
                
                  debouncerB.update();
                  // Get the update value
                  int valueB = debouncerB.read();
                  if (valueB != oldValueB) {
                    //send(msgB.set(stateB ? false : true), true); // Send new state and request ack back
                    send(msgB.set(stateB ? false : true), false); // Send new state with no request for ack
                    stateB = stateB ? false : true;                // invert the state
                     digitalWrite(relayPinB, stateB ? RELAY_ON : RELAY_OFF);  // toggle the relay
                    
                  oldValueB = valueB;
                  }
                }
                
                void receive(const MyMessage &message) {
                  // We only expect one type of message from controller. But we better check anyway.
                  if (message.type == V_STATUS) {
                      
                    switch (message.sensor) {
                      case 1:
                        stateA = message.getBool();
                        digitalWrite(message.sensor + 4, stateA ? RELAY_ON : RELAY_OFF);
                        
                        break;
                      case 2:
                        stateB = message.getBool();
                        digitalWrite(message.sensor + 4, stateB ? RELAY_ON : RELAY_OFF);
                        
                        break;
                      
                    }
                   
                      // Write some debug info
                    Serial.print("Incoming change for sensor:");
                    Serial.println(message.sensor);
                    Serial.print("from node:");
                    Serial.println(message.sender);
                    Serial.print(", New status: ");
                    Serial.println(message.getBool());
                  }
                }
                
                rayanR 1 Reply Last reply
                0
                • pepsonP Offline
                  pepsonP Offline
                  pepson
                  wrote on last edited by
                  #38

                  ok then i test it.
                  But can you also add option to set mode button ? Bistable and monostable ?

                  1 Reply Last reply
                  0
                  • Boots33B Boots33

                    @rayan said:

                    this your code is good, but there is a small issue .button work just when the connection is ok (radio with gateway) ! and when radio is disconnect or controller is off, so button dont work handy . do you have any idea for this ? that when controller is off the button work handy

                    As far as I know that is the way Mysensors works at the moment, if the node boots up and cannot find the gateway then it wont run the loop part of the sketch.
                    If the gateway drops out after the node has booted then the loop part of the sketch will still run while the node tries to re-establish the connection. Because the sketch relies on an ACK back from the gateway to toggle the relay it still wont work if the gateway is down.

                    You could modify the sketch so it does not rely on the ACK. This would at least allow it to work if the gateway goes down after the node has booted.
                    Another way to ensure the switch will operate would be to add some circuit to override the node, like discussed Here

                    Have made a quick change to the sketch so it does not need the ACK. I have not tried it but give it a go and see if it works

                    #define MY_DEBUG
                    #define MY_RADIO_NRF24
                    #define MY_REPEATER_FEATURE
                    
                    #include <SPI.h>
                    #include <MySensors.h>
                    #include <Bounce2.h>
                    
                    #define RELAY_ON 1
                    #define RELAY_OFF 0
                    
                    #define SSR_A_ID 1   // Id of the sensor child
                    #define SSR_B_ID 2   // Id of the sensor child
                    
                    const int buttonPinA = 18;
                    const int buttonPinB = 19;
                    const int relayPinA = 5;
                    const int relayPinB = 6;
                    int oldValueA = 0;
                    int oldValueB = 0;
                    bool stateA = false;
                    bool stateB = false;
                    int trigger = 0;
                    
                    
                    Bounce debouncerA = Bounce();
                    Bounce debouncerB = Bounce();
                    
                    MyMessage msgA(SSR_A_ID, V_STATUS);
                    MyMessage msgB(SSR_B_ID, V_STATUS);
                    
                    void setup()
                    {
                    
                      pinMode(buttonPinA, INPUT_PULLUP); // Setup the button Activate internal pull-up
                      pinMode(buttonPinB, INPUT_PULLUP); // Setup the button Activate internal pull-up
                    // Then set relay pins in output mode
                      pinMode(relayPinA, OUTPUT);
                      pinMode(relayPinB, OUTPUT);
                    
                      // After setting up the buttons, setup debouncer
                      debouncerA.attach(buttonPinA);
                      debouncerA.interval(5);
                      debouncerB.attach(buttonPinB);
                      debouncerB.interval(5);
                    
                      // Make sure relays are off when starting up
                      digitalWrite(relayPinA, RELAY_OFF);
                      digitalWrite(relayPinB, RELAY_OFF);
                      
                    
                        /*--------------------- Added these lines for toggle switch-------------------------*/
                      oldValueA = digitalRead(buttonPinA);  // set oldValueA to the current status of the toggle switch
                      oldValueB = digitalRead(buttonPinB);  // set oldValueB to the current status of the toggle switch
                     // send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                     // send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                      
                    }
                    
                    void presentation()  {
                      // Send the sketch version information to the gateway and Controller
                      sendSketchInfo("Mains Controller", "1.0");
                    
                      // Register all sensors to gw (they will be created as child devices)
                      present(SSR_A_ID, S_LIGHT);
                      present(SSR_B_ID, S_LIGHT);
                    
                    }
                    
                    /*
                       Example on how to asynchronously check for new messages from gw
                    */
                    void loop()
                    {
                    if (trigger == 0){
                      send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                      send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                      trigger = 1;
                    }
                    
                    
                      debouncerA.update();
                      // Get the update value
                      int valueA = debouncerA.read();
                      if (valueA != oldValueA) {
                       // send(msgA.set(stateA ? false : true), true); // Send new state and request ack back
                        send(msgA.set(stateA ? false : true), false); // Send new state with no request for ack
                        stateA = stateA ? false : true;               // invert the state
                         digitalWrite(relayPinA, stateA ? RELAY_ON : RELAY_OFF);  // toggle the relay
                      oldValueA = valueA;
                      }
                     
                    
                      debouncerB.update();
                      // Get the update value
                      int valueB = debouncerB.read();
                      if (valueB != oldValueB) {
                        //send(msgB.set(stateB ? false : true), true); // Send new state and request ack back
                        send(msgB.set(stateB ? false : true), false); // Send new state with no request for ack
                        stateB = stateB ? false : true;                // invert the state
                         digitalWrite(relayPinB, stateB ? RELAY_ON : RELAY_OFF);  // toggle the relay
                        
                      oldValueB = valueB;
                      }
                    }
                    
                    void receive(const MyMessage &message) {
                      // We only expect one type of message from controller. But we better check anyway.
                      if (message.type == V_STATUS) {
                          
                        switch (message.sensor) {
                          case 1:
                            stateA = message.getBool();
                            digitalWrite(message.sensor + 4, stateA ? RELAY_ON : RELAY_OFF);
                            
                            break;
                          case 2:
                            stateB = message.getBool();
                            digitalWrite(message.sensor + 4, stateB ? RELAY_ON : RELAY_OFF);
                            
                            break;
                          
                        }
                       
                          // Write some debug info
                        Serial.print("Incoming change for sensor:");
                        Serial.println(message.sensor);
                        Serial.print("from node:");
                        Serial.println(message.sender);
                        Serial.print(", New status: ");
                        Serial.println(message.getBool());
                      }
                    }
                    
                    rayanR Offline
                    rayanR Offline
                    rayan
                    wrote on last edited by rayan
                    #39

                    @Boots33
                    ack is important , so we can not found any solution for this ? for exapmle add a code to this sketch , that when radio is disconnect so without ack work and when radio is ok this way stop and with ack work again.
                    this idea is for when a radio have problem or fail or other reason... so this light or other divece dont stop working and work handy when radio go to correct or change radio....

                    if you can change your code and add this option , so your sketch is best code for light control

                    Boots33B 1 Reply Last reply
                    0
                    • pepsonP Offline
                      pepsonP Offline
                      pepson
                      wrote on last edited by pepson
                      #40

                      @korttoma your sketch not working for me. I change numer relay to 2 and change pin buttons and relay and not control relay.

                      @Boots33
                      Ok i correct your sketch and use:

                      Switch Bistable:

                      /**
                         DESCRIPTION
                         Sketch for 2x relay with buttons bistable. After back power all relays set OFF and send correct status OFF to controller.  
                      */
                      
                      // Enable debug prints to serial monitor
                      #define MY_DEBUG
                      
                      // Enable and select radio type attached
                      #define MY_RADIO_NRF24
                      //#define MY_RADIO_RFM69
                      
                      // Enabled repeater feature for this node
                      #define MY_REPEATER_FEATURE
                      
                      #include <SPI.h>
                      #include <MySensors.h>
                      #include <Bounce2.h>
                      
                      // Define Relays
                      #define RELAY_ON 1  // GPIO value to write to turn on attached relay
                      #define RELAY_OFF 0  // GPIO value to write to turn off attached relay
                      
                      // Define Sensor ID's
                      #define SSR_A_ID 1   // Id of the sensor child
                      #define SSR_B_ID 2   // Id of the sensor child
                      
                      // Define buttons and relays
                      const int buttonPinA = 3;
                      const int buttonPinB = 4;
                      const int relayPinA = 5;
                      const int relayPinB = 6;
                      
                      // Define Variables
                      int oldValueA = 0;
                      int oldValueB = 0;
                      bool stateA = false;
                      bool stateB = false;
                      int trigger = 0;
                      
                      
                      Bounce debouncerA = Bounce();
                      Bounce debouncerB = Bounce();
                      
                      MyMessage msgA(SSR_A_ID, V_STATUS);
                      MyMessage msgB(SSR_B_ID, V_STATUS);
                      
                      void setup()
                      {
                      
                        pinMode(buttonPinA, INPUT_PULLUP); // Setup the button Activate internal pull-up
                        pinMode(buttonPinB, INPUT_PULLUP); // Setup the button Activate internal pull-up
                      
                      
                        // After setting up the buttons, setup debouncer
                        debouncerA.attach(buttonPinA);
                        debouncerA.interval(5);
                        debouncerB.attach(buttonPinB);
                        debouncerB.interval(5);
                      
                        // Make sure relays are off when starting up
                        digitalWrite(relayPinA, RELAY_OFF);
                        digitalWrite(relayPinB, RELAY_OFF);
                        // Then set relay pins in output mode
                        pinMode(relayPinA, OUTPUT);
                        pinMode(relayPinB, OUTPUT);
                      
                          /*--------------------- Added these lines for toggle switch-------------------------*/
                        oldValueA = digitalRead(buttonPinA);  // set oldValueA to the current status of the toggle switch
                        oldValueB = digitalRead(buttonPinB);  // set oldValueB to the current status of the toggle switch
                       // send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                       // send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                        
                      }
                      
                      void presentation()  {
                        // Send the sketch version information to the gateway and Controller
                        sendSketchInfo("2xRelay with bistable", "1.1");
                      
                        // Register all sensors to gw (they will be created as child devices)
                        present(SSR_A_ID, S_LIGHT);
                        present(SSR_B_ID, S_LIGHT);
                      
                      }
                      
                      /*
                         Example on how to asynchronously check for new messages from gw
                      */
                      void loop()
                      {
                      if (trigger == 0){
                        send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                        send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                        trigger = 1;
                      }
                      
                      
                        debouncerA.update();
                        // Get the update value
                        int valueA = debouncerA.read();
                        if (valueA != oldValueA) {
                         // send(msgA.set(stateA ? false : true), true); // Send new state and request ack back
                          send(msgA.set(stateA ? false : true), false); // Send new state with no request for ack
                          stateA = stateA ? false : true;               // invert the state
                           digitalWrite(relayPinA, stateA ? RELAY_ON : RELAY_OFF);  // toggle the relay
                        oldValueA = valueA;
                        }
                       
                      
                        debouncerB.update();
                        // Get the update value
                        int valueB = debouncerB.read();
                        if (valueB != oldValueB) {
                          //send(msgB.set(stateB ? false : true), true); // Send new state and request ack back
                          send(msgB.set(stateB ? false : true), false); // Send new state with no request for ack
                          stateB = stateB ? false : true;                // invert the state
                           digitalWrite(relayPinB, stateB ? RELAY_ON : RELAY_OFF);  // toggle the relay
                          
                        oldValueB = valueB;
                        }
                      }
                      
                      void receive(const MyMessage &message) {
                        // We only expect one type of message from controller. But we better check anyway.
                        if (message.type == V_STATUS) {
                            
                          switch (message.sensor) {
                            case 1:
                              stateA = message.getBool();
                              digitalWrite(message.sensor + 4, stateA ? RELAY_ON : RELAY_OFF);
                              
                              break;
                            case 2:
                              stateB = message.getBool();
                              digitalWrite(message.sensor + 4, stateB ? RELAY_ON : RELAY_OFF);
                              
                              break;
                            
                          }
                         
                            // Write some debug info
                          Serial.print("Incoming change for sensor:");
                          Serial.println(message.sensor);
                          Serial.print("from node:");
                          Serial.println(message.sender);
                          Serial.print(", New status: ");
                          Serial.println(message.getBool());
                        }
                      }
                      

                      Switch monostable:

                      /**
                         DESCRIPTION
                         Sketch for 2x relay with buttons monostable. After back power all relays set OFF and send correct status OFF to controller.  
                      */
                      
                      // Enable debug prints to serial monitor
                      #define MY_DEBUG
                      
                      // Enable and select radio type attached
                      #define MY_RADIO_NRF24
                      //#define MY_RADIO_RFM69
                      
                      // Enabled repeater feature for this node
                      #define MY_REPEATER_FEATURE
                      
                      #include <SPI.h>
                      #include <MySensors.h>
                      #include <Bounce2.h>
                      
                      // Define Relays
                      #define RELAY_ON 1  // GPIO value to write to turn on attached relay
                      #define RELAY_OFF 0  // GPIO value to write to turn off attached relay
                      
                      // Define Sensor ID's
                      #define SSR_A_ID 1   // Id of the sensor child
                      #define SSR_B_ID 2   // Id of the sensor child
                      
                      // Define buttons and relays
                      const int buttonPinA = 3;
                      const int buttonPinB = 4;
                      const int relayPinA = 5;
                      const int relayPinB = 6;
                      
                      // Define Variables
                      int oldValueA = 0;
                      int oldValueB = 0;
                      bool stateA = false;
                      bool stateB = false;
                      int trigger = 0;
                      
                      Bounce debouncerA = Bounce();
                      Bounce debouncerB = Bounce();
                      
                      MyMessage msgA(SSR_A_ID, V_STATUS);
                      MyMessage msgB(SSR_B_ID, V_STATUS);
                      
                      void setup()
                      {
                      
                        pinMode(buttonPinA, INPUT_PULLUP); // Setup the button Activate internal pull-up
                        pinMode(buttonPinB, INPUT_PULLUP); // Setup the button Activate internal pull-up
                      
                      
                        // After setting up the buttons, setup debouncer
                        debouncerA.attach(buttonPinA);
                        debouncerA.interval(5);
                        debouncerB.attach(buttonPinB);
                        debouncerB.interval(5);
                      
                        // Make sure relays are off when starting up
                        digitalWrite(relayPinA, RELAY_OFF);
                        digitalWrite(relayPinB, RELAY_OFF);
                        // Then set relay pins in output mode
                        pinMode(relayPinA, OUTPUT);
                        pinMode(relayPinB, OUTPUT);
                      
                      }
                      
                      void presentation()  {
                        // Send the sketch version information to the gateway and Controller
                        sendSketchInfo("2xRelay with monostable", "1.0");
                      
                        // Register all sensors to gw (they will be created as child devices)
                        present(SSR_A_ID, S_LIGHT);
                        present(SSR_B_ID, S_LIGHT);
                      
                      }
                      
                      /*
                         Example on how to asynchronously check for new messages from gw
                      */
                      void loop()
                      {
                      if (trigger == 0){
                        send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                        send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                        trigger = 1;
                      }
                        
                        debouncerA.update();
                        // Get the update value
                        int valueA = debouncerA.read();
                        if (valueA != oldValueA && valueA == 0) {
                          send(msgA.set(stateA ? false : true), true); // Send new state and request ack back
                      
                        }
                        oldValueA = valueA;
                       
                      
                        debouncerB.update();
                        // Get the update value
                        int valueB = debouncerB.read();
                        if (valueB != oldValueB && valueB == 0) {
                          send(msgB.set(stateB ? false : true), true); // Send new state and request ack back
                      
                        }
                        oldValueB = valueB;
                      }
                      
                      void receive(const MyMessage &message) {
                        // We only expect one type of message from controller. But we better check anyway.
                        if (message.type == V_STATUS) {
                            
                          switch (message.sensor) {
                            case 1:
                              stateA = message.getBool();
                              digitalWrite(message.sensor + 4, stateA ? RELAY_ON : RELAY_OFF);
                              
                              break;
                            case 2:
                              stateB = message.getBool();
                              digitalWrite(message.sensor + 4, stateB ? RELAY_ON : RELAY_OFF);
                              
                              break;
                            
                          }
                         
                            // Write some debug info
                          Serial.print("Incoming change for sensor:");
                          Serial.println(message.sensor);
                          Serial.print("from node:");
                          Serial.println(message.sender);
                          Serial.print(", New status: ");
                          Serial.println(message.getBool());
                        }
                      }
                      

                      On this sketches it works ok. After power down and then power back all relays go to OFF and correct send info to Gateway and Domoticz that relays is OFF. But when Gateway is available.

                      But problem is when GATEWAY is not awailable when power for node come back.
                      If before lost power relay is ON and then power lost , and gateway is lost, and then power back to Node it goes to OFF all relay. It is ok.But when Gateway come back and now is available still show in Domoticz that relay is ON(on begin was ON). But Node should update status info after Gateway come back and is now available. But no update and show in Domoticz latest status.

                      It is very need and then this sketches will be the best for lights :)

                      When power lost and then come back, Node with sketches faster start then start Raspberry with Domoticz and connect Gateway Serial MySensors. An in this situation status is not update in Gateway/Domoticz.

                      Please help us. please

                      1 Reply Last reply
                      0
                      • rayanR rayan

                        @Boots33
                        ack is important , so we can not found any solution for this ? for exapmle add a code to this sketch , that when radio is disconnect so without ack work and when radio is ok this way stop and with ack work again.
                        this idea is for when a radio have problem or fail or other reason... so this light or other divece dont stop working and work handy when radio go to correct or change radio....

                        if you can change your code and add this option , so your sketch is best code for light control

                        Boots33B Offline
                        Boots33B Offline
                        Boots33
                        Hero Member
                        wrote on last edited by
                        #41

                        @rayan said:

                        @Boots33
                        ack is important , so we can not found any solution for this ? for exapmle add a code to this sketch , that when radio is disconnect so without ack work and when radio is ok this way stop and with ack work again.
                        this idea is for when a radio have problem or fail or other reason... so this light or other divece dont stop working and work handy when radio go to correct or change radio....

                        if you can change your code and add this option , so your sketch is best code for light control

                        There have been a few threads about the issue of nodes not running the loop part of the sketch if a connection to the gateway cannot be established. Have a look Here and Here for a bit more info. It is a feature I am sure many would like to see in the next version of MySensors. For the moment MySensors does not support 100% what you want to do.

                        If you want to combine the two versions of the sketches you will need to have a method to check whether a connection to the gateway is present. You could try something like this in the loop.

                        
                        if (isTransportOK()){
                        
                            // put code to execute when connection is available here
                        
                          } 
                          else {
                        
                            // put code to execute when no connection is available here
                        
                          }
                        
                        

                        You will be adding a fair bit of complexity to the sketch. Can you tell me why the ACK is so important for you.

                        rayanR 1 Reply Last reply
                        0
                        • pepsonP Offline
                          pepsonP Offline
                          pepson
                          wrote on last edited by pepson
                          #42

                          What is ACK ?

                          And can you show me all code with your if transport is ok to send update status to gateway...but if transport is wrong example try send every 1 minut and stop when send is good.

                          I am begginner sorry

                          Did you know any info that this function will be implement in next version as you write in latest your post ?

                          1 Reply Last reply
                          0
                          • Boots33B Boots33

                            @rayan said:

                            @Boots33
                            ack is important , so we can not found any solution for this ? for exapmle add a code to this sketch , that when radio is disconnect so without ack work and when radio is ok this way stop and with ack work again.
                            this idea is for when a radio have problem or fail or other reason... so this light or other divece dont stop working and work handy when radio go to correct or change radio....

                            if you can change your code and add this option , so your sketch is best code for light control

                            There have been a few threads about the issue of nodes not running the loop part of the sketch if a connection to the gateway cannot be established. Have a look Here and Here for a bit more info. It is a feature I am sure many would like to see in the next version of MySensors. For the moment MySensors does not support 100% what you want to do.

                            If you want to combine the two versions of the sketches you will need to have a method to check whether a connection to the gateway is present. You could try something like this in the loop.

                            
                            if (isTransportOK()){
                            
                                // put code to execute when connection is available here
                            
                              } 
                              else {
                            
                                // put code to execute when no connection is available here
                            
                              }
                            
                            

                            You will be adding a fair bit of complexity to the sketch. Can you tell me why the ACK is so important for you.

                            rayanR Offline
                            rayanR Offline
                            rayan
                            wrote on last edited by rayan
                            #43

                            @Boots33
                            ack is a feedback . is this true ? so when i am out of home and i want turn on light , so ack show me that light is on or no ! also when there is a problem in connection and ack dont receive, so node search and found a new way for connection.
                            now i dont have a arduino and radio for test :) but do you think this code will be ok ?without else.

                            void loop()
                            {
                             if (!isTransportOK())
                            {
                            if (...)            //if change switch to up or down
                            ...                 //change state of relay
                            if(isTransportOK())
                            send(msg.set(state ? true : false), true);  // (last state)
                            }
                              
                              debouncer.update();
                              // Get the update value
                              int value = debouncer.read();
                              if (value != oldValue && value == 0) {
                                send(msg.set(state ? false : true), true); // Send new state and request ack back
                              }
                              oldValue = value;
                            }
                            

                            (i can not work with Bounce2 library :) ) please help to fill lines
                            in loop we add a "if (!isTransportOK())" and write when change switch (on/off) state of relay change and this is repeat until connection will be ok ! so send a ack and for continue follow your code...
                            is this right ? can you do this change ?

                            1 Reply Last reply
                            0
                            • pepsonP Offline
                              pepsonP Offline
                              pepson
                              wrote on last edited by
                              #44

                              Hi
                              I can test it but i must have finall code because i dont know what code i must put in (...). I am begginer user and i dont know how write programming.

                              rayanR 1 Reply Last reply
                              0
                              • pepsonP pepson

                                Hi
                                I can test it but i must have finall code because i dont know what code i must put in (...). I am begginer user and i dont know how write programming.

                                rayanR Offline
                                rayanR Offline
                                rayan
                                wrote on last edited by
                                #45

                                @pepson

                                @Boots33 can solve this maybe because i dont work with Bounce2 lib.

                                1 Reply Last reply
                                0
                                • pepsonP Offline
                                  pepsonP Offline
                                  pepson
                                  wrote on last edited by
                                  #46

                                  Ok but can you give me ready code which i must put in code to my relays and then i test it.

                                  rayanR 1 Reply Last reply
                                  0
                                  • pepsonP pepson

                                    Ok but can you give me ready code which i must put in code to my relays and then i test it.

                                    rayanR Offline
                                    rayanR Offline
                                    rayan
                                    wrote on last edited by
                                    #47

                                    @pepson
                                    i dont have a ready sketch! wait to boots answer

                                    1 Reply Last reply
                                    0
                                    • pepsonP Offline
                                      pepsonP Offline
                                      pepson
                                      wrote on last edited by
                                      #48

                                      Ok i am waiting...

                                      1 Reply Last reply
                                      0
                                      • Boots33B Offline
                                        Boots33B Offline
                                        Boots33
                                        Hero Member
                                        wrote on last edited by Boots33
                                        #49

                                        Guys I feel this thread has wandered a long way from the original topic and has taken up a lot of time. i really don't think there is a lot to be gained by turning the fairly simple relay sketch into what you now desire.

                                        Even with the changes it still will not work if it boots up and can't find the gateway.

                                        I am posting a final sketch which you may like to try, again it is untested so you may still need to work on it. I hope you understand I have a few of my own uncompleted projects that I want to get back to with the limited free time I have. Good luck with your MySensors journey.

                                        #define MY_DEBUG
                                        #define MY_RADIO_NRF24
                                        #define MY_REPEATER_FEATURE
                                        
                                        #include <SPI.h>
                                        #include <MySensors.h>
                                        #include <Bounce2.h>
                                        
                                        #define RELAY_ON 1
                                        #define RELAY_OFF 0
                                        
                                        #define SSR_A_ID 1   // Id of the sensor child
                                        #define SSR_B_ID 2   // Id of the sensor child
                                        
                                        const int buttonPinA = 18;
                                        const int buttonPinB = 19;
                                        const int relayPinA = 5;
                                        const int relayPinB = 6;
                                        int oldValueA = 0;
                                        int oldValueB = 0;
                                        bool stateA = false;
                                        bool stateB = false;
                                        int trigger = 0;
                                        
                                        
                                        Bounce debouncerA = Bounce();
                                        Bounce debouncerB = Bounce();
                                        
                                        MyMessage msgA(SSR_A_ID, V_STATUS);
                                        MyMessage msgB(SSR_B_ID, V_STATUS);
                                        
                                        void setup()
                                        {
                                        
                                          pinMode(buttonPinA, INPUT_PULLUP); // Setup the button Activate internal pull-up
                                          pinMode(buttonPinB, INPUT_PULLUP); // Setup the button Activate internal pull-up
                                        // Then set relay pins in output mode
                                          pinMode(relayPinA, OUTPUT);
                                          pinMode(relayPinB, OUTPUT);
                                        
                                          // After setting up the buttons, setup debouncer
                                          debouncerA.attach(buttonPinA);
                                          debouncerA.interval(5);
                                          debouncerB.attach(buttonPinB);
                                          debouncerB.interval(5);
                                        
                                          // Make sure relays are off when starting up
                                          digitalWrite(relayPinA, RELAY_OFF);
                                          digitalWrite(relayPinB, RELAY_OFF);
                                          
                                        
                                            /*--------------------- Added these lines for toggle switch-------------------------*/
                                          oldValueA = digitalRead(buttonPinA);  // set oldValueA to the current status of the toggle switch
                                          oldValueB = digitalRead(buttonPinB);  // set oldValueB to the current status of the toggle switch
                                         // send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                                         // send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                                          
                                        }
                                        
                                        void presentation()  {
                                          // Send the sketch version information to the gateway and Controller
                                          sendSketchInfo("Mains Controller", "1.0");
                                        
                                          // Register all sensors to gw (they will be created as child devices)
                                          present(SSR_A_ID, S_LIGHT);
                                          present(SSR_B_ID, S_LIGHT);
                                        
                                        }
                                        
                                        /*
                                           Example on how to asynchronously check for new messages from gw
                                        */
                                        void loop()
                                        {
                                        if (trigger == 0){
                                          send(msgA.set(false)); // Send off state for relayA to ensure controller knows the switch is off
                                          send(msgB.set(false)); // Send off state for relayB to ensure controller knows the switch is off
                                          trigger = 1;
                                        }
                                        
                                        
                                        if (isTransportOK()){
                                           // put code to execute when connection is available here
                                            connectionPresent();
                                        
                                          } 
                                          else {
                                           // put code to execute when no connection is available here
                                           connectionLost();
                                          }
                                        
                                          
                                        }
                                        
                                        void receive(const MyMessage &message) {
                                          // We only expect one type of message from controller. But we better check anyway.
                                          if (message.type == V_STATUS) {
                                              
                                            switch (message.sensor) {
                                              case 1:
                                                stateA = message.getBool();
                                                digitalWrite(message.sensor + 4, stateA ? RELAY_ON : RELAY_OFF);
                                                
                                                break;
                                              case 2:
                                                stateB = message.getBool();
                                                digitalWrite(message.sensor + 4, stateB ? RELAY_ON : RELAY_OFF);
                                                
                                                break;
                                              
                                            }
                                           
                                              // Write some debug info
                                            Serial.print("Incoming change for sensor:");
                                            Serial.println(message.sensor);
                                            Serial.print("from node:");
                                            Serial.println(message.sender);
                                            Serial.print(", New status: ");
                                            Serial.println(message.getBool());
                                          }
                                        }
                                        
                                        
                                        
                                        void connectionPresent() {
                                        // put code to execute when connection is available here
                                             debouncerA.update();
                                          // Get the update value
                                          int valueA = debouncerA.read();
                                          if (valueA != oldValueA) {
                                            send(msgA.set(stateA ? false : true), true); // Send new state and request ack back
                                          oldValueA = valueA;
                                          }
                                         
                                        
                                          debouncerB.update();
                                          // Get the update value
                                          int valueB = debouncerB.read();
                                          if (valueB != oldValueB) {
                                            send(msgB.set(stateB ? false : true), true); // Send new state and request ack back
                                          oldValueB = valueB;
                                          } 
                                        }
                                        
                                        
                                        
                                          void connectionLost() {
                                        
                                           // put code to execute when no connection is available here
                                            debouncerA.update();
                                          // Get the update value
                                          int valueA = debouncerA.read();
                                          if (valueA != oldValueA) {
                                           // send(msgA.set(stateA ? false : true), true); // Send new state and request ack back
                                            send(msgA.set(stateA ? false : true), false); // Send new state with no request for ack
                                            stateA = stateA ? false : true;               // invert the state
                                             digitalWrite(relayPinA, stateA ? RELAY_ON : RELAY_OFF);  // toggle the relay
                                          oldValueA = valueA;
                                          }
                                         
                                        
                                          debouncerB.update();
                                          // Get the update value
                                          int valueB = debouncerB.read();
                                          if (valueB != oldValueB) {
                                            //send(msgB.set(stateB ? false : true), true); // Send new state and request ack back
                                            send(msgB.set(stateB ? false : true), false); // Send new state with no request for ack
                                            stateB = stateB ? false : true;                // invert the state
                                             digitalWrite(relayPinB, stateB ? RELAY_ON : RELAY_OFF);  // toggle the relay
                                            
                                          oldValueB = valueB;
                                          }
                                        }
                                        
                                        
                                        rayanR 2 Replies Last reply
                                        0
                                        • pepsonP Offline
                                          pepsonP Offline
                                          pepson
                                          wrote on last edited by
                                          #50

                                          Still not working correct. After lost connection with gateway and then change status , after connection restore , but status is still not update in Domoticz. Still show before lost connection.

                                          1 Reply Last reply
                                          0
                                          Reply
                                          • Reply as topic
                                          Log in to reply
                                          • Oldest to Newest
                                          • Newest to Oldest
                                          • Most Votes


                                          7

                                          Online

                                          11.7k

                                          Users

                                          11.2k

                                          Topics

                                          113.0k

                                          Posts


                                          Copyright 2019 TBD   |   Forum Guidelines   |   Privacy Policy   |   Terms of Service
                                          • Login

                                          • Don't have an account? Register

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • MySensors
                                          • OpenHardware.io
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular