Interrupt and sleep

[gohan]

I have been tinkering with MySensors and Arduino in the last few weeks, and now I have started to come out with a Domoticz controller, a NRF24L01+ Ethernet gateway and a sensor node that is running on a MEGA2560 just as prototype (later I'll use some Arduino Mini or similar boards) since it has much more pins to play with. So far I have connected ad PIR sensor and a crappy DHT11 just to get some values running. The problem I have now is the last line of the code, as it seems the arduino always sleeps for 10 seconds and does not quickly send the triggered PIR event. Could you pls advise if anything is wrong? I pretty much copied and merged code from examples and it is still not very clean but it should be fairly simple.

#define MY_NODE_ID 2
// Enable debug prints
#define MY_DEBUG

// Enable and select radio type attached 
#define MY_RADIO_NRF24
//#define MY_RADIO_RFM69
//#define MY_RS485

// Pin Confuguration for Arduino Mega
#define MY_RF24_CE_PIN 40
#define MY_RF24_CS_PIN 53

#include <SPI.h>
#include <MySensors.h>  
#include <DHT.h>

// Set this to the pin you connected the DHT's data pin to
#define DHT_DATA_PIN 4
#define DIGITAL_INPUT_SENSOR 3   // The digital input you attached your motion sensor.  (Only 2 and 3 generates interrupt!)

// Set this offset if the sensor has a permanent small offset to the real temperatures
#define SENSOR_TEMP_OFFSET 0
#define SENSOR_HUM_OFFSET 0

// Sleep time between sensor updates (in milliseconds)
// Must be >1000ms for DHT22 and >2000ms for DHT11
static const uint64_t UPDATE_INTERVAL = 60000;

unsigned long SLEEP_TIME = 10000; // Sleep time between reports (in milliseconds)

// Force sending an update of the temperature after n sensor reads, so a controller showing the
// timestamp of the last update doesn't show something like 3 hours in the unlikely case, that
// the value didn't change since;
// i.e. the sensor would force sending an update every UPDATE_INTERVAL*FORCE_UPDATE_N_READS [ms]
static const uint8_t FORCE_UPDATE_N_READS = 10;

#define CHILD_ID_PIR 0   // Id of the sensor child
#define CHILD_ID_HUM 1
#define CHILD_ID_TEMP 2

float lastTemp;
float lastHum;
uint8_t nNoUpdatesTemp;
uint8_t nNoUpdatesHum;
bool metric = true;

MyMessage msgPIR(CHILD_ID_PIR, V_TRIPPED);
MyMessage msgHum(CHILD_ID_HUM, V_HUM);
MyMessage msgTemp(CHILD_ID_TEMP, V_TEMP);
DHT dht;


void presentation()
{
	// Send the sketch version information to the gateway
	sendSketchInfo("PIR_TemperatureAndHumidity", "1.0");

	// Register all sensors to gw (they will be created as child devices)
	present(CHILD_ID_PIR, S_MOTION);
	present(CHILD_ID_HUM, S_HUM);
	present(CHILD_ID_TEMP, S_TEMP);

	metric = getConfig().isMetric;
}


void setup()
{
	dht.setup(DHT_DATA_PIN); // set data pin of DHT sensor
	if (UPDATE_INTERVAL <= dht.getMinimumSamplingPeriod()) {
		Serial.println("Warning: UPDATE_INTERVAL is smaller than supported by the sensor!");
	}
	// Sleep for the time of the minimum sampling period to give the sensor time to power up
	// (otherwise, timeout errors might occure for the first reading)
	sleep(dht.getMinimumSamplingPeriod());
}


void loop()
{
  // Read digital motion value
  bool tripped = digitalRead(DIGITAL_INPUT_SENSOR) == HIGH;

  Serial.println(tripped);
  send(msgPIR.set(tripped?"1":"0"));  // Send tripped value to gw
  
	// Force reading sensor, so it works also after sleep()
	dht.readSensor(true);

	// Get temperature from DHT library
	float temperature = dht.getTemperature();
	if (isnan(temperature)) {
		Serial.println("Failed reading temperature from DHT!");
	}
	else if (temperature != lastTemp || nNoUpdatesTemp == FORCE_UPDATE_N_READS) {
		// Only send temperature if it changed since the last measurement or if we didn't send an update for n times
		lastTemp = temperature;
		if (!metric) {
			temperature = dht.toFahrenheit(temperature);
		}
		// Reset no updates counter
		nNoUpdatesTemp = 0;
		temperature += SENSOR_TEMP_OFFSET;
		send(msgTemp.set(temperature, 1));

#ifdef MY_DEBUG
		Serial.print("T: ");
		Serial.println(temperature);
#endif
	}
	else {
		// Increase no update counter if the temperature stayed the same
		nNoUpdatesTemp++;
	}

	// Get humidity from DHT library
	float humidity = dht.getHumidity();
	if (isnan(humidity)) {
		Serial.println("Failed reading humidity from DHT");
	}
	else if (humidity != lastHum || nNoUpdatesHum == FORCE_UPDATE_N_READS) {
		// Only send humidity if it changed since the last measurement or if we didn't send an update for n times
		lastHum = humidity;
		// Reset no updates counter
		nNoUpdatesHum = 0;
    humidity += SENSOR_HUM_OFFSET;
		send(msgHum.set(humidity, 1));

#ifdef MY_DEBUG
		Serial.print("H: ");
		Serial.println(humidity);
#endif
	}
	else {
		// Increase no update counter if the humidity stayed the same
		nNoUpdatesHum++;
	}

	// Sleep for a while to save energy
	//sleep(UPDATE_INTERVAL);
   
  // Sleep until interrupt comes in on motion sensor. Send update every two minute.
  sleep(digitalPinToInterrupt(DIGITAL_INPUT_SENSOR), CHANGE, SLEEP_TIME);

}```

[mfalkvidd]

@gohan looks very similar to https://forum.mysensors.org/topic/5552/pin-change-interrupt-not-firing-with-mysensors - maybe that info helps?

[gohan]

Similar but not the same since I don't have crashes, just it is just ignoring interrupt and sleeping 10 seconds every time.

[mfalkvidd]

@gohan seems like we aren't reading the same thing. I don't see anyhing about a crash, only about interrupt not firing.

[gohan]

Are you referring to the sleep(0xff,0x00, 0xff, 0x00, 0)?

[mfalkvidd]

@gohan no. I am referring to "For some reason I am unable to get the board to respond to pin change interrupts when using MySensors gw.sleep() using the MotionSensor.ino" in the first post in the thread I linked to.

[elysion]

From your description it sounds like your problem is pretty much exactly same as mine was when I started that thread. I have not experienced any crashes. The issue is just that the board does not wake up on CHANGE. Have you tried using LOW instead of CHANGE for sleep? There were comments in the aforementioned thread that this might be an issue with a certain version of Arduino and boards file. Have not yet had time to investigate tough.

[gohan]

@elysion
I have updated IDE to latest version and I got a change: now it takes a variable time between 30 sec to 2 minutes for the motion sensor to restore to "0" .
If I set it to LOW it just skips the sleep as I see continuously errors from reading from the DHT11 sensor until I trigger the motion sensor. Changing it to HIGH or CHANGE I get the same result. Now it's late, so maybe tomorrow I'll try downgrading IDE and boards to 1.6.8 as suggested in another thread.

[gohan]

Downgraded to 1.6.8 IDE and boards but no change, also tried to compile it in Visual Studio but behavior is the same. Maybe the Mega has some issues that other boards don't have?
Here is log

5079 TSF:MSG:SEND,2-2-0-0,s=0,c=1,t=16,pt=0,l=1,sg=0,ft=0,st=OK:0
5107 MCO:SLP:MS=10000,SMS=0,I1=1,M1=1,I2=255,M2=255
5112 MCO:SLP:TPD
5113 MCO:SLP:WUP=1
1
5118 TSF:MSG:SEND,2-2-0-0,s=0,c=1,t=16,pt=0,l=1,sg=0,ft=0,st=OK:1
5149 TSF:MSG:SEND,2-2-0-0,s=2,c=1,t=0,pt=7,l=5,sg=0,ft=0,st=OK:20.9
T: 20.94
5156 MCO:SLP:MS=10000,SMS=0,I1=1,M1=1,I2=255,M2=255
5160 MCO:SLP:TPD
5163 MCO:SLP:WUP=-1
1
5168 TSF:MSG:SEND,2-2-0-0,s=0,c=1,t=16,pt=0,l=1,sg=0,ft=0,st=OK:1
5196 MCO:SLP:MS=10000,SMS=0,I1=1,M1=1,I2=255,M2=255
5200 MCO:SLP:TPD
5202 MCO:SLP:WUP=-1
1
5208 TSF:MSG:SEND,2-2-0-0,s=0,c=1,t=16,pt=0,l=1,sg=0,ft=0,st=OK:1
5238 TSF:MSG:SEND,2-2-0-0,s=1,c=1,t=1,pt=7,l=5,sg=0,ft=0,st=OK:20.0
H: 20.00
5244 MCO:SLP:MS=10000,SMS=0,I1=1,M1=1,I2=255,M2=255
5250 MCO:SLP:TPD
5252 MCO:SLP:WUP=-1
1
5256 TSF:MSG:SEND,2-2-0-0,s=0,c=1,t=16,pt=0,l=1,sg=0,ft=0,st=OK:1
5284 MCO:SLP:MS=10000,SMS=0,I1=1,M1=1,I2=255,M2=255
5289 MCO:SLP:TPD
5291 MCO:SLP:WUP=1
0
5298 TSF:MSG:SEND,2-2-0-0,s=0,c=1,t=16,pt=0,l=1,sg=0,ft=0,st=OK:0
5326 MCO:SLP:MS=10000,SMS=0,I1=1,M1=1,I2=255,M2=255
5331 MCO:SLP:TPD

As you can see when motion is triggered (the "1" on 5th line) it takes a while for it to go back to "0" and each message is 10 seconds from the previous like it is ignoring the interrupt.
I'm running out of options besides buying a few Pro Mini and start building a definitive sensor

[sundberg84]

@gohan - any change if you try to change the trigger delay on the motion sensor?

[gohan]

No, I tried to move it around but it doesn't change the behavior in this case.

[JoergP]

ahhhhhhhhhhhh - I created a door/window sensor some weeks ago - but I couldn't make it run to fire an interrupt on pin change (INT0 and INT1 are used to connect external magnetic sensors) - today I decided to work on this issue again and found this topic at the forum - so I downgraded my arduino IDE by downloading v1.6.8 from arduino.cc today - compiled my code again - falshed it - and voilà - it works
That is really frustrating by wasting that many hours of time only by inconsistancy with compiler/board definitions.
Is there any need to update to newer arduino-IDE - otherwise I would recommend to general stick to one version ...

[gohan]

@JoergP
Would you mind posting board version you are using and also your code? Did some test but I couldn't figure out anything on my mega so probably there is also something about that kind of board, so I didn't spend too much time on it and wait for the other minis I ordered

[JoergP]

I checked the used versions - as I already wrote the used arduino-IDE is 1.6.8. But due to the case that I used 1.8.0 before and downgraded the board definition by "Board manager" the board definition is 1.6.11 (if you down/upgrade by BoardManager you can find the files in dir "C:\Users...\AppData\Local\Arduino15\packages\arduino\hardware\avr\1.6.11"
I added my own definitions to board.txt (because I use 2AA Battery node -> https://www.openhardware.io/view/10/My-Slim-2AA-Battery-Node)

here my quick and dirty source - have to clean up if it works as expected:

// ---------------------------------------------------------
// based on 2AA Battery Node
// ATMEGA328P (@ internal OSC 1MHz)
// device ID = 0x07D5 (2005d )
// ---------------------------------------------------------
// 0  - Input 0 -> S_DOOR / V_TRIPPED
// 1  - Input 1 -> S_DOOR / V_TRIPPED
// 2  - temperature (HTU)
// 3  - humidity (HTU)
// ---------------------------------------------------------


// ---------------------------------------------------------
// includes
// ---------------------------------------------------------
#include <Wire.h>
#include "Adafruit_HTU21DF.h"

#include <Vcc.h>
#include <avr/wdt.h>

// ---------------------------------------------------------
// MySensors
// ---------------------------------------------------------
#define MY_RADIO_NRF24
#define MY_RF24_PA_LEVEL RF24_PA_MAX
#include <MySensors.h>
#include <SPI.h>

// ---------------------------------------------------------
// MySensor
// ---------------------------------------------------------
#define SN "AA - Windows / Temperature"
#define SV "1.1"
#define ms_input_0      0
#define ms_input_1      1
#define ms_temperature  2
#define ms_humidity     3

// ---------------------------------------------------------
// used PINs
// ---------------------------------------------------------
#define PIN_INPUT_0     2
#define PIN_INPUT_1     3

// ---------------------------------------------------------
// Sleep
// ---------------------------------------------------------
#define SLEEP_TIME 300000   // ms => 5 min
#define VALUE_MIN_COUNT 12  // send min every 12th measurement one value (once per hour)

// ---------------------------------------------------------
// Vcc
// ---------------------------------------------------------
#define VCC_MIN 1.9
#define VCC_MAX 3.3
#define BATTERY_COUNT 288   // 288 * 5 min = 1 day

// ---------------------------------------------------------
// global vars
// ---------------------------------------------------------
MyMessage msg(0,0);

Adafruit_HTU21DF htu = Adafruit_HTU21DF();
boolean htu_available = false;
float htu_temperature = 1000;
float htu_humidity = 1000;
int batteryCnt = 0;
int temperatureCnt = 0;
int humidityCnt = 0;;

Vcc vcc;


// #########################################################
// setup
// #########################################################
void setup() {
  // ---------
  // PINs
  // ---------  
  pinMode(PIN_INPUT_0, INPUT_PULLUP);
  pinMode(PIN_INPUT_1, INPUT_PULLUP);
  
  // ---------
  // HTU21
  // ---------
  if (htu.begin())
    htu_available = true;
}

// #########################################################
// presentation
// #########################################################
void presentation()
{
  // Send the sketch version information to the gateway and Controller
  sendSketchInfo(SN, SV);
  
  // Send sensor information
  present(ms_input_0, S_DOOR);
  present(ms_input_1, S_DOOR);

  if(htu_available) {
    present(ms_temperature, S_TEMP);
    present(ms_humidity, S_HUM);
  }
}

// #########################################################
// loop
// #########################################################
void loop() {
  // enable watchdog
  wdt_enable(WDTO_8S);

  // -------------
  // inputs
  // -------------
  sendInput0();
  sendInput1();

  // -------------
  // check battery
  // -------------
  if(batteryCnt == 0)
    sendBatteryReport();

  batteryCnt++;
  if(batteryCnt > BATTERY_COUNT)
    batteryCnt = 0;
  
  // -------------
  // temperature
  // -------------
  if(htu_available) {
    sendTemperature();
    sendHumidity();
  }
  
  // -------------
  // sleep
  // -------------
  delay(500);
  wdt_disable();
  sleep(digitalPinToInterrupt(PIN_INPUT_0), CHANGE, digitalPinToInterrupt(PIN_INPUT_1), CHANGE, SLEEP_TIME);
}


// #########################################################
// helper functions
// #########################################################
float rfloat(float val, unsigned int num) {
  if(num) {
    float f = 10.0 * num;
    return round(val*f)/f;
  }
  else
    return round(val);
}

void sendTemperature() {
  wdt_reset();
  float tmp = htu.readTemperature();
  if(tmp < 900){ // check errors
    tmp = rfloat(tmp, 1);
    if((tmp != htu_temperature) || (temperatureCnt >= VALUE_MIN_COUNT)){
      htu_temperature = tmp;
      send(msg.setSensor(ms_temperature).setType(V_TEMP).set(htu_temperature,1));
      temperatureCnt = 0;
    }
    else
      temperatureCnt++;
  }
}

void sendHumidity() {
  wdt_reset();
  float tmp = htu.readHumidity();
  if(tmp < 900){ // check errors
    tmp = rfloat(tmp, 0);
    if((tmp != htu_humidity) || (humidityCnt >= VALUE_MIN_COUNT)){
      htu_humidity = tmp;
      send(msg.setSensor(ms_humidity).setType(V_HUM).set(htu_humidity,0));
      humidityCnt = 0;
    }
    else
      humidityCnt++;
  }  
}

void sendBatteryReport() {
  wdt_reset();
  delay(500);
  float p = vcc.Read_Perc(VCC_MIN, VCC_MAX, true);
  int batteryPcnt = static_cast<int>(p);
  sendBatteryLevel(batteryPcnt);
}

void sendInput0() {
  wdt_reset();
  if(digitalRead(PIN_INPUT_0) == HIGH)
    send(msg.setSensor(ms_input_0).setType(V_TRIPPED).set(0));
  else
    send(msg.setSensor(ms_input_0).setType(V_TRIPPED).set(1));
}

void sendInput1() {
  wdt_reset();
  if(digitalRead(PIN_INPUT_1) == HIGH)
    send(msg.setSensor(ms_input_1).setType(V_TRIPPED).set(0));
  else
    send(msg.setSensor(ms_input_1).setType(V_TRIPPED).set(1));
}```

[gohan]

What does this do?
wdt_enable(WDTO_8S);

[gohan]

Tests so far are just as the same as before even with the changes you suggested, so I believe I'll just wait for the other new arduinos and use the mega for other purposes

[JoergP]

That's bad - if you like you can send me your source and I can try to compile it on my environment.
I use the watchdog in general - in the past I had the issue that some nodes stopped working without any reason - watchdog helped to solve this

[gohan]

Look at my first post, that's the code. It's a draft so it's not really cleaned up

[Efflon]

@JoergP ans others, I have tried versions 1.6.8 and the board definitions 1.6.11 and interrupt seems to work but in the case of using a PIR the sensor somehow seems to be triggered when going out of sleep due to time...

[JoergP]

@Efflon I'm not sure what exactly you mean - do you refer to my code? In that case this is a quick and dirty try - I'll send at every pin change and at timeout the input values ...