Automatic LED light - high WAF inside :)

[ben999]

Hi guys

Could you please comment on this :

bool tripped = digitalRead(PIN_MOTION) == HIGH;
if ( tripped =! prevTripped ) {     //only send data when there is a change
  send(msgMotion.set(tripped ? "1" : "0")); // Send tripped value to gw
  prevTripped = tripped;
  }

Goal is to send update to gateway when state of PIR sensor changes
Trouble is that node sends state of sensor every cycle and floods karaf console...
Any clue ?
Also can anyone explain this

bool tripped = digitalRead(PIN_MOTION) == HIGH;

I dont quite understand.... read, store, and compare... all at once?

Thanks a lot for your help

Cheers

[billgoolsby]

@ben999,
As for your last question, this line is simply converting the pin state (either HIGH or LOW) to a boolean. The right side expression evaluates to a boolean that is true when the pin is HIGH. This is assigned to the boolean variable "tripped". This makes it logically easy to use in the following IF statement.

First question: I'm not sure why it would send every cycle. The logic of the IF statement seems correct, and since prevTripped is global, its state will be preserved between loops.

[dbemowsk]

@ben999 Nice CNC work on the PCB.

[dbemowsk]

@ben999 I would rewrite some of the logic in your code to shorten it up a bit. I would change this:

  if ( lightMode == 0 ) {
    digitalWrite(PIN_RELAY, LOW);
  }

  if ( lightMode == 1 ) {
    digitalWrite(PIN_RELAY, HIGH);
  }

  if ( (tripped == 1) && ( lightMode == 2 ) )  {
    digitalWrite(PIN_RELAY, HIGH);
  }

  if ( (tripped == 0) && ( lightMode == 2 ) )  {
    digitalWrite(PIN_RELAY, LOW);
  }

To this:

  if ( ( (tripped == 1) && ( lightMode == 2 ) ) ||   lightMode == 1  )  {
    digitalWrite(PIN_RELAY, HIGH);
  }

  if ( ( (tripped == 0) && ( lightMode == 2 ) ) ||   lightMode == 0  )  {
    digitalWrite(PIN_RELAY, LOW);
  }

[ben999]

@dbemowsk thanks a lot :) i like that!

Do you rekon that would "speed" things up? Not that i need more speed to switch that light on but would this simplify and shorten the sketch processing time?

[ben999]

@billgoolsby thanks a lot for your comments that make more sense now :)

Trouble is that if sketch remains as above it doesn't get into the if ( tripped =! prevTripped ) loop (i have put Serial.print here and there and i never get to it)
On top of that tripped stays locked on HIGH but light is off...

Any clue? Sketch seems fine to you?

Thanks for your time :)

[ben999]

@dbemowsk said in Automatic LED light - high WAF inside :):

@ben999 Nice CNC work on the PCB.

I have some neat little tools in my workshop:

3x1.5m working area

500x300mm working area

[dbemowsk]

@ben999 OK, NO FAIR. Is the bottom one a laser cutter/engraver??

[ben999]

@dbemowsk :D i know i'm lucky to have all those toys handy

This is a 2.2kW spindle... other one is 13kW in case i need more :D

[dbemowsk]

@ben999 .oO{ JEALOUS }Oo.

[ben999]

@ben999 just for the record... =! is wrong. Should have been !=
Makes quite a difference :(