Door, Motion and Temperature Sensor

[robosensor]

DallasSensors.requestTemperatures(); delays code execution up to 750ms. MySensors DS18B20 library is bit outdated, you should update library (https://github.com/milesburton/Arduino-Temperature-Control-Library) and use following code:

In setup:

	DallasSensors.begin();
	DallasSensors.setWaitForConversion(false);

In loop:

		DallasSensors.requestTemperatures(); // no delay here
		gw.wait(750); // insert another value for non-12-bit resolution
		float tempC = DallasSensors.getTempCByIndex(1);

[CaptainZap]

@robosensor Thank you very much for your insight... do I just download the new library and overwrite the one in the Arduino IDE install folder ?

I've also used your code and I'm getting errors compiling it, any hints ? I guess it could be because of the library ?

Arduino: 1.6.4 (Windows 8.1), Board: "Arduino Mini, ATmega328"

Door_Motion_Temp_rev2.ino: In function 'void getTemps()':
Door_Motion_Temp_rev2:115: error: 'class MySensor' has no member named 'wait'
Multiple libraries were found for "DallasTemperature.h"

Used: C:\Users***\Documents\Arduino\libraries\DallasTemperature << this is where I've copied the downloaded library

Not used: C:\Users***\Documents\Arduino\libraries\Arduino-Temperature-Control-Library-master

'class MySensor' has no member named 'wait'

This report would have more information with
"Show verbose output during compilation"
enabled in File > Preferences.

'class MySensor' has no member named 'wait'

[robosensor]

@CaptainZap yes, but update two libraries (OneWire and Dallas).

gw.wait() function was added 1 feb 2015: https://github.com/mysensors/Arduino/commit/d45a48d8b786656968fb4b45b049e16700dd3fd0 so you should use latest stable 1.4.* code.

[CaptainZap]

@robosensor I don't know where to find the complete library for version 1.4.x

[robosensor]

@CaptainZap

http://www.mysensors.org/download/ click on Download button under "1.4 - Latest Release" section, download zip archive, extract archive and check Arduino-master\libraries\MySensors\Version.h file.

[CaptainZap]

@robosensor Thanks, I installed that but it's version 1.5 b1 and after using it it's giving me lots of errors :| I think there have been changes in how the code is used...

LE: I finally found the 1.4.1 branch and downloaded it however it's still giving me the same error about wait:

Door_Motion_Temp_rev2.ino: In function 'void getTemps()':
Door_Motion_Temp_rev2:115: error: 'class MySensor' has no member named 'wait'
'class MySensor' has no member named 'wait'

LLE: Just checked the cpp and there is no wait, this is the library I used :
https://github.com/mysensors/Arduino/tree/1.4.1

Can you tell me if there will be any issue if I comment that part ?

[robosensor]

@CaptainZap https://github.com/mysensors/Arduino/archive/master.zip

[hek]

@robosensor

LOL :)

[CaptainZap]

That was the version I was using when I first encountered the issues... anyways I'll remove arduino IDE with everything and reinstall it. Thanks.

@hek I also LOL-ed :D Gotta love the helping spirit in the community you guys built.

[robosensor]

@CaptainZap also try to backup and clean C:\Users***\Documents\Arduino\ directory :)

[robosensor]

@hek as I said before, Dallas library is bit outdated. Is it possible to update dallas and onewire libraries? I provided links for newer versions of this libraries in this thread. I can do PR in github myself, but I don't know how to do it :) I need to read github manuals first :)

requestTemperatures() is can be non-blocking in newer version of dallas library, so code can deep sleep (better for batteries) or process messages (better for repeaters and msg-receiving nodes) about 750 ms.

[hek]

@robosensor

Using github is quite easy (when you get a hang of it). We can use this as a "training session" if you want?

I did a quick getting-started guide here:
http://forum.mysensors.org/topic/330/how-to-contribute-code-to-the-mysensors-project

Basically you need to

• Fork the mysensors project on github
• Clone your fork from your computer.
• Replace the libraries that is outdated.
• Commit as push the changes back to your fork of github.
• Create a pull-request (see above instructions) which I'll review and merge.

Easy peasy.. :)

[robosensor]

@hek thank you, I'll read and try on dallas&onewire :)

[hek]

@robosensor

Great, just ask (or open a chat) if you run into trouble.

[robosensor]

@hek I have forked MySensors project, added 3 commits into master branch with updated libraries and updated dallas sensors example (lower power usage).

I'm using similar code in my own version of MySensors 1.5-dev in my home, but I havn't tested this committed 1.4.1 github code on real hardware, so I will make PR after test on real hardware.

https://github.com/mysensors/Arduino/compare/master...roboprint:master?diff=split&name=master

[hek]

Sounds good!

[robosensor]

@hek It seems that I did it. If this push request is correct, what I should patch? Development branch, master branch or both?

[hek]

Good!
You can create pull request on master (and I'll merge it to development later).

[hek]

@robosensor

Thanks and congrats! You've made your first contribution to the MySensors project. :)

[CaptainZap]

Guys, I had some free time tonight and tried to apply this fix... I ended up re-installing the arduino IDE + downloading the latest version, which now is 1.4.1 as opposed to the 1.4 that I used to have ?

Anyways I had to upgrade my ethernet gateway (ENC28J60) and it's no longer working now... any hints will be golden.
LE: I was too tired to check the sketch... I forgot to include the correct library and went to all debugging first, reset router config to default, but in the end I did notice the issue :) So I learned a valuable lesson, never work on this if it's late or you're tired.