1.6 gateway possible error
-
Problem found in 2.0.0-beta: the LED pins seems to be active on nodes even I didn't enable MY_LEDS_BLINKING_FEATURE in MyConfig.h, so I expect them to be unavailable and do not interfere with my sketch, but they did. How to disable them and keep the pins for my program?
In 1.6 they are not active. -
I use the development version downloaded about one hour before posting, then check several times with 1.6 and 2.0 versions. I change the LED pin to 2 for all three LEDs (Rx, Tx, Err) and then my switches that use old LED PINs works fine, while a LED connected to the PIN 2 was blinking.
-
I made a change, so that if any of the LED's where defined, then it will enable MY_LED_BLINKING_FEATURE
Could it be that you have a define for some of the LED's somewhere?
look for MY_DEFAULT_xx_LED defines..
Or are they set as default somewhere in the library @hek?
-
yes.. I see the problem now.. My bad :(
Didn't see that we set the MY_DEFAULT_xx_LED defines for different archs if they are not defined by the user..
I'll make the appropriate changes tonight (I'm not at my dev machine now)
@tbowmo, so does this mean that we no longer have to enable/uncomment the "MY_LED_BLINKING_FEATURE" in config.h? We are able to just assign the pins inside of the sketch (like the default sketch of the development branch shows) without touching out config file?
MySensors 2.1.1
Controller - OpenHAB (Virtual Machine)
Gateway - Arduino Mega MQTT Gateway W5100 -
@tbowmo, so does this mean that we no longer have to enable/uncomment the "MY_LED_BLINKING_FEATURE" in config.h? We are able to just assign the pins inside of the sketch (like the default sketch of the development branch shows) without touching out config file?
That was the initial thought, but I now see that it will not work, as the Leds are defined in the core, if they are missing, so they will always be defined when we reach the logic that enables MY_BLINKING_LED_FEATURE. And then that will always be enabled.
