2 dallas temp + 4 relays

[rejoe2]

@mghaff: please avoid double postings. It would have been nice if you'd at least have made a link to this post in the other one you did on that topic here: https://forum.mysensors.org/post/95894.

@both:
Imo you should implement a "non-blocking" code, nut just add a sleep or wait at the end of loop or just delete that. Otherwise most likely either your DS18B20 will not deliver any meaningfull measurements or you will not be able to controll your relays...
Please have a look at https://github.com/mysensors/MySensors/blob/master/examples/EnergyMeterPulseSensor/EnergyMeterPulseSensor.ino as a base example how to implement non-blocking code (path: sleepmode false) or have a look in the sketch I linked to in the answer to the other posting: https://forum.mysensors.org/post/95901

[dzjr]

@mghaff my sketch is working good, dallas and moisture readings are good, and i can control my relays.

[rejoe2]

@dzjr Didn't test that to be honest, but nevertheless, imho it is not a state of the art code design to use wait() nor is it best practice to use much hard-coded steps to do the same thing over and over. Rather use millis() for non-blocking coding and for-loops over comparable stuff, write to and read results from arrays. This keeps coding much easier to read and understand once you got the idea how it works.
But what in the end counts: It works...

[MGHaff]

@dzjr I tried to use your sketch to get mine to work and it does not. I might just rebuild it all with new everything and try it again.

[MGHaff]

Would this be my blocking loop?

void presentation() {
  // Send the sketch version information to the gateway and Controller
  sendSketchInfo("Fireplace interface", "1.1");
  //wait(LONG_WAIT);

  // Fetch the number of attached temperature sensors  
  numSensors = sensors.getDeviceCount();

  // Present all sensors to controller
  for (int i=0; i<numSensors && i<MAX_ATTACHED_DS18B20; i++) {   
     present(i+5, S_TEMP,"Fireplace Temp");
  //wait(SHORT_WAIT);
  }  
  for (int sensor=1, pin=RELAY_1; sensor<=NUMBER_OF_RELAYS; sensor++, pin++) {
   // Register all sensors to gw (they will be created as child devices)
    present(sensor, S_BINARY);
  //wait(SHORT_WAIT);
  }
}

[rejoe2]

@mghaff Looks quite ok in the presentation() function.
You do not need the "pin" variable in presentation, so you might shorten that to:

for (int sensor=1; sensor<=NUMBER_OF_RELAYS; sensor++) {
   // Register all sensors to gw (they will be created as child devices)
    present(sensor, S_BINARY);
 }

The "pin++" is needed in case you want to switch also the relays to a specific state. If you also want a completely flexible pin-assignment see sketch in https://forum.mysensors.org/topic/4847/multi-button-relay-sketch/33# as a very good example. There also the corresponding PIN is read from an predefined array (has some quite interesting button features also).

[MGHaff]

I tried to combine a couple other sketches and the closest I got was this one. But it still does not give me values for my Dallas temp. if I try each sketch separate they work fine and present fine with readings. I am a newbie and have luck, yes i call it luck cause my other sensors work just fine.

My debug is

---

| / |_ / | ___ _ __ ___ ___ _ __ ___
| |/| | | | _ \ / _ \ _ \/ __|/ _ \| _/ __|
| | | | || || | / | | _ \ _ | | _
|| ||_, |/ ___|| ||/_/|| |/
|__/ 2.3.1

16 MCO:BGN:INIT NODE,CP=RNNNA---,REL=255,VER=2.3.1
26 MCO:BGN:BFR
120 TSM:INIT
121 TSF:WUR:MS=0
129 TSM:INIT:TSP OK
130 TSM:INIT:STATID=8
136 TSF:SID:OK,ID=8
138 TSM:FPAR
174 TSF:MSG:SEND,8-8-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
448 TSF:MSG:READ,0-0-8,s=255,c=3,t=8,pt=1,l=1,sg=0:0
452 TSF:MSG:FPAR OK,ID=0,D=1
2181 TSM:FPAR:OK
2182 TSM:ID
2183 TSM:ID:OK
2185 TSM:UPL
2188 TSF:MSG:SEND,8-8-0-0,s=255,c=3,t=24,pt=1,l=1,sg=0,ft=0,st=OK:1
2195 TSF:MSG:READ,0-0-8,s=255,c=3,t=25,pt=1,l=1,sg=0:1
2200 TSF:MSG:PONG RECV,HP=1
2203 TSM:UPL:OK
2204 TSM:READY:ID=8,PAR=0,DIS=1
2209 TSF:MSG:SEND,8-8-0-0,s=255,c=3,t=15,pt=6,l=2,sg=0,ft=0,st=OK:0100
2217 TSF:MSG:READ,0-0-8,s=255,c=3,t=15,pt=6,l=2,sg=0:0100
2225 TSF:MSG:SEND,8-8-0-0,s=255,c=0,t=17,pt=0,l=5,sg=0,ft=0,st=OK:2.3.1
2233 TSF:MSG:SEND,8-8-0-0,s=255,c=3,t=6,pt=1,l=1,sg=0,ft=0,st=OK:0
2250 TSF:MSG:READ,0-0-8,s=255,c=3,t=6,pt=0,l=1,sg=0:M
2257 TSF:MSG:SEND,8-8-0-0,s=255,c=3,t=11,pt=0,l=18,sg=0,ft=0,st=OK:Temperature Sensor
2268 TSF:MSG:SEND,8-8-0-0,s=255,c=3,t=12,pt=0,l=3,sg=0,ft=0,st=OK:1.2
2276 TSF:MSG:SEND,8-8-0-0,s=1,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2283 TSF:MSG:SEND,8-8-0-0,s=21,c=0,t=6,pt=0,l=0,sg=0,ft=0,st=OK:
2290 TSF:MSG:SEND,8-8-0-0,s=2,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2298 TSF:MSG:SEND,8-8-0-0,s=21,c=0,t=6,pt=0,l=0,sg=0,ft=0,st=OK:
2306 TSF:MSG:SEND,8-8-0-0,s=3,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2314 TSF:MSG:SEND,8-8-0-0,s=21,c=0,t=6,pt=0,l=0,sg=0,ft=0,st=OK:
2321 TSF:MSG:SEND,8-8-0-0,s=1,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2328 TSF:MSG:SEND,8-8-0-0,s=22,c=0,t=6,pt=0,l=0,sg=0,ft=0,st=OK:
2336 TSF:MSG:SEND,8-8-0-0,s=2,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2343 TSF:MSG:SEND,8-8-0-0,s=22,c=0,t=6,pt=0,l=0,sg=0,ft=0,st=OK:
2352 TSF:MSG:SEND,8-8-0-0,s=3,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2359 TSF:MSG:SEND,8-8-0-0,s=22,c=0,t=6,pt=0,l=0,sg=0,ft=0,st=OK:
2365 MCO:REG:REQ
2368 TSF:MSG:SEND,8-8-0-0,s=255,c=3,t=26,pt=1,l=1,sg=0,ft=0,st=OK:2
2374 TSF:MSG:READ,0-0-8,s=255,c=3,t=27,pt=1,l=1,sg=0:1
2379 MCO:PIM:NODE REG=1
2382 MCO:BGN:STP
Hello world, I am a sensor.
2383 MCO:BGN:INIT OK,TSP=1
Starting new measurement(s)
Sensor #0 says it is -127.00 degrees
Sensor #1 says it is -127.00 degrees
zzzzZZZZzzzzZZZZzzzz

/**
   The MySensors Arduino library handles the wireless radio link and protocol
   between your home built sensors/actuators and HA controller of choice.
   The sensors forms a self healing radio network with optional repeaters. Each
   repeater and gateway builds a routing tables in EEPROM which keeps track of the
   network topology allowing messages to be routed to nodes.

   Created by Henrik Ekblad <henrik.ekblad@mysensors.org>
   Copyright (C) 2013-2015 Sensnology AB
   Full contributor list: https://github.com/mysensors/Arduino/graphs/contributors

   Documentation: http://www.mysensors.org
   Support Forum: http://forum.mysensors.org

   This program is free software; you can redistribute it and/or
   modify it under the terms of the GNU General Public License
   version 2 as published by the Free Software Foundation.

 *******************************

   DESCRIPTION

   Example sketch showing how to send in DS1820B OneWire temperature readings back to the controller
   http://www.mysensors.org/build/temp

   The cool thing about this temperature sensor (pun intended) is thay you can attach multiple Dallas temperature sensors outputs to the same arduino pin. They will all automatically be recognised as separate sensors.

   At the moment of writing (februari 2017) you need older versions of the Dallas and OneWire libraries. Please check the website or forum to see if this is still the case.

   Modifications by anonymous user so that it can now simultaneously function as a MySensors repeater.
*/


// Enable debug prints to serial monitor
#define MY_DEBUG

// Enable and select radio type attached
#define MY_RADIO_RF24                            // A 2.4Ghz transmitter and receiver, often used with MySensors.
//#define MY_RF24_PA_LEVEL RF24_PA_MIN              // This sets a low-power mode for the radio. Useful if you use the verison with the bigger antenna, but don' want to power that from a separate source. It can also fix problems with fake Chinese versions of the radio.
//#define MY_RADIO_RFM69                          // 433Mhz transmitter and reveiver.
#define MY_NODE_ID 8
// Choose if you want this sensor to also be a repeater.
// #define MY_REPEATER_FEATURE                    // Just remove the two slashes at the beginning of this line to also enable this sensor to act as a repeater for other sensors. If this node is on battery power, you probably shouldn't enable this.
// Are you using this sensor on battery power?
//#define BATTERY_POWERED                   // Just remove the two slashes at the beginning of this line if your node is battery powered. It will then go into deep sleep as much as possible. But when it' sleeping it can' work as a repeater.

#include <SPI.h>
#include <MySensors.h>
#include <DallasTemperature.h>
#include <OneWire.h>


// These defines and variables can be changed:
#define COMPARE_TEMP 1                            // Send temperature only if changed? 1 = Yes 0 = No. Can save battery.
#define ONE_WIRE_BUS 3                            // Pin where Dallas sensor(s) is/are connected.
#define MAX_ATTACHED_DS18B20 16                   // Maximum amount of teperature sensors you can connect to this arduino (16).
#define RELAY_PIN 4  // Arduino Digital I/O pin number for first relay (second on pin+1 etc)
#define NUMBER_OF_RELAYS 3 // Total number of attached relays
#define RELAY_ON 1  // GPIO value to write to turn on attached relay
#define RELAY_OFF 0 // GPIO value to write to turn off attached relay


unsigned long measurementInterval = 30000;        // Time to wait between reads (in milliseconds).

// You should not change these:
OneWire oneWire(ONE_WIRE_BUS);                    // Setup a oneWire instance to communicate with any OneWire devices (not just Maxim/Dallas temperature ICs)
DallasTemperature sensors(&oneWire);              // Pass the oneWire reference to Dallas Temperature.
float lastTemperature[MAX_ATTACHED_DS18B20];      // creates an array to hold the previous temperature measurements for each possible sensor.
int numSensors = 0;                               // variable to contain the number of found attached sensors.
boolean metric = true;                            // old Mysensors??
unsigned long measurementSleepTime = 0;           // variable to store the Sleep time if the node is battery powered.


// Mysensors settings
MyMessage msg(0, V_TEMP);                         // Sets up the message format that we'l be sending to the MySensors gateway later.


void before()
{
  sensors.begin();                              // Startup up the OneWire library. It allows multiple sensors to talk over one wire (one pin).
  for (int sensor = 1, pin = RELAY_PIN; sensor <= NUMBER_OF_RELAYS; sensor++, pin++) {
    // Then set relay pins in output mode
    pinMode(pin, OUTPUT);
    // Set relay to last known state (using eeprom storage)
    digitalWrite(pin, loadState(sensor) ? RELAY_ON : RELAY_OFF);
  }
}
void setup()
{
  for (int i = 0; i < MAX_ATTACHED_DS18B20; i++) {
    lastTemperature[i] = 0;  //Pre-filling array with 0's.
  }
  sensors.setWaitForConversion(false);            // requestTemperatures() will not block current thread

#ifdef BATTERY_POWERED
  measurementSleepTime = measurementInterval;
  measurementInterval = 1;                    // We'll let Sleep take over the scheduling. When the arduino is asleep, millis doesn't increment anymore (time stops as it were). To fix this, we'l set the measurement interval time to 1, so that when the arduino wakes up it will immediately try to measure again.
#endif

  Serial.begin(115200);                           // for serial debugging.
  Serial.print("Hello world, I am a sensor. \n ");

}

void presentation()
{
  sendSketchInfo("Temperature Sensor", "1.2");    // Send the sketch version information to the gateway and Controller
  numSensors = sensors.getDeviceCount();          // Fetch the number of attached temperature sensors
  for (int i = 0; i < numSensors && i < MAX_ATTACHED_DS18B20; i++)
  for (int sensor = 1, pin = RELAY_PIN; sensor <= NUMBER_OF_RELAYS; sensor++, pin++) {
    // Register all sensors to gw (they will be created as child devices)
    present(sensor, S_BINARY);
    present(i+21, S_TEMP);                          // Present all sensors to controller (16 maximum).
  }
}

void loop()
{

  // You should not change these variables:
  static boolean isMeasuring = true;                // Used to indicate when the time is right for a new measurement to be made.
  static boolean isCalculating = false;                     // Used to bridge the time that is needed to calculate the temperature values by the Dallas library.
  static unsigned long currentMillis = 0;                   // The millisecond clock in the main loop.
  static unsigned long previousMeasurementMillis = 0;       // Used to remember the time of the last temperature measurement.
  static int16_t conversionTime = 0;                        // Used to store the time needed to calculate the temperature from measurements.

  currentMillis = millis(); // The time since the sensor started, counted in milliseconds. This script tries to avoid using the Sleep function, so that it could at the same time be a MySensors repeater.

  // Let's measure the temperature
  if (isMeasuring == true && currentMillis - previousMeasurementMillis >= measurementInterval) { // If we're not calculating, and enough time has passed, we'll start again.
    isMeasuring = false; // We're measuring, so let's take it off our to-do list.
    Serial.print("Starting new measurement(s)\n");
    previousMeasurementMillis = currentMillis; // Mark the time of the initialiation of this measurement.

    // Fetch temperatures from Dallas sensors
    sensors.requestTemperatures();

    // query conversion time. Apparently it takes a while to calculate.
    //CONVERSION_TIME = sensors.millisToWaitForConversion(sensors.getResolution());
    conversionTime = millisToWaitForConversion(sensors.getResolution());
    isCalculating = true; //Next step is to re-calculate the temperature again.
  }


  // Next, let's calculate and send the temperature
  if (isCalculating == true && currentMillis > previousMeasurementMillis + conversionTime ) {
    isCalculating = false; // check calculating off the to-do list too.

    for (int i = 0; i < numSensors && i < MAX_ATTACHED_DS18B20; i++) { // Loop through all the attached temperatur sensors.
      float temperature = static_cast<float>(static_cast<int>((getControllerConfig().isMetric ? sensors.getTempCByIndex(i) : sensors.getTempFByIndex(i)) * 10.)) / 10.; // Fetch and round temperature to one decimal
      Serial.print("Sensor #");
      Serial.print(i);
      Serial.print(" says it is ");
      Serial.print(temperature);
      Serial.print(" degrees\n");
      if (temperature != -127.00 && temperature != 85.00) { // avoid working with measurement errors.
        if (COMPARE_TEMP == 1 && lastTemperature[i] == temperature) {
          Serial.print("Not sending it though, because it's the same temperature as before.\n");
        } else {
          Serial.print("Sending the temperature to the gateway.\n");
          send(msg.setSensor(i).set(temperature, 1));
          lastTemperature[i] = temperature; // Save new temperatures to be able to compare in the next round.
        }
      }
    }

    // Both tasks are done. Time to wait until we should measure again.
    Serial.print("zzzzZZZZzzzzZZZZzzzz\n");

#ifdef BATTERY_POWERED
    unsigned long quicktimecheck = millis(); // check how much time has passed during the measurement (can be up to 750 milliseconds), and then calculate from that how long to sleep until the next intended measuring time.
    unsigned long sleeptime = measurementSleepTime - (quicktimecheck - previousMeasurementMillis); //How much time has passed already during the calculating? Subtract that from the intended interval time.
    sleep (sleeptime);
#endif

    isMeasuring = true;
  }
}


// This function helps to avoid a problem with the latest Dallas temperature library.
int16_t millisToWaitForConversion(uint8_t bitResolution)
{
  switch (bitResolution) {
    case 9:
      return 94;
    case 10:
      return 188;
    case 11:
      return 375;
    default:
      return 750;
  }
}

void receive(const MyMessage &message)
{
  // We only expect one type of message from controller. But we better check anyway.
  if (message.type == V_STATUS) {
    // Change relay state
    digitalWrite(message.sensor - 1 + RELAY_PIN, message.getBool() ? RELAY_ON : RELAY_OFF);
    // Store state in eeprom
    saveState(message.sensor, message.getBool());
    // Write some debug info
    Serial.print("Incoming change for sensor:");
    Serial.print(message.sensor);
    Serial.print(", New status: ");
    Serial.println(message.getBool());
  }
}

/*Last note : celsius/farenheit in dallatemperature lib is not handled by the metric variable. To get the conversion you need to use C or F functions as below. I've not checked how you handle this in sketch.

    // returns temperature in degrees C
    float getTempC(const uint8_t*);

    // returns temperature in degrees F
    float getTempF(const uint8_t*);

    // Get temperature for device index (slow)
    float getTempCByIndex(uint8_t);

    // Get temperature for device index (slow)
  float getTempFByIndex(uint8_t);
*/

[rejoe2]

Have a look at at least 2 things in the sketch:
The for-loop(s) in presentation should be seperate ones for temp and relays.
Imo you try to send out temperature using a different ChildID than in presentation().

Additionally, -127 degrees indicates some wiring problems.

[dzjr]

@rejoe2 said in 2 dallas temp + 4 relays:

ost in the other on

thank you for your tip to adjust the sketch, I am now working with a node for the water meter (partly based on your example of GITHUB) and I think I understand now what you mean.

I will adjust the sketch of the example!

I still have a wait (3000); in "void before" to start just after the gateway, because I use an RS-485 network.

[dzjr]

@rejoe2

To be honest I had to experiment a bit to get it working, but that is probably because I have little "experience" with Arduino code writing.

But fortunately here at MySensors we get a lot of help and tips at this forum.

[dzjr]

@mghaff

in the Dallas temperature library there is also a test sketch, with that you can check of the Dallas sensors are working.

My experience with multiple dallas sensors (more than 4) is that de 4K7 resistor not the right choise is, beter to use a 2K2 resisitor.

maybe you can look at this forum post for that

[rejoe2]

@dzjr Good to hear your positive feedback, it's not always easy to decide whether to make some critical remarks or not.
Imo, the wait() in before() might only be needed because of the transport-wait-flag, this is not related to RS485 as transport layer.
I also use a 3.3kOhm resistor, the right value depends on some more variables than just the number of sensors.

[MGHaff]

This post is deleted!

[MGHaff]

@dzjr If i use the mysensors dallas temp that i use for my pool the sensors work just fine. If i use the relay sketch it works fine Alone. Whenever i combine these two sketches is when i have problems. I have been trying sketches that are working for others with no progress myself. I have even rewired twice. I am no programmer i took 2 classes in college but they r not helping me either.

[MGHaff]

@rejoe2 When i tried the for loops separate they don't show up at all in my serial. That was the only way to get them to present. I'm trying another sketch that looks more promising for me to build from but it as well doesn't show my temp. I get presentation but no reading.

BTW thanks for the help.

[dzjr]

@rejoe2

I have again put a wait (500) in the loop, otherwise the sketch does not read any temperature .....
between

{
    //Dallas temperature sensoren
    // Fetch temperatures from Dallas sensors 
    sensors.requestTemperatures();
    // query conversion time and sleep until conversion completed
    int16_t conversionTime = sensors.millisToWaitForConversion(sensors.getResolution());
    
 
    wait(500);

    // Read temperatures and send them to controller 
    for (int i=0; i<numSensors && i<MAX_ATTACHED_DS18B20; i++) {

[TheoL]

You calculate the conversion time, but you don't use it. So it makes sense that you won't get any readings without a wait, because the sensors don't get anytime to read. You should wait for the conversionTime before you read the sensors. Which is I'm guessing shorter than 500 ms, but I don't use Dallas temp sensors. So no expert on that.

[rejoe2]

@theol said in 2 dallas temp + 4 relays:

You calculate the conversion time, but you don't use it. So it makes sense that you won't get any readings without a wait, because the sensors don't get anytime to read. You should wait for the conversionTime before you read the sensors. Which is I'm guessing shorter than 500 ms, but I don't use Dallas temp sensors. So no expert on that.

Absolutely right.
Conversion time depends on resolution, max is 750ms according to data sheet.

[TheoL]

@rejoe2 changing
wait(500);

to

wait( millisToWaitForConversion );

Should do the trick.
But wait has an unsigned long as parameter and your conversionTime is a signed int16_t, you might need to cast it. Best to update the millisWaitForConversion to unsigned long as well.

// This function helps to avoid a problem with the latest Dallas temperature library.
unsigned long millisToWaitForConversion(uint8_t bitResolution)
{
  switch (bitResolution) {
    case 9:
      return 94;
    case 10:
      return 188;
    case 11:
      return 375;
    default:
      return 750;
  }
}

But it's hard to help with only a fragment of the code. I'm guessing that the resolution doesn't change when your sketch is running. In that case I'd declare a global unsigned long conversionWaitDuration and initialize it in the setup. I honestly would never ever use a wait in a sketchs main loop though. I always use a none blocking wait which uses millis().

But again hard to help with coding when you can only see a fragment of the code.

[dzjr]

@theol

i have uploaded the complete sketch at Github at here: link url)