LED Dimmer not working as it should

mfalkvidd

@homer sleeping and sending from within receive() won't work. Move those to loop().

Loop in your current sketch will send an endless stream of messages, with no pause. That's wasteful.

Homer

I had merged the example LED strip and motion sketches to get what I had and somehow I made a couple mistakes in the process.

I don't want the sensor to sleep. I had thought I had done enough within the sketch to just have it wait, but I think I have solved that now. When merging the sketches I had moved the wait part from loop to receive, which has now been rectified along with changing it to wait. I hope that it will work correctly; I have set the wait time for 1.5 seconds. I think I understand it right; this wait will only impact the repeater function rather than the motion sensor?

The adjusted sketch compiles, and I will upload it soon to my sensor. I have tidied the sketch up a bit and here it is:

/**
   Here is the motion sketch example merged with the LED strip example.
   Instead of sleeping, it uses wait.
   This is because this sensor is also a Repeater
*/

// Enable debug prints to serial monitor
#define MY_DEBUG

// Enable the repeater feature
#define MY_REPEATER_FEATURE

// Enable and select radio type attached
#define MY_RADIO_RF24


#include <MySensors.h>

#define SN "DimmableLED and Motion"
#define SV "1.2"

// setup LED stuff
#define LED_PIN 3      // Arduino pin attached to MOSFET Gate pin
#define FADE_DELAY 10  // Delay in ms for each percentage fade up/down (10ms = 1s full-range dim)

// setup Motion stuff
uint32_t WAIT_TIME = 1500; // Wait time between reports (in milliseconds) Current value (2000) is 1.5 seconds.
#define DIGITAL_INPUT_SENSOR 4   // The digital input you attached your motion sensor.
#define CHILD_ID 1   // Id of the sensor child

static int16_t currentLevel = 0;  // Current dim level...
MyMessage dimmerMsg(0, V_DIMMER);
MyMessage lightMsg(0, V_LIGHT);
MyMessage msg(CHILD_ID, V_TRIPPED);

void setup()
{

  // Pull the gateway's current dim level - restore light level upon node power-up
  request( 0, V_DIMMER );


  pinMode(DIGITAL_INPUT_SENSOR, INPUT);      // sets the motion sensor digital pin as input

}

void presentation()
{

  // Register sensors with the gateway
  present( 0, S_DIMMER );
  present(CHILD_ID, S_MOTION);

  sendSketchInfo(SN, SV);

}

void loop()
{

  // Read digital motion value
  bool tripped = digitalRead(DIGITAL_INPUT_SENSOR) == HIGH;

  Serial.println(tripped);
  send(msg.set(tripped ? "1" : "0")); // Send tripped value to gw

  // Wait until interrupt comes in on motion sensor. Send update every 1.5 seconds.
  wait(digitalPinToInterrupt(DIGITAL_INPUT_SENSOR), CHANGE, WAIT_TIME);

}

void receive(const MyMessage &message)
{

  if (message.type == V_LIGHT || message.type == V_DIMMER)
  {

    //  Retrieve the power or dim level from the incoming request message
    int requestedLevel = atoi( message.data );

    // Adjust incoming level if this is a V_LIGHT variable update [0 == off, 1 == on]
    requestedLevel *= ( message.type == V_LIGHT ? 100 : 1 );

    // Clip incoming level to valid range of 0 to 100
    requestedLevel = requestedLevel > 100 ? 100 : requestedLevel;
    requestedLevel = requestedLevel < 0   ? 0   : requestedLevel;

    Serial.print( "Changing level to " );
    Serial.print( requestedLevel );
    Serial.print( ", from " );
    Serial.println( currentLevel );

    fadeToLevel( requestedLevel );

    // Inform the gateway of the current DimmableLED's SwitchPower1 and LoadLevelStatus value...
    send(lightMsg.set(currentLevel > 0));

    send( dimmerMsg.set(currentLevel) );

  }
}

/***
    This method provides a graceful fade up/down effect
*/
void fadeToLevel( int toLevel )
{

  int delta = ( toLevel - currentLevel ) < 0 ? -1 : 1;

  while ( currentLevel != toLevel ) {
    currentLevel += delta;
    analogWrite( LED_PIN, (int)(currentLevel / 100. * 255) );
    delay( FADE_DELAY );

  }
}```

Homer

The LED strip is working as it should, but not the motion detector. It isn't tripping at all, even if I bridge pin 4 to earth. I'm thinking that this has something to do with how I have swapped sleep for wait.

Homer

OK.... I have decided to not have this sensor as a repeater, which means I can let it sleep. But I still have problems...

I read that only pins 2 and 3 have interrupt, so I moved the motion sensor to pin 3. This was where the LED strip was connected so I moved it to pin 5, as this pin is supposed to also have PWM. So it now should work, right? Nope lol

The motion sensor is working as it should, but the LED strip is no longer working. Apparently pins 3,5,6,9 and 11 all provide 8 bit PWM so I am going to try each pin at a time and see how I go, because those specs are for genuine Mini Pro and I don't think mine is the real deal and that could mean that the pins have been setup differently.

Time to start testing :-) :-)

Homer

Haha I've just worked out why breadboards are so useful!!! I've been playing around with the hardware so much that it looks like some connections have gone bad. I think I have everything setup right and working, but the lights won't go on until I have the Arduino in my hand lol

I don't think I feel like pulling this one apart and redoing it, so I'm going to start from scratch with another one and see how I go.

Homer

After lots of testing, I can confirm that the issue I have must be related to the sketch. The LED lights will flicker like mad. Sometimes it stops, but it is always momentarily. Sometimes the light can even be controlled so it brightens or dims, but again it's only briefly. When I wipe the arduino and upload a identical sketch but just without the motion sensing, the LED light works exactly as it should.

Here is the problem sketch which hopefully someone can point me in the right direction :-)

/**
   Here is the motion sketch example merged with the LED strip example.
   Instead of sleeping, it uses wait.
   This is because this sensor is also a Repeater
*/

// Enable debug prints to serial monitor
#define MY_DEBUG


// Enable and select radio type attached
#define MY_RADIO_RF24


#include <MySensors.h>

#define SN "DimmableLED and Motion"
#define SV "1.4"

// setup LED stuff
#define LED_PIN 5      // Arduino pin attached to MOSFET Gate pin
#define FADE_DELAY 15  // Delay in ms for each percentage fade up/down (10ms = 1s full-range dim)

// setup Motion stuff
uint32_t SLEEP_TIME = 120000; // Sleep time between reports (in milliseconds)
#define DIGITAL_INPUT_SENSOR 3   // The digital input you attached your motion sensor.
#define CHILD_ID 1   // Id of the sensor child

static int16_t currentLevel = 0;  // Current dim level...
MyMessage dimmerMsg(0, V_DIMMER);
MyMessage lightMsg(0, V_LIGHT);
MyMessage msg(CHILD_ID, V_TRIPPED);

void setup()
{

  // Pull the gateway's current dim level - restore light level upon node power-up
  request( 0, V_DIMMER );


  pinMode(DIGITAL_INPUT_SENSOR, INPUT);      // sets the motion sensor digital pin as input

}

void presentation()
{

  // Register sensors with the gateway
  present( 0, S_DIMMER );
  present(CHILD_ID, S_MOTION);

  sendSketchInfo(SN, SV);

}

void loop()
{

  // Read digital motion value
  bool tripped = digitalRead(DIGITAL_INPUT_SENSOR) == HIGH;

  Serial.println(tripped);
  send(msg.set(tripped ? "1" : "0")); // Send tripped value to gw

    // Sleep until interrupt comes in on motion sensor. Send update every two minute.
    sleep(digitalPinToInterrupt(DIGITAL_INPUT_SENSOR), CHANGE, SLEEP_TIME);

}

void receive(const MyMessage &message)
{

  if (message.type == V_LIGHT || message.type == V_DIMMER)
  {

    //  Retrieve the power or dim level from the incoming request message
    int requestedLevel = atoi( message.data );

    // Adjust incoming level if this is a V_LIGHT variable update [0 == off, 1 == on]
    requestedLevel *= ( message.type == V_LIGHT ? 100 : 1 );

    // Clip incoming level to valid range of 0 to 100
    requestedLevel = requestedLevel > 100 ? 100 : requestedLevel;
    requestedLevel = requestedLevel < 0   ? 0   : requestedLevel;

    Serial.print( "Changing level to " );
    Serial.print( requestedLevel );
    Serial.print( ", from " );
    Serial.println( currentLevel );

    fadeToLevel( requestedLevel );

    // Inform the gateway of the current DimmableLED's SwitchPower1 and LoadLevelStatus value...
    send(lightMsg.set(currentLevel > 0));

    send( dimmerMsg.set(currentLevel) );

  }
}

/***
    This method provides a graceful fade up/down effect
*/
void fadeToLevel( int toLevel )
{

  int delta = ( toLevel - currentLevel ) < 0 ? -1 : 1;

  while ( currentLevel != toLevel ) {
    currentLevel += delta;
    analogWrite( LED_PIN, (int)(currentLevel / 100. * 255) );
    delay( FADE_DELAY );

  }
}```

Homer

I have continued trying to get this to work, but I can't work out what the issue is. I found an old example of a sketch which was similar to this, and I tried to use it in this project, but had no success. I just can't understand why I can't get the LED strip and a motion detector working on the one arduino.

skywatch

@homer

@homer said in LED Dimmer not working as it should:

... I think I have everything setup right and working, but the lights won't go on until I have the Arduino in my hand lol

This suggests one of 2 things.

A bad connection or broken wire somewhere. Check with magnifying glass all solder joints and give them a pull and wiggle just to make sure.
You have not connected all the ground wires together. Ground from pro mini, power supply, driver board with mosfets and led strip all need to be connected together, preferably in one point.

Homer

@skywatch

Thanks for your tips! I'll have to check those things on the next build, because I've had to pack everything up for now as I've been doing this on the kitchen table and I really need to keep my wife happy!

So for now I've installed the LED strip where I wanted it, which is under the kitchen breakfast bar. I plan to create the same setup elsewhere in the house and I'll try again to incorporate a motion sensor, and if I can get it to work I'll pull this setup down and try to fix it. For now though, I have at least achieved some of my goal. I'll post pictures below, but please excuse the mess as I took them before I cleaned up lol

Homer

LED Dimmer not working as it should

18

11.7k

11.2k

113.1k