Are we initializing the nRF24L01+ correctly?

[tekka]

@stevebus I'm doing a major RF24 lib refactoring to fully meet the nRF24L01+ specs.
Please feel free to test it, feedbacks are appreciated.

[Yveaux]

@tekka Good effort!
I see you also start by setting PWR_UP flag to 0, as I suggested in this topic.
I scanned your implementation and biggest changes compared to the current implementation (apart from the refactoring) are in the initialization code, correct?

[tekka]

@Yveaux The current implementation does not initialize all registers properly, or modifies single bits (thus, the possibility of undefined conditions). The major changes are not necessarily in the init code, but rather in the pipe handling (all active RX pipes have now unique addresses) and less frequent register reading/writing.
Over all, the library is faster, optimized to the specs and uses ~2kb less flash. However, this is still WIP and a few more pending changes before PR to dev.

[mfalkvidd]

Awesome work @tekka !

[stevebus]

Cool @tekka , I'll give it a try. Thanks for putting all the effort into it!

[stevebus]

@tekka -- I downloaded the updated libraries and tried them. Still failed to initialize my "dead" radio..

from serial monitor:
Starting sensor (RNNNA-, 2.0.0-beta)
Radio init failed. Check wiring.

using MockSensor to test. Wiring is correct. It's certainly possible that the radio is truly 'dead', but I don't think so, as it was working fine before resets of the Arduino (and I have another in the same state.. and the same Arduino is currently being used in a sensor with a third radio).

thoughts? I know you said it was a WIP, so it could be that it's not supposed to work yet. LMK.

[tekka]

@stevebus If they fail with both library versions - I assume they're dead if you can exclude wiring problems or wrong Vcc.

[stevebus]

thanks @tekka... I fear you are right. The main thing that sucks is I don't know what killed them. Oh well. Such is life.

[davboecki]

@tekka Your rewrite actually fixed a problem I was having. For what ever reason I could not send messages from my ESP8266 based gateway to my test node. At the same time acknowledgement worked.
Log of the original lib:

0;255;3;0;9;send: 0-0-1-1 s=1,c=1,t=2,pt=4,l=4,sg=0,st=fail:1
0;255;3;0;9;send: 0-0-1-1 s=1,c=1,t=2,pt=4,l=4,sg=0,st=fail:1
0;255;3;0;9;send: 0-0-1-1 s=1,c=1,t=2,pt=4,l=4,sg=0,st=fail:1

Same sketch with just your commit added:

0;255;3;0;9;send: 0-0-1-1 s=1,c=1,t=2,pt=4,l=4,sg=0,st=ok:1
0;255;3;0;9;send: 0-0-1-1 s=1,c=1,t=2,pt=4,l=4,sg=0,st=ok:1
0;255;3;0;9;send: 0-0-1-1 s=1,c=1,t=2,pt=4,l=4,sg=0,st=ok:1

Nothing else was changed.
I didn't do any extensive testing. Just a quick check to see if your commit fixed my problem.

[tekka]

@davboecki :+1: