Irrigation Controller



  • Hi and thanks to all contributors of this great project. I am fairly new to all this but a long term programmer and electronics nerd. I have recently built the Irrigation Contoller project and debugged it (I thought well until I mounted it on the wall and connected everything).

    I have found a number of code issues with the example code and I am wondering the best way to update or request updates to the master. I have made a pull request for a simple update which was causing the initial setup to miss getting the VAR_1 data during the setup process - is this the right way to submit updates as I have done a lot of additional work on the code to fix a number of issues I have found. An example of this being the goGetValveTimes() routine has no delays and creates NACK requests due to bombarding the radio module with 3 requests in quick succession without then waiting for the reply. Should I post these as Github pulls or should I pop it in this forum system for update?

    I have some more issues with the code and project but wanting to see the best way to provide my updates back to the community firstly.

    Thanks David


  • Mod

    Pull requests are a nice way to help programmers ☺️


  • Admin

    @itbeyond,

    Yes, PRs is the correct way of improving core library and/or examples. If you plan for big behavioral changes, it might be good to discuss it with the community first. Discussions could take place here or in a github issue.



  • @hek Great thanks - I am setting a pull request right now which fixes another issue with the goGetValveTimes function which causes NACKs due to 3 successive sends to the radio without any pause or delay. This is a simple bug in the code and should not really need a discussion to implement as careful analysis of the DEBUG results will always yield this error. I basically copied the setup code that reads the data - put it in the function and changed the setup to call this updated function.

    There is another bug I am trying to stamp out right now which is causing the manual button start to NOT send the status updates to the controller via the radio - again this is a standard bug and may or may not get seen by many if you are not testing the manual button operation. Once this is resolved I will make a pull for it also.



  • OK so I have added several pull requests to Github for the irrigation controller. I thought I would now show you may take on the irrigation controller firstly a pic of my unit:

    Irrigation controller mounted on wall

    The button on the left that is glowing - turns on/off the LCD backlight as most of the time I do not want to see it and have it glowing at night - this box is mounted on a wall outside my house under the eves. The right button is the flashing led coupled with the manual operation function - I also slowed down the on time for this led again to not glow and flash as much.

    As I live in Australia I regionalised the displays for none US dates and here is my final code which is setup for 6 zones. I also made a modification to always switch on Zone 8 as a master valve when any other zone is activated. My original system has a master valve which enables the water supply to the other valves and hence needed to switch this on. If you want to copy my code and remove this it is at line 500 - 501 - just remove the ' - 128' from both these lines. The rest of this code has all the fixes added to the github repo for the Irrigation Controller - enjoy.

    /*
      MySprinkler for MySensors
    
      Arduino Multi-Zone Sprinkler Control
    
      May 31, 2015
    
    *** Version 2.0
    
    *** Upgraded to http://MySensors.org version 1.4.1
    *** Expanded for up to 16 Valves
    *** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
    *** Switch to bitshift method vs byte arrays
    *** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
    *** Added optional LCD display featuring remaining time, date last ran & current time
    *** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively
    *** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone)
    *** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names)
    
      Utilizing your Vera home automation controller and the MySensors.org gateway you can
      control up to a sixteen zone irrigation system with only three digital pins.  This sketch
      will create NUMBER_OF_VALVES + 1 devices on your Vera controller
    
      This sketch features the following:
    
      Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.
      Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n)
      using Variable1 as the "ON" time in minutes in each of the vera devices created.
      Use the individual zone controller to activate a single zone.  This feature uses
      Variable2 as the "ON" time for each individual device/zone.
      Connect according to pinout below and uses Shift Registers as to allow the MySensors
      standard radio configuration and still leave available digital pins
      Turning on any zone will stop the current process and begin that particular process.
      Turning off any zone will stop the current process and turn off all zones.
      To push your new time intervals for your zones, simply change the variable on your Vera and
      your arduino will call to Vera once a minute and update accordingly.  Variables will also be
      requested when the device is first powered on.
      Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program
      LED status indicator
    
      PARTS LIST:
      Available from the MySensors store - http://www.mysensors.org/store/
      Relays (8 channel)
      Female Pin Header Connector Strip
      Prototype Universal Printed Circuit Boards (PCB)
      NRF24L01 Radio
      Arduino (I used a Pro Mini)
      FTDI USB to TTL Serial Adapter
      Capacitors (10uf and .1uf)
      3.3v voltage regulator
      Resistors (270, 1K & 10K)
      Female Dupont Cables
      1602 LCD (with I2C Interface)
      LED
      Push button
      Shift Register (SN74HC595)
      2 Pole 5mm Pitch PCB Mount Screw Terminal Block
      3 Pole 5mm Pitch PCB Mount Screw Terminal Block
      22-24 gauge wire or similar (I used Cat5/Cat6 cable)
      18 gauge wire (for relay)
      Irrigation Power Supply (24-Volt/750 mA Transformer)
    
    
      INSTRUCTIONS:
    
      A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI
      After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to
      A4 and A5) and relays, and load the sketch.
      Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
      Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
      the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
      you may use the defaulet zone names by leaving Variable3 blank.
      Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
      Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
      on the serial monitor.
      Your arduino should slow-flash, indicating that it is in ready mode.
      There are multiple debug serial prints that can be monitored to assure that it is operating properly.
    * ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours
    
      Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain
    
      Modified David Martin.
      Changed date format to Australia standard dd/mm/yy
      Added valve 8 as master valve during watering sequence - so 8 will be on whenever a valve/zone is active
      Fixed initial valve read system to ensure all data read - via update of getValveTimes routine
      Changed display details for VAR_3 to be consistent with other data reads
      Updated various displays and debug outputs
    */
    //
    
    // Enable debug prints
    //#define MY_DEBUG
    
    // Enable node as Repeater
    //#define MY_REPEATER_FEATURE
    
    // Enable and select radio type attached
    #define MY_RADIO_NRF24
    #define MY_RF24_PA_LEVEL RF24_PA_LOW
    
    #define MY_NODE_ID 2  // Set this to fix your Radio ID or use Auto
    
    #include <Wire.h>
    #include <TimeLib.h>
    #include <SPI.h>
    #include <MySensors.h>
    #include <LiquidCrystal.h>
    #include <LiquidCrystal_I2C.h>
    
    
    #define NUMBER_OF_VALVES 6  // Change this to set your valve count up to 16.
    #define VALVE_RESET_TIME 2500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
    #define VALVE_TIMES_RELOAD 720000UL  // Change this (in milliseconds) for how often to update all valves data from the controller (Loops at value/number valves)
                                         // ie: 300000 for 5 valves produces requests every minute with all valves updated every 5mins 
    #define SKETCH_NAME "MySprinkler"
    #define SKETCH_VERSION "2.2"
    //
    #define CHILD_ID_SPRINKLER 0
    //
    #define ACTIVE_LOW // comment out this line if your relays are active high
    //
    #define DEBUG_ON   // comment out to supress serial monitor output
    //
    #ifdef ACTIVE_LOW
    #define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
    #define ALL_VALVES_OFF 0xFFFF
    #else
    #define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
    #define ALL_VALVES_OFF 0U
    #endif
    //
    #ifdef DEBUG_ON
    #define DEBUG_PRINT(x)   Serial.print(x)
    #define DEBUG_PRINTLN(x) Serial.println(x)
    #else
    #define DEBUG_PRINT(x)
    #define DEBUG_PRINTLN(x)
    #define SERIAL_START(x)
    #endif
    //
    typedef enum {
      STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
    }
    SprinklerStates;
    //
    SprinklerStates state = STAND_BY_ALL_OFF;
    SprinklerStates lastState;
    byte menuState = 0;
    unsigned long menuTimer;
    byte countDownTime = 10;
    //
    int allZoneTime [NUMBER_OF_VALVES + 1];
    int valveSoloTime [NUMBER_OF_VALVES + 1];
    int valveNumber;
    int lastValve;
    unsigned long startMillis;
    const int ledPin = 5;
    const int waterButtonPin = 3;
    bool buttonPushed = false;
    bool showTime = true;
    bool clockUpdating = false;
    bool recentUpdate = true;
    int allVars[] = {V_VAR1, V_VAR2, V_VAR3};
    const char *dayOfWeek[] = {
      "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
    };
    // Name your Zones here or use Vera to edit them by adding a name in Variable3...
    String valveNickName[17] = {
      "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
    };
    //
    time_t lastTimeRun = 0;
    //Setup Shift Register...
    const int latchPin = 8;
    const int clockPin = 4;
    const int dataPin  = 7;
    const int outputEnablePin = 6;
    //
    byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
    byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
    // Set the pins on the I2C chip used for LCD connections:
    //                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
    LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27
    //
    MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
    MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
    MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);
    MyMessage var3valve(CHILD_ID_SPRINKLER, V_VAR3);
    
    bool receivedInitialValue = false;
    bool inSetup = true;
    //
    void setup()
    {
      DEBUG_PRINTLN(F("Initialising..."));
      pinMode(latchPin, OUTPUT);
      pinMode(clockPin, OUTPUT);
      pinMode(dataPin, OUTPUT);
      pinMode(ledPin, OUTPUT);
      pinMode(outputEnablePin, OUTPUT);
      digitalWrite (outputEnablePin, LOW);
      pinMode(waterButtonPin, INPUT_PULLUP);
      //pinMode(waterButtonPin, INPUT);
      attachInterrupt(digitalPinToInterrupt(waterButtonPin), PushButton, RISING); //May need to change for your Arduino model
      digitalWrite (ledPin, HIGH);
      DEBUG_PRINTLN(F("Turning All Valves Off..."));
      updateRelays(ALL_VALVES_OFF);
      //delay(5000);
      lcd.begin(16, 2); //(16 characters and 2 line display)
      lcd.clear();
      lcd.backlight();
      lcd.createChar(0, clock);
      lcd.createChar(1, raindrop);
      //
      //check for saved date in EEPROM
      DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
      delay(500);
      if (loadState(0) == 0xFF) // EEPROM flag
      {
        DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
        for (int i = 0; i < 4 ; i++)
        {
          lastTimeRun = lastTimeRun << 8;
          lastTimeRun = lastTimeRun | loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
        }
      }
    
      DEBUG_PRINTLN(F("Sensor Presentation Complete"));
      //
      digitalWrite (ledPin, LOW);
      DEBUG_PRINTLN(F("Ready..."));
      //
      lcd.setCursor(0, 0);
      lcd.print(F(" Syncing Time  "));
      lcd.setCursor(15, 0);
      lcd.write(byte(0));
      lcd.setCursor(0, 1);
      int clockCounter = 0;
      while (timeStatus() == timeNotSet && clockCounter < 21)
      {
        requestTime();
        DEBUG_PRINTLN(F("Requesting time from Gateway:"));
        wait(1000);
        lcd.print(".");
        clockCounter++;
        if (clockCounter > 16)
        {
          DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
          lcd.clear();
          lcd.print(F("  Failed Clock  "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Syncronization "));
          wait(2000);
          break;
        }
      }
      for (byte i = 1; i <= NUMBER_OF_VALVES; i++)
      {
        lcd.clear();
        goGetValveTimes();
      }
      lcd.clear();
    }
    
    
    void presentation()
    {
      sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        present(i, S_LIGHT);
      }
    }
    
    //
    void loop()
    {
      inSetup = false;
      updateClock();
      updateDisplay();
      goGetValveTimes();
      //
      if (buttonPushed)
      {
        menuTimer = millis();
        DEBUG_PRINTLN(F("Button Pressed"));
        if (state == STAND_BY_ALL_OFF)
        {
          state = ZONE_SELECT_MENU;
          menuState = 0;
        }
        else if (state == ZONE_SELECT_MENU)
        {
          menuState++;
          if (menuState > NUMBER_OF_VALVES)
          {
            menuState = 0;
          }
        }
        else
        {
          state = STAND_BY_ALL_OFF;
        }
        buttonPushed = false;
      }
      if (state == STAND_BY_ALL_OFF)
      {
        slowToggleLED ();
        if (state != lastState)
        {
          updateRelays(ALL_VALVES_OFF);
          DEBUG_PRINTLN(F("State Changed... all Zones off"));
          for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
          {
            wait(50);
            send(msg1valve.setSensor(i).set(false), false);
          }
          lcd.clear();
          lcd.setCursor(0, 0);
          lcd.print(F("** Irrigation **"));
          lcd.setCursor(0, 1);
          lcd.print(F("**   Halted   **"));
          wait(2000);
          lastValve = -1;
        }
      }
      //
      else if (state == RUN_ALL_ZONES)
      {
        if (lastValve != valveNumber)
        {
          for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
          {
            if (i == 0 || i == valveNumber)
            {
              send(msg1valve.setSensor(i).set(true), false);
            }
            else
            {
              send(msg1valve.setSensor(i).set(false), false);
            }
            wait(50);
          }
        }
        lastValve = valveNumber;
        fastToggleLed();
        if (state != lastState)
        {
          valveNumber = 1;
          updateRelays(ALL_VALVES_OFF);
          DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
        }
        unsigned long nowMillis = millis();
        if (nowMillis - startMillis < VALVE_RESET_TIME)
        {
          updateRelays(ALL_VALVES_OFF);
        }
        else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
        {
          updateRelays(BITSHIFT_VALVE_NUMBER);
        }
        else
        {
          DEBUG_PRINTLN(F("Changing Valves..."));
          updateRelays(ALL_VALVES_OFF);
          startMillis = millis();
          valveNumber++;
          if (valveNumber > NUMBER_OF_VALVES)
          {
            state = CYCLE_COMPLETE;
            startMillis = millis();
            lastValve = -1;
            lastTimeRun = now();
            saveDateToEEPROM(lastTimeRun);
            for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
            {
              send(msg1valve.setSensor(i).set(false), false);
            }
            DEBUG_PRINT(F("State = "));
            DEBUG_PRINTLN(state);
          }
        }
      }
      //
      else if (state == RUN_SINGLE_ZONE)
      {
        fastToggleLed();
        if (state != lastState)
        {
          for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
          {
            if (i == 0 || i == valveNumber)
            {
              send(msg1valve.setSensor(i).set(true), false);
            }
            else
            {
              send(msg1valve.setSensor(i).set(false), false);
            }
            wait(50);
          }
          DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
          DEBUG_PRINT(F("Zone: "));
          DEBUG_PRINTLN(valveNumber);
        }
        unsigned long nowMillis = millis();
        if (nowMillis - startMillis < VALVE_RESET_TIME)
        {
          updateRelays(ALL_VALVES_OFF);
        }
        else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
        {
          updateRelays(BITSHIFT_VALVE_NUMBER);
        }
        else
        {
          updateRelays(ALL_VALVES_OFF);
          for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
          {
            send(msg1valve.setSensor(i).set(false), false);
          }
          state = CYCLE_COMPLETE;
          startMillis = millis();
          DEBUG_PRINT(F("State = "));
          DEBUG_PRINTLN(state);
        }
        lastTimeRun = now();
      }
      else if (state == CYCLE_COMPLETE)
      {
        if (millis() - startMillis < 30000UL)
        {
          fastToggleLed();
        }
        else
        {
          state = STAND_BY_ALL_OFF;
        }
      }
      if (state == ZONE_SELECT_MENU)
      {
        displayMenu();
      } 
      else 
      {
        lastState = state;
      }
    }
    //
    void displayMenu(void)
    {
      static byte lastMenuState = -1;
      static int lastSecond;
      if (menuState != lastMenuState)
      {
        lcd.clear();
        lcd.setCursor(0, 0);
        lcd.print(valveNickName[menuState]);
        lcd.setCursor(0, 1);
        lcd.print(F("Starting"));
        DEBUG_PRINT(valveNickName[menuState]);
        Serial.print(F(" Starting Shortly"));
      }
      int thisSecond = (millis() - menuTimer) / 1000UL;
      if (thisSecond != lastSecond && thisSecond < 8)
      {
        lcd.print(F("."));
        Serial.print(".");
      }
      lastSecond = thisSecond;
      if (millis() - menuTimer > 10000UL)
      {
        startMillis = millis();
        if (menuState == 0)
        {
          valveNumber = 1;
          state = RUN_ALL_ZONES;
        }
        else
        {
          valveNumber = menuState;
          state = RUN_SINGLE_ZONE;
        }
      }
      else
      {
    
      }
      lastMenuState = menuState;
    }
    //
    void updateRelays(int value)
    {
      digitalWrite(latchPin, LOW);
      if (value == -1) {
        shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
        shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
      } else {
        // Valve 8 is master and must be on to turn on water supply -128 for 8
        shiftOut(dataPin, clockPin, MSBFIRST, highByte(value - 128));
        shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value - 128));
      }
      digitalWrite(latchPin, HIGH);
    }
    //
    void PushButton() //interrupt with debounce
    {
      static unsigned long last_interrupt_time = 0;
      unsigned long interrupt_time = millis();
      if (interrupt_time - last_interrupt_time > 200)
      {
        buttonPushed = true;
      }
      last_interrupt_time = interrupt_time;
    }
    //
    void fastToggleLed()
    {
      static unsigned long fastLedTimer;
      if (millis() - fastLedTimer >= 100UL)
      {
        digitalWrite(ledPin, !digitalRead(ledPin));
        fastLedTimer = millis ();
      }
    }
    //
    void slowToggleLED ()
    {
      static unsigned long slowLedTimer;
      if (millis() - slowLedTimer >= 20000UL)
      {
        digitalWrite(ledPin, !digitalRead(ledPin));
        if (!digitalRead(ledPin)) {
          slowLedTimer = millis();
        } else {
          slowLedTimer = millis() - 19000UL;
        }
      }
    }
    //
    void receive(const MyMessage &message)
    {
      bool zoneTimeUpdate = false;
      if (message.isAck())
      {
        DEBUG_PRINTLN(F("This is an ack from gateway"));
      }
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (message.sensor == i)
        {
          if (message.type == V_LIGHT)
          {
            int switchState = atoi(message.data);
            if (switchState == 0)
            {
              state = STAND_BY_ALL_OFF;
              DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
            }
            else
            {
              if (i == 0)
              {
                state = RUN_ALL_ZONES;
                valveNumber = 1;
                DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
              }
              else
              {
                state = RUN_SINGLE_ZONE;
                valveNumber = i;
                DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
                DEBUG_PRINTLN(i);
              }
            }
            startMillis = millis();
          }
          else if (message.type == V_VAR1)
          {
            int variable1 = atoi(message.data);// RUN_ALL_ZONES time
            DEBUG_PRINT(F("Recieved variable1 valve:"));
            DEBUG_PRINT(i);
            DEBUG_PRINT(F(" = "));
            DEBUG_PRINTLN(variable1);
            if (variable1 != allZoneTime[i])
            {
              allZoneTime[i] = variable1;
    
              zoneTimeUpdate = true;
            }
            receivedInitialValue = true;
          }
          else if (message.type == V_VAR2)
          {
            int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
            DEBUG_PRINT(F("Recieved variable2 valve:"));
            DEBUG_PRINT(i);
            DEBUG_PRINT(F(" = "));
            DEBUG_PRINTLN(variable2);
            if (variable2 != valveSoloTime[i])
            {
              valveSoloTime[i] = variable2;
              zoneTimeUpdate = true;
            }
            receivedInitialValue = true;
          }
          else if (message.type == V_VAR3)
          {
            String newMessage = String(message.data);
            if (newMessage.length() == 0)
            {
              DEBUG_PRINT(F("No Name Recieved for zone "));
              DEBUG_PRINTLN(i);
              break;
            }
            if (newMessage.length() > 16)
            {
              newMessage.substring(0, 16);
            }
            valveNickName[i] = "";
            valveNickName[i] += newMessage;
            DEBUG_PRINT(F("Recieved variable3 valve: "));
            DEBUG_PRINT(i);
            DEBUG_PRINT(F(" = "));
            DEBUG_PRINTLN(valveNickName[i]);
           }
          receivedInitialValue = true;
        }
      }
      if (zoneTimeUpdate)
      {
        //
        DEBUG_PRINTLN(F("New Zone Times Recieved..."));
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          if (i != 0)
          {
            DEBUG_PRINT(F("Zone "));
            DEBUG_PRINT(i);
            DEBUG_PRINT(F(" individual time: "));
            DEBUG_PRINT(valveSoloTime[i]);
            DEBUG_PRINT(F(" group time: "));
            DEBUG_PRINT(allZoneTime[i]);
            DEBUG_PRINT(F(" name: "));
            DEBUG_PRINTLN(valveNickName[i]);
            recentUpdate = true;
          }
        }
      }
      else
      {
        recentUpdate = false;
      }
    }
    //
    void updateDisplay()
    {
      static unsigned long lastUpdateTime;
      static bool displayToggle = false;
      //static byte toggleCounter = 0;
      static SprinklerStates lastDisplayState;
      if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
      {
        displayToggle = !displayToggle;
        switch (state) {
          case STAND_BY_ALL_OFF:
            //
            fastClear();
            lcd.setCursor(0, 0);
            if (displayToggle)
            {
              lcd.print(F("  System Ready "));
              if (clockUpdating)
              {
                lcd.setCursor(15, 0);
                lcd.write(byte(0));
              }
              lcd.setCursor(0, 1);
              lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
              lcd.print(hourFormat12());
              lcd.print(minute() < 10 ? F(":0") : F(":"));
              lcd.print(minute());
              lcd.print(isAM() ? F("am") : F("pm"));
              lcd.print(day() < 10 ? F(" 0") : F("  "));
              lcd.print(day());
              lcd.print(month() < 10 ? F("/0") : F("/"));
              lcd.print(month());
              lcd.print(F("/"));
              lcd.print(year() % 100);
            }
            else
            {
              lcd.print(F("  Last Watered "));
              if (clockUpdating)
              {
                lcd.setCursor(15, 0);
                lcd.write(byte(0));
              }
              lcd.setCursor(0, 1);
              lcd.print(dayOfWeek[weekday(lastTimeRun)]);
              lcd.setCursor(11, 1);
              lcd.print(day(lastTimeRun) < 10 ? F("0") : F(""));
              lcd.print(day(lastTimeRun));
              lcd.print(month(lastTimeRun) < 10 ? F("/0") : F("/"));
              lcd.print(month(lastTimeRun));
            }
            break;
          case RUN_SINGLE_ZONE:
            //
            fastClear();
            lcd.setCursor(0, 0);
            if (displayToggle)
            {
              lcd.print(F("Single Zone Mode"));
              lcd.setCursor(0, 1);
              lcd.print(F(" Zone:"));
              if (valveNumber < 10) lcd.print(F("0"));
              lcd.print(valveNumber);
              lcd.print(F(" Active"));
            }
            else
            {
              lcd.print(F(" Time Remaining "));
              lcd.setCursor(0, 1);
              if (valveSoloTime[valveNumber] == 0)
              {
                lcd.print(F(" No Valve Time "));
              }
              else
              {
                unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
                lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
                lcd.print(timeRemaining / 60);
                lcd.print("min");
                lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
                lcd.print(timeRemaining % 60);
                lcd.print("sec  ");
              }
            }
            break;
          case RUN_ALL_ZONES:
            //
            fastClear();
            lcd.setCursor(0, 0);
            if (displayToggle)
            {
              lcd.print(F(" All-Zone  Mode "));
              lcd.setCursor(0, 1);
              lcd.print(F(" Zone:"));
              if (valveNumber < 10) lcd.print(F("0"));
              lcd.print(valveNumber);
              lcd.print(F(" Active "));
            }
            else
            {
              lcd.print(F(" Time Remaining "));
              lcd.setCursor(0, 1);
              int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
              lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
              lcd.print(timeRemaining / 60);
              lcd.print("min");
              lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
              lcd.print(timeRemaining % 60);
              lcd.print("sec  ");
            }
            break;
          case CYCLE_COMPLETE:
            //
            if (displayToggle)
            {
              lcd.setCursor(0, 0);
              lcd.print(F(" Watering Cycle "));
              lcd.setCursor(0, 1);
              lcd.print(F("    Complete    "));
            }
            else
            {
              int totalTimeRan = 0;
              for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
              {
                totalTimeRan += allZoneTime[i];
              }
              lcd.setCursor(0, 0);
              lcd.print(F(" Total Time Run "));
              lcd.setCursor(0, 1);
              lcd.print(totalTimeRan < 10 ? "   0" : "   ");
              lcd.print(totalTimeRan);
              lcd.print(" Minutes   ");
            }
          default:
            // what of ZONE_SELECT_MENU?
            break;
        }
        lastUpdateTime = millis();
      }
      lastDisplayState = state;
    }
    void receiveTime(time_t newTime)
    {
      DEBUG_PRINTLN(F("Time value received and updated..."));
      int lastSecond = second();
      int lastMinute = minute();
      int lastHour = hour();
      setTime(newTime);
      if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
      {
        DEBUG_PRINTLN(F("Clock updated...."));
        DEBUG_PRINT(F("Sensor's time currently set to:"));
        DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
        DEBUG_PRINT(hourFormat12());
        DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
        DEBUG_PRINT(minute());
        DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
        DEBUG_PRINT(month());
        DEBUG_PRINT(F("/"));
        DEBUG_PRINT(day());
        DEBUG_PRINT(F("/"));
        DEBUG_PRINTLN(year());
        DEBUG_PRINTLN(dayOfWeek[weekday()]);
        showTime = false;
      }
      else
      {
        DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
      }
      clockUpdating = false;
    }
    void fastClear()
    {
      lcd.setCursor(0, 0);
      lcd.print(F("                "));
      lcd.setCursor(0, 1);
      lcd.print(F("                "));
    }
    //
    void updateClock()
    {
      static unsigned long lastVeraGetTime;
      if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
      {
        DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
        lcd.setCursor(15, 0);
        lcd.write(byte(0));
        clockUpdating = true;
        requestTime();
        lastVeraGetTime = millis();
      }
    }
    //
    void saveDateToEEPROM(unsigned long theDate)
    {
      DEBUG_PRINTLN(F("Saving Last Run date"));
      if (loadState(0) != 0xFF)
      {
        saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
      }
      //
      for (int i = 1; i < 5; i++)
      {
        saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
      }
    }
    //
    void goGetValveTimes()
    {
      static unsigned long valveUpdateTime;
      static byte valveIndex = 1;
      if (inSetup || millis() - valveUpdateTime >= VALVE_TIMES_RELOAD / NUMBER_OF_VALVES) // update each valve once every 5 mins (distributes the traffic)
      {
        if (inSetup) {
          lcd.print(F(" Updating  "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Valve Data: "));
          lcd.print(valveIndex);
        }
        bool flashIcon = false;
        DEBUG_PRINT(F("Calling for Valve "));
        DEBUG_PRINT(valveIndex);
        DEBUG_PRINTLN(F(" Data..."));
    
        for (int a = 0; a < (sizeof(allVars)/sizeof(int)); a++) {
          receivedInitialValue = false;
          byte timeout = 10;
          while (!receivedInitialValue && timeout > 0)
          {
            lcd.setCursor(15, 0);
            flashIcon = !flashIcon;
            flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
            request(valveIndex, allVars[a]);
            wait(50);
            timeout--;
          }
        }
        valveUpdateTime = millis();
        valveIndex++;
        if (valveIndex > NUMBER_OF_VALVES)
        {
          valveIndex = 1;
        }
      }
    }
    
    


  • Hi David,

    I am starting with my irrigation controller and your code looks ideal.

    To make sure I am using the latest, I would like to get it from GitHub. Unfortunately I really struggle with GitHub and the only reference to this code, I can find does not have any pull requests, so I'm not convinced it is correct.

    Can you post a GitHub link to your updated code?

    Thanks
    Malcolm


  • Mod

    @Woodside https://github.com/mysensors/MySensorsArduinoExamples/blob/master/examples/IrrigationController/IrrigationController.ino seems to be the most current version. It was last updated 4 days ago. But note that the sketch is still using MySensors 1.x so it won't work with a MySensors 2 gateway.



  • @Woodside the code in this post is the latest with one exception. I am not using the internal pullup on the waterbuttonPin any more as I have installed a cap/resistor mode to facilitate a hardware debouce. The details of this have been published in the Rain Gauge project (see troubleshooting). Apart from that the above code is fully made for AU dates and is running my system now.

    The GitHub version is US date based and not AU converted but has my mods for the gateway comms and some updates - https://github.com/mysensors/MySensorsArduinoExamples/blob/master/examples/IrrigationController/IrrigationController.ino

    If you run into any problems or issues let me know.


Log in to reply
 

Looks like your connection to MySensors Forum was lost, please wait while we try to reconnect.