Skip to content
  • MySensors
  • OpenHardware.io
  • Categories
  • Recent
  • Tags
  • Popular
Skins
  • Light
  • Brite
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Brand Logo
  1. Home
  2. Development
  3. cppcheck old-style c cast

cppcheck old-style c cast

Scheduled Pinned Locked Moved Development
5 Posts 4 Posters 1.5k Views 2 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • nagelcN Offline
    nagelcN Offline
    nagelc
    wrote on last edited by
    #1

    I'm working on updates to adapt the STM32 driver for the STM32WL series and using the tools from the Contribution Guide.
    When committing, I get a lot of cppcheck errors in the existing code, mostly this one:

    warning: Potentially invalid type conversion in old-style C cast, clarify/fix with C++ cast [dangerousTypeCast]
    

    I'm sure I could figure this out, but hate to mess with working code. What's the MySensors philosophy here? If I don't fix it now, how do you get thru the cppcheck to commit?

    Thanks in advance for any advice. I mostly just write code for myself, so am a bit of a noob at contributing back.

    1 Reply Last reply
    1
    • T Offline
      T Offline
      TheoL
      Contest Winner
      wrote on last edited by
      #2

      @mfalkvidd do you know the answer to this?

      1 Reply Last reply
      0
      • mfalkviddM Offline
        mfalkviddM Offline
        mfalkvidd
        Mod
        wrote on last edited by
        #3

        Sorry, I have no idea.

        1 Reply Last reply
        0
        • T Offline
          T Offline
          tekka
          Admin
          wrote on last edited by
          #4

          Hi @nagelc, our CI pipeline is currently running cppcheck version 2.1. Could you let me know which version you're using on your end?

          1 Reply Last reply
          0
          • nagelcN Offline
            nagelcN Offline
            nagelc
            wrote on last edited by
            #5

            Hi. I'm running cppcheck 2.18.3 Just grabbed the latest.
            The above were from MyCryptoGeneric.cpp.
            Perhaps some new checks were added since 2.1

            1 Reply Last reply
            0

            Hello! It looks like you're interested in this conversation, but you don't have an account yet.

            Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.

            With your input, this post could be even better 💗

            Register Login
            Reply
            • Reply as topic
            Log in to reply
            • Oldest to Newest
            • Newest to Oldest
            • Most Votes


            16

            Online

            12.0k

            Users

            11.2k

            Topics

            113.4k

            Posts


            Copyright 2025 TBD   |   Forum Guidelines   |   Privacy Policy   |   Terms of Service
            • Login

            • Don't have an account? Register

            • Login or register to search.
            • First post
              Last post
            0
            • MySensors
            • OpenHardware.io
            • Categories
            • Recent
            • Tags
            • Popular