Code for beta-testing?
-
You are experiencing the problem @jka describes above. When the message header bitfield is packed (by the compiler) if differs on the Arduino and RPI which result in garbled header and CRC-check-errors.
We have to introduce our own bit manupilation when adding/extracting stuff from the (bit-field)-header to overcome this cross platform problems.
-
please excuse the frivolity
u mean like this both on arduino and Pi?
// The message structure
typedef struct {
unsigned char crc; // uint8_t crc; // 8 bits crc
unsigned char version; // (3 bits) protocol version
unsigned char binary; // (1 bit). Data is binary and should be encoded when sent to sensor net gateway
unsigned char from; // 8 bits. RadioId of sender node
unsigned char to; // 8 bits. RadioId of destination node
unsigned char last; // 8 bits. RadioId of last node this message passed
unsigned char childId; // 8 bits. Up to MAX_CHILD_DEVICES child sensors per radioId
unsigned char messageType; // (4 bits). Type of message. See messageType
unsigned char type; // 8 bits. variableType or deviceType depending on messageType
} header_s; -
please excuse the frivolity
u mean like this both on arduino and Pi?
// The message structure
typedef struct {
unsigned char crc; // uint8_t crc; // 8 bits crc
unsigned char version; // (3 bits) protocol version
unsigned char binary; // (1 bit). Data is binary and should be encoded when sent to sensor net gateway
unsigned char from; // 8 bits. RadioId of sender node
unsigned char to; // 8 bits. RadioId of destination node
unsigned char last; // 8 bits. RadioId of last node this message passed
unsigned char childId; // 8 bits. Up to MAX_CHILD_DEVICES child sensors per radioId
unsigned char messageType; // (4 bits). Type of message. See messageType
unsigned char type; // 8 bits. variableType or deviceType depending on messageType
} header_s; -
@andriej and @jendrush, I commited some code to my repository for the python gateway with half (oneway) Domoticz integration. It also support Openhab, The Openhab integarion is what I think I will integarate for my self and continue to develop. Domoticz needs provide a proper API that I can use without spending a lot of time trying to figure out how it works. My code is at https://github.com/wbcode/ham. You can try it out if you want. The installation part and configuration is missing a lot of instructions.
Will create my own thread for my gateway code when I have a name for it and I have spent the time to do a proper update to the wiki and better a presenation on what you cand do.
Please note that iit's not a full replacment for a Vera and it's my first time codeing python...
-
hi there,
nagging time ...did all that (unsigned char on both ends arduino and rpi) but all i get in my rpi is below
any ideas?!!
thanx
GStarting Gateway...
Sensor-1Gateway created...
SPI device = /dev/spidev0.0
SPI speed = 8000000
CE GPIO = 25
STATUS = 0x0e RX_DR=0 TX_DS=0 MAX_RT=0 RX_P_NO=7 TX_FULL=0
RX_ADDR_P0-1 \0 = 0xe7e7e7e7e7 0xc2c2c2c2c2
RX_ADDR_P2-5 \0 = 0xff 0xc4 0xc5 0xc6
TX_ADDR = 0xe7e7e7e7e7
RX_PW_P0-6 \0 = 0x00 0x00 0x20 0x00 0x00 0x00
EN_AA = 0x3f
EN_RXADDR \0 = 0x07
RF_CH = 0x4c
RF_SETUP \0 = 0x07
CONFIG = 0x0c
DYNPD/FEATURE \0 = 0x3f 0x04
Data Rate = 1MBPS
Model = nRF24L01+
CRC Length = 16 bits
PA Power = PA_MAX
Radio setup complete-0;0;4;11;Arduino startup complete.
Begin called
Dynamic payload size=11
Received: from=16, to=18, childId=0, mtype=50, type=49, crc=120, '.7'
Message crc error.
header.type=49, header.to=18, radioId=0
Dynamic payload size=11
Received: from=16, to=2, childId=1, mtype=54, type=53, crc=231, '.2'
Message crc error.
header.type=53, header.to=2, radioId=0 -
@andriej
Hi, I had problem using the main branch mysensors/Raspberry, that because of the bit-field struct (header_s) in Sensor.h They will get packed in different order on the arduino compared to the RPi (at least with my compiler, gcc). In order to fix this I created the 1.4dev branch. It uses full bytes instead of the bit-fields, but you need (of cause) to compile both the sensors (arduino) and the gateway (RPi) using the 1.4dev branch.We need to fix this in the main branch later on (and use the same files as in mysensors/Arduino/libraries/MySensors)
-
Hi there again
A quick question @jka I used the 1.4 branch on both arduino and rpi and all I get o rpi are messed up messages with crc errors, can u point me a direction on what I do wrong?
Thanx
G -
Sorry, I don't know why you are experiencing problem. We will soon have a look at the RPI stuff again and make a usable version.
The last week all our mysensors-time has been spend on server infrastructure (prod/stage environment etc) to prepare for the new services.
Getting this right took more time that we initially anticipated.In the meantime. Anyone having a good low footprint node-database-candidate for storing sensor data in the RPI?
The purpose is having a local backup of all historic data and to keep a record of which data has been sent to cloud-service.
There won't be much local querying, mostly storing.Right now I'm considering:
NeDB/NEDBLogger (https://github.com/louischatriot/nedb)
Levelup/Leveldb (https://github.com/rvagg/node-levelup) -
The "Message crc error." is a bit misleading. The code in the validate() routine actually checks the crc as well as the protocol version. Looking at the Arduino and the RPi 1.4 branch the versions don't match. I've adjusted the library and protocol version in the Sensor.h file on the Rpi to:
LIBRARY_VERSION "1.4"
PROTOCOL_VERSION 2and the crc error disappeared.
While changing the data rate from 2M to 1M in line 30 of the Arduino Sensor.cpp, I had to fix a syntax error to recompile successfully in line 361: a missing "}" to close the do/while. The full line should be "} while (--retry);"
With these two fixed the RPi and the Arduino now communicate - but I get a lot of "Send failed" messages on the Arduino and a lot of "Error looking up radioIds" on the RPi now:
RPi output:
Received: from=255, to=0, childId=255, mtype=4, type=5, crc=139, ''
139, 2, 0, 255, 0, 255, 255, 4, 5
Message crc ok.
header.type=5, header.to=0, radioId=0
Got message
Message type: 4
msgTypeId=4 int=4
Error looking up radioIds
...and so on...Android in DEBUG mode:
Started sensor.
Relay=0, distance=1
No radio id found in EEPROM fetching one from sensor net gateway
Relaying message back to gateway.
Tx: fr=255,to=0,la=255,ne=0,ci=255,mt=4,ty=5,cr=139:
Send failed.
Relaying message back to gateway.
Tx: fr=255,to=0,la=255,ne=0,ci=255,mt=4,ty=5,cr=139:
Send failed.
...and so on... -
Changing the mongo database URL in the dbDetails,js file
from:
mongodb://mysensors:27017/pi
to:
mongodb://localhost:27017/mysensorsfixed the "Error looking up radioIdo" issue on the RPi. Now the Rpi generates a new radioId but the attempt to send this to the Arduino fails:
RPi output:
Received: from=255, to=0, childId=255, mtype=4, type=5, crc=139, ''
139, 2, 0, 255, 0, 255, 255, 4, 5
Message crc ok.
header.type=5, header.to=0, radioId=0
Got message
Message type: 4
msgTypeId=4 int=4
Sending data 255;255;4;5;1
Writing back messageWe have input
Nread=14
INP:255;255;4;5;1
.
INGOT radioId=255, childId=255, messageType=4, type=5, value=1
Sending data to GATEWAYRelaying message back to gateway.
Sending: from=0, to=255, childId=255, mtype=4, type=5, crc=193, '1
', sent via 0
193, 2, 0, 0, 255, 0, 255, 4, 5
radioId: Inserted id=1
Send failed. No ack received.
Sent to JS
Dynamic payload size=9 -
The "Message crc error." is a bit misleading. The code in the validate() routine actually checks the crc as well as the protocol version. Looking at the Arduino and the RPi 1.4 branch the versions don't match. I've adjusted the library and protocol version in the Sensor.h file on the Rpi to:
LIBRARY_VERSION "1.4"
PROTOCOL_VERSION 2and the crc error disappeared.
While changing the data rate from 2M to 1M in line 30 of the Arduino Sensor.cpp, I had to fix a syntax error to recompile successfully in line 361: a missing "}" to close the do/while. The full line should be "} while (--retry);"
With these two fixed the RPi and the Arduino now communicate - but I get a lot of "Send failed" messages on the Arduino and a lot of "Error looking up radioIds" on the RPi now:
RPi output:
Received: from=255, to=0, childId=255, mtype=4, type=5, crc=139, ''
139, 2, 0, 255, 0, 255, 255, 4, 5
Message crc ok.
header.type=5, header.to=0, radioId=0
Got message
Message type: 4
msgTypeId=4 int=4
Error looking up radioIds
...and so on...Android in DEBUG mode:
Started sensor.
Relay=0, distance=1
No radio id found in EEPROM fetching one from sensor net gateway
Relaying message back to gateway.
Tx: fr=255,to=0,la=255,ne=0,ci=255,mt=4,ty=5,cr=139:
Send failed.
Relaying message back to gateway.
Tx: fr=255,to=0,la=255,ne=0,ci=255,mt=4,ty=5,cr=139:
Send failed.
...and so on... -
@BMLSX - probably rather saved your stomach - eating the raspberry sounds noxious :)
I got one step further (maybe) - the Arduino now receives the radioId... looking at the log from the RPi above I stumbled over the RPi sending the data to the gateway ??? the RPi is the gateway !!! Comparing the code to the SerialGateway which seems to work for a lot of folks I found that the sendData() function is missing in the Relay.cpp code used for the RPi. Once that procedure is in place the RPi actually submits the new radioId to the sensor:
RPi : now "sent via 255" instead of "sent via 0"
Dynamic payload size=9
Received: from=255, to=0, childId=255, mtype=4, type=5, crc=65, ''
Message crc ok.
header.type=5, header.to=0, radioId=0
Got message
Message type: 4
Writing back message
msgTypeId=4 int=4
Sending data 255;255;4;5;1
We have input
Nread=14
INP:255;255;4;5;1
.
INGOT radioId=255, childId=255, messageType=4, type=5, value=1
Sending data to GATEWAY
No route... try sending direct.
Sending: from=0, to=255, childId=255, mtype=4, type=5, crc=11, '1
', sent via 255
radioId: Inserted id=1
Send failed. No ack received.
Sent to JSArduino
Started sensor.
Open ping reading pipe: 255
Tx: fr=255,to=255,la=255,ne=255,ci=255,mt=4,ty=9,cr=235:
Message available on pipe 1
Rx: fr=0,to=255,la=0,ci=255,mt=4,t=10,cr=106(ok): 0
Message addressed for this node.
Using relay 0. Distance is 0
Relay=0, distance=1
No radio id found in EEPROM fetching one from sensor net gateway
TH: get: n=0,c=255,st=4,rt=4,vt=5
Relaying message back to gateway.
Tx: fr=255,to=0,la=255,ne=0,ci=255,mt=4,ty=5,cr=65:
Ack: receive timeout
Message available on pipe 1
Sent ack msg to 0
Rx: fr=0,to=255,la=0,ci=255,mt=4,t=5,cr=11(ok): 1Message addressed for this node.
Radio id received: 1
Radio id stored in EEPROM was: 1
Relaying message back to gateway.
Tx: fr=1,to=0,la=1,ne=0,ci=255,mt=0,ty=17,cr=17: 1.3b3 (7afb55c)
Ack: receive timeout
Relaying message back to gateway.
Tx: fr=1,to=0,la=1,ne=0,ci=255,mt=4,ty=7,cr=176: 0
Ack: receive timeout
Relaying message back to gateway.
Tx: fr=1,to=0,la=1,ne=0,ci=255,mt=4,ty=14,cr=21: Temperature Sensor
Ack: receive timeout
Relaying message back to gateway.
Tx: fr=1,to=0,la=1,ne=0,ci=255,mt=4,ty=15,cr=13: 1.0
Ack: receive timeout
Relaying message back to gateway.
Tx: fr=1,to=0,la=1,ne=0,ci=0,mt=0,ty=6,cr=99: 1.3b3 (7afb55c)
Ack: receive timeout
TH: get: n=0,c=255,st=4,rt=4,vt=13
Relaying message back to gateway.
Tx: fr=1,to=0,la=1,ne=0,ci=255,mt=4,ty=13,cr=200:
Ack: receive timeoutI'm still not sure if the missing ACK for the majority of the messages is by purpose or by accident... would be relatively easy to fix by either not waiting for an ACK for all messages or by always sending an ACK - but I don't want to mess with this code without knowing why it was implemented this way.
-
RPi and Arduino now talk to each other, the Arduino receives the radioId from the Rpi and stores it in the EEPROM and the Arduino presents itself to the network. I still see some timing issues (ACKs too late / replies too early while the other end is still waiting for an ACK / ...) but in general it works.
To get there I forked both the Arduino and the RPi project and tried to get to the latest and greatest code by merging some of the branches (mainly master and 1.4dev)... When I ran into additional issues due to the RPi code not getting the latest updates and bug fixes available in the Arduino project, I decided to merge across the two and ended up with a common set of RF files: a common codebase for RF24 as well as Sensor/Relay/Gateway. If any of this is of interest for themain development then please let me know and I'll create a pull request.What I did in detail:
Arduino:
- started new branch tosa-dev based on latest master branch
- adjusted the message header to use full bytes as mentioned earlier in this thread
- no need to merge the 1.4dev branch as the message header was essentially the only remaining relevant change in there
- no need to merge other branches as the majority of these were already merged back into master
Raspberry:
- started new branch tosa-dev based on latest master branch
- merged the 1.4dev branch into tosa-dev
- a couple of minor tweaks (mongoDb URL / start and stop scripts / data rate / ... majority listed earlier in this thread)
When I found the missing Relay::sendData() routine I decided to stop tweaking bit by bit and instead looked at what it would take to use the more advanced Arduino code for RF24 and Sensor/Relay/Gateway for the RPi as well. Based on comments in the forum this seems to work for several people using a SerialGateway or EthernetGateway so my expectation was to find well maintained code there avoiding some of the low level communication issues I ran into so far with the RPi code. This code is available in a separate branch "tosa-dev-commonrf" for both Arduino and Raspberry.
The code is not perfect yet but it works. I'm not a GIT expert but as far as I can tell the fork is public and everybody should be able to see it:
https://github.com/ToSa27/Raspberry/tree/tosa-dev-commonrf
https://github.com/ToSa27/Arduino/tree/tosa-dev-commonrfAgain: happy to create pull requests if you want to use this setup as part of the master branch at some point. The main reason for me to do this is to get a solid foundation to start working on the OTA update code...
-
@ToSa i tried compiling your code but it fails on the RPi with allot of errors :
pi@raspberrypi ~/Raspberry $ make
make -C librf24
make[1]: Entering directory/home/pi/Raspberry/librf24' g++ -Wall -fPIC -Ofast -mfpu=vfp -mfloat-abi=hard -march=armv6zk -mtune=arm1176jzf-s -c RF24.cpp RF24.h: In constructor ‘RF24::RF24(std::string, uint32_t, uint8_t)’: RF24.h:65:12: warning: ‘RF24::spispeed’ will be initialized after [-Wreorder] RF24.h:53:11: warning: ‘uint8_t RF24::ce_pin’ [-Wreorder] RF24.cpp:258:1: warning: when initialized here [-Wreorder] g++ -shared -Wl,-soname,librf24.so.1 -Ofast -mfpu=vfp -mfloat-abi=hard -march=armv6zk -mtune=arm1176jzf-s -o librf24.so.1 compatibility.o gpio.o spi.o RF24.o make[1]: Leaving directory/home/pi/Raspberry/librf24'
g++ -c -g -o Gateway.o Gateway.cpp -Wall -Ofast -mfpu=vfp -DDEBUG -DRPI -mfloat-abi=hard -march=armv6zk -mtune=arm1176jzf-s -I/home/pi/RF24/RPi/RF24/
In file included from Sensor.h:15:0,
from Relay.h:15,
from Gateway.h:15,
from Gateway.cpp:12:
Config.h:15:0: warning: "DEBUG" redefined [enabled by default]
<command-line>:0:0: note: this is the location of the previous definition
In file included from Relay.h:15:0,
from Gateway.h:15,
from Gateway.cpp:12:
Sensor.h:154:16: error: expected ‘)’ before ‘_spidevice’
In file included from Gateway.h:15:0,
from Gateway.cpp:12:
Relay.h:43:16: error: expected ‘)’ before ‘_spidevice’
In file included from Gateway.cpp:12:0:
Gateway.h:47:18: error: expected ‘)’ before ‘_spidevice’
Gateway.cpp:34:1: error: prototype for ‘Gateway::Gateway(std::string, uint32_t, uint8_t, uint8_t)’ does not match any in class ‘Gateway’
Gateway.h:24:7: error: candidates are: Gateway::Gateway(const Gateway&)
Gateway.h:24:7: error: Gateway::Gateway()
Gateway.cpp: In member function ‘void Gateway::begin(rf24_pa_dbm_e, uint8_t, rf24_datarate_e, void ()(char))’:
Gateway.cpp:62:18: error: ‘OUTPUT’ was not declared in this scope
Gateway.cpp:62:24: error: ‘pinMode’ was not declared in this scope
Gateway.cpp:65:26: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:70:25: error: ‘INPUT’ was not declared in this scope
Gateway.cpp:86:53: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::checkButtonTriggeredInclusion()’:
Gateway.cpp:104:59: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::parseAndSend(char*)’:
Gateway.cpp:161:35: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::setInclusionMode(boolean)’:
Gateway.cpp:181:33: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::serial(message_s)’:
Gateway.cpp:236:33: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::ledTimersInterrupt()’:
Gateway.cpp:243:28: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:246:30: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:252:28: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:255:30: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:262:28: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:265:30: error: ‘digitalWrite’ was not declared in this scope
make: *** [Gateway.o] Error 1 -
@ToSa i tried compiling your code but it fails on the RPi with allot of errors :
pi@raspberrypi ~/Raspberry $ make
make -C librf24
make[1]: Entering directory/home/pi/Raspberry/librf24' g++ -Wall -fPIC -Ofast -mfpu=vfp -mfloat-abi=hard -march=armv6zk -mtune=arm1176jzf-s -c RF24.cpp RF24.h: In constructor ‘RF24::RF24(std::string, uint32_t, uint8_t)’: RF24.h:65:12: warning: ‘RF24::spispeed’ will be initialized after [-Wreorder] RF24.h:53:11: warning: ‘uint8_t RF24::ce_pin’ [-Wreorder] RF24.cpp:258:1: warning: when initialized here [-Wreorder] g++ -shared -Wl,-soname,librf24.so.1 -Ofast -mfpu=vfp -mfloat-abi=hard -march=armv6zk -mtune=arm1176jzf-s -o librf24.so.1 compatibility.o gpio.o spi.o RF24.o make[1]: Leaving directory/home/pi/Raspberry/librf24'
g++ -c -g -o Gateway.o Gateway.cpp -Wall -Ofast -mfpu=vfp -DDEBUG -DRPI -mfloat-abi=hard -march=armv6zk -mtune=arm1176jzf-s -I/home/pi/RF24/RPi/RF24/
In file included from Sensor.h:15:0,
from Relay.h:15,
from Gateway.h:15,
from Gateway.cpp:12:
Config.h:15:0: warning: "DEBUG" redefined [enabled by default]
<command-line>:0:0: note: this is the location of the previous definition
In file included from Relay.h:15:0,
from Gateway.h:15,
from Gateway.cpp:12:
Sensor.h:154:16: error: expected ‘)’ before ‘_spidevice’
In file included from Gateway.h:15:0,
from Gateway.cpp:12:
Relay.h:43:16: error: expected ‘)’ before ‘_spidevice’
In file included from Gateway.cpp:12:0:
Gateway.h:47:18: error: expected ‘)’ before ‘_spidevice’
Gateway.cpp:34:1: error: prototype for ‘Gateway::Gateway(std::string, uint32_t, uint8_t, uint8_t)’ does not match any in class ‘Gateway’
Gateway.h:24:7: error: candidates are: Gateway::Gateway(const Gateway&)
Gateway.h:24:7: error: Gateway::Gateway()
Gateway.cpp: In member function ‘void Gateway::begin(rf24_pa_dbm_e, uint8_t, rf24_datarate_e, void ()(char))’:
Gateway.cpp:62:18: error: ‘OUTPUT’ was not declared in this scope
Gateway.cpp:62:24: error: ‘pinMode’ was not declared in this scope
Gateway.cpp:65:26: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:70:25: error: ‘INPUT’ was not declared in this scope
Gateway.cpp:86:53: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::checkButtonTriggeredInclusion()’:
Gateway.cpp:104:59: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::parseAndSend(char*)’:
Gateway.cpp:161:35: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::setInclusionMode(boolean)’:
Gateway.cpp:181:33: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::serial(message_s)’:
Gateway.cpp:236:33: error: ‘PSTR’ was not declared in this scope
Gateway.cpp: In member function ‘void Gateway::ledTimersInterrupt()’:
Gateway.cpp:243:28: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:246:30: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:252:28: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:255:30: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:262:28: error: ‘digitalWrite’ was not declared in this scope
Gateway.cpp:265:30: error: ‘digitalWrite’ was not declared in this scope
make: *** [Gateway.o] Error 1 -
