MySensors 1.5.2 Released

[korttoma]

Whell a sketch used to compile just fine using 1.5 but now I get:

In file included from (sketch file) MultiTemp.ino:39:
(personal library file) MySensors/MySensor.h:158:70: error: unknown type name 'MyHwDriver'
MySensor(MyTransport &radio =*new MyTransportNRF24(), MyHw &hw=*new MyHwDriver()
^
(sketch file) MultiTemp.ino:71:10: error: redefinition of 'transport' with a different type: 'MySensor' vs 'MyTransportNRF24'
MySensor(transport);
^
(sketch file) MultiTemp.ino:69:18: note: previous definition is here
MyTransportNRF24 transport(RF24_CE_PIN, RF24_CS_PIN, RF24_PA_LEVEL);

[Anticimex]

If you skipped on 1.5.1 and went from 1.5 to 1.5.2 I think @hek needs to fill you (and me) in on what changes has been made.

[korttoma]

Btw, I just upload the MySensor folder from the library as a .zip to codebender. Do I need anything outside this folder?

[Anticimex]

I don't think so. Perhaps it helps to re-download the image. Which link did you use? The zip link to 1.5.2 is here.

[hek]

Github is the best place. I have a vague memory of routing problems fixed in 1.5.1.
https://github.com/mysensors/Arduino/releases

[korttoma]

Tried to get the Lib again but it does not seem to be any different:

Trying to compile the sketch (coodiebender.something/sketch:213307) unchanged results in this:

In file included from (sketch file) MultiTemp.ino:35:
(personal library file) MySensors/MySensor.h:158:70: error: unknown type name 'MyHwDriver'
        MySensor(MyTransport &radio =*new MyTransportNRF24(), MyHw &hw=*new MyHwDriver()
                                                                            ^
(sketch file) MultiTemp.ino:63:10: error: no matching constructor for initialization of 'MySensor'
MySensor gw(transport);

So I remove the "gw" but it stil complains:

(personal library file) MySensors/MySensor.h:158:70: error: unknown type name 'MyHwDriver'
        MySensor(MyTransport &radio =*new MyTransportNRF24(), MyHw &hw=*new MyHwDriver()
                                                                            ^
(sketch file) MultiTemp.ino:63:11: error: redefinition of 'transport' with a different type: 'MySensor' vs 'MyTransportNRF24'
MySensor (transport);

I'm just not doing it right that is all, but how should it be done?

[Anticimex]

Have you looked at one of the existing examples as a reference? For example the DallasTemperatureSensor.ino

[korttoma]

The examples do not include a transport definition

[korttoma]

Is there "SOMETHING" missing like this??

MySensor gw(transport, SOMETHING);

candidate constructor not viable: requires 2 arguments, but 1 was provided
        MySensor(MyTransport &radio =*new MyTransportNRF24(), MyHw &hw=*new MyHwDriver()

How do I define "MyHwDriver"??

[Anticimex]

Have a look at this example

[korttoma]

Thanks for the example @Anticimex now I know how but it is stil not working when using codebender.

(personal library file) MySensors/MySensor.h:158:70: error: unknown type name 'MyHwDriver'
        MySensor(MyTransport &radio =*new MyTransportNRF24(), MyHw &hw=*new MyHwDriver()
                                                                            ^
(sketch file) MultiTemp.ino:66:1: error: unknown type name 'MyHwATMega328'
MyHwATMega328 hw; // Select AtMega328 hardware profile

I tested now with Arduino IDE 1.6.5 and my sketch compiles just fine.

[Anticimex]

Sorry, I am not very familiar with codebender. It looks to me that the library you try to build with is very out if date if it lacks those hw definitions. I don't know how the library ends up at codebender. Perhaps @hek has some communication with them to support it.

[carlierd]

Hello,

I tried to compile with 1.5.2 and got these errors:

/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp: In member function 'boolean MySensor::sendRoute(MyMessage&)':
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp:27:25: error: '_doSign' was not declared in this scope
 #define DO_SIGN(node) (~_doSign[node>>3]&(1<<(node%8)))
                         ^
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp:356:6: note: in expansion of macro 'DO_SIGN'
  if (DO_SIGN(message.destination) && message.sender == nc.nodeId && !mGetAck(message) && mGetLength(message) &&
      ^
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp: In member function 'boolean MySensor::process()':
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp:28:25: error: '_doSign' was not declared in this scope
 #define SET_SIGN(node) (_doSign[node>>3]&=~(1<<(node%8)))
                         ^
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp:670:6: note: in expansion of macro 'SET_SIGN'
      SET_SIGN(msg.sender);
      ^
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp:29:27: error: '_doSign' was not declared in this scope
 #define CLEAR_SIGN(node) (_doSign[node>>3]|=(1<<(node%8)))
                           ^
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp:673:6: note: in expansion of macro 'CLEAR_SIGN'
      CLEAR_SIGN(msg.sender);
      ^
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp:27:25: error: '_doSign' was not declared in this scope
 #define DO_SIGN(node) (~_doSign[node>>3]&(1<<(node%8)))
                         ^
/Users/carlierd/Arduino/libraries/MySensors/MySensor.cpp:682:40: note: in expansion of macro 'DO_SIGN'
      if (signer.requestSignatures() && DO_SIGN(msg.sender))
                                        ^
Erreur lors de la compilation.

No compilation issue with 1.5. And everything is working perfectly.

David.

[hek]

@Anticimex
Yes, I'll have to update the codebender library manually.

[Anticimex]

@carlierd I found a problem there. I have to make a new release. Sorry for the inconvenience!

[carlierd]

@Anticimex No problem !! Thanks for the support :)

[korttoma]

@hek said:

@Anticimex
Yes, I'll have to update the codebender library manually.

I have uploaded 1.5.2 library as a Personal Library in codebender. I have not had any trouble doing this before. Just tried 1.5.3 but I get the same error.

[hek]

candidate constructor not viable: requires 2 arguments, but 1 was provided
        MySensor(MyTransport &radio =*new MyTransportNRF24(), MyHw &hw=*new MyHwDriver()

Weird it finds the MySensors constructor, it has a default value (MyHwDriver) but doesn't use it. Darn compilers.

[Anticimex]

And you have selected a atmega328-based target when you build?

[korttoma]

@hek said:

Weird it finds the MySensors constructor, it has a default value (MyHwDriver) but doesn't use it. Darn compilers.

I take it you have managed to reproduce the situation or do you need some more information from me?

@Anticimex said:

And you have selected a atmega328-based target when you build?

Yes, I have an "Arduino Pro Mini 5V 16MHz w/ ATmega328" selected when compiling.