Irrigation Controller (up to 16 valves with Shift Registers)
My Project
371
Posts
56
Posters
248.8k
Views
52
Watching
-
OK, so I have this built this and have it mostly working with my Vera Plus. Below is a link to a video of a problem I am having.
http://www.dan.bemowski.info/videos/20170601_004213.mp4
So my sprinkler system has a pump start relay which gets turned on any time a valve is turned on. Because of this I made a slight hardware modification which thus required a software modification. For the hardware, I ended up using relay number 1 of my 8 channel relay board as my pump start relay control. This I have wired to pin A1. Relays 2 through 8 are connected to the shift register on Qb through Qh (outputs 2-8) skipping output 1. Because of this I had to change how the code defined which valve to start on. To do this, I changed the commented lines removing the (-1) on the bit shift. I made the assumption that in code, the relay numbers start with 0.
#ifdef ACTIVE_LOW //#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1)) #define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber)) #define ALL_VALVES_OFF 0xFFFF #else //#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1)) #define BITSHIFT_VALVE_NUMBER (1U << (valveNumber)) #define ALL_VALVES_OFF 0U #endifThen I needed to define the pump start relay.
const int pumpStart = A1;and then in setup I have this:
pinMode(pumpStart, OUTPUT); digitalWrite (pumpStart, HIGH);Lastly, to operate the pump start relay whenever a zone is triggered, this is the updateRelays() function:
void updateRelays(int value) { if (value == ALL_VALVES_OFF) { digitalWrite(pumpStart, HIGH); } else { digitalWrite(pumpStart, LOW); } digitalWrite(latchPin, LOW); shiftOut(dataPin, clockPin, MSBFIRST, highByte(value)); shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value)); digitalWrite(latchPin, HIGH); }All of this seems to work. When I trigger a zone, I see the pump start relay kick on as well as the triggered zone relay. The only problem I have is that the screen keeps cycling valve data: (1-4) on the screen, as can be seen in the video clip.
Here is my entire modified sketch that I have uploaded:
/* MySprinkler for MySensors Arduino Multi-Zone Sprinkler Control May 31, 2015 *** Version 2.0 *** Upgraded to http://MySensors.org version 1.4.1 *** Expanded for up to 16 Valves *** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high *** Switch to bitshift method vs byte arrays *** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve) *** Added optional LCD display featuring remaining time, date last ran & current time *** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively *** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone) *** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names) Utilizing your Vera home automation controller and the MySensors.org gateway you can control up to a sixteen zone irrigation system with only three digital pins. This sketch will create NUMBER_OF_VALVES + 1 devices on your Vera controller This sketch features the following: * Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control. * Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n) using Variable1 as the "ON" time in minutes in each of the vera devices created. * Use the individual zone controller to activate a single zone. This feature uses Variable2 as the "ON" time for each individual device/zone. * Connect according to pinout below and uses Shift Registers as to allow the MySensors standard radio configuration and still leave available digital pins * Turning on any zone will stop the current process and begin that particular process. * Turning off any zone will stop the current process and turn off all zones. * To push your new time intervals for your zones, simply change the variable on your Vera and your arduino will call to Vera once a minute and update accordingly. Variables will also be requested when the device is first powered on. * Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program * LED status indicator PARTS LIST: Available from the MySensors store - http://www.mysensors.org/store/ * Relays (8 channel) * Female Pin Header Connector Strip * Prototype Universal Printed Circuit Boards (PCB) * NRF24L01 Radio * Arduino (I used a Pro Mini) * FTDI USB to TTL Serial Adapter * Capacitors (10uf and .1uf) * 3.3v voltage regulator * Resistors (270, 1K & 10K) * Female Dupont Cables * 1602 LCD (with I2C Interface) * LED * Push button * Shift Register (SN74HC595) * 2 Pole 5mm Pitch PCB Mount Screw Terminal Block * 3 Pole 5mm Pitch PCB Mount Screw Terminal Block * 22-24 gauge wire or similar (I used Cat5/Cat6 cable) * 18 gauge wire (for relay) * Irrigation Power Supply (24-Volt/750 mA Transformer) INSTRUCTIONS: * A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI * After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to A4 and A5) and relays, and load the sketch. * Following the instructions at https://MySensors.org include the device to your MySensors Gateway. * Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2). The values entered for times may be zero and you may use the defaulet zone names by leaving Variable3 blank. * Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera. * Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed on the serial monitor. * Your arduino should slow-flash, indicating that it is in ready mode. * There are multiple debug serial prints that can be monitored to assure that it is operating properly. * ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain */ // // Enable debug prints #define MY_DEBUG // Enable and select radio type attached #define MY_RADIO_NRF24 //#define MY_RADIO_RFM69 //#define MY_NODE_ID 1 // Set this to fix your Radio ID or use Auto #include <Wire.h> #include <TimeLib.h> #include <SPI.h> #include <MySensors.h> #include <LiquidCrystal.h> #include <LiquidCrystal_I2C.h> #define NUMBER_OF_VALVES 4 // Change this to set your valve count up to 16. #define VALVE_RESET_TIME 7500UL // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state #define VALVE_TIMES_RELOAD 300000UL // Change this (in milliseconds) for how often to update all valves data from the controller (Loops at value/number valves) // ie: 300000 for 8 valves produces requests 37.5seconds with all valves updated every 5mins #define SKETCH_NAME "MySprinkler" #define SKETCH_VERSION "2.2" // #define CHILD_ID_SPRINKLER 0 // #define ACTIVE_LOW // comment out this line if your relays are active high // #define DEBUG_ON // comment out to supress serial monitor output // #ifdef ACTIVE_LOW //#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1)) #define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber)) #define ALL_VALVES_OFF 0xFFFF #else //#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1)) #define BITSHIFT_VALVE_NUMBER (1U << (valveNumber)) #define ALL_VALVES_OFF 0U #endif // #ifdef DEBUG_ON #define DEBUG_PRINT(x) Serial.print(x) #define DEBUG_PRINTLN(x) Serial.println(x) #else #define DEBUG_PRINT(x) #define DEBUG_PRINTLN(x) #define SERIAL_START(x) #endif // typedef enum { STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU } SprinklerStates; // SprinklerStates state = STAND_BY_ALL_OFF; SprinklerStates lastState; byte menuState = 0; unsigned long menuTimer; byte countDownTime = 10; // int allZoneTime [NUMBER_OF_VALVES + 1]; int valveSoloTime [NUMBER_OF_VALVES + 1]; int valveNumber; int lastValve; unsigned long startMillis; const int ledPin = 5; const int waterButtonPin = 3; bool buttonPushed = false; bool showTime = true; bool clockUpdating = false; bool recentUpdate = true; int allVars[] = {V_VAR1, V_VAR2, V_VAR3}; const char *dayOfWeek[] = { "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday " }; // Name your Zones here or use Vera to edit them by adding a name in Variable3... String valveNickName[17] = { "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16" }; // time_t lastTimeRun = 0; //Setup Shift Register... const int latchPin = 6; const int clockPin = 4; const int dataPin = 7; const int outputEnablePin = A0; const int pumpStart = A1; // byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator // Set the pins on the I2C chip used for LCD connections: // addr, en,rw,rs,d4,d5,d6,d7,bl,blpol LiquidCrystal_I2C lcd(0x3F, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE); // Set the LCD I2C address to 0x27. Mine was actually 0x3F // MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT); MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1); MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2); bool receivedInitialValue = false; bool inSetup = true; // void setup() { DEBUG_PRINTLN(F("Initialising...")); pinMode(latchPin, OUTPUT); pinMode(clockPin, OUTPUT); pinMode(dataPin, OUTPUT); pinMode(ledPin, OUTPUT); pinMode(outputEnablePin, OUTPUT); digitalWrite (outputEnablePin, LOW); pinMode(ledPin, OUTPUT); pinMode(pumpStart, OUTPUT); digitalWrite (pumpStart, HIGH); pinMode(waterButtonPin, INPUT_PULLUP); //pinMode(waterButtonPin, INPUT); attachInterrupt(digitalPinToInterrupt(waterButtonPin), PushButton, RISING); //May need to change for your Arduino model digitalWrite (ledPin, HIGH); DEBUG_PRINTLN(F("Turning All Valves Off...")); updateRelays(ALL_VALVES_OFF); //delay(5000); lcd.begin(16, 2); //(16 characters and 2 line display) lcd.clear(); lcd.backlight(); lcd.createChar(0, clock); lcd.createChar(1, raindrop); // //check for saved date in EEPROM DEBUG_PRINTLN(F("Checking EEPROM for stored date:")); delay(500); if (loadState(0) == 0xFF) // EEPROM flag { DEBUG_PRINTLN(F("Retreiving last run time from EEPROM...")); for (int i = 0; i < 4 ; i++) { lastTimeRun = lastTimeRun << 8; lastTimeRun = lastTimeRun | loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp } } DEBUG_PRINTLN(F("Sensor Presentation Complete")); // digitalWrite (ledPin, LOW); DEBUG_PRINTLN(F("Ready...")); // lcd.setCursor(0, 0); lcd.print(F(" Syncing Time ")); lcd.setCursor(15, 0); lcd.write(byte(0)); lcd.setCursor(0, 1); int clockCounter = 0; while (timeStatus() == timeNotSet && clockCounter < 21) { requestTime(); DEBUG_PRINTLN(F("Requesting time from Gateway:")); wait(1000); lcd.print("."); clockCounter++; if (clockCounter > 16) { DEBUG_PRINTLN(F("Failed initial clock synchronization!")); lcd.clear(); lcd.print(F(" Failed Clock ")); lcd.setCursor(0, 1); lcd.print(F(" Syncronization ")); wait(2000); break; } } // //Update valve data when first powered on for (byte i = 1; i <= NUMBER_OF_VALVES; i++) { lcd.clear(); goGetValveTimes(); } lcd.clear(); } void presentation() { sendSketchInfo(SKETCH_NAME, SKETCH_VERSION); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { present(i, S_LIGHT); } } // void loop() { updateClock(); updateDisplay(); goGetValveTimes(); // if (buttonPushed) { menuTimer = millis(); DEBUG_PRINTLN(F("Button Pressed")); if (state == STAND_BY_ALL_OFF) { state = ZONE_SELECT_MENU; menuState = 0; } else if (state == ZONE_SELECT_MENU) { menuState++; if (menuState > NUMBER_OF_VALVES) { menuState = 0; } } else { state = STAND_BY_ALL_OFF; } buttonPushed = false; } if (state == STAND_BY_ALL_OFF) { slowToggleLED (); if (state != lastState) { updateRelays(ALL_VALVES_OFF); DEBUG_PRINTLN(F("State Changed... all Zones off")); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { wait(50); send(msg1valve.setSensor(i).set(false), false); } lcd.clear(); lcd.setCursor(0,0); lcd.print(F("** Irrigation **")); lcd.setCursor(0,1); lcd.print(F("** Halted **")); wait(2000); lastValve = -1; } } // else if (state == RUN_ALL_ZONES) { if (lastValve != valveNumber) { for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { if (i == 0 || i == valveNumber) { send(msg1valve.setSensor(i).set(true), false); } else { send(msg1valve.setSensor(i).set(false), false); } wait(50); } } lastValve = valveNumber; fastToggleLed(); if (state != lastState) { valveNumber = 1; updateRelays(ALL_VALVES_OFF); DEBUG_PRINTLN(F("State Changed, Running All Zones...")); } unsigned long nowMillis = millis(); if (nowMillis - startMillis < VALVE_RESET_TIME) { updateRelays(ALL_VALVES_OFF); } else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL)) { updateRelays(BITSHIFT_VALVE_NUMBER); } else { DEBUG_PRINTLN(F("Changing Valves...")); updateRelays(ALL_VALVES_OFF); startMillis = millis(); valveNumber++; if (valveNumber > NUMBER_OF_VALVES) { state = CYCLE_COMPLETE; startMillis = millis(); lastValve = -1; lastTimeRun = now(); saveDateToEEPROM(lastTimeRun); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { send(msg1valve.setSensor(i).set(false), false); wait(50); } DEBUG_PRINT(F("State = ")); DEBUG_PRINTLN(state); } } } // else if (state == RUN_SINGLE_ZONE) { fastToggleLed(); if (state != lastState) { for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { if (i == 0 || i == valveNumber) { send(msg1valve.setSensor(i).set(true), false); } else { send(msg1valve.setSensor(i).set(false), false); } wait(50); } DEBUG_PRINTLN(F("State Changed, Single Zone Running...")); DEBUG_PRINT(F("Zone: ")); DEBUG_PRINTLN(valveNumber); } unsigned long nowMillis = millis(); if (nowMillis - startMillis < VALVE_RESET_TIME) { updateRelays(ALL_VALVES_OFF); } else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL)) { updateRelays(BITSHIFT_VALVE_NUMBER); } else { updateRelays(ALL_VALVES_OFF); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { send(msg1valve.setSensor(i).set(false), false); } state = CYCLE_COMPLETE; startMillis = millis(); DEBUG_PRINT(F("State = ")); DEBUG_PRINTLN(state); } lastTimeRun = now(); } else if (state == CYCLE_COMPLETE) { if (millis() - startMillis < 30000UL) { fastToggleLed(); } else { state = STAND_BY_ALL_OFF; } } if (state == ZONE_SELECT_MENU) { displayMenu(); } else { lastState = state; } } // void displayMenu(void) { static byte lastMenuState = -1; static int lastSecond; if (menuState != lastMenuState) { lcd.clear(); lcd.setCursor(0, 0); lcd.print(valveNickName[menuState]); lcd.setCursor(0, 1); lcd.print(F("Starting")); DEBUG_PRINT(valveNickName[menuState]); Serial.print(F(" Starting Shortly")); } int thisSecond = (millis() - menuTimer) / 1000UL; if (thisSecond != lastSecond && thisSecond < 8) { lcd.print(F(".")); Serial.print("."); } lastSecond = thisSecond; if (millis() - menuTimer > 10000UL) { startMillis = millis(); if (menuState == 0) { valveNumber = 1; state = RUN_ALL_ZONES; } else { valveNumber = menuState; state = RUN_SINGLE_ZONE; } } else { } lastMenuState = menuState; } // void updateRelays(int value) { if (value == ALL_VALVES_OFF) { digitalWrite(pumpStart, HIGH); } else { digitalWrite(pumpStart, LOW); } digitalWrite(latchPin, LOW); shiftOut(dataPin, clockPin, MSBFIRST, highByte(value)); shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value)); digitalWrite(latchPin, HIGH); } // void PushButton() //interrupt with debounce { static unsigned long last_interrupt_time = 0; unsigned long interrupt_time = millis(); if (interrupt_time - last_interrupt_time > 200) { buttonPushed = true; } last_interrupt_time = interrupt_time; } // void fastToggleLed() { static unsigned long fastLedTimer; if (millis() - fastLedTimer >= 100UL) { digitalWrite(ledPin, !digitalRead(ledPin)); fastLedTimer = millis (); } } // void slowToggleLED () { static unsigned long slowLedTimer; if (millis() - slowLedTimer >= 1250UL) { digitalWrite(ledPin, !digitalRead(ledPin)); slowLedTimer = millis (); } } // void receive(const MyMessage &message) { bool zoneTimeUpdate = false; if (message.isAck()) { DEBUG_PRINTLN(F("This is an ack from gateway")); } for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { if (message.sensor == i) { if (message.type == V_LIGHT) { int switchState = atoi(message.data); if (switchState == 0) { state = STAND_BY_ALL_OFF; DEBUG_PRINTLN(F("Recieved Instruction to Cancel...")); } else { if (i == 0) { state = RUN_ALL_ZONES; valveNumber = 1; DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones...")); } else { state = RUN_SINGLE_ZONE; valveNumber = i; DEBUG_PRINT(F("Recieved Instruction to Activate Zone: ")); DEBUG_PRINTLN(i); } } startMillis = millis(); } else if (message.type == V_VAR1) { int variable1 = atoi(message.data);// RUN_ALL_ZONES time DEBUG_PRINT(F("Recieved variable1 valve:")); DEBUG_PRINT(i); DEBUG_PRINT(F(" = ")); DEBUG_PRINTLN(variable1); if (variable1 != allZoneTime[i]) { allZoneTime[i] = variable1; zoneTimeUpdate = true; } receivedInitialValue = true; } else if (message.type == V_VAR2) { int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time DEBUG_PRINT(F("Recieved variable2 valve:")); DEBUG_PRINT(i); DEBUG_PRINT(F(" = ")); DEBUG_PRINTLN(variable2); if (variable2 != valveSoloTime[i]) { valveSoloTime[i] = variable2; zoneTimeUpdate = true; } receivedInitialValue = true; } else if (message.type == V_VAR3) { String newMessage = String(message.data); if (newMessage.length() == 0) { DEBUG_PRINT(F("No Name Recieved for zone ")); DEBUG_PRINTLN(i); break; } if (newMessage.length() > 16) { newMessage.substring(0, 16); } valveNickName[i] = ""; valveNickName[i] += newMessage; DEBUG_PRINT(F("Recieved variable3 valve: ")); DEBUG_PRINT(i); DEBUG_PRINT(F(" = ")); DEBUG_PRINTLN(valveNickName[i]); } receivedInitialValue = true; } } if (zoneTimeUpdate) { // DEBUG_PRINTLN(F("New Zone Times Recieved...")); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { if (i != 0) { DEBUG_PRINT(F("Zone ")); DEBUG_PRINT(i); DEBUG_PRINT(F(" individual time: ")); DEBUG_PRINT(valveSoloTime[i]); DEBUG_PRINT(F(" group time: ")); DEBUG_PRINT(allZoneTime[i]); DEBUG_PRINT(F(" name: ")); DEBUG_PRINTLN(valveNickName[i]); recentUpdate = true; } } } else { recentUpdate = false; } } // void updateDisplay() { static unsigned long lastUpdateTime; static bool displayToggle = false; //static byte toggleCounter = 0; static SprinklerStates lastDisplayState; if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL) { displayToggle = !displayToggle; switch (state) { case STAND_BY_ALL_OFF: // fastClear(); lcd.setCursor(0, 0); if (displayToggle) { lcd.print(F(" System Ready ")); if (clockUpdating) { lcd.setCursor(15, 0); lcd.write(byte(0)); } lcd.setCursor(0, 1); lcd.print(hourFormat12() < 10 ? F(" ") : F("")); lcd.print(hourFormat12()); lcd.print(minute() < 10 ? F(":0") : F(":")); lcd.print(minute()); lcd.print(isAM() ? F("am") : F("pm")); lcd.print(month() < 10 ? F(" 0") : F(" ")); lcd.print(month()); lcd.print(day() < 10 ? F("/0") : F("/")); lcd.print(day()); lcd.print(F("/")); lcd.print(year() % 100); } else { lcd.print(F(" Last Watered ")); if (clockUpdating) { lcd.setCursor(15, 0); lcd.write(byte(0)); } lcd.setCursor(0, 1); lcd.print(dayOfWeek[weekday(lastTimeRun)]); lcd.setCursor(11, 1); lcd.print(month(lastTimeRun) < 10 ? F(" ") : F("")); lcd.print(month(lastTimeRun)); lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/")); lcd.print(day(lastTimeRun)); } break; case RUN_SINGLE_ZONE: // fastClear(); lcd.setCursor(0, 0); if (displayToggle) { lcd.print(F("Single Zone Mode")); lcd.setCursor(0, 1); lcd.print(F(" Zone:")); if (valveNumber < 10) lcd.print(F("0")); lcd.print(valveNumber); lcd.print(F(" Active")); } else { lcd.print(F(" Time Remaining ")); lcd.setCursor(0, 1); if (valveSoloTime[valveNumber] == 0) { lcd.print(F(" No Valve Time ")); } else { unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000); lcd.print(timeRemaining / 60 < 10 ? " 0" : " "); lcd.print(timeRemaining / 60); lcd.print("min"); lcd.print(timeRemaining % 60 < 10 ? " 0" : " "); lcd.print(timeRemaining % 60); lcd.print("sec "); } } break; case RUN_ALL_ZONES: // fastClear(); lcd.setCursor(0, 0); if (displayToggle) { lcd.print(F(" All-Zone Mode ")); lcd.setCursor(0, 1); lcd.print(F(" Zone:")); if (valveNumber < 10) lcd.print(F("0")); lcd.print(valveNumber); lcd.print(F(" Active ")); } else { lcd.print(F(" Time Remaining ")); lcd.setCursor(0, 1); int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000); lcd.print((timeRemaining / 60) < 10 ? " 0" : " "); lcd.print(timeRemaining / 60); lcd.print("min"); lcd.print(timeRemaining % 60 < 10 ? " 0" : " "); lcd.print(timeRemaining % 60); lcd.print("sec "); } break; case CYCLE_COMPLETE: // if (displayToggle) { lcd.setCursor(0, 0); lcd.print(F(" Watering Cycle ")); lcd.setCursor(0, 1); lcd.print(F(" Complete ")); } else { int totalTimeRan = 0; for (int i = 1; i < NUMBER_OF_VALVES + 1; i++) { totalTimeRan += allZoneTime[i]; } lcd.setCursor(0, 0); lcd.print(F(" Total Time Run ")); lcd.setCursor(0, 1); lcd.print(totalTimeRan < 10 ? " 0" : " "); lcd.print(totalTimeRan); lcd.print(" Minutes "); } default: // what of ZONE_SELECT_MENU? break; } lastUpdateTime = millis(); } lastDisplayState = state; } void receiveTime(time_t newTime) { DEBUG_PRINTLN(F("Time value received and updated...")); int lastSecond = second(); int lastMinute = minute(); int lastHour = hour(); setTime(newTime); if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime) { DEBUG_PRINTLN(F("Clock updated....")); DEBUG_PRINT(F("Sensor's time currently set to:")); DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" ")); DEBUG_PRINT(hourFormat12()); DEBUG_PRINT(minute() < 10 ? F(":0") : F(":")); DEBUG_PRINT(minute()); DEBUG_PRINTLN(isAM() ? F("am") : F("pm")); DEBUG_PRINT(month()); DEBUG_PRINT(F("/")); DEBUG_PRINT(day()); DEBUG_PRINT(F("/")); DEBUG_PRINTLN(year()); DEBUG_PRINTLN(dayOfWeek[weekday()]); showTime = false; } else { DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second.")); } clockUpdating = false; } void fastClear() { lcd.setCursor(0, 0); lcd.print(F(" ")); lcd.setCursor(0, 1); lcd.print(F(" ")); } // void updateClock() { static unsigned long lastVeraGetTime; if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour { DEBUG_PRINTLN(F("Requesting time and valve data from Gateway...")); lcd.setCursor(15, 0); lcd.write(byte(0)); clockUpdating = true; requestTime(); lastVeraGetTime = millis(); } } // void saveDateToEEPROM(unsigned long theDate) { DEBUG_PRINTLN(F("Saving Last Run date")); if (loadState(0) != 0xFF) { saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero) } // for (int i = 1; i < 5; i++) { saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one } } // void goGetValveTimes() { static unsigned long valveUpdateTime; static byte valveIndex = 1; if (inSetup || millis() - valveUpdateTime >= VALVE_TIMES_RELOAD / NUMBER_OF_VALVES) // update each valve once every 5 mins (distributes the traffic) { if (inSetup) { lcd.print(F(" Updating ")); lcd.setCursor(0, 1); lcd.print(F(" Valve Data: ")); lcd.print(valveIndex); } bool flashIcon = false; DEBUG_PRINT(F("Calling for Valve ")); DEBUG_PRINT(valveIndex); DEBUG_PRINTLN(F(" Data...")); for (int a = 0; a < (sizeof(allVars)/sizeof(int)); a++) { receivedInitialValue = false; byte timeout = 10; while (!receivedInitialValue && timeout > 0) { lcd.setCursor(15, 0); flashIcon = !flashIcon; flashIcon ? lcd.write(byte(1)) : lcd.print(F(" ")); request(valveIndex, allVars[a]); wait(50); timeout--; } } valveUpdateTime = millis(); valveIndex++; if (valveIndex > NUMBER_OF_VALVES) { valveIndex = 1; } } }As always, any help is appreciated.
what's happening in the Serial debug?
-
I'll look later and report. Got company at the moment. The odd thing is that I can turn my zones on and they seem to run for the specified time just fine. It's only what I see on the display that is messed up.
-
I've just started playing with a Z-Uno and was looking at ways to use for a project like this.
I'm a believer in not re-inventing the wheel and it seem that all I would need to do is to delete the radio and re-code the sketch for the extra relays ( I have already built a 4 channel relay, it's just getting over the hurdle of learning about Shift Registers).
Do you think this is possible or would I be better just starting from scratch? -
I've just started playing with a Z-Uno and was looking at ways to use for a project like this.
I'm a believer in not re-inventing the wheel and it seem that all I would need to do is to delete the radio and re-code the sketch for the extra relays ( I have already built a 4 channel relay, it's just getting over the hurdle of learning about Shift Registers).
Do you think this is possible or would I be better just starting from scratch?@Black-Cat said in Irrigation Controller (up to 16 valves with Shift Registers):
Z-Uno
wicked cool...
I'm in North America, so I have to stand by!
You you should be able to easily port this for use with Z-Uno...
-
I'll look later and report. Got company at the moment. The odd thing is that I can turn my zones on and they seem to run for the specified time just fine. It's only what I see on the display that is messed up.
yes, weird...
-
OK, so I have this built this and have it mostly working with my Vera Plus. Below is a link to a video of a problem I am having.
http://www.dan.bemowski.info/videos/20170601_004213.mp4
So my sprinkler system has a pump start relay which gets turned on any time a valve is turned on. Because of this I made a slight hardware modification which thus required a software modification. For the hardware, I ended up using relay number 1 of my 8 channel relay board as my pump start relay control. This I have wired to pin A1. Relays 2 through 8 are connected to the shift register on Qb through Qh (outputs 2-8) skipping output 1. Because of this I had to change how the code defined which valve to start on. To do this, I changed the commented lines removing the (-1) on the bit shift. I made the assumption that in code, the relay numbers start with 0.
#ifdef ACTIVE_LOW //#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1)) #define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber)) #define ALL_VALVES_OFF 0xFFFF #else //#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1)) #define BITSHIFT_VALVE_NUMBER (1U << (valveNumber)) #define ALL_VALVES_OFF 0U #endifThen I needed to define the pump start relay.
const int pumpStart = A1;and then in setup I have this:
pinMode(pumpStart, OUTPUT); digitalWrite (pumpStart, HIGH);Lastly, to operate the pump start relay whenever a zone is triggered, this is the updateRelays() function:
void updateRelays(int value) { if (value == ALL_VALVES_OFF) { digitalWrite(pumpStart, HIGH); } else { digitalWrite(pumpStart, LOW); } digitalWrite(latchPin, LOW); shiftOut(dataPin, clockPin, MSBFIRST, highByte(value)); shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value)); digitalWrite(latchPin, HIGH); }All of this seems to work. When I trigger a zone, I see the pump start relay kick on as well as the triggered zone relay. The only problem I have is that the screen keeps cycling valve data: (1-4) on the screen, as can be seen in the video clip.
Here is my entire modified sketch that I have uploaded:
/* MySprinkler for MySensors Arduino Multi-Zone Sprinkler Control May 31, 2015 *** Version 2.0 *** Upgraded to http://MySensors.org version 1.4.1 *** Expanded for up to 16 Valves *** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high *** Switch to bitshift method vs byte arrays *** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve) *** Added optional LCD display featuring remaining time, date last ran & current time *** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively *** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone) *** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names) Utilizing your Vera home automation controller and the MySensors.org gateway you can control up to a sixteen zone irrigation system with only three digital pins. This sketch will create NUMBER_OF_VALVES + 1 devices on your Vera controller This sketch features the following: * Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control. * Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n) using Variable1 as the "ON" time in minutes in each of the vera devices created. * Use the individual zone controller to activate a single zone. This feature uses Variable2 as the "ON" time for each individual device/zone. * Connect according to pinout below and uses Shift Registers as to allow the MySensors standard radio configuration and still leave available digital pins * Turning on any zone will stop the current process and begin that particular process. * Turning off any zone will stop the current process and turn off all zones. * To push your new time intervals for your zones, simply change the variable on your Vera and your arduino will call to Vera once a minute and update accordingly. Variables will also be requested when the device is first powered on. * Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program * LED status indicator PARTS LIST: Available from the MySensors store - http://www.mysensors.org/store/ * Relays (8 channel) * Female Pin Header Connector Strip * Prototype Universal Printed Circuit Boards (PCB) * NRF24L01 Radio * Arduino (I used a Pro Mini) * FTDI USB to TTL Serial Adapter * Capacitors (10uf and .1uf) * 3.3v voltage regulator * Resistors (270, 1K & 10K) * Female Dupont Cables * 1602 LCD (with I2C Interface) * LED * Push button * Shift Register (SN74HC595) * 2 Pole 5mm Pitch PCB Mount Screw Terminal Block * 3 Pole 5mm Pitch PCB Mount Screw Terminal Block * 22-24 gauge wire or similar (I used Cat5/Cat6 cable) * 18 gauge wire (for relay) * Irrigation Power Supply (24-Volt/750 mA Transformer) INSTRUCTIONS: * A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI * After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to A4 and A5) and relays, and load the sketch. * Following the instructions at https://MySensors.org include the device to your MySensors Gateway. * Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2). The values entered for times may be zero and you may use the defaulet zone names by leaving Variable3 blank. * Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera. * Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed on the serial monitor. * Your arduino should slow-flash, indicating that it is in ready mode. * There are multiple debug serial prints that can be monitored to assure that it is operating properly. * ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain */ // // Enable debug prints #define MY_DEBUG // Enable and select radio type attached #define MY_RADIO_NRF24 //#define MY_RADIO_RFM69 //#define MY_NODE_ID 1 // Set this to fix your Radio ID or use Auto #include <Wire.h> #include <TimeLib.h> #include <SPI.h> #include <MySensors.h> #include <LiquidCrystal.h> #include <LiquidCrystal_I2C.h> #define NUMBER_OF_VALVES 4 // Change this to set your valve count up to 16. #define VALVE_RESET_TIME 7500UL // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state #define VALVE_TIMES_RELOAD 300000UL // Change this (in milliseconds) for how often to update all valves data from the controller (Loops at value/number valves) // ie: 300000 for 8 valves produces requests 37.5seconds with all valves updated every 5mins #define SKETCH_NAME "MySprinkler" #define SKETCH_VERSION "2.2" // #define CHILD_ID_SPRINKLER 0 // #define ACTIVE_LOW // comment out this line if your relays are active high // #define DEBUG_ON // comment out to supress serial monitor output // #ifdef ACTIVE_LOW //#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1)) #define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber)) #define ALL_VALVES_OFF 0xFFFF #else //#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1)) #define BITSHIFT_VALVE_NUMBER (1U << (valveNumber)) #define ALL_VALVES_OFF 0U #endif // #ifdef DEBUG_ON #define DEBUG_PRINT(x) Serial.print(x) #define DEBUG_PRINTLN(x) Serial.println(x) #else #define DEBUG_PRINT(x) #define DEBUG_PRINTLN(x) #define SERIAL_START(x) #endif // typedef enum { STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU } SprinklerStates; // SprinklerStates state = STAND_BY_ALL_OFF; SprinklerStates lastState; byte menuState = 0; unsigned long menuTimer; byte countDownTime = 10; // int allZoneTime [NUMBER_OF_VALVES + 1]; int valveSoloTime [NUMBER_OF_VALVES + 1]; int valveNumber; int lastValve; unsigned long startMillis; const int ledPin = 5; const int waterButtonPin = 3; bool buttonPushed = false; bool showTime = true; bool clockUpdating = false; bool recentUpdate = true; int allVars[] = {V_VAR1, V_VAR2, V_VAR3}; const char *dayOfWeek[] = { "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday " }; // Name your Zones here or use Vera to edit them by adding a name in Variable3... String valveNickName[17] = { "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16" }; // time_t lastTimeRun = 0; //Setup Shift Register... const int latchPin = 6; const int clockPin = 4; const int dataPin = 7; const int outputEnablePin = A0; const int pumpStart = A1; // byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator // Set the pins on the I2C chip used for LCD connections: // addr, en,rw,rs,d4,d5,d6,d7,bl,blpol LiquidCrystal_I2C lcd(0x3F, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE); // Set the LCD I2C address to 0x27. Mine was actually 0x3F // MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT); MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1); MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2); bool receivedInitialValue = false; bool inSetup = true; // void setup() { DEBUG_PRINTLN(F("Initialising...")); pinMode(latchPin, OUTPUT); pinMode(clockPin, OUTPUT); pinMode(dataPin, OUTPUT); pinMode(ledPin, OUTPUT); pinMode(outputEnablePin, OUTPUT); digitalWrite (outputEnablePin, LOW); pinMode(ledPin, OUTPUT); pinMode(pumpStart, OUTPUT); digitalWrite (pumpStart, HIGH); pinMode(waterButtonPin, INPUT_PULLUP); //pinMode(waterButtonPin, INPUT); attachInterrupt(digitalPinToInterrupt(waterButtonPin), PushButton, RISING); //May need to change for your Arduino model digitalWrite (ledPin, HIGH); DEBUG_PRINTLN(F("Turning All Valves Off...")); updateRelays(ALL_VALVES_OFF); //delay(5000); lcd.begin(16, 2); //(16 characters and 2 line display) lcd.clear(); lcd.backlight(); lcd.createChar(0, clock); lcd.createChar(1, raindrop); // //check for saved date in EEPROM DEBUG_PRINTLN(F("Checking EEPROM for stored date:")); delay(500); if (loadState(0) == 0xFF) // EEPROM flag { DEBUG_PRINTLN(F("Retreiving last run time from EEPROM...")); for (int i = 0; i < 4 ; i++) { lastTimeRun = lastTimeRun << 8; lastTimeRun = lastTimeRun | loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp } } DEBUG_PRINTLN(F("Sensor Presentation Complete")); // digitalWrite (ledPin, LOW); DEBUG_PRINTLN(F("Ready...")); // lcd.setCursor(0, 0); lcd.print(F(" Syncing Time ")); lcd.setCursor(15, 0); lcd.write(byte(0)); lcd.setCursor(0, 1); int clockCounter = 0; while (timeStatus() == timeNotSet && clockCounter < 21) { requestTime(); DEBUG_PRINTLN(F("Requesting time from Gateway:")); wait(1000); lcd.print("."); clockCounter++; if (clockCounter > 16) { DEBUG_PRINTLN(F("Failed initial clock synchronization!")); lcd.clear(); lcd.print(F(" Failed Clock ")); lcd.setCursor(0, 1); lcd.print(F(" Syncronization ")); wait(2000); break; } } // //Update valve data when first powered on for (byte i = 1; i <= NUMBER_OF_VALVES; i++) { lcd.clear(); goGetValveTimes(); } lcd.clear(); } void presentation() { sendSketchInfo(SKETCH_NAME, SKETCH_VERSION); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { present(i, S_LIGHT); } } // void loop() { updateClock(); updateDisplay(); goGetValveTimes(); // if (buttonPushed) { menuTimer = millis(); DEBUG_PRINTLN(F("Button Pressed")); if (state == STAND_BY_ALL_OFF) { state = ZONE_SELECT_MENU; menuState = 0; } else if (state == ZONE_SELECT_MENU) { menuState++; if (menuState > NUMBER_OF_VALVES) { menuState = 0; } } else { state = STAND_BY_ALL_OFF; } buttonPushed = false; } if (state == STAND_BY_ALL_OFF) { slowToggleLED (); if (state != lastState) { updateRelays(ALL_VALVES_OFF); DEBUG_PRINTLN(F("State Changed... all Zones off")); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { wait(50); send(msg1valve.setSensor(i).set(false), false); } lcd.clear(); lcd.setCursor(0,0); lcd.print(F("** Irrigation **")); lcd.setCursor(0,1); lcd.print(F("** Halted **")); wait(2000); lastValve = -1; } } // else if (state == RUN_ALL_ZONES) { if (lastValve != valveNumber) { for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { if (i == 0 || i == valveNumber) { send(msg1valve.setSensor(i).set(true), false); } else { send(msg1valve.setSensor(i).set(false), false); } wait(50); } } lastValve = valveNumber; fastToggleLed(); if (state != lastState) { valveNumber = 1; updateRelays(ALL_VALVES_OFF); DEBUG_PRINTLN(F("State Changed, Running All Zones...")); } unsigned long nowMillis = millis(); if (nowMillis - startMillis < VALVE_RESET_TIME) { updateRelays(ALL_VALVES_OFF); } else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL)) { updateRelays(BITSHIFT_VALVE_NUMBER); } else { DEBUG_PRINTLN(F("Changing Valves...")); updateRelays(ALL_VALVES_OFF); startMillis = millis(); valveNumber++; if (valveNumber > NUMBER_OF_VALVES) { state = CYCLE_COMPLETE; startMillis = millis(); lastValve = -1; lastTimeRun = now(); saveDateToEEPROM(lastTimeRun); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { send(msg1valve.setSensor(i).set(false), false); wait(50); } DEBUG_PRINT(F("State = ")); DEBUG_PRINTLN(state); } } } // else if (state == RUN_SINGLE_ZONE) { fastToggleLed(); if (state != lastState) { for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { if (i == 0 || i == valveNumber) { send(msg1valve.setSensor(i).set(true), false); } else { send(msg1valve.setSensor(i).set(false), false); } wait(50); } DEBUG_PRINTLN(F("State Changed, Single Zone Running...")); DEBUG_PRINT(F("Zone: ")); DEBUG_PRINTLN(valveNumber); } unsigned long nowMillis = millis(); if (nowMillis - startMillis < VALVE_RESET_TIME) { updateRelays(ALL_VALVES_OFF); } else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL)) { updateRelays(BITSHIFT_VALVE_NUMBER); } else { updateRelays(ALL_VALVES_OFF); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { send(msg1valve.setSensor(i).set(false), false); } state = CYCLE_COMPLETE; startMillis = millis(); DEBUG_PRINT(F("State = ")); DEBUG_PRINTLN(state); } lastTimeRun = now(); } else if (state == CYCLE_COMPLETE) { if (millis() - startMillis < 30000UL) { fastToggleLed(); } else { state = STAND_BY_ALL_OFF; } } if (state == ZONE_SELECT_MENU) { displayMenu(); } else { lastState = state; } } // void displayMenu(void) { static byte lastMenuState = -1; static int lastSecond; if (menuState != lastMenuState) { lcd.clear(); lcd.setCursor(0, 0); lcd.print(valveNickName[menuState]); lcd.setCursor(0, 1); lcd.print(F("Starting")); DEBUG_PRINT(valveNickName[menuState]); Serial.print(F(" Starting Shortly")); } int thisSecond = (millis() - menuTimer) / 1000UL; if (thisSecond != lastSecond && thisSecond < 8) { lcd.print(F(".")); Serial.print("."); } lastSecond = thisSecond; if (millis() - menuTimer > 10000UL) { startMillis = millis(); if (menuState == 0) { valveNumber = 1; state = RUN_ALL_ZONES; } else { valveNumber = menuState; state = RUN_SINGLE_ZONE; } } else { } lastMenuState = menuState; } // void updateRelays(int value) { if (value == ALL_VALVES_OFF) { digitalWrite(pumpStart, HIGH); } else { digitalWrite(pumpStart, LOW); } digitalWrite(latchPin, LOW); shiftOut(dataPin, clockPin, MSBFIRST, highByte(value)); shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value)); digitalWrite(latchPin, HIGH); } // void PushButton() //interrupt with debounce { static unsigned long last_interrupt_time = 0; unsigned long interrupt_time = millis(); if (interrupt_time - last_interrupt_time > 200) { buttonPushed = true; } last_interrupt_time = interrupt_time; } // void fastToggleLed() { static unsigned long fastLedTimer; if (millis() - fastLedTimer >= 100UL) { digitalWrite(ledPin, !digitalRead(ledPin)); fastLedTimer = millis (); } } // void slowToggleLED () { static unsigned long slowLedTimer; if (millis() - slowLedTimer >= 1250UL) { digitalWrite(ledPin, !digitalRead(ledPin)); slowLedTimer = millis (); } } // void receive(const MyMessage &message) { bool zoneTimeUpdate = false; if (message.isAck()) { DEBUG_PRINTLN(F("This is an ack from gateway")); } for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { if (message.sensor == i) { if (message.type == V_LIGHT) { int switchState = atoi(message.data); if (switchState == 0) { state = STAND_BY_ALL_OFF; DEBUG_PRINTLN(F("Recieved Instruction to Cancel...")); } else { if (i == 0) { state = RUN_ALL_ZONES; valveNumber = 1; DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones...")); } else { state = RUN_SINGLE_ZONE; valveNumber = i; DEBUG_PRINT(F("Recieved Instruction to Activate Zone: ")); DEBUG_PRINTLN(i); } } startMillis = millis(); } else if (message.type == V_VAR1) { int variable1 = atoi(message.data);// RUN_ALL_ZONES time DEBUG_PRINT(F("Recieved variable1 valve:")); DEBUG_PRINT(i); DEBUG_PRINT(F(" = ")); DEBUG_PRINTLN(variable1); if (variable1 != allZoneTime[i]) { allZoneTime[i] = variable1; zoneTimeUpdate = true; } receivedInitialValue = true; } else if (message.type == V_VAR2) { int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time DEBUG_PRINT(F("Recieved variable2 valve:")); DEBUG_PRINT(i); DEBUG_PRINT(F(" = ")); DEBUG_PRINTLN(variable2); if (variable2 != valveSoloTime[i]) { valveSoloTime[i] = variable2; zoneTimeUpdate = true; } receivedInitialValue = true; } else if (message.type == V_VAR3) { String newMessage = String(message.data); if (newMessage.length() == 0) { DEBUG_PRINT(F("No Name Recieved for zone ")); DEBUG_PRINTLN(i); break; } if (newMessage.length() > 16) { newMessage.substring(0, 16); } valveNickName[i] = ""; valveNickName[i] += newMessage; DEBUG_PRINT(F("Recieved variable3 valve: ")); DEBUG_PRINT(i); DEBUG_PRINT(F(" = ")); DEBUG_PRINTLN(valveNickName[i]); } receivedInitialValue = true; } } if (zoneTimeUpdate) { // DEBUG_PRINTLN(F("New Zone Times Recieved...")); for (byte i = 0; i <= NUMBER_OF_VALVES; i++) { if (i != 0) { DEBUG_PRINT(F("Zone ")); DEBUG_PRINT(i); DEBUG_PRINT(F(" individual time: ")); DEBUG_PRINT(valveSoloTime[i]); DEBUG_PRINT(F(" group time: ")); DEBUG_PRINT(allZoneTime[i]); DEBUG_PRINT(F(" name: ")); DEBUG_PRINTLN(valveNickName[i]); recentUpdate = true; } } } else { recentUpdate = false; } } // void updateDisplay() { static unsigned long lastUpdateTime; static bool displayToggle = false; //static byte toggleCounter = 0; static SprinklerStates lastDisplayState; if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL) { displayToggle = !displayToggle; switch (state) { case STAND_BY_ALL_OFF: // fastClear(); lcd.setCursor(0, 0); if (displayToggle) { lcd.print(F(" System Ready ")); if (clockUpdating) { lcd.setCursor(15, 0); lcd.write(byte(0)); } lcd.setCursor(0, 1); lcd.print(hourFormat12() < 10 ? F(" ") : F("")); lcd.print(hourFormat12()); lcd.print(minute() < 10 ? F(":0") : F(":")); lcd.print(minute()); lcd.print(isAM() ? F("am") : F("pm")); lcd.print(month() < 10 ? F(" 0") : F(" ")); lcd.print(month()); lcd.print(day() < 10 ? F("/0") : F("/")); lcd.print(day()); lcd.print(F("/")); lcd.print(year() % 100); } else { lcd.print(F(" Last Watered ")); if (clockUpdating) { lcd.setCursor(15, 0); lcd.write(byte(0)); } lcd.setCursor(0, 1); lcd.print(dayOfWeek[weekday(lastTimeRun)]); lcd.setCursor(11, 1); lcd.print(month(lastTimeRun) < 10 ? F(" ") : F("")); lcd.print(month(lastTimeRun)); lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/")); lcd.print(day(lastTimeRun)); } break; case RUN_SINGLE_ZONE: // fastClear(); lcd.setCursor(0, 0); if (displayToggle) { lcd.print(F("Single Zone Mode")); lcd.setCursor(0, 1); lcd.print(F(" Zone:")); if (valveNumber < 10) lcd.print(F("0")); lcd.print(valveNumber); lcd.print(F(" Active")); } else { lcd.print(F(" Time Remaining ")); lcd.setCursor(0, 1); if (valveSoloTime[valveNumber] == 0) { lcd.print(F(" No Valve Time ")); } else { unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000); lcd.print(timeRemaining / 60 < 10 ? " 0" : " "); lcd.print(timeRemaining / 60); lcd.print("min"); lcd.print(timeRemaining % 60 < 10 ? " 0" : " "); lcd.print(timeRemaining % 60); lcd.print("sec "); } } break; case RUN_ALL_ZONES: // fastClear(); lcd.setCursor(0, 0); if (displayToggle) { lcd.print(F(" All-Zone Mode ")); lcd.setCursor(0, 1); lcd.print(F(" Zone:")); if (valveNumber < 10) lcd.print(F("0")); lcd.print(valveNumber); lcd.print(F(" Active ")); } else { lcd.print(F(" Time Remaining ")); lcd.setCursor(0, 1); int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000); lcd.print((timeRemaining / 60) < 10 ? " 0" : " "); lcd.print(timeRemaining / 60); lcd.print("min"); lcd.print(timeRemaining % 60 < 10 ? " 0" : " "); lcd.print(timeRemaining % 60); lcd.print("sec "); } break; case CYCLE_COMPLETE: // if (displayToggle) { lcd.setCursor(0, 0); lcd.print(F(" Watering Cycle ")); lcd.setCursor(0, 1); lcd.print(F(" Complete ")); } else { int totalTimeRan = 0; for (int i = 1; i < NUMBER_OF_VALVES + 1; i++) { totalTimeRan += allZoneTime[i]; } lcd.setCursor(0, 0); lcd.print(F(" Total Time Run ")); lcd.setCursor(0, 1); lcd.print(totalTimeRan < 10 ? " 0" : " "); lcd.print(totalTimeRan); lcd.print(" Minutes "); } default: // what of ZONE_SELECT_MENU? break; } lastUpdateTime = millis(); } lastDisplayState = state; } void receiveTime(time_t newTime) { DEBUG_PRINTLN(F("Time value received and updated...")); int lastSecond = second(); int lastMinute = minute(); int lastHour = hour(); setTime(newTime); if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime) { DEBUG_PRINTLN(F("Clock updated....")); DEBUG_PRINT(F("Sensor's time currently set to:")); DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" ")); DEBUG_PRINT(hourFormat12()); DEBUG_PRINT(minute() < 10 ? F(":0") : F(":")); DEBUG_PRINT(minute()); DEBUG_PRINTLN(isAM() ? F("am") : F("pm")); DEBUG_PRINT(month()); DEBUG_PRINT(F("/")); DEBUG_PRINT(day()); DEBUG_PRINT(F("/")); DEBUG_PRINTLN(year()); DEBUG_PRINTLN(dayOfWeek[weekday()]); showTime = false; } else { DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second.")); } clockUpdating = false; } void fastClear() { lcd.setCursor(0, 0); lcd.print(F(" ")); lcd.setCursor(0, 1); lcd.print(F(" ")); } // void updateClock() { static unsigned long lastVeraGetTime; if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour { DEBUG_PRINTLN(F("Requesting time and valve data from Gateway...")); lcd.setCursor(15, 0); lcd.write(byte(0)); clockUpdating = true; requestTime(); lastVeraGetTime = millis(); } } // void saveDateToEEPROM(unsigned long theDate) { DEBUG_PRINTLN(F("Saving Last Run date")); if (loadState(0) != 0xFF) { saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero) } // for (int i = 1; i < 5; i++) { saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one } } // void goGetValveTimes() { static unsigned long valveUpdateTime; static byte valveIndex = 1; if (inSetup || millis() - valveUpdateTime >= VALVE_TIMES_RELOAD / NUMBER_OF_VALVES) // update each valve once every 5 mins (distributes the traffic) { if (inSetup) { lcd.print(F(" Updating ")); lcd.setCursor(0, 1); lcd.print(F(" Valve Data: ")); lcd.print(valveIndex); } bool flashIcon = false; DEBUG_PRINT(F("Calling for Valve ")); DEBUG_PRINT(valveIndex); DEBUG_PRINTLN(F(" Data...")); for (int a = 0; a < (sizeof(allVars)/sizeof(int)); a++) { receivedInitialValue = false; byte timeout = 10; while (!receivedInitialValue && timeout > 0) { lcd.setCursor(15, 0); flashIcon = !flashIcon; flashIcon ? lcd.write(byte(1)) : lcd.print(F(" ")); request(valveIndex, allVars[a]); wait(50); timeout--; } } valveUpdateTime = millis(); valveIndex++; if (valveIndex > NUMBER_OF_VALVES) { valveIndex = 1; } } }As always, any help is appreciated.
@dbemowsk
I had this same issue. What I did to fix the issue was I commented out in the void loop the line to goGetValveTimes. I then added the timeAlarms library and set a timer to get valve times once every five minutes. The section of code looks like this.Alarm.timerRepeat (300,goGetValveTimes);
I inserted that line as the last line of cade in the void setup -
Okay, so I was just looking over the code. I first did a search for "Valve Data:" as that was what was showing on the screen. I found that in the goGetValveTimes() method. According to the code, that is only supposed to show if the inSetup variable evaluates to true. I then searched on that variable, and in the code just before the setup() method, I see this:
bool inSetup = true;But I don't see anywhere in the code where it sets that value to false. So every time the main loop() calls goGetValveTimes();, it is going to display that since inSetup never gets changed to false. At the very end of the setup routine I see this bit of code:
// //Update valve data when first powered on for (byte i = 1; i <= NUMBER_OF_VALVES; i++) { lcd.clear(); goGetValveTimes(); } lcd.clear();I think that it is just after that for loop, or after the lcd.clear(); that it is supposed to set inSetup to false. I have not tested this theory yet as I need to unmount my controller and open it up to push the new code to it, but I am pretty sure that this is the issue. That would explain why everything else with it appears to work normally.
I double checked with the example code on the build page to see if possibly I may have deleted something when doing my edits. Looking it over, I found the same thing. If you ask me, this looks to be a bug in the code and it should be fixed and updated.
-
Okay, so I was just looking over the code. I first did a search for "Valve Data:" as that was what was showing on the screen. I found that in the goGetValveTimes() method. According to the code, that is only supposed to show if the inSetup variable evaluates to true. I then searched on that variable, and in the code just before the setup() method, I see this:
bool inSetup = true;But I don't see anywhere in the code where it sets that value to false. So every time the main loop() calls goGetValveTimes();, it is going to display that since inSetup never gets changed to false. At the very end of the setup routine I see this bit of code:
// //Update valve data when first powered on for (byte i = 1; i <= NUMBER_OF_VALVES; i++) { lcd.clear(); goGetValveTimes(); } lcd.clear();I think that it is just after that for loop, or after the lcd.clear(); that it is supposed to set inSetup to false. I have not tested this theory yet as I need to unmount my controller and open it up to push the new code to it, but I am pretty sure that this is the issue. That would explain why everything else with it appears to work normally.
I double checked with the example code on the build page to see if possibly I may have deleted something when doing my edits. Looking it over, I found the same thing. If you ask me, this looks to be a bug in the code and it should be fixed and updated.
@dbemowsk
I am in front of my computer and I have my controller in front of me and hooked up. Give me a couple minutes and I will run it. See what happens. -
I just made the change and tested it. That was definitely the problem. Works perfect now.
Not sure who can change the example code, but all that needs to be added is this:
// //Update valve data when first powered on for (byte i = 1; i <= NUMBER_OF_VALVES; i++) { lcd.clear(); goGetValveTimes(); } lcd.clear(); //Add this line inSetup = false; -
I just made the change and tested it. That was definitely the problem. Works perfect now.
Not sure who can change the example code, but all that needs to be added is this:
// //Update valve data when first powered on for (byte i = 1; i <= NUMBER_OF_VALVES; i++) { lcd.clear(); goGetValveTimes(); } lcd.clear(); //Add this line inSetup = false;@dbemowsk
You beat me too it. I added the same line in same location and it works perfect. Every so often I see the raindrop icon to show that it is pulling data to update the valve times. -
So it is definitely a confirmed bug. I ended up finding some old sample code from when I started this last year and this bit of code was actually in the setup method and not in goGetValveTimes:
lcd.print(F(" Updating ")); lcd.setCursor(0, 1); lcd.print(F(" Valve Data: ")); lcd.print(valveIndex);So some time in the past year the sample code had been changed.
Vera Plus running UI7 with MySensors, Sonoffs and 1-Wire devices
Visit my website for more Bits, Bytes and Ramblings from me: http://dan.bemowski.info/ -
So it is definitely a confirmed bug. I ended up finding some old sample code from when I started this last year and this bit of code was actually in the setup method and not in goGetValveTimes:
lcd.print(F(" Updating ")); lcd.setCursor(0, 1); lcd.print(F(" Valve Data: ")); lcd.print(valveIndex);So some time in the past year the sample code had been changed.
-
Hi I just order all the parts that was listed. Do I need to read the 230 post or it's ok just watched the video.
@tombstone You shouldn't need to read all the posts. Maybe just search the thread if you run into any snags. What kind of setup are you dropping this into? Do you currently have valves installed? Does your setup have a master valve or pump relay? Is it a standard 24V AC system?
-
Its my 1st project and I have learnt alot but have got myself a snag and I am getting this....
Arduino: 1.8.3 (Windows 10), Board: "Arduino Pro or Pro Mini, ATmega328 (5V, 16 MHz)"
C:\Users\HTPC\Documents\Arduino\Irrigation_Controller_1\Irrigation_Controller_1..ino:82:21: fatal error: TimeLib.h: No such file or directory
#include <TimeLib.h>
^compilation terminated.
exit status 1
Error compiling for board Arduino Pro or Pro Mini.
