💬 Temperature Sensor

rejoe2

Very strange.
I just mad the test and copied the code (out of your post above) to my IDE, compiled and uploaded: No problem, worked fine. Node gets registered by FHEM, sends ID once and Temp regularly as expected. For testing, I used just one DS18B20, but that shouldn't make any difference. (And MySensors lib version 2.2-beta, but that also shouldn't be an issue).

Btw: what kind of a GW you are using?
Recently, I came across a situation with a WiFi-GW that absolutely refused to accept new nodes. Using a serial one, everything was fine... Strange thing, too. (The GW itself was ok, there were several other nodes working without any communication problems. the new HW was also ok. Last, the channel was also correct, as all the existing nodes just switched over to the serial GW.... Reflashing that nasty thing also was no solution.)

Dick

I put some deug lines i it and after uploadig the sketch it stops here (wait conversationtime.)
setup done.
2191 MCO:BGN:INIT OK,TSP=1
fetch sensors.
wait conversationtime.
fetch sensors.
wait conversationtime.
fetch sensors.
wait conversationtime.
fetch sensors.
wait conversationtime.
fetch sensors.
wait conversationtime.
fetch sensors.
wait conversationtime.
fetch sensors.
wait conversationtime.

mfalkvidd

@Dick could you try printing the value of numSensors in presentation()? (or in loop, it should have the same value there)

Dick

@mfalkvidd how can I manage that? sorr for the perhaps stupid qestion?

mfalkvidd

@Dick

Serial.print("Number of attached sensors found by the DallasTemperature library: ");
Serial.println(numSensors);

rejoe2

@Dick best place would be after numSensors = ... in presentation()

Just to mention that: The Arduino I used already had a node ID (I usually assign it manually). But your problem seems to be something completely different.

Dick

@mfalkvidd I tried it in Presentation() and in Loop() inboth no results in the log (copied it as you advised me how to do. so no result bisible). it is getting complex I think!
6 TSM:INIT
7 TSF:WUR:MS=0
14 TSM:INIT:TSP OK
16 TSF:SID:OK,ID=12
17 TSM:FPAR
59 TSF:MSG:SEND,12-12-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
452 TSF:MSG:READ,0-0-12,s=255,c=3,t=8,pt=1,l=1,sg=0:0
457 TSF:MSG:FPAR OK,ID=0,D=1
561 TSF:MSG:READ,20-20-12,s=255,c=3,t=8,pt=1,l=1,sg=0:1
2066 TSM:FPAR:OK
2067 TSM:ID
2068 TSM:ID:OK
2070 TSM:UPL
2074 TSF:MSG:SEND,12-12-0-0,s=255,c=3,t=24,pt=1,l=1,sg=0,ft=0,st=OK:1
2086 TSF:MSG:READ,0-0-12,s=255,c=3,t=25,pt=1,l=1,sg=0:1
2092 TSF:MSG:PONG RECV,HP=1
2094 TSM:UPL:OK
2096 TSM:READY:ID=12,PAR=0,DIS=1
2101 TSF:MSG:SEND,12-12-0-0,s=255,c=3,t=15,pt=6,l=2,sg=0,ft=0,st=OK:0100
2110 TSF:MSG:READ,0-0-12,s=255,c=3,t=15,pt=6,l=2,sg=0:0100
2118 TSF:MSG:SEND,12-12-0-0,s=255,c=0,t=18,pt=0,l=5,sg=0,ft=0,st=OK:2.1.1
2127 TSF:MSG:SEND,12-12-0-0,s=255,c=3,t=6,pt=1,l=1,sg=0,ft=0,st=OK:0
2142 TSF:MSG:READ,0-0-12,s=255,c=3,t=6,pt=0,l=1,sg=0:M
2151 TSF:MSG:SEND,12-12-0-0,s=255,c=3,t=11,pt=0,l=18,sg=0,ft=0,st=OK:Temperature Sensor
2161 TSF:MSG:SEND,12-12-0-0,s=255,c=3,t=12,pt=0,l=3,sg=0,ft=0,st=OK:1.2
2168 MCO:REG:REQ
2172 TSF:MSG:SEND,12-12-0-0,s=255,c=3,t=26,pt=1,l=1,sg=0,ft=0,st=OK:2
2181 TSF:MSG:READ,0-0-12,s=255,c=3,t=27,pt=1,l=1,sg=0:1
2186 MCO:PIM:NODE REG=1
2189 MCO:BGN:STP
setup done.
2190 MCO:BGN:INIT OK,TSP=1
fetch sensors.
wait conversationtime.
fetch sensors.
wait conversationtime.
fetch sensors.
wait conversationtime.

rejoe2

How are your sensors wired? Parasitic or 3 wires?
Sounds like a broken sensor, wrong wiring or a lot of sensors (to much for the pullup used).

mfalkvidd

Ok. I give up. If the node isn't executing the serial prints I know no way of troubleshooting.

Dick

@mfalkvidd I ony can tell "thanksfo the support ad you time" . Have a nice wekend!!!

skywatch

I have been frustrated with this for weeks now. Today I notice that void loop is not closed with a curly brace and if I add one it does not compile.
So what black magic is going on here?

I have been trying to get sensor readings every 2 mins and battery every half hour. But whatever I try it still gives temp every minute and battery at once a minute too. No wonder my batteries are draining so fast.

mfalkvidd

@skywatch the curly braces were discussed and explained earlier in this thread.

Could you post your sketch and the debug output of your node?

skywatch

@mfalkvidd

Thanks for fast reply! See code below. If you don't see problem there I will debug tomorrow. The battery time is set for 90sec to test, but is taking 18mins between sends!



// Enable debug prints to serial monitor
//#define MY_DEBUG

// Enable and select radio type attached
#define MY_RADIO_NRF24
//#define MY_RADIO_RFM69
#define COMPARE_TEMP 1 // Send temperature only if changed? 1 = Yes 0 = No
#define MY_RF24_PA_LEVEL (RF24_PA_LOW)
#define ONE_WIRE_BUS 3 // Pin where dallase sensor is connected 
#define MAX_ATTACHED_DS18B20 3
#include <SPI.h>
#include <MySensors.h>
#include <DallasTemperature.h>
#include <OneWire.h>
int BATTERY_SENSE_PIN = A0;  // select the input pin for the battery sense point
int batteryPcnt = 0;
unsigned long SLEEP_TIME = 117000; // Sleep time between reads (in milliseconds)
OneWire oneWire(ONE_WIRE_BUS); // Setup a oneWire instance to communicate with any OneWire devices (not just Maxim/Dallas temperature ICs)
DallasTemperature sensors(&oneWire); // Pass the oneWire reference to Dallas Temperature.
float lastTemperature[MAX_ATTACHED_DS18B20];
int numSensors = 0;
const long interval = 90000;
unsigned long previousMillis = 0;
bool receivedConfig = false;
bool metric = true;
// Initialize temperature message
MyMessage msg(0, V_TEMP);

void before()
{
  // Startup up the OneWire library
  sensors.begin();
}

void setup()
{
  // requestTemperatures() will not block current thread
  sensors.setWaitForConversion(false);
  analogReference(INTERNAL);
}

void presentation() {
  // Send the sketch version information to the gateway and Controller
  sendSketchInfo("HW/CH", "0.4");

  // Fetch the number of attached temperature sensors
  numSensors = sensors.getDeviceCount();

  // Present all sensors to controller
  for (int i = 0; i < numSensors && i < MAX_ATTACHED_DS18B20; i++) {
    present(i, S_TEMP);
  }
}

void loop()
{
  // get the battery Voltage
  unsigned long currentMillis = millis();

  if (currentMillis - previousMillis >= interval) {
    previousMillis = currentMillis;
    int sensorValue = analogRead(BATTERY_SENSE_PIN);
    batteryPcnt = sensorValue / 10;
    sendBatteryLevel(batteryPcnt);
  }

  // Fetch temperatures from Dallas sensors
  sensors.requestTemperatures();

  // query conversion time and sleep until conversion completed
  int16_t conversionTime = sensors.millisToWaitForConversion(sensors.getResolution());
  // sleep() call can be replaced by wait() call if node need to process incoming messages (or if node is repeater)
  sleep(conversionTime);

  // Read temperatures and send them to controller
  for (int i = 0; i < numSensors && i < MAX_ATTACHED_DS18B20; i++) {

    // Fetch and round temperature to one decimal
    float temperature = static_cast<float>(static_cast<int>((getControllerConfig().isMetric ? sensors.getTempCByIndex(i) : sensors.getTempFByIndex(i)) * 10.)) / 10.;

    // Only send data if temperature has changed and no error
#if COMPARE_TEMP == 1
    if (lastTemperature[i] != temperature && temperature != -127.00 && temperature != 85.00) {
#else
    if (temperature != -127.00 && temperature != 85.00) {
#endif

      // Send in the new temperature
      send(msg.setSensor(i).set(temperature, 1));
      // Save new temperatures for next compare
      lastTemperature[i] = temperature;
    }
  }

  int8_t sleep(1, FALLING, SLEEP_TIME);
}```

mfalkvidd

@skywatch doing what you want is a bit hard since millis won't update while the node is in power save mode (sleeping). But this should do it:
set SLEEP_TIME = 2 * 60 * 1000 // 2 minutes
and change

void loop()
{
  // get the battery Voltage
  unsigned long currentMillis = millis();

  if (currentMillis - previousMillis >= interval) {
    previousMillis = currentMillis;
    int sensorValue = analogRead(BATTERY_SENSE_PIN);
    batteryPcnt = sensorValue / 10;
    sendBatteryLevel(batteryPcnt);
  }
...

to

unsigned int batteryReportFactor = 30*60*1000ul/SLEEP_TIME; // Only report battery every x SLEEP times (x=15 with current values)
unsigned int timesSlept = 0;
void loop()
{
  if (timesSlept < batteryReportFactor) {
    timesSlept++;
  } else {
    // get the battery Voltage
    timesSlept = 0;
    int sensorValue = analogRead(BATTERY_SENSE_PIN);
    batteryPcnt = sensorValue / 10;
    sendBatteryLevel(batteryPcnt);
  }
...

I don't understand why you're using interrupt to sleep though.

skywatch

@mfalkvidd said in 💬 Temperature Sensor:
Thank you very much for helping out with this! - I will try it today if I can. I guess I could use the same principle to send sensor data every 2 minutes instead of every 1 minute and further reduce battery draw. I know the DS18B20 sensors are correctly going into sleep mode, but the node itself is still using too much juice.

@skywatch doing what you want is a bit hard since millis won't update while the node is in power save mode (sleeping).

There is nothing in the API about this, would be nice if it were added as I don't think I will be the only person with such requirements. Also, what does sleep actually do and are there further things I could do to reduce the power use?

I don't understand why you're using interrupt to sleep though.

That is because I haven't finished this node yet.... I am working on it systematically and in future a water leak detector will be added. But only when this part is working correctly and I have good battery life from the node.

mfalkvidd

@skywatch said in 💬 Temperature Sensor:

There is nothing in the API about this, would be nice if it were added as I don't think I will be the only person with such requirements.

Good point. I have added a note on https://www.mysensors.org/download/sensor_api_20#sleeping

Also, what does sleep actually do and are there further things I could do to reduce the power use?

It does a lot of things, but basically it puts the radio and the Arduino in power save mode and uses the Arduino's watchdog timer to roughly keep track of time (exact timing is not possible because exact timing requires power, and power save mode is all about saving power).

https://www.mysensors.org/build/battery has the official MySensors recommendations on how to save power in battery-operated nodes.

If you want to dive deeper, start with https://www.gammon.com.au/power

gohan

I'd use the sleep time to 2 minutes and then simply set a counter that every 15 loops of the code sends battery status and resets the counter. Imho 2 minutes are quite often for battery life.

mfalkvidd

@gohan wasn't that what I did?

skywatch

This can't be right, can it???

(http://imagebucket.net/7mtp8rcnqss2/BattGraph.jpg)

gohan

@mfalkvidd I'm on mobile, I didn't read the code 😇

💬 Temperature Sensor

23

11.7k

11.2k

113.1k