Skip to content
  • MySensors
  • OpenHardware.io
  • Categories
  • Recent
  • Tags
  • Popular
Skins
  • Light
  • Brite
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Brand Logo
  1. Home
  2. Troubleshooting
  3. Combining relay and temperature sketch

Combining relay and temperature sketch

Scheduled Pinned Locked Moved Troubleshooting
76 Posts 9 Posters 14.2k Views 12 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • Tim76T Tim76

    @gohan no I didn't...

      // Present all sensors to controller
      for (int i=17; i<numSensors && i<MAX_ATTACHED_DS18B20; i++) {   
         present(i, S_TEMP);
      }
      for (int sensor=1, pin=RELAY_1; sensor<=NUMBER_OF_RELAYS; sensor++, pin++) {
        // Then set relay pins in output mode
        pinMode(pin, OUTPUT);
        // Set relay to last known state (using eeprom storage)
        digitalWrite(pin, loadState(sensor)?RELAY_ON:RELAY_OFF);
      }
    }```
    Tim76T Offline
    Tim76T Offline
    Tim76
    wrote on last edited by
    #27

    @gohan seems like it's early for both of us.....;-)

    1 Reply Last reply
    0
    • gohanG Offline
      gohanG Offline
      gohan
      Mod
      wrote on last edited by
      #28

      you only have present(i, S_TEMP) but you also need to add present(sensor, S_BINARY) in the relay section otherwise you will not present any relay at all.

      Tim76T 2 Replies Last reply
      0
      • gohanG gohan

        you only have present(i, S_TEMP) but you also need to add present(sensor, S_BINARY) in the relay section otherwise you will not present any relay at all.

        Tim76T Offline
        Tim76T Offline
        Tim76
        wrote on last edited by
        #29

        @gohan 😳😳😳 seems like it's only early for one of us...... I,ll change it later today.....

        1 Reply Last reply
        0
        • gohanG gohan

          you only have present(i, S_TEMP) but you also need to add present(sensor, S_BINARY) in the relay section otherwise you will not present any relay at all.

          Tim76T Offline
          Tim76T Offline
          Tim76
          wrote on last edited by
          #30

          @gohan so I fixed that....... and now I get this in Domoticz....

          0 Unknown! #1. V_TEMP (20.7) true 2017-05-10 11:44:39
          1 S_LIGHT/S_BINARY #1. V_TEMP (20.7) true 2017-05-10 11:44:43
          2 S_LIGHT/S_BINARY #1. V_TEMP (20.9) true 2017-05-10 11:44:04
          3 S_LIGHT/S_BINARY true 2017-05-10 11:34:13
          4 S_LIGHT/S_BINARY true 2017-05-10 11:34:14
          5 S_LIGHT/S_BINARY true 2017-05-10 11:34:15
          6 S_LIGHT/S_BINARY true 2017-05-10 11:34:15
          7 S_LIGHT/S_BINARY true 2017-05-10 11:34:16
          8 S_LIGHT/S_BINARY true 2017-05-10 11:34:17
          9 S_LIGHT/S_BINARY true 2017-05-10 11:34:17
          10 S_LIGHT/S_BINARY true 2017-05-10 11:34:18
          11 S_LIGHT/S_BINARY true 2017-05-10 11:34:18
          12 S_LIGHT/S_BINARY true 2017-05-10 11:34:19
          13 S_LIGHT/S_BINARY true 2017-05-10 11:34:19
          14 S_LIGHT/S_BINARY true 2017-05-10 11:34:20
          15 S_LIGHT/S_BINARY true 2017-05-10 11:34:20
          16 S_LIGHT/S_BINARY true 2017-05-10 11:34:21
          17 S_TEMP true 2017-05-10 11:34:12
          18 S_TEMP true 2017-05-10 11:34:12
          255 S_ARDUINO_NODE 2.1.1 false 2017-05-10 11:34:12

          so it seems I do get temp Id's from 17 to 32, but the values stay in 0,1,2 where the relays 1 and 2 don't work.....

          1 Reply Last reply
          0
          • gohanG Offline
            gohanG Offline
            gohan
            Mod
            wrote on last edited by gohan
            #31

            There must be a bug in the relay section, I can't check it today, I'm out all day.
            Try to add some debug serial print to see what values are being exchanged

            Tim76T 1 Reply Last reply
            0
            • gohanG gohan

              There must be a bug in the relay section, I can't check it today, I'm out all day.
              Try to add some debug serial print to see what values are being exchanged

              Tim76T Offline
              Tim76T Offline
              Tim76
              wrote on last edited by
              #32

              @gohan output of the serial port

              0 MCO:BGN:INIT NODE,CP=RNNNA--,VER=2.1.1
              3 MCO:BGN:BFR
              144 TSM:INIT
              145 TSF:WUR:MS=0
              153 TSM:INIT:TSP OK
              154 TSM:INIT:STATID=51
              157 TSF:SID:OK,ID=51
              158 TSM:FPAR
              195 TSF:MSG:SEND,51-51-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
              986 TSF:MSG:READ,0-0-51,s=255,c=3,t=8,pt=1,l=1,sg=0:0
              990 TSF:MSG:FPAR OK,ID=0,D=1
              2202 TSM:FPAR:OK
              2203 TSM:ID
              2204 TSM:ID:OK
              2206 TSM:UPL
              2211 TSF:MSG:SEND,51-51-0-0,s=255,c=3,t=24,pt=1,l=1,sg=0,ft=0,st=OK:1
              2232 TSF:MSG:READ,0-0-51,s=255,c=3,t=25,pt=1,l=1,sg=0:1
              2237 TSF:MSG:PONG RECV,HP=1
              2240 TSM:UPL:OK
              2241 TSM:READY:ID=51,PAR=0,DIS=1
              2246 TSF:MSG:SEND,51-51-0-0,s=255,c=3,t=15,pt=6,l=2,sg=0,ft=0,st=OK:0100
              2284 TSF:MSG:READ,0-0-51,s=255,c=3,t=15,pt=6,l=2,sg=0:0100
              2291 TSF:MSG:SEND,51-51-0-0,s=255,c=0,t=17,pt=0,l=5,sg=0,ft=0,st=OK:2.1.1
              2301 TSF:MSG:SEND,51-51-0-0,s=255,c=3,t=6,pt=1,l=1,sg=0,ft=0,st=OK:0
              4329 TSF:MSG:SEND,51-51-0-0,s=255,c=3,t=11,pt=0,l=25,sg=0,ft=0,st=OK:Greenhouse main controlle
              4340 TSF:MSG:SEND,51-51-0-0,s=255,c=3,t=12,pt=0,l=3,sg=0,ft=0,st=OK:1.0
              4350 TSF:MSG:SEND,51-51-0-0,s=17,c=0,t=6,pt=0,l=0,sg=0,ft=0,st=OK:
              4359 TSF:MSG:SEND,51-51-0-0,s=18,c=0,t=6,pt=0,l=0,sg=0,ft=0,st=OK:
              4369 TSF:MSG:SEND,51-51-0-0,s=1,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4376 TSF:MSG:SEND,51-51-0-0,s=2,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4384 TSF:MSG:SEND,51-51-0-0,s=3,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4397 TSF:MSG:SEND,51-51-0-0,s=4,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4407 TSF:MSG:SEND,51-51-0-0,s=5,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4418 TSF:MSG:SEND,51-51-0-0,s=6,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4434 TSF:MSG:SEND,51-51-0-0,s=7,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4449 TSF:MSG:SEND,51-51-0-0,s=8,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4459 TSF:MSG:SEND,51-51-0-0,s=9,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4489 TSF:MSG:SEND,51-51-0-0,s=10,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4505 TSF:MSG:SEND,51-51-0-0,s=11,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4515 TSF:MSG:SEND,51-51-0-0,s=12,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4528 TSF:MSG:SEND,51-51-0-0,s=13,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4540 TSF:MSG:SEND,51-51-0-0,s=14,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4556 TSF:MSG:SEND,51-51-0-0,s=15,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4564 TSF:MSG:SEND,51-51-0-0,s=16,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
              4571 MCO:REG:REQ
              4576 TSF:MSG:SEND,51-51-0-0,s=255,c=3,t=26,pt=1,l=1,sg=0,ft=0,st=OK:2
              4583 TSF:MSG:READ,0-0-51,s=255,c=3,t=27,pt=1,l=1,sg=0:1
              4588 MCO:PIM:NODE REG=1
              4590 MCO:BGN:STP
              4591 MCO:BGN:INIT OK,TSP=1
              4596 MCO:SLP:MS=750,SMS=0,I1=255,M1=255,I2=255,M2=255
              4601 MCO:SLP:TPD
              4602 MCO:SLP:WUP=-1
              4636 TSF:MSG:SEND,51-51-0-0,s=0,c=1,t=0,pt=7,l=5,sg=0,ft=0,st=OK:20.2
              4690 TSF:MSG:SEND,51-51-0-0,s=1,c=1,t=0,pt=7,l=5,sg=0,ft=0,st=OK:20.5
              4755 TSF:MSG:SEND,51-51-0-0,s=2,c=1,t=0,pt=7,l=5,sg=0,ft=0,st=OK:20.4
              7763 MCO:SLP:MS=750,SMS=0,I1=255,M1=255,I2=255,M2=255
              7768 MCO:SLP:TPD
              7770 MCO:SLP:WUP=-1
              10898 MCO:SLP:MS=750,SMS=0,I1=255,M1=255,I2=255,M2=255
              10902 MCO:SLP:TPD
              10904 MCO:SLP:WUP=-1

              1 Reply Last reply
              0
              • gohanG Offline
                gohanG Offline
                gohan
                Mod
                wrote on last edited by
                #33

                I'm talking about adding code to your sketch so that it prints in serial monitor the values before they are sent for presentations and you debug from those, I can't debug it for you from here 😀

                Tim76T 1 Reply Last reply
                0
                • gohanG gohan

                  I'm talking about adding code to your sketch so that it prints in serial monitor the values before they are sent for presentations and you debug from those, I can't debug it for you from here 😀

                  Tim76T Offline
                  Tim76T Offline
                  Tim76
                  wrote on last edited by
                  #34

                  @gohan oh.... ok..... pretty new at coding, but I guess you allready figured that out.....;-)

                  1 Reply Last reply
                  0
                  • gohanG Offline
                    gohanG Offline
                    gohan
                    Mod
                    wrote on last edited by
                    #35

                    No problem, it's normal, everybody started from being new at coding.
                    For debugging add only 1 or 2 temp sensors and same for relays, work it out simple and then add more

                    Tim76T 1 Reply Last reply
                    0
                    • gohanG gohan

                      No problem, it's normal, everybody started from being new at coding.
                      For debugging add only 1 or 2 temp sensors and same for relays, work it out simple and then add more

                      Tim76T Offline
                      Tim76T Offline
                      Tim76
                      wrote on last edited by
                      #36

                      @gohan hey Gohan,
                      I will not be able to continue to work on my code till after the weekend....😑

                      1 Reply Last reply
                      0
                      • gohanG Offline
                        gohanG Offline
                        gohan
                        Mod
                        wrote on last edited by
                        #37

                        No problem, I'm here anyway 😀

                        Tim76T 1 Reply Last reply
                        0
                        • gohanG gohan

                          No problem, I'm here anyway 😀

                          Tim76T Offline
                          Tim76T Offline
                          Tim76
                          wrote on last edited by
                          #38

                          @gohan
                          Due to work related schedule problems I won't be able to work on this code for a few weeks...... :angry:

                          1 Reply Last reply
                          0
                          • N Offline
                            N Offline
                            Newzwaver
                            wrote on last edited by
                            #39

                            Did you get this working and if so can you share?

                            B 1 Reply Last reply
                            1
                            • N Newzwaver

                              Did you get this working and if so can you share?

                              B Offline
                              B Offline
                              bluezr1
                              wrote on last edited by
                              #40

                              @newzwaver I'm curious aswell, been pounding my head all night trying to get a temperature and relay into one sketch.

                              1 Reply Last reply
                              0
                              • N Offline
                                N Offline
                                Newzwaver
                                wrote on last edited by
                                #41

                                HI

                                I did get it to work and will post the sketch later today after work. I have it working on the ESP8266 and Arduino.

                                1 Reply Last reply
                                0
                                • N Offline
                                  N Offline
                                  Newzwaver
                                  wrote on last edited by gohan
                                  #42

                                  I figured why wait, this has the temp, hum and 2 relays working not problem. One relay controls my fan for my AV and the other controls my doorbell for my HTD Lync system.

                                  /**
                                   * The MySensors Arduino library handles the wireless radio link and protocol
                                   * between your home built sensors/actuators and HA controller of choice.
                                   * The sensors forms a self healing radio network with optional repeaters. Each
                                   * repeater and gateway builds a routing tables in EEPROM which keeps track of the
                                   * network topology allowing messages to be routed to nodes.
                                   *
                                   * Created by Henrik Ekblad <henrik.ekblad@mysensors.org>
                                   * Copyright (C) 2013-2015 Sensnology AB
                                   * Full contributor list: https://github.com/mysensors/Arduino/graphs/contributors
                                   *
                                   * Documentation: http://www.mysensors.org
                                   * Support Forum: http://forum.mysensors.org
                                   *
                                   * This program is free software; you can redistribute it and/or
                                   * modify it under the terms of the GNU General Public License
                                   * version 2 as published by the Free Software Foundation.
                                   *
                                   *******************************
                                   *
                                   * REVISION HISTORY
                                   * Version 1.0: Henrik EKblad
                                   * Version 1.1 - 2016-07-20: Converted to MySensors v2.0 and added various improvements - Torben Woltjen (mozzbozz)
                                   * 
                                   * DESCRIPTION
                                   * This sketch provides an example of how to implement a humidity/temperature
                                   * sensor using a DHT11/DHT-22.
                                   *  
                                   * For more information, please visit:
                                   * http://www.mysensors.org/build/humidity
                                   * 
                                   */
                                  
                                  // Enable debug prints
                                  #define MY_DEBUG
                                  #define MY_NODE_ID 29
                                  // Enable and select radio type attached 
                                  #define MY_RADIO_NRF24
                                  //#define MY_RADIO_RFM69
                                  //#define MY_RS485
                                  
                                  // Enable repeater functionality for this node
                                  #define MY_REPEATER_FEATURE
                                  
                                  
                                  #include <SPI.h>
                                  #include <MySensors.h>  
                                  #include <DHT.h>
                                  
                                    
                                  // Set this to the pin you connected the DHT's data pin to
                                  #define DHT_DATA_PIN 3
                                  
                                  #define RELAY_1  4  // Arduino Digital I/O pin number for first relay (second on pin+1 etc)
                                  #define RELAY_2  5  // Arduino Digital I/O pin number for first relay (second on pin+1 etc)
                                  
                                  #define NUMBER_OF_RELAYS 2 // Total number of attached relays
                                  #define RELAY_ON 1  // GPIO value to write to turn on attached relay
                                  #define RELAY_OFF 0 // GPIO value to write to turn off attached relay
                                  
                                  // Set this offset if the sensor has a permanent small offset to the real temperatures
                                  #define SENSOR_TEMP_OFFSET 0
                                  
                                  // Sleep time between sensor updates (in milliseconds)
                                  // Must be >1000ms for DHT22 and >2000ms for DHT11
                                  static const uint64_t UPDATE_INTERVAL = 60000;
                                  
                                  // Force sending an update of the temperature after n sensor reads, so a controller showing the
                                  // timestamp of the last update doesn't show something like 3 hours in the unlikely case, that
                                  // the value didn't change since;
                                  // i.e. the sensor would force sending an update every UPDATE_INTERVAL*FORCE_UPDATE_N_READS [ms]
                                  static const uint8_t FORCE_UPDATE_N_READS = 10;
                                  
                                  #define CHILD_ID_HUM 28
                                  #define CHILD_ID_TEMP 30
                                  
                                  float lastTemp;
                                  float lastHum;
                                  uint8_t nNoUpdatesTemp;
                                  uint8_t nNoUpdatesHum;
                                  bool metric = true;
                                  
                                  MyMessage msgHum(CHILD_ID_HUM, V_HUM);
                                  MyMessage msgTemp(CHILD_ID_TEMP, V_TEMP);
                                  DHT dht;
                                  void before()
                                  {
                                    for (int sensor=1, pin=RELAY_1; sensor<=NUMBER_OF_RELAYS; sensor++, pin++) {
                                      // Then set relay pins in output mode
                                      pinMode(pin, OUTPUT);
                                      // Set relay to last known state (using eeprom storage)
                                      digitalWrite(pin, loadState(sensor)?RELAY_ON:RELAY_OFF);
                                    }
                                  }
                                  
                                  void presentation()  
                                  { 
                                    // Send the sketch version information to the gateway
                                    sendSketchInfo("AVCABRelayTempAndHumidity", "1.1");
                                  
                                    // Register all sensors to gw (they will be created as child devices)
                                    present(CHILD_ID_HUM, S_HUM);
                                    present(CHILD_ID_TEMP, S_TEMP);
                                  
                                    metric = getControllerConfig().isMetric;
                                  }
                                  
                                  
                                  void setup()
                                  {
                                    dht.setup(DHT_DATA_PIN); // set data pin of DHT sensor
                                    if (UPDATE_INTERVAL <= dht.getMinimumSamplingPeriod()) {
                                      Serial.println("Warning: UPDATE_INTERVAL is smaller than supported by the sensor!");
                                    }
                                    // Sleep for the time of the minimum sampling period to give the sensor time to power up
                                    // (otherwise, timeout errors might occure for the first reading)
                                    sleep(dht.getMinimumSamplingPeriod());
                                  }
                                  
                                  
                                  void receive(const MyMessage &message)     
                                  {  
                                    // Force reading sensor, so it works also after sleep()
                                    dht.readSensor(true);
                                  
                                    // Get temperature from DHT library
                                    float temperature = dht.getTemperature();
                                    if (isnan(temperature)) {
                                      Serial.println("Failed reading temperature from DHT!");
                                    } else if (temperature != lastTemp || nNoUpdatesTemp == FORCE_UPDATE_N_READS) {
                                      // Only send temperature if it changed since the last measurement or if we didn't send an update for n times
                                      lastTemp = temperature;
                                      if (!metric) {
                                        temperature = dht.toFahrenheit(temperature);
                                      }
                                      // Reset no updates counter
                                      nNoUpdatesTemp = 0;
                                      temperature += SENSOR_TEMP_OFFSET;
                                      send(msgTemp.set(temperature, 1));
                                  
                                      #ifdef MY_DEBUG
                                      Serial.print("T: ");
                                      Serial.println(temperature);
                                      #endif
                                    } else {
                                      // Increase no update counter if the temperature stayed the same
                                      nNoUpdatesTemp++;
                                    }
                                  
                                    // Get humidity from DHT library
                                    float humidity = dht.getHumidity();
                                    if (isnan(humidity)) {
                                      Serial.println("Failed reading humidity from DHT");
                                    } else if (humidity != lastHum || nNoUpdatesHum == FORCE_UPDATE_N_READS) {
                                      // Only send humidity if it changed since the last measurement or if we didn't send an update for n times
                                      lastHum = humidity;
                                      // Reset no updates counter
                                      nNoUpdatesHum = 0;
                                      send(msgHum.set(humidity, 1));
                                    if (message.type==V_STATUS) {
                                  
                                      // Change relay state
                                      digitalWrite(message.sensor-1+RELAY_1, message.getBool()?RELAY_ON:RELAY_OFF);
                                      // Store state in eeprom
                                      saveState(message.sensor, message.getBool());
                                      #ifdef MY_DEBUG
                                      Serial.print("H: ");
                                      Serial.println(humidity);
                                      Serial.print("Incoming change for sensor:");
                                      Serial.print(message.sensor);
                                      Serial.print(", New status: ");
                                      Serial.println(message.getBool());
                                      #endif
                                    } else {
                                      // Increase no update counter if the humidity stayed the same
                                      nNoUpdatesHum++;
                                    }
                                  
                                    // Sleep for a while to save energy
                                    sleep(UPDATE_INTERVAL); 
                                    }}
                                  
                                  rejoe2R 1 Reply Last reply
                                  1
                                  • N Newzwaver

                                    I figured why wait, this has the temp, hum and 2 relays working not problem. One relay controls my fan for my AV and the other controls my doorbell for my HTD Lync system.

                                    /**
                                     * The MySensors Arduino library handles the wireless radio link and protocol
                                     * between your home built sensors/actuators and HA controller of choice.
                                     * The sensors forms a self healing radio network with optional repeaters. Each
                                     * repeater and gateway builds a routing tables in EEPROM which keeps track of the
                                     * network topology allowing messages to be routed to nodes.
                                     *
                                     * Created by Henrik Ekblad <henrik.ekblad@mysensors.org>
                                     * Copyright (C) 2013-2015 Sensnology AB
                                     * Full contributor list: https://github.com/mysensors/Arduino/graphs/contributors
                                     *
                                     * Documentation: http://www.mysensors.org
                                     * Support Forum: http://forum.mysensors.org
                                     *
                                     * This program is free software; you can redistribute it and/or
                                     * modify it under the terms of the GNU General Public License
                                     * version 2 as published by the Free Software Foundation.
                                     *
                                     *******************************
                                     *
                                     * REVISION HISTORY
                                     * Version 1.0: Henrik EKblad
                                     * Version 1.1 - 2016-07-20: Converted to MySensors v2.0 and added various improvements - Torben Woltjen (mozzbozz)
                                     * 
                                     * DESCRIPTION
                                     * This sketch provides an example of how to implement a humidity/temperature
                                     * sensor using a DHT11/DHT-22.
                                     *  
                                     * For more information, please visit:
                                     * http://www.mysensors.org/build/humidity
                                     * 
                                     */
                                    
                                    // Enable debug prints
                                    #define MY_DEBUG
                                    #define MY_NODE_ID 29
                                    // Enable and select radio type attached 
                                    #define MY_RADIO_NRF24
                                    //#define MY_RADIO_RFM69
                                    //#define MY_RS485
                                    
                                    // Enable repeater functionality for this node
                                    #define MY_REPEATER_FEATURE
                                    
                                    
                                    #include <SPI.h>
                                    #include <MySensors.h>  
                                    #include <DHT.h>
                                    
                                      
                                    // Set this to the pin you connected the DHT's data pin to
                                    #define DHT_DATA_PIN 3
                                    
                                    #define RELAY_1  4  // Arduino Digital I/O pin number for first relay (second on pin+1 etc)
                                    #define RELAY_2  5  // Arduino Digital I/O pin number for first relay (second on pin+1 etc)
                                    
                                    #define NUMBER_OF_RELAYS 2 // Total number of attached relays
                                    #define RELAY_ON 1  // GPIO value to write to turn on attached relay
                                    #define RELAY_OFF 0 // GPIO value to write to turn off attached relay
                                    
                                    // Set this offset if the sensor has a permanent small offset to the real temperatures
                                    #define SENSOR_TEMP_OFFSET 0
                                    
                                    // Sleep time between sensor updates (in milliseconds)
                                    // Must be >1000ms for DHT22 and >2000ms for DHT11
                                    static const uint64_t UPDATE_INTERVAL = 60000;
                                    
                                    // Force sending an update of the temperature after n sensor reads, so a controller showing the
                                    // timestamp of the last update doesn't show something like 3 hours in the unlikely case, that
                                    // the value didn't change since;
                                    // i.e. the sensor would force sending an update every UPDATE_INTERVAL*FORCE_UPDATE_N_READS [ms]
                                    static const uint8_t FORCE_UPDATE_N_READS = 10;
                                    
                                    #define CHILD_ID_HUM 28
                                    #define CHILD_ID_TEMP 30
                                    
                                    float lastTemp;
                                    float lastHum;
                                    uint8_t nNoUpdatesTemp;
                                    uint8_t nNoUpdatesHum;
                                    bool metric = true;
                                    
                                    MyMessage msgHum(CHILD_ID_HUM, V_HUM);
                                    MyMessage msgTemp(CHILD_ID_TEMP, V_TEMP);
                                    DHT dht;
                                    void before()
                                    {
                                      for (int sensor=1, pin=RELAY_1; sensor<=NUMBER_OF_RELAYS; sensor++, pin++) {
                                        // Then set relay pins in output mode
                                        pinMode(pin, OUTPUT);
                                        // Set relay to last known state (using eeprom storage)
                                        digitalWrite(pin, loadState(sensor)?RELAY_ON:RELAY_OFF);
                                      }
                                    }
                                    
                                    void presentation()  
                                    { 
                                      // Send the sketch version information to the gateway
                                      sendSketchInfo("AVCABRelayTempAndHumidity", "1.1");
                                    
                                      // Register all sensors to gw (they will be created as child devices)
                                      present(CHILD_ID_HUM, S_HUM);
                                      present(CHILD_ID_TEMP, S_TEMP);
                                    
                                      metric = getControllerConfig().isMetric;
                                    }
                                    
                                    
                                    void setup()
                                    {
                                      dht.setup(DHT_DATA_PIN); // set data pin of DHT sensor
                                      if (UPDATE_INTERVAL <= dht.getMinimumSamplingPeriod()) {
                                        Serial.println("Warning: UPDATE_INTERVAL is smaller than supported by the sensor!");
                                      }
                                      // Sleep for the time of the minimum sampling period to give the sensor time to power up
                                      // (otherwise, timeout errors might occure for the first reading)
                                      sleep(dht.getMinimumSamplingPeriod());
                                    }
                                    
                                    
                                    void receive(const MyMessage &message)     
                                    {  
                                      // Force reading sensor, so it works also after sleep()
                                      dht.readSensor(true);
                                    
                                      // Get temperature from DHT library
                                      float temperature = dht.getTemperature();
                                      if (isnan(temperature)) {
                                        Serial.println("Failed reading temperature from DHT!");
                                      } else if (temperature != lastTemp || nNoUpdatesTemp == FORCE_UPDATE_N_READS) {
                                        // Only send temperature if it changed since the last measurement or if we didn't send an update for n times
                                        lastTemp = temperature;
                                        if (!metric) {
                                          temperature = dht.toFahrenheit(temperature);
                                        }
                                        // Reset no updates counter
                                        nNoUpdatesTemp = 0;
                                        temperature += SENSOR_TEMP_OFFSET;
                                        send(msgTemp.set(temperature, 1));
                                    
                                        #ifdef MY_DEBUG
                                        Serial.print("T: ");
                                        Serial.println(temperature);
                                        #endif
                                      } else {
                                        // Increase no update counter if the temperature stayed the same
                                        nNoUpdatesTemp++;
                                      }
                                    
                                      // Get humidity from DHT library
                                      float humidity = dht.getHumidity();
                                      if (isnan(humidity)) {
                                        Serial.println("Failed reading humidity from DHT");
                                      } else if (humidity != lastHum || nNoUpdatesHum == FORCE_UPDATE_N_READS) {
                                        // Only send humidity if it changed since the last measurement or if we didn't send an update for n times
                                        lastHum = humidity;
                                        // Reset no updates counter
                                        nNoUpdatesHum = 0;
                                        send(msgHum.set(humidity, 1));
                                      if (message.type==V_STATUS) {
                                    
                                        // Change relay state
                                        digitalWrite(message.sensor-1+RELAY_1, message.getBool()?RELAY_ON:RELAY_OFF);
                                        // Store state in eeprom
                                        saveState(message.sensor, message.getBool());
                                        #ifdef MY_DEBUG
                                        Serial.print("H: ");
                                        Serial.println(humidity);
                                        Serial.print("Incoming change for sensor:");
                                        Serial.print(message.sensor);
                                        Serial.print(", New status: ");
                                        Serial.println(message.getBool());
                                        #endif
                                      } else {
                                        // Increase no update counter if the humidity stayed the same
                                        nNoUpdatesHum++;
                                      }
                                    
                                      // Sleep for a while to save energy
                                      sleep(UPDATE_INTERVAL); 
                                      }}
                                    
                                    rejoe2R Offline
                                    rejoe2R Offline
                                    rejoe2
                                    wrote on last edited by
                                    #43

                                    @newzwaver your code is pretty hard to read due to not beeing entirely formatted as code.
                                    Nevertheless there seems not to exist any loop() section and the node is put to sleep after having received anything for a certain periode of time.
                                    This may work in most cases, but imo is not a "lucky code design".

                                    Imo better aproach:
                                    Use the https://www.arduino.cc/en/tutorial/BlinkWithoutDelay - principle. Additionally a wait() is used instead of sleep() for the time to fulfill measurements (DS18B20 in my case).
                                    If you need a working implementation of the blink-without-delay function within MySensors, see the https://www.mysensors.org/build/pulse_power example.
                                    At least three of my nodes (combining temperature and relays) work pretty well like that.

                                    Controller: FHEM; MySensors: 2.3.1, RS485,nRF24,RFM69, serial Gateways

                                    B 1 Reply Last reply
                                    1
                                    • rejoe2R rejoe2

                                      @newzwaver your code is pretty hard to read due to not beeing entirely formatted as code.
                                      Nevertheless there seems not to exist any loop() section and the node is put to sleep after having received anything for a certain periode of time.
                                      This may work in most cases, but imo is not a "lucky code design".

                                      Imo better aproach:
                                      Use the https://www.arduino.cc/en/tutorial/BlinkWithoutDelay - principle. Additionally a wait() is used instead of sleep() for the time to fulfill measurements (DS18B20 in my case).
                                      If you need a working implementation of the blink-without-delay function within MySensors, see the https://www.mysensors.org/build/pulse_power example.
                                      At least three of my nodes (combining temperature and relays) work pretty well like that.

                                      B Offline
                                      B Offline
                                      bluezr1
                                      wrote on last edited by bluezr1
                                      #44

                                      @rejoe2 said in Combining relay and temperature sketch:

                                      Thanks Newzwaver

                                      You wouldn't happen to have a sketch with the DS18B20? I have both DHTs and DS18B20s but plan on using this to turn on and off a fan to keep my AV equipment cool. So I'm not that concerned about humidity although it wouldn't be deal breaker if it did.

                                      Thanks,

                                      rejoe2R 1 Reply Last reply
                                      0
                                      • B bluezr1

                                        @rejoe2 said in Combining relay and temperature sketch:

                                        Thanks Newzwaver

                                        You wouldn't happen to have a sketch with the DS18B20? I have both DHTs and DS18B20s but plan on using this to turn on and off a fan to keep my AV equipment cool. So I'm not that concerned about humidity although it wouldn't be deal breaker if it did.

                                        Thanks,

                                        rejoe2R Offline
                                        rejoe2R Offline
                                        rejoe2
                                        wrote on last edited by
                                        #45

                                        @bluezr1 Sure... But imo it is easier to stick with the given examples, they may be much easier to understand than e.g. this one:grin:

                                        Controller: FHEM; MySensors: 2.3.1, RS485,nRF24,RFM69, serial Gateways

                                        sinczeS 1 Reply Last reply
                                        0
                                        • rejoe2R rejoe2

                                          @bluezr1 Sure... But imo it is easier to stick with the given examples, they may be much easier to understand than e.g. this one:grin:

                                          sinczeS Offline
                                          sinczeS Offline
                                          sincze
                                          MySensors Evangelist
                                          wrote on last edited by
                                          #46

                                          @rejoe2 NIce example thanks.

                                          rejoe2R sinczeS 2 Replies Last reply
                                          0
                                          Reply
                                          • Reply as topic
                                          Log in to reply
                                          • Oldest to Newest
                                          • Newest to Oldest
                                          • Most Votes


                                          18

                                          Online

                                          11.7k

                                          Users

                                          11.2k

                                          Topics

                                          113.1k

                                          Posts


                                          Copyright 2025 TBD   |   Forum Guidelines   |   Privacy Policy   |   Terms of Service
                                          • Login

                                          • Don't have an account? Register

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • MySensors
                                          • OpenHardware.io
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular