Skip to content
  • MySensors
  • OpenHardware.io
  • Categories
  • Recent
  • Tags
  • Popular
Skins
  • Light
  • Brite
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Brand Logo
  1. Home
  2. Development
  3. LED name wrong in 2.0.0 beta

LED name wrong in 2.0.0 beta

Scheduled Pinned Locked Moved Development
7 Posts 3 Posters 1.6k Views 3 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • L Offline
    L Offline
    lafleur
    wrote on last edited by
    #1

    In MyConfig.h names are:

    #define MY_DEFAULT_ERR_LED x
    #define MY_DEFAULT_TX_LED x
    #define MY_DEFAULT_RX_LED x
    

    In MyLeds.ccp they are:

    #define MY_DEFAULT_TX_LED_PIN     
    #define MY_DEFAULT_ERR_LED_PIN   
    #define MY_DEFAULT_RX_LED_PIN     
    
    1 Reply Last reply
    0
    • hekH Offline
      hekH Offline
      hek
      Admin
      wrote on last edited by
      #2

      Thanks for reporting, will fix the comment.

      1 Reply Last reply
      0
      • L Offline
        L Offline
        lafleur
        wrote on last edited by
        #3

        Variable name is wrong, not the comments

        1 Reply Last reply
        0
        • hekH Offline
          hekH Offline
          hek
          Admin
          wrote on last edited by
          #4

          MY_DEFAULT_TX_LED _PIN

          Is the correct suffix. I could only find a commented section in MyConfig.h without the correct suffix. Or what do you mean? Show me a link/line number to github where you found the incorrect declaration.

          1 Reply Last reply
          0
          • L Offline
            L Offline
            lafleur
            wrote on last edited by
            #5

            My pull from the development hub is a few weeks old, I'll check my pull from current master when I get home tonight ....

            1 Reply Last reply
            1
            • L Offline
              L Offline
              lafleur
              wrote on last edited by
              #6

              I pulled the current development version... on 3 Mar 2016

              In myconfig.h at line 167, we have the block below:

              if you un comment one of the LED define, they do NOT enable the LED, only if you use the 2nd versions as defined in MyLeds.ccp.

              #define MY_DEFAULT_ERR_LED 15 <--- not working
              #define MY_DEFAULT_ERR_LED_PIN 15 <--- working

              /**********************************
              *  Information LEDs blinking
              ***********************************/
              // This feature enables LEDs blinking on message receive, transmit
              // or if some error occurred. This was commonly used only in gateways,
              // but now can be used in any sensor node. Also the LEDs can now be
              // disabled in the gateway.
              
              //#define MY_LEDS_BLINKING_FEATURE
              
              // The following setting allows you to inverse the blinking feature MY_LEDS_BLINKING_FEATURE
              // When MY_WITH_LEDS_BLINKING_INVERSE is enabled LEDSs are normally turned on and switches
              // off when blinking
              
              //#define MY_WITH_LEDS_BLINKING_INVERSE
              
              // The following defines can be used to set the port pin, that the LED is connected to
              // If one of the following is defined here, or in the sketch, MY_LEDS_BLINKING_FEATURE will be
              // enabled by default. (Replace x with the pin number you have the LED on)
              //#define MY_DEFAULT_ERR_LED x
              //#define MY_DEFAULT_TX_LED x
              //#define MY_DEFAULT_RX_LED x
              
              ~~
              1 Reply Last reply
              0
              • tbowmoT Offline
                tbowmoT Offline
                tbowmo
                Admin
                wrote on last edited by
                #7

                @lafleur

                You could create a PR to change this (We would love to get contributions to the code)

                1 Reply Last reply
                0
                Reply
                • Reply as topic
                Log in to reply
                • Oldest to Newest
                • Newest to Oldest
                • Most Votes


                23

                Online

                11.7k

                Users

                11.2k

                Topics

                113.1k

                Posts


                Copyright 2025 TBD   |   Forum Guidelines   |   Privacy Policy   |   Terms of Service
                • Login

                • Don't have an account? Register

                • Login or register to search.
                • First post
                  Last post
                0
                • MySensors
                • OpenHardware.io
                • Categories
                • Recent
                • Tags
                • Popular