Irrigation Controller (up to 16 valves with Shift Registers)

[BulldogLowell]

@petewill

I edited above to give more detail...

[petewill]

@BulldogLowell said:

I edited above to give more detail...

Ok, thanks. I did a little research and found this from the Arduino website:

When referencing custom character "0", if it is not in a variable, you need to cast it as a byte, otherwise the compiler throws an error. See the example below.

http://www.arduino.cc/en/Reference/LiquidCrystalCreateChar

I changed the code to this:

byte clock[8] = {0x0,0xe,0x15,0x17,0x11,0xe,0x0};

and this

lcd.write(byte(0));

and now it's compiling. But, I don't know if it's working.

I'm still working on a couple of other small things I found. I'll post the code when I get it to a point where it's ready for your review.

[petewill]

@BulldogLowell

Here is the code with some changes. I have also attached a document with the changes highlighted. The most notable thing is I added some code to update the valve times when the device is first powered on. I hope that's ok.

One thing I can't figure out, but hopefully you can, is the button is always acting like it's "pressed" when the Arduino is first powered on. This could be a problem as the power seems to go off in my house a couple of times a year (I don't want my irrigation to run when it's not supposed to). Any idea how to fix it? I've tried everything I could think of (which isn't much) and nothing worked.

Anyway, here is the PDF with the changes Irrigation Controller Changes.pdf

And the code:

/*
MySprinkler for MySensors

Arduino Multi-Zone Sprinkler Control

November, 2014

*** Version 2.0 

*** Upgraded to http://MySensors.org version 1.4.1
*** Expanded for up to 16 Valves
*** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
*** Switch to bitshift method vs byte arrays
*** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
*** Added optional LCD display featuring remaining time, date last ran & current time
*** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve times and clock respectively

Utilizing your Vera home automation controller and the MySensors.org gateway you can
control up to a sixteen zone irrigation system with only three digital pins.  This sketch 
will create NUMBER_OF_VALVES + 1 devices on your Vera controller

This sketch features the following:

* Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.  
* Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n) 
using Variable1 as the "ON" time in minutes in each of the vera devices created.
* Use the individual zone controller to activate a single zone.  This feature uses 
Variable2 as the "ON" time for each individual device/zone.
* Connect according to pinout below and uses Shift Registers as to allow the MySensors 
standard radio configuration and still leave available digital pins
* Turning on any zone will stop the current process and begin that particular process.
* Turning off any zone will stop the current process and turn off all zones.
* To push your new time intervals for your zones, simply change the variable on your Vera and 
your arduino will call to Vera once a minute and update accordingly.
* Pushbutton activation to RUN_ALL_ZONES
* LED status indicator

INSTRUCTIONS:

* After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to 
A4 and A5) and relays, and load the sketch.
* Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
* Verify that each new device has a Variable1 and Variable2. Populate data accordingly with whole minutes for 
the RUN_ALL_ZONES routine and the RUN_SINGLE_ZONE routines.  The values entered may be zero.  
* Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
* Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
on the serial monitor.
* Your arduino should slow-flash, indicating that it is in ready mode.
* There are multiple debug serial prints that can be monitored to assure that it is operating properly.
* https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours

Contributed by Jim (BulldogLowell@gmail.com) and is released to the public domain
*/
// 
#include <Wire.h>
#include <Time.h>
#include <MySensor.h>
#include <SPI.h>
#include <LiquidCrystal_I2C.h>
//
#define NUMBER_OF_VALVES 5  // Change this to set your valve count up to 16.
#define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
#define RADIO_ID AUTO // AUTO  // Change this to fix your Radio ID or use Auto
#define SKETCH_NAME "MySprinkler"
#define SKETCH_VERSION "2.0"
//
#define CHILD_ID_SPRINKLER 0
//
#define ACTIVE_LOW // comment out this line if your relays are active high
//
#define DEBUG_ON   // comment out to supress serial monitor output
//
#ifdef ACTIVE_LOW
#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
#define ALL_VALVES_OFF 0xFFFF
#else
#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
#define ALL_VALVES_OFF 0U
#endif
//
#ifdef DEBUG_ON
#define DEBUG_PRINT(x)   Serial.print(x)
#define DEBUG_PRINTLN(x) Serial.println(x)
#define SERIAL_START(x)  Serial.begin(x)
#else
#define DEBUG_PRINT(x)
#define DEBUG_PRINTLN(x)
#define SERIAL_START(x)
#endif
//
typedef enum {
 STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE}
SprinklerStates;
//
SprinklerStates state = STAND_BY_ALL_OFF;
SprinklerStates lastState;
//
int allZoneTime [NUMBER_OF_VALVES + 1];
int valveSoloTime [NUMBER_OF_VALVES + 1];
int valveNumber;
int lastValve;
unsigned long startMillis;
const int ledPin = 5;
const int waterButtonPin = 3;
boolean buttonPushed = false;
boolean showTime = true;
boolean clockUpdating = false;
boolean recentUpdate = true;
const char *dayOfWeek[] = {
 "Null","Sunday ","Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "};
//
time_t lastTimeRun = 0;
//Setup Shift Register...
const int latchPin = 8;
const int clockPin = 4;
const int dataPin  = 7;
// 
byte clock[8] = {0x0,0xe,0x15,0x17,0x11,0xe,0x0}; // fetching time indicator
byte raindrop[8] = {0x4,0x4,0xA,0xA,0x11,0xE,0x0,}; // fetching Valve Data indicator
LiquidCrystal_I2C lcd(0x27);  // set the LCD I2C address to 0x27
MySensor gw;
//
MyMessage msg1valve(CHILD_ID_SPRINKLER,V_LIGHT);
MyMessage var1valve(CHILD_ID_SPRINKLER,V_VAR1);
MyMessage var2valve(CHILD_ID_SPRINKLER,V_VAR2);
//
void setup() 
{ 
  delay(5000);
 //*Added
 lcd.begin(16, 2); //(16 characters and 2 line display)
//*Removed 
// lcd.init();
 lcd.clear();
 lcd.backlight();
 lcd.createChar(0, clock);
 lcd.createChar(1, raindrop);
 DEBUG_PRINTLN(F("Initialising..."));
 pinMode(latchPin, OUTPUT);
 pinMode(clockPin, OUTPUT);
 pinMode(dataPin, OUTPUT);
 pinMode(ledPin, OUTPUT);
 pinMode(waterButtonPin, INPUT_PULLUP);
 attachInterrupt(1, PushButton, RISING); //May need to change for your Arduino model
 digitalWrite (ledPin, HIGH);
 // 
 //check for saved date in EEPROM
 DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
 if (gw.loadState(0) == 0xFF); // EEPROM flag
 {
    DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
    for (int i = 0; i < 4 ; i++)
    {
     lastTimeRun = lastTimeRun << 8;
     lastTimeRun = lastTimeRun | gw.loadState(i+1); // assemble 4 bytes into an ussigned long epoch timestamp
    }
 }
 gw.begin(getVariables, RADIO_ID, false); // Change 'false' to 'true' to create a Radio repeating node
 gw.sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
 for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
 {
    gw.present(i, S_LIGHT);
 }
 DEBUG_PRINTLN(F("Sensor Presentation Complete"));
 //
 DEBUG_PRINTLN(F("Turning All Valves Off..."));
 updateRelays(ALL_VALVES_OFF);
 digitalWrite (ledPin, LOW);
 DEBUG_PRINTLN(F("Ready..."));
 //
 lcd.setCursor(0, 0);
 lcd.print(F(" Syncing Time  "));
 lcd.setCursor(15, 0);
 lcd.write(byte(0));  //lcd.print(0, BYTE);
 lcd.setCursor(0, 1);
 int clockCounter = 0;
 while(timeStatus() == timeNotSet && clockCounter < 21)
 {
    gw.process();
    gw.requestTime(receiveTime);
    DEBUG_PRINTLN(F("Requesting time from Gateway:"));
    delay(1000);
    lcd.print(".");
    //DEBUG_PRINT(F("."));
    clockCounter++;
    if (clockCounter > 16)
    {
     DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
     lcd.clear();
     lcd.print(F("  Failed Clock  "));
     lcd.setCursor(0,1);
     lcd.print(F(" Syncronization "));
     delay(2000);
     break;
    }
 }
 //
 lcd.clear();
 //Update valve times when first powered on
 for(byte i = 0; i <= NUMBER_OF_VALVES; i++)
 {
   allZoneTime[i]=-1;
   valveSoloTime[i]=-1;
   int clockCounter = 0;
   while((valveSoloTime[i]==-1 || allZoneTime[i]==-1) && clockCounter < 10)
   {
     DEBUG_PRINTLN(F("Calling for Valve Times..."));
     lcd.setCursor(15, 0);
     lcd.write(byte(1)); //lcd.write(1);
     gw.request(i, V_VAR1);
     gw.request(i, V_VAR2);
     delay(1000);
     gw.process();
     clockCounter++;
     if (clockCounter > 10)
     {
        DEBUG_PRINTLN(F("Failed initial valve synchronization!"));
        lcd.clear();
        lcd.print(F("  Failed Valve  "));
        lcd.setCursor(0,1);
        lcd.print(F(" Syncronization "));
     }
   }
 }
 
}
//
void loop()
{
 gw.process();
 updateClock();
 updateDisplay();
 goGetValveTimes();
 //
 if (buttonPushed)
 {
    DEBUG_PRINTLN(F("Button Pressed"));
    if (state != RUN_ALL_ZONES)
    {
     state = RUN_ALL_ZONES;
     valveNumber = 1;
     gw.send(msg1valve.setSensor(0).set(true), false);
     startMillis = millis();
     for (byte i = 0; i < 5; i++)  // flash lcd backlight on button press
     {
        lcd.noBacklight(); 
        delay(25);
        lcd.backlight();
     }
     delay(50);
     fastClear();
     lcd.setCursor(0,0);
     lcd.print(F("*AllZone Active*"));
     lcd.setCursor(0,0);
     lcd.print(F(" Cycling  Zones "));
     delay(1000);
     DEBUG_PRINT(F("State = "));
     DEBUG_PRINTLN(state);
    }
    else
    {
      state = STAND_BY_ALL_OFF;
      //valveNumber = 1;
      gw.send(msg1valve.setSensor(0).set(false), false);
      startMillis = millis();
      for (byte i = 0; i < 5; i++)  // flash lcd backlight on button press
      {
        lcd.noBacklight(); 
        delay(25);
        lcd.backlight();
      }
      delay(50);
      fastClear();
      lcd.setCursor(0,0);
      lcd.print(F("*AllZone Off*"));
      lcd.setCursor(0,0);
      lcd.print(F(" Stopping  Zones "));
      delay(1000);
      DEBUG_PRINT(F("State = "));
      DEBUG_PRINTLN(state);
    }
    buttonPushed = false;
 }
 if (state == STAND_BY_ALL_OFF) 
 {
    slowToggleLED (); 
    if (state != lastState)
    {
     updateRelays(ALL_VALVES_OFF);
     DEBUG_PRINTLN(F("State Changed... all Zones off"));
     for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
     {
        delay(50);
        gw.send(msg1valve.setSensor(i).set(false), false);
     }
     lastValve = -1;
    }
 }
 //
 else if (state == RUN_ALL_ZONES)
 { 
    if (lastValve != valveNumber)
    {
     for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
     {
        if (i == 0 || i == valveNumber)
        {
         gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
         gw.send(msg1valve.setSensor(i).set(false), false);
        }
     }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
     valveNumber = 1;
     updateRelays(ALL_VALVES_OFF);
     DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
     updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
     updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
     DEBUG_PRINTLN(F("Changing Valves..."));
     updateRelays(ALL_VALVES_OFF);
     startMillis = millis();
     valveNumber++;
     if (valveNumber > NUMBER_OF_VALVES) 
     {
        state = CYCLE_COMPLETE;
        startMillis = millis();
        lastValve = -1;
        lastTimeRun = now();
        saveDateToEEPROM(lastTimeRun);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
         gw.send(msg1valve.setSensor(i).set(false), false);
        }
        DEBUG_PRINT(F("State = ")); 
        DEBUG_PRINTLN(state);
     }
    }
 }
 //
 else if (state == RUN_SINGLE_ZONE)
 {
    fastToggleLed();
    if (state != lastState)
    {
     for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
     {
        if (i == 0 || i == valveNumber)
        {
         gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
         gw.send(msg1valve.setSensor(i).set(false), false);
        }
     }
     DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
     DEBUG_PRINT(F("Zone: "));
     DEBUG_PRINTLN(valveNumber);
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
     updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
    {
     updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
     updateRelays(ALL_VALVES_OFF);
     for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
     {
        gw.send(msg1valve.setSensor(i).set(false), false);
     }
     state = CYCLE_COMPLETE;
     startMillis = millis();
     DEBUG_PRINT(F("State = ")); 
     DEBUG_PRINTLN(state);
    }
    lastTimeRun = now();
 }
 else if (state == CYCLE_COMPLETE)
 {
    if (millis() - startMillis < 30000UL)
    {
     fastToggleLed();
    }
    else
    {
     state = STAND_BY_ALL_OFF;
    }
 }
 lastState = state;
}
//
void updateRelays(int value)
{
 digitalWrite(latchPin, LOW);
 shiftOut(dataPin, clockPin, MSBFIRST, highByte(value)); 
 shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
 digitalWrite(latchPin, HIGH);
}
//
void PushButton() //interrupt with debounce
{ 
 static unsigned long last_interrupt_time = 0;
 unsigned long interrupt_time = millis();
 if (interrupt_time - last_interrupt_time > 200)
 {
    buttonPushed = true;
 }
 last_interrupt_time = interrupt_time;
}
//
void fastToggleLed()
{
 static unsigned long fastLedTimer;
 if (millis() - fastLedTimer >= 100UL)
 {
    digitalWrite(ledPin, !digitalRead(ledPin));
    fastLedTimer = millis (); 
 }   
}
//
void slowToggleLED ()
{
 static unsigned long slowLedTimer;
 if (millis() - slowLedTimer >= 1250UL)
 {
    digitalWrite(ledPin, !digitalRead(ledPin));
    slowLedTimer = millis (); 
 } 
}
//
void getVariables(const MyMessage &message)
{
 boolean zoneTimeUpdate = false;
 if (message.isAck()) 
 {
    DEBUG_PRINTLN(F("This is an ack from gateway"));
 }
 for (byte i = 0; i<= NUMBER_OF_VALVES; i++)
 {
    if (message.sensor == i)
    {
     if (message.type == V_LIGHT)
     {
        int switchState = atoi(message.data);
        if (switchState == 0)
        {
         state = STAND_BY_ALL_OFF;
         DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
        }
        else
        {
         if (i == 0)
         {
            state = RUN_ALL_ZONES;
            valveNumber = 1;
            DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
         }
         else 
         {
            state = RUN_SINGLE_ZONE;
            valveNumber = i;
            DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
            DEBUG_PRINTLN(i);
         }
        }
        startMillis = millis();
     }
     else if (message.type == V_VAR1)
     {
        int variable1 = atoi(message.data);// RUN_ALL_ZONES time
        DEBUG_PRINT(F("Recieved variable1 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable1);
        if (variable1 != allZoneTime[i])
        {
         allZoneTime[i] = variable1;
     
         zoneTimeUpdate = true;
        }
     }
     else if (message.type == V_VAR2)
     {
        int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
        DEBUG_PRINT(F("Recieved variable2 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable2);
        if (variable2 != valveSoloTime[i])
        {
         valveSoloTime[i] = variable2;
         zoneTimeUpdate = true;
        }
     }
    }
 }
 if (zoneTimeUpdate)
 {
    //
    DEBUG_PRINTLN(F("New Zone Times Recieved..."));
    for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
    {
     if (i != 0)
     {
        DEBUG_PRINT(F("Zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" individual time: "));
        DEBUG_PRINT(valveSoloTime[i]);
        DEBUG_PRINT(F(" group time: "));
        DEBUG_PRINTLN(allZoneTime[i]);
        recentUpdate = true;
     }
    }
 }
 else
 {
    recentUpdate = false;
 }
}
//
void updateDisplay()
{
 static unsigned long lastUpdateTime;
 static boolean displayToggle = false;
 //static byte toggleCounter = 0;
 static SprinklerStates lastDisplayState;
 if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
 {
    displayToggle = !displayToggle;
    switch (state){
    case STAND_BY_ALL_OFF:
     //
     fastClear();
     lcd.setCursor(0,0);
     if (displayToggle)
     {
        lcd.print(F("  System Ready "));
        if (clockUpdating)
        {
         lcd.setCursor(15,0);         
         lcd.write(byte(0));
        }
        lcd.setCursor(0,1);
        lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
        lcd.print(hourFormat12());
        lcd.print(minute() < 10 ? F(":0") : F(":"));
        lcd.print(minute());
        lcd.print(isAM() ? F("am") : F("pm"));
        lcd.print(F(" "));
        lcd.print(month() < 10? F("0") : F(""));
        lcd.print(month());
        lcd.print(day() < 10? F("/0") : F("/"));
        lcd.print(day());
        lcd.print(F("/"));
        lcd.print(year()%100);
     }
     else
     {
        lcd.print(F("  Last Watered "));
        if (clockUpdating)
        {
         lcd.setCursor(15,0);
         lcd.write(byte(0));
        }
        lcd.setCursor(0,1);
        lcd.print(dayOfWeek[weekday(lastTimeRun)]);
        lcd.setCursor(11,1);
        lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
        lcd.print(month(lastTimeRun));
        lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/"));
        lcd.print(day(lastTimeRun));
     }
     break;
    case RUN_SINGLE_ZONE:
     //
     fastClear();
     lcd.setCursor(0,0);
     if (displayToggle)
     {
        lcd.print(F("Single Zone Mode"));
        lcd.setCursor(0,1);
        lcd.print(F(" Zone:"));
        if (valveNumber < 10) lcd.print(F("0"));
        lcd.print(valveNumber);
        lcd.print(F(" Active"));
     }
     else
     {
        lcd.print(F(" Time Remaining "));
        lcd.setCursor(0,1);
        unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
        lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
        lcd.print(timeRemaining / 60);
        lcd.print("min");
        lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
        lcd.print(timeRemaining % 60);
        lcd.print("sec  ");
     }
     break;
    case RUN_ALL_ZONES:
     //
     fastClear();
     lcd.setCursor(0,0);
     if (displayToggle)
     {
        lcd.print(F(" All-Zone  Mode "));
        lcd.setCursor(0,1);
        lcd.print(F(" Zone:"));
        if (valveNumber < 10) lcd.print(F("0"));
        lcd.print(valveNumber);
        lcd.print(F(" Active "));
     }
     else
     {
        lcd.print(F(" Time Remaining "));
        lcd.setCursor(0,1);
        int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
        lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
        lcd.print(timeRemaining / 60);
        lcd.print("min");
        lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
        lcd.print(timeRemaining % 60);
        lcd.print("sec  ");
     }
     break;
    case CYCLE_COMPLETE:
     //
     if (displayToggle)
     {
        lcd.setCursor(0,0);
        lcd.print(F(" Watering Cycle "));
        lcd.setCursor(0,1);
        lcd.print(F("    Complete    "));
     }
     else
     {
        int totalTimeRan = 0;
        for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
        {
         totalTimeRan += allZoneTime[i];
        }
        lcd.setCursor(0,0);
        lcd.print(F(" Total Time Run "));
        lcd.setCursor(0,1);
        lcd.print(totalTimeRan < 10 ? "   0" : "   ");
        lcd.print(totalTimeRan);
        lcd.print(" Minutes   ");
     }
    }
    lastUpdateTime = millis();
 }
 lastDisplayState = state;
}
void receiveTime(time_t newTime)
{
 DEBUG_PRINTLN(F("Time value received and updated..."));
 int lastSecond = second();
 int lastMinute = minute();
 int lastHour = hour();
 setTime(newTime);
 if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
 {
    DEBUG_PRINTLN(F("Clock updated...."));
    DEBUG_PRINT(F("Sensor's time currently set to:"));
    DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
    DEBUG_PRINT(hourFormat12());
    DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
    DEBUG_PRINT(minute());
    DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
    DEBUG_PRINT(month());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINT(day());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINTLN(year());
    DEBUG_PRINTLN(dayOfWeek[weekday()]);
    showTime = false;
 }
 else 
 {
    DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
 }
 clockUpdating = false;
}
void fastClear()
{
 lcd.setCursor(0,0);
 lcd.print(F("                "));
 lcd.setCursor(0,1);
 lcd.print(F("                "));
}
//
void updateClock()
{
 static unsigned long lastVeraGetTime;
 if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
 {
    DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
    lcd.setCursor(15,0);
    lcd.write(byte(0));
    clockUpdating = true;
    gw.requestTime(receiveTime);
    lastVeraGetTime = millis();
 }
}
//
void saveDateToEEPROM(unsigned long theDate)
{
 DEBUG_PRINTLN(F("Saving Last Run date"));
 if (gw.loadState(0) != 0xFF) 
 {
    gw.saveState(0,0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
 }
 //
 for (int i = 1; i < 5; i++)
 {
    gw.saveState(5-i, byte(theDate >> 8 * (i-1)));// store epoch datestamp in 4 bytes of EEPROM starting in location one
 }
}
//
void goGetValveTimes()
{
 static unsigned long valveUpdateTime;
 static byte valveIndex = 1;
 if (millis() - valveUpdateTime >= 300000UL / NUMBER_OF_VALVES)// update each valve once every 5 mins (distributes the traffic)
 {
    DEBUG_PRINTLN(F("Calling for Valve Times..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(1)); //lcd.write(1);
    gw.request(valveIndex, V_VAR1);
    gw.request(valveIndex, V_VAR2);
    valveUpdateTime = millis();
    valveIndex++;
    if (valveIndex > NUMBER_OF_VALVES+1)
    {
     valveIndex = 1;
    }
 }
}```

[BulldogLowell]

@petewill said:

One thing I can't figure out, but hopefully you can, is the button is always acting like it's "pressed" when the Arduino is first powered on. This could be a problem as the power seems to go off in my house a couple of times a year (I don't want my irrigation to run when it's not supposed to).

You could try a bigger pullup resistor, maybe the pin floats for a brief moment or it is somehow energized... I've read about others having a problem like that. Alternatively, reverse the logic and pull pull the pin down to ground. I'd expect that one or both can correct that issue.

Glad to have the improvements in the code, that's great! Always better to have another set of eyes on a project.

[petewill]

@BulldogLowell said:

You could try a bigger pullup resistor, maybe the pin floats for a brief moment or it is somehow energized...

Ok, I'll do some testing with that. I don't think I'll get the chance today but I should be able to do some tomorrow. It works perfectly after the first start up so hopefully a bigger resistor will help.

[BulldogLowell]

@petewill

yeah, I see in the code that the pushbutton is using interrupt pin, but still needs to be set to input

pinMode(PushButton, INPUT_PULLUP);

start there, sorry!

[petewill]

@BulldogLowell said:

yeah, I see in the code that the pushbutton is using interrupt pin, but still needs to be set to input

I thought I added it already with this:

pinMode(waterButtonPin, INPUT_PULLUP);

Is that correct? Maybe that's my problem...

[petewill]

@BulldogLowell said:

were you not getting a compile error? on the PushButton variable being undeclared?

Ok, I still think I have some things to learn about interrupts. I thought PushButton was the method being called when the interrupt was triggered. I didn't think it was the pin. I thought the pin was the first item 1 in this case. But, I thought 1 isn't even the pin. It's the interrupt number which is pin 3 in the case of a Pro Mini. I also thought I needed to declare the pinMode even if it's already in the interrupt. So confusing... Am I totally off?

[BulldogLowell]

@petewill

post deleted, my bad! your understanding is 100% correct!

your PushButton is the ISR, so you are right

Try the extra pullup or pull-down

really sorry for confusing you! I'm mega jet lagged

[petewill]

@BulldogLowell said:

I'm mega jet lagged

Totally understandable

Ok, I'll try the other options discussed above and post back. Thanks.

[petewill]

@BulldogLowell said:

Try the extra pullup

Well, I had almost no time to work on MySensors stuff this weekend. I did do a quick test last night and it seems the external pullup worked! I power cycled the node 3 times and each time it worked flawlessly. I'll continue to test but so far so good. Thank you!

[BulldogLowell]

@petewill

glad to hear that worked!

[Sparkman]

@BulldogLowell Thanks for posting this. A sprinkler controller to replace my Rainbird controller is next on my list of projects.

For those looking for a good and relatively cheap soil moisture sensor, these ones are pretty good and use a capacitive sensor: http://www.ebay.com/itm/261675851824. They transmit on 433 MHz. I currently use them with RFXCom and HomeSeer, but for those that don't have RFXCom, the protocol should be relatively easy to reverse engineer and then use directly with MySensors and a 433MHz receiver. I've also bought a few from here: https://www.plantcaretools.com/en/webshop/wireless-moisture-sensor-en-detail. Both sellers were good to deal with. The only drawback to them is that the antenna (and therefore range) is not very good, but there is an easy mod to improve that: http://www.domoticz.com/forum/viewtopic.php?f=13&t=2712

Cheers
Al

[hek]

Added your project to the main site togeter with @petewill excellent new video.

http://www.mysensors.org/build/irrigation

How To - Cheap, DIY Arduino Irrigation Controller with MySensors – 35:33
— Pete B

[BulldogLowell]

Cool @hek!

Well done @petewill So easy for folks to follow along your outstanding video!

MySensors Community Rocks!

[petewill]

@BulldogLowell said:

MySensors Community Rocks!

Agreed!!! Thanks to both @BulldogLowell and @hek for making this possible. I love seeing it hanging on my wall every time I go into the basement

[RJ_Make]

Great Work Guys!!

[DrJeff]

@Sparkman I like the sensors, I just built some and was dbating the way to make smaller, what kind of battery life do those moisture sensors have?

@petewill Time to change my current 16 valve arduino sprinklers to a little smarter version like yours! I love this community.
You have been coming on with some awesome videos and contributions!

[petewill]

@DrJeff I agree this is a great community! So much fun!

Thanks for the kind words! All credit for this project goes to @BulldogLowell though. I just made the video

[DrJeff]

@BulldogLowell Sorry For not giving the credit where it is due! Major Props @BulldogLowell !

[Sparkman]

@DrJeff said:

@Sparkman I like the sensors, I just built some and was dbating the way to make smaller, what kind of battery life do those moisture sensors have?

They've been running for about 9 months on the first set of batteries (2xAAA) so far and are still going strong.

Cheers
Al

[BulldogLowell]

Thanks @DrJeff

I just made an irrigation controller... @petewill made it for everyone!

[tbowmo]

just for inspiration, here's another irrigation controller video (no, it's not mine.. but one of my friends that made it)

Arduino controlled garden watering system – 01:04
— Nikolaj Rahbek

[Didi]

Wow 48 channels thats awesome

[petewill]

@tbowmo WOW! What did he use that for??

[DrJeff]

@tbowmo Time for a Shower, Can you say body sprays!

[tbowmo]

@petewill

He recently planted a lot of trees, so instead of walking around and watering each one manually he made this

Its a arduino with a nrf24 module, but not using the mysensors library (yet...)

[petewill]

@tbowmo said:

@petewill

He recently planted a lot of trees

I guess so

Cool!

[BulldogLowell]

@treb0r

here is a stab at modification for no shift register... not much changes.

Not tested but it compiles...

Let me know if you see anything in testing.

/*
MySprinkler for MySensors

Arduino Multi-Zone Sprinkler Control

June 30, 2015

*** Version 2.0nsr //MODIFIED FOR NO SHIFT REGISTER

*** Upgraded to http://MySensors.org version 1.4.1
*** Expanded for up to 16 Valves
*** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
*** Switch to bitshift method vs byte arrays
*** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
*** Added optional LCD display featuring remaining time, date last ran & current time
*** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively
*** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone)
*** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names)

Utilizing your Vera home automation controller and the MySensors.org gateway you can
control up to a sixteen zone irrigation system with only three digital pins.  This sketch
will create NUMBER_OF_VALVES + 1 devices on your Vera controller

This sketch features the following:

* Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.
* Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n)
  using Variable1 as the "ON" time in minutes in each of the vera devices created.
* Use the individual zone controller to activate a single zone.  This feature uses
  Variable2 as the "ON" time for each individual device/zone.
* Connect according to pinout below and uses Shift Registers as to allow the MySensors
  standard radio configuration and still leave available digital pins
* Turning on any zone will stop the current process and begin that particular process.
* Turning off any zone will stop the current process and turn off all zones.
* To push your new time intervals for your zones, simply change the variable on your Vera and
  your arduino will call to Vera once a minute and update accordingly.  Variables will also be
  requested when the device is first powered on.
* Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program
* LED status indicator

PARTS LIST:
Available from the MySensors store - http://www.mysensors.org/store/
* Relays (8 channel)
* Female Pin Header Connector Strip
* Prototype Universal Printed Circuit Boards (PCB)
* NRF24L01 Radio
* Arduino (I used a Pro Mini)
* FTDI USB to TTL Serial Adapter
* Capacitors (10uf and .1uf)
* 3.3v voltage regulator
* Resistors (270 & 10K)
* Female Dupont Cables
* 1602 LCD (with I2C Interface)
* LED
* Push button
* Shift Register (SN74HC595)
* 2 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 3 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 22-24 gauge wire or similar (I used Cat5/Cat6 cable)
* 18 gauge wire (for relay)
* Irrigation Power Supply (24-Volt/750 mA Transformer)


INSTRUCTIONS:

* A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI
* After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to
  A4 and A5) and relays, and load the sketch.
* Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
* Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
  the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
  you may use the defaulet zone names by leaving Variable3 blank.
* Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
* Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
  on the serial monitor.
* Your arduino should slow-flash, indicating that it is in ready mode.
* There are multiple debug serial prints that can be monitored to assure that it is operating properly.
* ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours

Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain
*/
//
#include <Wire.h>
#include <Time.h>
#include <MySensor.h>
#include <SPI.h>
#include <LiquidCrystal.h>
#include <LiquidCrystal_I2C.h>

//
#define NUMBER_OF_VALVES 4  // Change this to set your valve count up to 16.
#define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
#define RADIO_ID AUTO  // Change this to fix your Radio ID or use Auto

#define SKETCH_NAME "MySprinkler"
#define SKETCH_VERSION "2.0nsr"
//
#define CHILD_ID_SPRINKLER 0
//
#define ACTIVE_LOW // comment out this line if your relays are active high
//
#define DEBUG_ON   // comment out to supress serial monitor output
//
#ifdef ACTIVE_LOW
#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
#define ALL_VALVES_OFF 0xFFFF
#else
#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
#define ALL_VALVES_OFF 0U
#endif
//
#ifdef DEBUG_ON
#define DEBUG_PRINT(x)   Serial.print(x)
#define DEBUG_PRINTLN(x) Serial.println(x)
#define SERIAL_START(x)  Serial.begin(x)
#else
#define DEBUG_PRINT(x)
#define DEBUG_PRINTLN(x)
#define SERIAL_START(x)
#endif
//
typedef enum {
  STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
}
SprinklerStates;
//
SprinklerStates state = STAND_BY_ALL_OFF;
SprinklerStates lastState;
//
const int relayPin[NUMBER_OF_VALVES] = {5,6,7,8};//<<<<<<<<<<<<<<<<<<< YOUR DIGITAL PINS HERE
//
byte menuState = 0;
unsigned long menuTimer;
byte countDownTime = 10;
//
int allZoneTime [NUMBER_OF_VALVES + 1];
int valveSoloTime [NUMBER_OF_VALVES + 1];
int valveNumber;
int lastValve;
unsigned long startMillis;
const int ledPin = 4;//<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< CHANGED THIS TOO
const int waterButtonPin = 3;
boolean buttonPushed = false;
boolean showTime = true;
boolean clockUpdating = false;
boolean recentUpdate = true;
const char *dayOfWeek[] = {
  "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
};
// Name your Zones here or use Vera to edit them by adding a name in Variable3...
String valveNickName[17] = {
  "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
};
//
time_t lastTimeRun = 0;
/*Setup Shift Register...<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< COMMENTED OUT THIS BIT
const int latchPin = 8;
const int clockPin = 4;
const int dataPin  = 7;
*/
byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
// Set the pins on the I2C chip used for LCD connections:
//                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27
MySensor gw;
//
MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);
//
void setup()
{
  SERIAL_START(115200);
  DEBUG_PRINTLN(F("Initialising..."));
  /*  <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< COMMENTED OUT THIS BLOCK
  pinMode(latchPin, OUTPUT);
  pinMode(clockPin, OUTPUT);
  pinMode(dataPin, OUTPUT);
  */
  pinMode(ledPin, OUTPUT);
  pinMode(waterButtonPin, INPUT_PULLUP);
  //pinMode(waterButtonPin, INPUT);
  attachInterrupt(1, PushButton, RISING); //May need to change for your Arduino model
  digitalWrite (ledPin, HIGH);
  DEBUG_PRINTLN(F("Turning All Valves Off..."));
  updateRelays(ALL_VALVES_OFF);
  //delay(5000);
  lcd.begin(16, 2); //(16 characters and 2 line display)
  lcd.clear();
  lcd.backlight();
  lcd.createChar(0, clock);
  lcd.createChar(1, raindrop);
  //
  //check for saved date in EEPROM
  DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
  delay(500);
  if (gw.loadState(0) == 0xFF); // EEPROM flag
  {
    DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
    for (int i = 0; i < 4 ; i++)
    {
      lastTimeRun = lastTimeRun << 8;
      lastTimeRun = lastTimeRun | gw.loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
    }
  }
  gw.begin(getVariables, RADIO_ID, false); // Change 'false' to 'true' to create a Radio repeating node
  gw.sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    gw.present(i, S_LIGHT);
  }
  DEBUG_PRINTLN(F("Sensor Presentation Complete"));
  //
  digitalWrite (ledPin, LOW);
  DEBUG_PRINTLN(F("Ready..."));
  //
  lcd.setCursor(0, 0);
  lcd.print(F(" Syncing Time  "));
  lcd.setCursor(15, 0);
  lcd.write(byte(0));
  lcd.setCursor(0, 1);
  int clockCounter = 0;
  while (timeStatus() == timeNotSet && clockCounter < 21)
  {
    gw.process();
    gw.requestTime(receiveTime);
    DEBUG_PRINTLN(F("Requesting time from Gateway:"));
    delay(1000);
    lcd.print(".");
    clockCounter++;
    if (clockCounter > 16)
    {
      DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
      lcd.clear();
      lcd.print(F("  Failed Clock  "));
      lcd.setCursor(0, 1);
      lcd.print(F(" Syncronization "));
      delay(2000);
      break;
    }
  }
  //
  lcd.clear();
  //Update valve data when first powered on
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    pinMode(relayPin[i], OUTPUT);//<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< ADDED PINMODE HERE
    lcd.print(F(" Updating  "));
    lcd.setCursor(0, 1);
    lcd.print(F(" Valve Data: "));
    lcd.print(i);
    boolean flashIcon = false;
    DEBUG_PRINT(F("Calling for Valve "));
    DEBUG_PRINT(i);
    DEBUG_PRINTLN(F(" Data..."));
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR1);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR2);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR3);
      delay(100);
    }
  }
  lcd.clear();
}
//
void loop()
{
  gw.process();
  updateClock();
  updateDisplay();
  goGetValveTimes();
  //
  if (buttonPushed)
  {
    menuTimer = millis();
    DEBUG_PRINTLN(F("Button Pressed"));
    if (state == STAND_BY_ALL_OFF)
    {
      state = ZONE_SELECT_MENU;
      menuState = 0;
    }
    else if (state == ZONE_SELECT_MENU)
    {
      menuState++;
      if (menuState > NUMBER_OF_VALVES)
      {
        menuState = 0;
      }
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
    buttonPushed = false;
  }
  if (state == STAND_BY_ALL_OFF)
  {
    slowToggleLED ();
    if (state != lastState)
    {
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed... all Zones off"));
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        delay(50);
        gw.send(msg1valve.setSensor(i).set(false), false);
      }
      lcd.clear();
      lcd.setCursor(0,0);
      lcd.print(F("** Irrigation **"));
      lcd.setCursor(0,1);
      lcd.print(F("**   Halted   **"));
      delay(2000);
      lastValve = -1;
    }
  }
  //
  else if (state == RUN_ALL_ZONES)
  {
    if (lastValve != valveNumber)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
      valveNumber = 1;
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      DEBUG_PRINTLN(F("Changing Valves..."));
      updateRelays(ALL_VALVES_OFF);
      startMillis = millis();
      valveNumber++;
      if (valveNumber > NUMBER_OF_VALVES)
      {
        state = CYCLE_COMPLETE;
        startMillis = millis();
        lastValve = -1;
        lastTimeRun = now();
        saveDateToEEPROM(lastTimeRun);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
        DEBUG_PRINT(F("State = "));
        DEBUG_PRINTLN(state);
      }
    }
  }
  //
  else if (state == RUN_SINGLE_ZONE)
  {
    fastToggleLed();
    if (state != lastState)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
      DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
      DEBUG_PRINT(F("Zone: "));
      DEBUG_PRINTLN(valveNumber);
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      updateRelays(ALL_VALVES_OFF);
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        gw.send(msg1valve.setSensor(i).set(false), false);
      }
      state = CYCLE_COMPLETE;
      startMillis = millis();
      DEBUG_PRINT(F("State = "));
      DEBUG_PRINTLN(state);
    }
    lastTimeRun = now();
  }
  else if (state == CYCLE_COMPLETE)
  {
    if (millis() - startMillis < 30000UL)
    {
      fastToggleLed();
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
  }
  else if (state = ZONE_SELECT_MENU)
  {
    displayMenu();
  }
  lastState = state;
}
//
void displayMenu(void)
{
  static byte lastMenuState = -1;
  static int lastSecond;
  if (menuState != lastMenuState)
  {
    lcd.clear();
    lcd.setCursor(0, 0);
    lcd.print(valveNickName[menuState]);
    lcd.setCursor(0, 1);
    lcd.print(F("Starting"));
    DEBUG_PRINT(valveNickName[menuState]);
    Serial.print(F(" Starting Shortly"));
  }
  int thisSecond = (millis() - menuTimer) / 1000UL;
  if (thisSecond != lastSecond && thisSecond < 8)
  {
    lcd.print(F("."));
    Serial.print(".");
  }
  lastSecond = thisSecond;
  if (millis() - menuTimer > 10000UL)
  {
    startMillis = millis();
    if (menuState == 0)
    {
      valveNumber = 1;
      state = RUN_ALL_ZONES;
    }
    else
    {
      valveNumber = menuState;
      state = RUN_SINGLE_ZONE;
    }
  }
  else
  {

  }
  lastMenuState = menuState;
}
//
void updateRelays(int value)
{
  /*<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<  COMMENTED OUT THIS BLOCK BELOW
  digitalWrite(latchPin, LOW);
  shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
  shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
  digitalWrite(latchPin, HIGH);
  */
  //<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<   ADDED THIS BLOCK BELOW
  for (byte i = 0; i < NUMBER_OF_VALVES; i++)
  {
    digitalWrite(relayPin[i], bitRead(value, i));
  }
}
//
void PushButton() //interrupt with debounce
{
  static unsigned long last_interrupt_time = 0;
  unsigned long interrupt_time = millis();
  if (interrupt_time - last_interrupt_time > 200)
  {
    buttonPushed = true;
  }
  last_interrupt_time = interrupt_time;
}
//
void fastToggleLed()
{
  static unsigned long fastLedTimer;
  if (millis() - fastLedTimer >= 100UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    fastLedTimer = millis ();
  }
}
//
void slowToggleLED ()
{
  static unsigned long slowLedTimer;
  if (millis() - slowLedTimer >= 1250UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    slowLedTimer = millis ();
  }
}
//
void getVariables(const MyMessage &message)
{
  boolean zoneTimeUpdate = false;
  if (message.isAck())
  {
    DEBUG_PRINTLN(F("This is an ack from gateway"));
  }
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    if (message.sensor == i)
    {
      if (message.type == V_LIGHT)
      {
        int switchState = atoi(message.data);
        if (switchState == 0)
        {
          state = STAND_BY_ALL_OFF;
          DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
        }
        else
        {
          if (i == 0)
          {
            state = RUN_ALL_ZONES;
            valveNumber = 1;
            DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
          }
          else
          {
            state = RUN_SINGLE_ZONE;
            valveNumber = i;
            DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
            DEBUG_PRINTLN(i);
          }
        }
        startMillis = millis();
      }
      else if (message.type == V_VAR1)
      {
        int variable1 = atoi(message.data);// RUN_ALL_ZONES time
        DEBUG_PRINT(F("Recieved variable1 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable1);
        if (variable1 != allZoneTime[i])
        {
          allZoneTime[i] = variable1;

          zoneTimeUpdate = true;
        }
      }
      else if (message.type == V_VAR2)
      {
        int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
        DEBUG_PRINT(F("Recieved variable2 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable2);
        if (variable2 != valveSoloTime[i])
        {
          valveSoloTime[i] = variable2;
          zoneTimeUpdate = true;
        }
      }
      else if (message.type == V_VAR3)
      {
        String newMessage = String(message.data);
        if (newMessage.length() == 0) 
        {
          DEBUG_PRINT(F("No Name Recieved for zone "));
          DEBUG_PRINTLN(i);
          break;
        }
        if (newMessage.length() > 16)
        {
          newMessage.substring(0, 16);
        }
        valveNickName[i] = "";
        valveNickName[i] += newMessage;
        DEBUG_PRINT(F("Recieved new name for zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" and it is now called: "));
        DEBUG_PRINTLN(valveNickName[i]);
      }
    }
  }
  if (zoneTimeUpdate)
  {
    //
    DEBUG_PRINTLN(F("New Zone Times Recieved..."));
    for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
    {
      if (i != 0)
      {
        DEBUG_PRINT(F("Zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" individual time: "));
        DEBUG_PRINT(valveSoloTime[i]);
        DEBUG_PRINT(F(" group time: "));
        DEBUG_PRINTLN(allZoneTime[i]);
        recentUpdate = true;
      }
    }
  }
  else
  {
    recentUpdate = false;
  }
}
//
void updateDisplay()
{
  static unsigned long lastUpdateTime;
  static boolean displayToggle = false;
  //static byte toggleCounter = 0;
  static SprinklerStates lastDisplayState;
  if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
  {
    displayToggle = !displayToggle;
    switch (state) {
      case STAND_BY_ALL_OFF:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("  System Ready "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
          lcd.print(hourFormat12());
          lcd.print(minute() < 10 ? F(":0") : F(":"));
          lcd.print(minute());
          lcd.print(isAM() ? F("am") : F("pm"));
          lcd.print(month() < 10 ? F(" 0") : F(" "));
          lcd.print(month());
          lcd.print(day() < 10 ? F("/0") : F("/"));
          lcd.print(day());
          lcd.print(F("/"));
          lcd.print(year() % 100);
        }
        else
        {
          lcd.print(F("  Last Watered "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(dayOfWeek[weekday(lastTimeRun)]);
          lcd.setCursor(11, 1);
          lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
          lcd.print(month(lastTimeRun));
          lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/"));
          lcd.print(day(lastTimeRun));
        }
        break;
      case RUN_SINGLE_ZONE:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("Single Zone Mode"));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active"));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          if (valveSoloTime[valveNumber] == 0)
          {
            lcd.print(F(" No Valve Time "));
          }
          else
          {
            unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
            lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
            lcd.print(timeRemaining / 60);
            lcd.print("min");
            lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
            lcd.print(timeRemaining % 60);
            lcd.print("sec  ");
          }
        }
        break;
      case RUN_ALL_ZONES:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F(" All-Zone  Mode "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active "));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
          lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
          lcd.print(timeRemaining / 60);
          lcd.print("min");
          lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
          lcd.print(timeRemaining % 60);
          lcd.print("sec  ");
        }
        break;
      case CYCLE_COMPLETE:
        //
        if (displayToggle)
        {
          lcd.setCursor(0, 0);
          lcd.print(F(" Watering Cycle "));
          lcd.setCursor(0, 1);
          lcd.print(F("    Complete    "));
        }
        else
        {
          int totalTimeRan = 0;
          for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
          {
            totalTimeRan += allZoneTime[i];
          }
          lcd.setCursor(0, 0);
          lcd.print(F(" Total Time Run "));
          lcd.setCursor(0, 1);
          lcd.print(totalTimeRan < 10 ? "   0" : "   ");
          lcd.print(totalTimeRan);
          lcd.print(" Minutes   ");
        }
    }
    lastUpdateTime = millis();
  }
  lastDisplayState = state;
}
void receiveTime(time_t newTime)
{
  DEBUG_PRINTLN(F("Time value received and updated..."));
  int lastSecond = second();
  int lastMinute = minute();
  int lastHour = hour();
  setTime(newTime);
  if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
  {
    DEBUG_PRINTLN(F("Clock updated...."));
    DEBUG_PRINT(F("Sensor's time currently set to:"));
    DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
    DEBUG_PRINT(hourFormat12());
    DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
    DEBUG_PRINT(minute());
    DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
    DEBUG_PRINT(month());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINT(day());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINTLN(year());
    DEBUG_PRINTLN(dayOfWeek[weekday()]);
    showTime = false;
  }
  else
  {
    DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
  }
  clockUpdating = false;
}
void fastClear()
{
  lcd.setCursor(0, 0);
  lcd.print(F("                "));
  lcd.setCursor(0, 1);
  lcd.print(F("                "));
}
//
void updateClock()
{
  static unsigned long lastVeraGetTime;
  if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
  {
    DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(0));
    clockUpdating = true;
    gw.requestTime(receiveTime);
    lastVeraGetTime = millis();
  }
}
//
void saveDateToEEPROM(unsigned long theDate)
{
  DEBUG_PRINTLN(F("Saving Last Run date"));
  if (gw.loadState(0) != 0xFF)
  {
    gw.saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
  }
  //
  for (int i = 1; i < 5; i++)
  {
    gw.saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
  }
}
//
void goGetValveTimes()
{
  static unsigned long valveUpdateTime;
  static byte valveIndex = 1;
  if (millis() - valveUpdateTime >= 300000UL / NUMBER_OF_VALVES)// update each valve once every 5 mins (distributes the traffic)
  {
    DEBUG_PRINTLN(F("Calling for Valve Data..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(1)); //lcd.write(1);
    gw.request(valveIndex, V_VAR1);
    gw.request(valveIndex, V_VAR2);
    gw.request(valveIndex, V_VAR3);
    valveUpdateTime = millis();
    valveIndex++;
    if (valveIndex > NUMBER_OF_VALVES + 1)
    {
      valveIndex = 1;
    }
  }
}

[treb0r]

thank you for this modification. I will test it today. Shall it be working withou any problems with Domoticz on Raspberry Pi?

[BulldogLowell]

@treb0r said:

Shall it be working withou any problems with Domoticz on Raspberry Pi?

I assume so. It is using S_LIGHT, one of the most used device types. I am unsure however if Domoticz supports V_VAR1 & V_VAR2 for that device type, so you may have to check with other forum members who use Domoticz.

[epierre]

Do you think I I could use that kind of design in parallel of a static watering controller, so I could have the basic program with the controller, and manage extras with the arduino/mysensors ?

[Sparkman]

@epierre said:

Do you think I I could use that kind of design in parallel of a static watering controller, so I could have the basic program with the controller, and manage extras with the arduino/mysensors ?

Inspired by @BulldogLowell's controller, I've been working on a MySensors irrigation controller that works in parallel with my RainBird Controller. I'm using a double set of relays (one 5VDC set that's controlled by the Arduino and a 24VAC set that's controlled by the 5VDC relays and the RainBird). This way I can also sense in my HA system when the valves have been opened by the RainBird controller. I have the base functionality finished and working on some additional bells and whistles. Will post some details in a separate thread later today.

Cheers
Al

[treb0r]

Regarding the Video presenting this irrigation project: is the 15 min time, which is counting down after starting the valve via pressing the button, programed somewhere in the arduino code? Or it is taken from timer set in the Vera (or Domoticz) controller?

[treb0r]

@BulldogLowell said:

@treb0r said:

Shall it be working withou any problems with Domoticz on Raspberry Pi?

I assume so. It is using S_LIGHT, one of the most used device types. I am unsure however if Domoticz supports V_VAR1 & V_VAR2 for that device type, so you may have to check with other forum members who use Domoticz.

Well, it is not working. Domoticz finds 5 switches, but on LCD there is Message: Failed Clock Synchronisation, and the Updating Valves but still 0 Is the problems with V_VAR1 & V_VAR2 variables?

[BulldogLowell]

@treb0r said:

Regarding the Video presenting this irrigation project: is the 15 min time, which is counting down after starting the valve via pressing the button, programed somewhere in the arduino code? Or it is taken from timer set in the Vera (or Domoticz) controller?

On my Vera controller (as demonstrated by @petewill ) you would edit the times under Variable1 and Variable2, which corresponds to V_VAR1 and V_VAR2 in the program.

The video shows how to modify the values in the arduino by changing the values. I am not sure if Domoticz supports such dataflow. Does Domoticz support V_VAR1 and V_VAR2?

@treb0r said:

on LCD there is Message: Failed Clock Synchronisation, and the Updating Valves but still 0 Is the problems with V_VAR1 & V_VAR2 variables?

does Domoticz support MySensors time function? That I do not know.

[treb0r]

@BulldogLowell
I am afraid that Domoticz doesn't have such advanced options of configuration of devices. Or maybe I am wrong? Is there any chance to bypass the V_VAR1 variables?

[Moshe Livne]

@treb0r This thread seems to imply that V_VAR1 etc are supported. I guess @AWI can say more about that.

[BulldogLowell]

thanks for your help, @Moshe-Livne

Do you know if Domoticz supports returning Unix timestamp using requestTime()?

[Moshe Livne]

@BulldogLowell Sorry, I don't know.

[BulldogLowell]

thanks @Moshe-Livne

@treb0r said:

@BulldogLowell
I am afraid that Domoticz doesn't have such advanced options of configuration of devices. Or maybe I am wrong? Is there any chance to bypass the V_VAR1 variables?

@treb0r,

If you can find out if V_VAR1 & V_VAR2 can work you can try that. Otherwise we can hard code the watering times by zone into the programming.

If requestTime() isn't supported, we can attach a Real Time Clock (RTC) device to gain back the clock functionality.

You can then use the Domoticz devices to start the ALL_ZONE sequence or individual zones...

Let me know what you would like to do and I can modify the program for you.

[treb0r]

@BulldogLowell

requestTime() seems not be supported. A have rtc ds3231 or ds1307. They can use the same commands and libraries. If you would change the code that would perfect As you proposed you would also include in the code the timers for zones, instead of requesting them from Domoticz. As I understand these timers are only for manuals starts (via button) right?

[BulldogLowell]

@treb0r said:

@BulldogLowell
As I understand these timers are only for manuals starts (via button) right?

Well, those times will be used when you activate the device using the Domoticz on/off controls (or activate using 'scene' in Domotocz.

Give me a day or so and I will try to code for you.

[BulldogLowell]

@treb0r

Would you like to try this, untested.

Just to see if the RTC is working...

/*
MySprinkler for MySensors

Arduino Multi-Zone Sprinkler Control

June 30, 2015

*** Version 2.0nsr //MODIFIED FOR NO SHIFT REGISTER

*** Upgraded to http://MySensors.org version 1.4.1
*** Expanded for up to 16 Valves
*** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
*** Switch to bitshift method vs byte arrays
*** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
*** Added optional LCD display featuring remaining time, date last ran & current time
*** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively
*** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone)
*** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names)

Utilizing your Vera home automation controller and the MySensors.org gateway you can
control up to a sixteen zone irrigation system with only three digital pins.  This sketch
will create NUMBER_OF_VALVES + 1 devices on your Vera controller

This sketch features the following:

* Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.
* Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n)
  using Variable1 as the "ON" time in minutes in each of the vera devices created.
* Use the individual zone controller to activate a single zone.  This feature uses
  Variable2 as the "ON" time for each individual device/zone.
* Connect according to pinout below and uses Shift Registers as to allow the MySensors
  standard radio configuration and still leave available digital pins
* Turning on any zone will stop the current process and begin that particular process.
* Turning off any zone will stop the current process and turn off all zones.
* To push your new time intervals for your zones, simply change the variable on your Vera and
  your arduino will call to Vera once a minute and update accordingly.  Variables will also be
  requested when the device is first powered on.
* Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program
* LED status indicator

PARTS LIST:
Available from the MySensors store - http://www.mysensors.org/store/
* Relays (8 channel)
* Female Pin Header Connector Strip
* Prototype Universal Printed Circuit Boards (PCB)
* NRF24L01 Radio
* Arduino (I used a Pro Mini)
* FTDI USB to TTL Serial Adapter
* Capacitors (10uf and .1uf)
* 3.3v voltage regulator
* Resistors (270 & 10K)
* Female Dupont Cables
* 1602 LCD (with I2C Interface)
* LED
* Push button
* Shift Register (SN74HC595)
* 2 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 3 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 22-24 gauge wire or similar (I used Cat5/Cat6 cable)
* 18 gauge wire (for relay)
* Irrigation Power Supply (24-Volt/750 mA Transformer)


INSTRUCTIONS:

* A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI
* After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to
  A4 and A5) and relays, and load the sketch.
* Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
* Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
  the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
  you may use the defaulet zone names by leaving Variable3 blank.
* Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
* Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
  on the serial monitor.
* Your arduino should slow-flash, indicating that it is in ready mode.
* There are multiple debug serial prints that can be monitored to assure that it is operating properly.
* ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours

Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain
*/
//
#include <Wire.h>
#include <DS1307RTC.h>
#include <Time.h>
#include <MySensor.h>
#include <SPI.h>
#include <LiquidCrystal.h>
#include <LiquidCrystal_I2C.h>
//

//
#define NUMBER_OF_VALVES 4  // Change this to set your valve count up to 16.
#define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
#define RADIO_ID AUTO  // Change this to fix your Radio ID or use Auto

#define SKETCH_NAME "MySprinkler"
#define SKETCH_VERSION "2.0nsr"
//
#define CHILD_ID_SPRINKLER 0
//
#define ACTIVE_LOW // comment out this line if your relays are active high
//
#define DEBUG_ON   // comment out to supress serial monitor output
//
#ifdef ACTIVE_LOW
#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
#define ALL_VALVES_OFF 0xFFFF
#else
#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
#define ALL_VALVES_OFF 0U
#endif
//
#ifdef DEBUG_ON
#define DEBUG_PRINT(x)   Serial.print(x)
#define DEBUG_PRINTLN(x) Serial.println(x)
#define SERIAL_START(x)  Serial.begin(x)
#else
#define DEBUG_PRINT(x)
#define DEBUG_PRINTLN(x)
#define SERIAL_START(x)
#endif
//
typedef enum {
  STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
}
SprinklerStates;
//
SprinklerStates state = STAND_BY_ALL_OFF;
SprinklerStates lastState;
//
const int relayPin[NUMBER_OF_VALVES] = {5, 6, 7, 8}; //<<<<<<<<<<<<<<<<<<< YOUR DIGITAL PINS HERE
//
byte menuState = 0;
unsigned long menuTimer;
byte countDownTime = 10;
//
int allZoneTime [NUMBER_OF_VALVES + 1] = {0, 1, 1, 1, 1}; //minutes
int valveSoloTime [NUMBER_OF_VALVES + 1] = {0, 2, 2, 2, 2};
int valveNumber;
int lastValve;
unsigned long startMillis;
const int ledPin = 4;
const int waterButtonPin = 3;
boolean buttonPushed = false;
boolean showTime = true;
boolean clockUpdating = false;
boolean recentUpdate = true;
const char *verboseDayOfWeek[] = {
  /*"Null",*/ "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
};
// Name your Zones here or use Vera to edit them by adding a name in Variable3...
String valveNickName[17] = {
  "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
};
//
time_t lastTimeRun = 0;
/*Setup Shift Register...<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< COMMENTED OUT THIS BIT
const int latchPin = 8;
const int clockPin = 4;
const int dataPin  = 7;
*/
byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
// Set the pins on the I2C chip used for LCD connections:
//                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27
MySensor gw;
//
MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);
//
//
void setup()
{
  SERIAL_START(115200);
  DEBUG_PRINTLN(F("Initialising..."));
  pinMode(ledPin, OUTPUT);
  pinMode(waterButtonPin, INPUT_PULLUP);
  //pinMode(waterButtonPin, INPUT);
  attachInterrupt(1, PushButton, RISING); //May need to change for your Arduino model
  digitalWrite (ledPin, HIGH);
  DEBUG_PRINTLN(F("Turning All Valves Off..."));
  updateRelays(ALL_VALVES_OFF);
  //delay(5000);
  lcd.begin(16, 2); //(16 characters and 2 line display)
  lcd.clear();
  lcd.backlight();
  lcd.createChar(0, clock);
  lcd.createChar(1, raindrop);
  //
  // RTC setup
  setSyncProvider(RTC.get);   // the function to get the time from the RTC
  if(timeStatus()!= timeSet) 
     Serial.println("Unable to sync with the RTC");
  else
     Serial.println("RTC has set the system time"); 
  //
  //check for saved date in EEPROM
  DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
  delay(500);
  if (gw.loadState(0) == 0xFF); // EEPROM flag
  {
    DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
    for (int i = 0; i < 4 ; i++)
    {
      lastTimeRun = lastTimeRun << 8;
      lastTimeRun = lastTimeRun | gw.loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
    }
  }
  gw.begin(getVariables, RADIO_ID, false); // Change 'false' to 'true' to create a Radio repeating node
  gw.sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    gw.present(i, S_LIGHT);
  }
  DEBUG_PRINTLN(F("Sensor Presentation Complete"));
  //
  digitalWrite (ledPin, LOW);
  DEBUG_PRINTLN(F("Ready..."));
  //
  lcd.clear();
  //Update valve data when first powered on
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    pinMode(relayPin[i], OUTPUT);
    lcd.print(F(" Updating  "));
    lcd.setCursor(0, 1);
    lcd.print(F(" Valve Data: "));
    lcd.print(i);
    boolean flashIcon = false;
    DEBUG_PRINT(F("Calling for Valve "));
    DEBUG_PRINT(i);
    DEBUG_PRINTLN(F(" Data..."));
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR1);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR2);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR3);
      delay(100);
    }
  }
  lcd.clear();
}
//
void loop()
{
  gw.process();
  updateDisplay();
  goGetValveTimes();
  //
  if (buttonPushed)
  {
    menuTimer = millis();
    DEBUG_PRINTLN(F("Button Pressed"));
    if (state == STAND_BY_ALL_OFF)
    {
      state = ZONE_SELECT_MENU;
      menuState = 0;
    }
    else if (state == ZONE_SELECT_MENU)
    {
      menuState++;
      if (menuState > NUMBER_OF_VALVES)
      {
        menuState = 0;
      }
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
    buttonPushed = false;
  }
  if (state == STAND_BY_ALL_OFF)
  {
    slowToggleLED ();
    if (state != lastState)
    {
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed... all Zones off"));
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        delay(50);
        gw.send(msg1valve.setSensor(i).set(false), false);
      }
      lcd.clear();
      lcd.setCursor(0, 0);
      lcd.print(F("** Irrigation **"));
      lcd.setCursor(0, 1);
      lcd.print(F("**   Halted   **"));
      delay(2000);
      lastValve = -1;
    }
  }
  //
  else if (state == RUN_ALL_ZONES)
  {
    if (lastValve != valveNumber)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
      valveNumber = 1;
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      DEBUG_PRINTLN(F("Changing Valves..."));
      updateRelays(ALL_VALVES_OFF);
      startMillis = millis();
      valveNumber++;
      if (valveNumber > NUMBER_OF_VALVES)
      {
        state = CYCLE_COMPLETE;
        startMillis = millis();
        lastValve = -1;
        lastTimeRun = now();
        saveDateToEEPROM(lastTimeRun);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
        DEBUG_PRINT(F("State = "));
        DEBUG_PRINTLN(state);
      }
    }
  }
  //
  else if (state == RUN_SINGLE_ZONE)
  {
    fastToggleLed();
    if (state != lastState)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
      DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
      DEBUG_PRINT(F("Zone: "));
      DEBUG_PRINTLN(valveNumber);
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      updateRelays(ALL_VALVES_OFF);
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        gw.send(msg1valve.setSensor(i).set(false), false);
      }
      state = CYCLE_COMPLETE;
      startMillis = millis();
      DEBUG_PRINT(F("State = "));
      DEBUG_PRINTLN(state);
    }
    lastTimeRun = now();
  }
  else if (state == CYCLE_COMPLETE)
  {
    if (millis() - startMillis < 30000UL)
    {
      fastToggleLed();
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
  }
  else if (state = ZONE_SELECT_MENU)
  {
    displayMenu();
  }
  lastState = state;
}
//
void displayMenu(void)
{
  static byte lastMenuState = -1;
  static int lastSecond;
  if (menuState != lastMenuState)
  {
    lcd.clear();
    lcd.setCursor(0, 0);
    lcd.print(valveNickName[menuState]);
    lcd.setCursor(0, 1);
    lcd.print(F("Starting"));
    DEBUG_PRINT(valveNickName[menuState]);
    Serial.print(F(" Starting Shortly"));
  }
  int thisSecond = (millis() - menuTimer) / 1000UL;
  if (thisSecond != lastSecond && thisSecond < 8)
  {
    lcd.print(F("."));
    Serial.print(".");
  }
  lastSecond = thisSecond;
  if (millis() - menuTimer > 10000UL)
  {
    startMillis = millis();
    if (menuState == 0)
    {
      valveNumber = 1;
      state = RUN_ALL_ZONES;
    }
    else
    {
      valveNumber = menuState;
      state = RUN_SINGLE_ZONE;
    }
  }
  else
  {

  }
  lastMenuState = menuState;
}
//
void updateRelays(int value)
{
  for (byte i = 0; i < NUMBER_OF_VALVES; i++)
  {
    digitalWrite(relayPin[i], bitRead(value, i));
  }
}
//
void PushButton() //interrupt with debounce
{
  static unsigned long last_interrupt_time = 0;
  unsigned long interrupt_time = millis();
  if (interrupt_time - last_interrupt_time > 200)
  {
    buttonPushed = true;
  }
  last_interrupt_time = interrupt_time;
}
//
void fastToggleLed()
{
  static unsigned long fastLedTimer;
  if (millis() - fastLedTimer >= 100UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    fastLedTimer = millis ();
  }
}
//
void slowToggleLED ()
{
  static unsigned long slowLedTimer;
  if (millis() - slowLedTimer >= 1250UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    slowLedTimer = millis ();
  }
}
//
void getVariables(const MyMessage &message)
{
  boolean zoneTimeUpdate = false;
  if (message.isAck())
  {
    DEBUG_PRINTLN(F("This is an ack from gateway"));
  }
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    if (message.sensor == i)
    {
      if (message.type == V_LIGHT)
      {
        int switchState = atoi(message.data);
        if (switchState == 0)
        {
          state = STAND_BY_ALL_OFF;
          DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
        }
        else
        {
          if (i == 0)
          {
            state = RUN_ALL_ZONES;
            valveNumber = 1;
            DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
          }
          else
          {
            state = RUN_SINGLE_ZONE;
            valveNumber = i;
            DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
            DEBUG_PRINTLN(i);
          }
        }
        startMillis = millis();
      }
      else if (message.type == V_VAR1)
      {
        int variable1 = atoi(message.data);// RUN_ALL_ZONES time
        DEBUG_PRINT(F("Recieved variable1 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable1);
        if (variable1 != allZoneTime[i])
        {
          allZoneTime[i] = variable1;

          zoneTimeUpdate = true;
        }
      }
      else if (message.type == V_VAR2)
      {
        int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
        DEBUG_PRINT(F("Recieved variable2 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable2);
        if (variable2 != valveSoloTime[i])
        {
          valveSoloTime[i] = variable2;
          zoneTimeUpdate = true;
        }
      }
      else if (message.type == V_VAR3)
      {
        String newMessage = String(message.data);
        if (newMessage.length() == 0)
        {
          DEBUG_PRINT(F("No Name Recieved for zone "));
          DEBUG_PRINTLN(i);
          break;
        }
        if (newMessage.length() > 16)
        {
          newMessage.substring(0, 16);
        }
        valveNickName[i] = "";
        valveNickName[i] += newMessage;
        DEBUG_PRINT(F("Recieved new name for zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" and it is now called: "));
        DEBUG_PRINTLN(valveNickName[i]);
      }
    }
  }
  if (zoneTimeUpdate)
  {
    //
    DEBUG_PRINTLN(F("New Zone Times Recieved..."));
    for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
    {
      if (i != 0)
      {
        DEBUG_PRINT(F("Zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" individual time: "));
        DEBUG_PRINT(valveSoloTime[i]);
        DEBUG_PRINT(F(" group time: "));
        DEBUG_PRINTLN(allZoneTime[i]);
        recentUpdate = true;
      }
    }
  }
  else
  {
    recentUpdate = false;
  }
}
//
void updateDisplay()
{
  static unsigned long lastUpdateTime;
  static boolean displayToggle = false;
  //static byte toggleCounter = 0;
  static SprinklerStates lastDisplayState;
  if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
  {
    displayToggle = !displayToggle;
    switch (state) {
      case STAND_BY_ALL_OFF:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("  System Ready "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
          lcd.print(hourFormat12());
          lcd.print(minute() < 10 ? F(":0") : F(":"));
          lcd.print(minute());
          lcd.print(isAM() ? F("am") : F("pm"));
          lcd.print(month() < 10 ? F(" 0") : F(" "));
          lcd.print(month());
          lcd.print(day() < 10 ? F("/0") : F("/"));
          lcd.print(day());
          lcd.print(F("/"));
          lcd.print(year() % 100);
        }
        else
        {
          lcd.print(F("  Last Watered "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(verboseDayOfWeek[weekday(lastTimeRun)]);
          lcd.setCursor(11, 1);
          lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
          lcd.print(month(lastTimeRun));
          lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/"));
          lcd.print(day(lastTimeRun));
        }
        break;
      case RUN_SINGLE_ZONE:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("Single Zone Mode"));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active"));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          if (valveSoloTime[valveNumber] == 0)
          {
            lcd.print(F(" No Valve Time "));
          }
          else
          {
            unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
            lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
            lcd.print(timeRemaining / 60);
            lcd.print("min");
            lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
            lcd.print(timeRemaining % 60);
            lcd.print("sec  ");
          }
        }
        break;
      case RUN_ALL_ZONES:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F(" All-Zone  Mode "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active "));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
          lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
          lcd.print(timeRemaining / 60);
          lcd.print("min");
          lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
          lcd.print(timeRemaining % 60);
          lcd.print("sec  ");
        }
        break;
      case CYCLE_COMPLETE:
        //
        if (displayToggle)
        {
          lcd.setCursor(0, 0);
          lcd.print(F(" Watering Cycle "));
          lcd.setCursor(0, 1);
          lcd.print(F("    Complete    "));
        }
        else
        {
          int totalTimeRan = 0;
          for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
          {
            totalTimeRan += allZoneTime[i];
          }
          lcd.setCursor(0, 0);
          lcd.print(F(" Total Time Run "));
          lcd.setCursor(0, 1);
          lcd.print(totalTimeRan < 10 ? "   0" : "   ");
          lcd.print(totalTimeRan);
          lcd.print(" Minutes   ");
        }
    }
    lastUpdateTime = millis();
  }
  lastDisplayState = state;
}
//
void fastClear()
{
  lcd.setCursor(0, 0);
  lcd.print(F("                "));
  lcd.setCursor(0, 1);
  lcd.print(F("                "));
}
//
void saveDateToEEPROM(unsigned long theDate)
{
  DEBUG_PRINTLN(F("Saving Last Run date"));
  if (gw.loadState(0) != 0xFF)
  {
    gw.saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
  }
  //
  for (int i = 1; i < 5; i++)
  {
    gw.saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
  }
}
//
void goGetValveTimes()
{
  static unsigned long valveUpdateTime;
  static byte valveIndex = 1;
  if (millis() - valveUpdateTime >= 300000UL / NUMBER_OF_VALVES)// update each valve once every 5 mins (distributes the traffic)
  {
    DEBUG_PRINTLN(F("Calling for Valve Data..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(1)); //lcd.write(1);
    gw.request(valveIndex, V_VAR1);
    gw.request(valveIndex, V_VAR2);
    gw.request(valveIndex, V_VAR3);
    valveUpdateTime = millis();
    valveIndex++;
    if (valveIndex > NUMBER_OF_VALVES + 1)
    {
      valveIndex = 1;
    }
  }
}

[treb0r]

@BulldogLowell
HI
Thanks for the post. On LCD there is no info about Time Synchronisation fail. It stops, as previously on info: Updating Valve : 0
So I cant check if the RTC is working
treb0r

[BulldogLowell]

@treb0r

did you get your RTC connected and tested?

[treb0r]

@BulldogLowell
Yes, RTC is connected and tested with different sketches (just to check if RTC work correctly). Works ok.
With your correctes projects, as above mentioned: On LCD there is no info neither about Time Synchronisation, nor about Time Synchronisation fail. It stops, as previously on info: Updating Valve : 0
treb0r

[BulldogLowell]

Yes, since clock no longer needs to call server for time, synchronizing is not necessary.

You should post serial output or show a video.

Did you find out if Domoticz supports V_VAR1?

[treb0r]

@BulldogLowell
OK, I will post the video. If I will manage I will also post serial output
treb0r

[Moshe Livne]

@treb0r @BulldogLowel I had a chance to play a little bit with VAR1 this weekend. I verified that if you declare MyMessage var(CHILD_ID, V_VAR1); you can set it with gw.send(var.set("hello")); and request its value from the gateway using gw.request(CHILD_ID, V_VAR1);. you will get the answer in the incoming message handler under the V_VAR1 message

   if (message.type==V_VAR1) {
   	 Serial.println("got var1 answer");
   	 Serial.println(message.getString());
   }

However I still didn't manage to find how to access or show these values on the domoticz. their site crashed so couldn't ask this in the forum

[epierre]

@Moshe-Livne Domoticz (as of today) doesn't support V_VARx ...

[Moshe Livne]

@epierre it does but in a strange way. The vars are not display vars. They are stored in the db and can be fetched and set only by the sensor. Tried it, it works....

[epierre]

@Moshe-Livne this is not what @GizMoCuz said in a post... strange...

[Moshe Livne]

@epierre can you please link to the post?

[epierre]

here it is:

http://www.domoticz.com/forum/viewtopic.php?f=42&t=7187&p=48366&hilit=v_var#p48366

[Moshe Livne]

@epierre He meant in the sense that it does not display or use it for anything. he said there "it is used to store/retrieve variables". The thread was about the option to show the vars as part of the sensor output. for storing and retrieving, it works.... verified.... I might get annoyed enough to add to the code that the lua script can also retrieve these vars and then it would be sweet.....

[epierre]

ok good although it was not explicit... now I'll have to go back to him about water meter that heavily use V_VARs but is recognized.... as a power meter...

[moffen666]

Hello
And thx for a nice forum, I did build the irrigation controller and tried to connect it to Domoticz. Everything just seems fine, LCD works, push button works and I can turn on the irrigation from Domoticz and it shows in the LCD.

But the problem is that it doesn't switch the relays on, it just says "no valve time" and then go watering cycle complete.

Any suggestions on what the problem might be...... Domoticz?

Regards

[BulldogLowell]

@moffen666

I don't have Domoticz but I suspect that the callback isn't functioning.

try populating the array with the desired times for each sequence. replace this:

int allZoneTime [NUMBER_OF_VALVES + 1];
int valveSoloTime [NUMBER_OF_VALVES + 1];

with something like this:

int allZoneTime [NUMBER_OF_VALVES + 1] = {0, 10, 10, 10, 5,<... how many valves you have with zero in the first position>} ;
int valveSoloTime [NUMBER_OF_VALVES + 1] = {0, 5, 5, 5, 5,<... how many valves you have with zero in the first position>};

This will load in the times that the program uses as your 'default' values. Then, you can check with Domoticz experts on getting the V_VAR variables working.

[moffen666]

Thx Bulldog
I will check asap and get back with the result.

Regards

[moffen666]

Hi
I tried the code but it didn't compile, and I'm not good enough to be sure whats wrong.

I did try change the code and I did get it to compile, but I don't know if I got it right. You can see the lame attempt below the colored line.

[BulldogLowell]

@moffen666

Clearly you understand that you are to put the times for each of the valve zones, led by a zero into the array, and not copy my verbatim instructions...

How many valves do you have? You need that many (plus one) integer numbers separated by commas...

Example 8 valves:

...= {0,5,5,5,5,5,5,5,5};

You've commented out the wrong lines.

[moffen666]

Thx for the quick answer

I use 4 valves atm, I tried your suggestion but it seems it wont work for me.

Regards

[moffen666]

The inserted values in the array works from start, but it looks like the irrigation controller immediately starts to request valve data from the controller for variable1 and 2. As we cant set variable1 and 2 in Domoticz I guess it returns 0 and overwrite the inserted values in the arrays...or is it anything else happening?

Initialising...
Turning All Valves Off...
Unable to sync with the RTC
Checking EEPROM for stored date:
Retreiving last run time from EEPROM...
send: 7-7-0-0 s=255,c=0,t=17,pt=0,l=3,sg=0,st=ok:1.5
send: 7-7-0-0 s=255,c=3,t=6,pt=1,l=1,sg=0,st=ok:0
read: 0-0-7 s=255,c=3,t=6,pt=0,l=1,sg=0:M
sensor started, id=7, parent=0, distance=1
send: 7-7-0-0 s=255,c=3,t=11,pt=0,l=11,sg=0,st=ok:MySprinkler
send: 7-7-0-0 s=255,c=3,t=12,pt=0,l=6,sg=0,st=ok:2.0nsr
send: 7-7-0-0 s=0,c=0,t=3,pt=0,l=0,sg=0,st=ok:
send: 7-7-0-0 s=1,c=0,t=3,pt=0,l=0,sg=0,st=ok:
send: 7-7-0-0 s=2,c=0,t=3,pt=0,l=0,sg=0,st=ok:
send: 7-7-0-0 s=3,c=0,t=3,pt=0,l=0,sg=0,st=ok:
send: 7-7-0-0 s=4,c=0,t=3,pt=0,l=0,sg=0,st=ok:
Sensor Presentation Complete
Ready...
Calling for Valve 0 Data...
send: 7-7-0-0 s=0,c=2,t=24,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=0,c=2,t=24,pt=0,l=0,sg=0:
Recieved variable1 valve:0 = 0
send: 7-7-0-0 s=0,c=2,t=25,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=0,c=2,t=25,pt=0,l=0,sg=0:
Recieved variable2 valve:0 = 0
send: 7-7-0-0 s=0,c=2,t=26,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=0,c=2,t=26,pt=0,l=0,sg=0:
No Name Recieved for zone 0
Calling for Valve 1 Data...
send: 7-7-0-0 s=1,c=2,t=24,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=1,c=2,t=24,pt=0,l=0,sg=0:
Recieved variable1 valve:1 = 0
New Zone Times Recieved...
Zone 1 individual time: 1 group time: 0
Zone 2 individual time: 1 group time: 1
Zone 3 individual time: 1 group time: 1
Zone 4 individual time: 1 group time: 1
send: 7-7-0-0 s=1,c=2,t=25,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=1,c=2,t=25,pt=0,l=0,sg=0:
Recieved variable2 valve:1 = 0
New Zone Times Recieved...
Zone 1 individual time: 0 group time: 0
Zone 2 individual time: 1 group time: 1
Zone 3 individual time: 1 group time: 1
Zone 4 individual time: 1 group time: 1
send: 7-7-0-0 s=1,c=2,t=26,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=1,c=2,t=26,pt=0,l=0,sg=0:
No Name Recieved for zone 1
Calling for Valve 2 Data...
send: 7-7-0-0 s=2,c=2,t=24,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=2,c=2,t=24,pt=0,l=0,sg=0:
Recieved variable1 valve:2 = 0
New Zone Times Recieved...
Zone 1 individual time: 0 group time: 0
Zone 2 individual time: 1 group time: 0
Zone 3 individual time: 1 group time: 1
Zone 4 individual time: 1 group time: 1
send: 7-7-0-0 s=2,c=2,t=25,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=2,c=2,t=25,pt=0,l=0,sg=0:
Recieved variable2 valve:2 = 0
New Zone Times Recieved...
Zone 1 individual time: 0 group time: 0
Zone 2 individual time: 0 group time: 0
Zone 3 individual time: 1 group time: 1
Zone 4 individual time: 1 group time: 1
send: 7-7-0-0 s=2,c=2,t=26,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=2,c=2,t=26,pt=0,l=0,sg=0:
No Name Recieved for zone 2
Calling for Valve 3 Data...
send: 7-7-0-0 s=3,c=2,t=24,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=3,c=2,t=24,pt=0,l=0,sg=0:
Recieved variable1 valve:3 = 0
New Zone Times Recieved...
Zone 1 individual time: 0 group time: 0
Zone 2 individual time: 0 group time: 0
Zone 3 individual time: 1 group time: 0
Zone 4 individual time: 1 group time: 1
send: 7-7-0-0 s=3,c=2,t=25,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=3,c=2,t=25,pt=0,l=0,sg=0:
Recieved variable2 valve:3 = 0
New Zone Times Recieved...
Zone 1 individual time: 0 group time: 0
Zone 2 individual time: 0 group time: 0
Zone 3 individual time: 0 group time: 0
Zone 4 individual time: 1 group time: 1
send: 7-7-0-0 s=3,c=2,t=26,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=3,c=2,t=26,pt=0,l=0,sg=0:
No Name Recieved for zone 3
Calling for Valve 4 Data...
send: 7-7-0-0 s=4,c=2,t=24,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=4,c=2,t=24,pt=0,l=0,sg=0:
Recieved variable1 valve:4 = 0
New Zone Times Recieved...
Zone 1 individual time: 0 group time: 0
Zone 2 individual time: 0 group time: 0
Zone 3 individual time: 0 group time: 0
Zone 4 individual time: 1 group time: 0
send: 7-7-0-0 s=4,c=2,t=25,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=4,c=2,t=25,pt=0,l=0,sg=0:
Recieved variable2 valve:4 = 0
New Zone Times Recieved...
Zone 1 individual time: 0 group time: 0
Zone 2 individual time: 0 group time: 0
Zone 3 individual time: 0 group time: 0
Zone 4 individual time: 0 group time: 0
send: 7-7-0-0 s=4,c=2,t=26,pt=0,l=0,sg=0,st=ok:
read: 0-0-7 s=4,c=2,t=26,pt=0,l=0,sg=0:
No Name Recieved for zone 4

[BulldogLowell]

@moffen666

try commenting out this in setup():

/*
for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    pinMode(relayPin[i], OUTPUT);
    lcd.print(F(" Updating  "));
    lcd.setCursor(0, 1);
    lcd.print(F(" Valve Data: "));
    lcd.print(i);
    boolean flashIcon = false;
    DEBUG_PRINT(F("Calling for Valve "));
    DEBUG_PRINT(i);
    DEBUG_PRINTLN(F(" Data..."));
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR1);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR2);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR3);
      delay(100);
    }
  }*/

and this in loop():

//goGetValveTimes();

That will disable those callbacks and you should be OK with a HardCoded time table for the valves and valve names.

[moffen666]

Thx Bulldog for all the help, everything seems to be working as it should now.

Keep up the good work

Updated code for Domoticz.

/*
MySprinkler for MySensors

Arduino Multi-Zone Sprinkler Control

May 31, 2015

*** Version 2.0

*** Upgraded to http://MySensors.org version 1.4.1
*** Expanded for up to 16 Valves
*** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
*** Switch to bitshift method vs byte arrays
*** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
*** Added optional LCD display featuring remaining time, date last ran & current time
*** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively
*** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone)
*** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names)

Utilizing your Vera home automation controller and the MySensors.org gateway you can
control up to a sixteen zone irrigation system with only three digital pins.  This sketch
will create NUMBER_OF_VALVES + 1 devices on your Vera controller

This sketch features the following:

* Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.
* Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n)
  using Variable1 as the "ON" time in minutes in each of the vera devices created.
* Use the individual zone controller to activate a single zone.  This feature uses
  Variable2 as the "ON" time for each individual device/zone.
* Connect according to pinout below and uses Shift Registers as to allow the MySensors
  standard radio configuration and still leave available digital pins
* Turning on any zone will stop the current process and begin that particular process.
* Turning off any zone will stop the current process and turn off all zones.
* To push your new time intervals for your zones, simply change the variable on your Vera and
  your arduino will call to Vera once a minute and update accordingly.  Variables will also be
  requested when the device is first powered on.
* Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program
* LED status indicator

PARTS LIST:
Available from the MySensors store - http://www.mysensors.org/store/
* Relays (8 channel)
* Female Pin Header Connector Strip
* Prototype Universal Printed Circuit Boards (PCB)
* NRF24L01 Radio
* Arduino (I used a Pro Mini)
* FTDI USB to TTL Serial Adapter
* Capacitors (10uf and .1uf)
* 3.3v voltage regulator
* Resistors (270 & 10K)
* Female Dupont Cables
* 1602 LCD (with I2C Interface)
* LED
* Push button
* Shift Register (SN74HC595)
* 2 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 3 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 22-24 gauge wire or similar (I used Cat5/Cat6 cable)
* 18 gauge wire (for relay)
* Irrigation Power Supply (24-Volt/750 mA Transformer)


INSTRUCTIONS:

* A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI
* After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to
  A4 and A5) and relays, and load the sketch.
* Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
* Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
  the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
  you may use the defaulet zone names by leaving Variable3 blank.
* Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
* Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
  on the serial monitor.
* Your arduino should slow-flash, indicating that it is in ready mode.
* There are multiple debug serial prints that can be monitored to assure that it is operating properly.
* ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours

Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain
*/
//
#include <Wire.h>
#include <Time.h>
#include <MySensor.h>
#include <SPI.h>
#include <LiquidCrystal.h>
#include <LiquidCrystal_I2C.h>


//
#define NUMBER_OF_VALVES 4  // Change this to set your valve count up to 16.
#define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
#define RADIO_ID AUTO  // Change this to fix your Radio ID or use Auto

#define SKETCH_NAME "MySprinkler Domoticz"
#define SKETCH_VERSION "2.0"
//
#define CHILD_ID_SPRINKLER 0
//
//#define ACTIVE_LOW // comment out this line if your relays are active high
//
#define DEBUG_ON   // comment out to supress serial monitor output
//
#ifdef ACTIVE_LOW
#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
#define ALL_VALVES_OFF 0xFFFF
#else
#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
#define ALL_VALVES_OFF 0U
#endif
//
#ifdef DEBUG_ON
#define DEBUG_PRINT(x)   Serial.print(x)
#define DEBUG_PRINTLN(x) Serial.println(x)
#define SERIAL_START(x)  Serial.begin(x)
#else
#define DEBUG_PRINT(x)
#define DEBUG_PRINTLN(x)
#define SERIAL_START(x)
#endif
//
typedef enum {
  STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
}
SprinklerStates;
//
SprinklerStates state = STAND_BY_ALL_OFF;
SprinklerStates lastState;
byte menuState = 0;
unsigned long menuTimer;
byte countDownTime = 10;
//
int allZoneTime [NUMBER_OF_VALVES + 1]= {0, 1, 1, 1, 1};     // Insert values in min, 0 = all zone (always 0) this is a 4 chan relay
int valveSoloTime [NUMBER_OF_VALVES + 1]= {0, 1, 1, 1, 1};   // Insert values in min, 0 = all zone (always 0) this is a 4 chan relay
int valveNumber;
int lastValve;
unsigned long startMillis;
const int ledPin = 5;
const int waterButtonPin = 3;
boolean buttonPushed = false;
boolean showTime = true;
boolean clockUpdating = false;
boolean recentUpdate = true;
const char *dayOfWeek[] = {
  "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
};
// Name your Zones here or use Vera to edit them by adding a name in Variable3...
String valveNickName[17] = {
  "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
};
//
time_t lastTimeRun = 0;
//Setup Shift Register...
const int latchPin = 8;
const int clockPin = 4;
const int dataPin  = 7;
//
byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
// Set the pins on the I2C chip used for LCD connections:
//                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27
MySensor gw;
//
MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);
//
void setup()
{
  SERIAL_START(115200);
  DEBUG_PRINTLN(F("Initialising..."));
  pinMode(latchPin, OUTPUT);
  pinMode(clockPin, OUTPUT);
  pinMode(dataPin, OUTPUT);
  pinMode(ledPin, OUTPUT);
  pinMode(waterButtonPin, INPUT_PULLUP);
  //pinMode(waterButtonPin, INPUT);
  attachInterrupt(1, PushButton, RISING); //May need to change for your Arduino model
  digitalWrite (ledPin, HIGH);
  DEBUG_PRINTLN(F("Turning All Valves Off..."));
  updateRelays(ALL_VALVES_OFF);
  //delay(5000);
  lcd.begin(16, 2); //(16 characters and 2 line display)
  lcd.clear();
  lcd.backlight();
  lcd.createChar(0, clock);
  lcd.createChar(1, raindrop);
  //
  //check for saved date in EEPROM
  DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
  delay(500);
  if (gw.loadState(0) == 0xFF); // EEPROM flag
  {
    DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
    for (int i = 0; i < 4 ; i++)
    {
      lastTimeRun = lastTimeRun << 8;
      lastTimeRun = lastTimeRun | gw.loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
    }
  }
  gw.begin(getVariables, RADIO_ID, false); // Change 'false' to 'true' to create a Radio repeating node
  gw.sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    gw.present(i, S_LIGHT);
  }
  DEBUG_PRINTLN(F("Sensor Presentation Complete"));
  //
  digitalWrite (ledPin, LOW);
  DEBUG_PRINTLN(F("Ready..."));
  //
  lcd.setCursor(0, 0);
  lcd.print(F(" Syncing Time  "));
  lcd.setCursor(15, 0);
  lcd.write(byte(0));
  lcd.setCursor(0, 1);
  int clockCounter = 0;
  while (timeStatus() == timeNotSet && clockCounter < 21)
  {
    gw.process();
    gw.requestTime(receiveTime);
    DEBUG_PRINTLN(F("Requesting time from Gateway:"));
    delay(1000);
    lcd.print(".");
    clockCounter++;
    if (clockCounter > 16)
    {
      DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
      lcd.clear();
      lcd.print(F("  Failed Clock  "));
      lcd.setCursor(0, 1);
      lcd.print(F(" Syncronization "));
      delay(2000);
      break;
    }
  }
  //
  lcd.clear();

  /*
  //Update valve data when first powered on
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    lcd.print(F(" Updating  "));
    lcd.setCursor(0, 1);
    lcd.print(F(" Valve Data: "));
    lcd.print(i);
    boolean flashIcon = false;
    DEBUG_PRINT(F("Calling for Valve "));
    DEBUG_PRINT(i);
    DEBUG_PRINTLN(F(" Data..."));
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR1);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR2);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR3);
      delay(100);
    }
  }
  */
  lcd.clear();
}
//
void loop()
{
  gw.process();
  updateClock();
  updateDisplay();
  //goGetValveTimes();
  //
  if (buttonPushed)
  {
    menuTimer = millis();
    DEBUG_PRINTLN(F("Button Pressed"));
    if (state == STAND_BY_ALL_OFF)
    {
      state = ZONE_SELECT_MENU;
      menuState = 0;
    }
    else if (state == ZONE_SELECT_MENU)
    {
      menuState++;
      if (menuState > NUMBER_OF_VALVES)
      {
        menuState = 0;
      }
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
    buttonPushed = false;
  }
  if (state == STAND_BY_ALL_OFF)
  {
    slowToggleLED ();
    if (state != lastState)
    {
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed... all Zones off"));
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        delay(50);
        gw.send(msg1valve.setSensor(i).set(false), false);
      }
      lcd.clear();
      lcd.setCursor(0,0);
      lcd.print(F("** Irrigation **"));
      lcd.setCursor(0,1);
      lcd.print(F("**   Halted   **"));
      delay(2000);
      lastValve = -1;
    }
  }
  //
  else if (state == RUN_ALL_ZONES)
  {
    if (lastValve != valveNumber)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
      valveNumber = 1;
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      DEBUG_PRINTLN(F("Changing Valves..."));
      updateRelays(ALL_VALVES_OFF);
      startMillis = millis();
      valveNumber++;
      if (valveNumber > NUMBER_OF_VALVES)
      {
        state = CYCLE_COMPLETE;
        startMillis = millis();
        lastValve = -1;
        lastTimeRun = now();
        saveDateToEEPROM(lastTimeRun);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
        DEBUG_PRINT(F("State = "));
        DEBUG_PRINTLN(state);
      }
    }
  }
  //
  else if (state == RUN_SINGLE_ZONE)
  {
    fastToggleLed();
    if (state != lastState)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
      DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
      DEBUG_PRINT(F("Zone: "));
      DEBUG_PRINTLN(valveNumber);
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      updateRelays(ALL_VALVES_OFF);
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        gw.send(msg1valve.setSensor(i).set(false), false);
      }
      state = CYCLE_COMPLETE;
      startMillis = millis();
      DEBUG_PRINT(F("State = "));
      DEBUG_PRINTLN(state);
    }
    lastTimeRun = now();
  }
  else if (state == CYCLE_COMPLETE)
  {
    if (millis() - startMillis < 30000UL)
    {
      fastToggleLed();
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
  }
  else if (state = ZONE_SELECT_MENU)
  {
    displayMenu();
  }
  lastState = state;
}
//
void displayMenu(void)
{
  static byte lastMenuState = -1;
  static int lastSecond;
  if (menuState != lastMenuState)
  {
    lcd.clear();
    lcd.setCursor(0, 0);
    lcd.print(valveNickName[menuState]);
    lcd.setCursor(0, 1);
    lcd.print(F("Starting"));
    DEBUG_PRINT(valveNickName[menuState]);
    Serial.print(F(" Starting Shortly"));
  }
  int thisSecond = (millis() - menuTimer) / 1000UL;
  if (thisSecond != lastSecond && thisSecond < 8)
  {
    lcd.print(F("."));
    Serial.print(".");
  }
  lastSecond = thisSecond;
  if (millis() - menuTimer > 10000UL)
  {
    startMillis = millis();
    if (menuState == 0)
    {
      valveNumber = 1;
      state = RUN_ALL_ZONES;
    }
    else
    {
      valveNumber = menuState;
      state = RUN_SINGLE_ZONE;
    }
  }
  else
  {

  }
  lastMenuState = menuState;
}
//
void updateRelays(int value)
{
  digitalWrite(latchPin, LOW);
  shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
  shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
  digitalWrite(latchPin, HIGH);
}
//
void PushButton() //interrupt with debounce
{
  static unsigned long last_interrupt_time = 0;
  unsigned long interrupt_time = millis();
  if (interrupt_time - last_interrupt_time > 200)
  {
    buttonPushed = true;
  }
  last_interrupt_time = interrupt_time;
}
//
void fastToggleLed()
{
  static unsigned long fastLedTimer;
  if (millis() - fastLedTimer >= 100UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    fastLedTimer = millis ();
  }
}
//
void slowToggleLED ()
{
  static unsigned long slowLedTimer;
  if (millis() - slowLedTimer >= 1250UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    slowLedTimer = millis ();
  }
}
//
void getVariables(const MyMessage &message)
{
  boolean zoneTimeUpdate = false;
  if (message.isAck())
  {
    DEBUG_PRINTLN(F("This is an ack from gateway"));
  }
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    if (message.sensor == i)
    {
      if (message.type == V_LIGHT)
      {
        int switchState = atoi(message.data);
        if (switchState == 0)
        {
          state = STAND_BY_ALL_OFF;
          DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
        }
        else
        {
          if (i == 0)
          {
            state = RUN_ALL_ZONES;
            valveNumber = 1;
            DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
          }
          else
          {
            state = RUN_SINGLE_ZONE;
            valveNumber = i;
            DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
            DEBUG_PRINTLN(i);
          }
        }
        startMillis = millis();
      }
      else if (message.type == V_VAR1)
      {
        int variable1 = atoi(message.data);// RUN_ALL_ZONES time
        DEBUG_PRINT(F("Recieved variable1 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable1);
        if (variable1 != allZoneTime[i])
        {
          allZoneTime[i] = variable1;

          zoneTimeUpdate = true;
        }
      }
      else if (message.type == V_VAR2)
      {
        int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
        DEBUG_PRINT(F("Recieved variable2 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable2);
        if (variable2 != valveSoloTime[i])
        {
          valveSoloTime[i] = variable2;
          zoneTimeUpdate = true;
        }
      }
      else if (message.type == V_VAR3)
      {
        String newMessage = String(message.data);
        if (newMessage.length() == 0) 
        {
          DEBUG_PRINT(F("No Name Recieved for zone "));
          DEBUG_PRINTLN(i);
          break;
        }
        if (newMessage.length() > 16)
        {
          newMessage.substring(0, 16);
        }
        valveNickName[i] = "";
        valveNickName[i] += newMessage;
        DEBUG_PRINT(F("Recieved new name for zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" and it is now called: "));
        DEBUG_PRINTLN(valveNickName[i]);
      }
    }
  }
  if (zoneTimeUpdate)
  {
    //
    DEBUG_PRINTLN(F("New Zone Times Recieved..."));
    for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
    {
      if (i != 0)
      {
        DEBUG_PRINT(F("Zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" individual time: "));
        DEBUG_PRINT(valveSoloTime[i]);
        DEBUG_PRINT(F(" group time: "));
        DEBUG_PRINTLN(allZoneTime[i]);
        recentUpdate = true;
      }
    }
  }
  else
  {
    recentUpdate = false;
  }
}
//
void updateDisplay()
{
  static unsigned long lastUpdateTime;
  static boolean displayToggle = false;
  //static byte toggleCounter = 0;
  static SprinklerStates lastDisplayState;
  if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
  {
    displayToggle = !displayToggle;
    switch (state) {
      case STAND_BY_ALL_OFF:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("  System Ready "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
          lcd.print(hourFormat12());
          lcd.print(minute() < 10 ? F(":0") : F(":"));
          lcd.print(minute());
          lcd.print(isAM() ? F("am") : F("pm"));
          lcd.print(month() < 10 ? F(" 0") : F(" "));
          lcd.print(month());
          lcd.print(day() < 10 ? F("/0") : F("/"));
          lcd.print(day());
          lcd.print(F("/"));
          lcd.print(year() % 100);
        }
        else
        {
          lcd.print(F("  Last Watered "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(dayOfWeek[weekday(lastTimeRun)]);
          lcd.setCursor(11, 1);
          lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
          lcd.print(month(lastTimeRun));
          lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/"));
          lcd.print(day(lastTimeRun));
        }
        break;
      case RUN_SINGLE_ZONE:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("Single Zone Mode"));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active"));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          if (valveSoloTime[valveNumber] == 0)
          {
            lcd.print(F(" No Valve Time "));
          }
          else
          {
            unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
            lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
            lcd.print(timeRemaining / 60);
            lcd.print("min");
            lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
            lcd.print(timeRemaining % 60);
            lcd.print("sec  ");
          }
        }
        break;
      case RUN_ALL_ZONES:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F(" All-Zone  Mode "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active "));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
          lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
          lcd.print(timeRemaining / 60);
          lcd.print("min");
          lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
          lcd.print(timeRemaining % 60);
          lcd.print("sec  ");
        }
        break;
      case CYCLE_COMPLETE:
        //
        if (displayToggle)
        {
          lcd.setCursor(0, 0);
          lcd.print(F(" Watering Cycle "));
          lcd.setCursor(0, 1);
          lcd.print(F("    Complete    "));
        }
        else
        {
          int totalTimeRan = 0;
          for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
          {
            totalTimeRan += allZoneTime[i];
          }
          lcd.setCursor(0, 0);
          lcd.print(F(" Total Time Run "));
          lcd.setCursor(0, 1);
          lcd.print(totalTimeRan < 10 ? "   0" : "   ");
          lcd.print(totalTimeRan);
          lcd.print(" Minutes   ");
        }
    }
    lastUpdateTime = millis();
  }
  lastDisplayState = state;
}
void receiveTime(time_t newTime)
{
  DEBUG_PRINTLN(F("Time value received and updated..."));
  int lastSecond = second();
  int lastMinute = minute();
  int lastHour = hour();
  setTime(newTime);
  if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
  {
    DEBUG_PRINTLN(F("Clock updated...."));
    DEBUG_PRINT(F("Sensor's time currently set to:"));
    DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
    DEBUG_PRINT(hourFormat12());
    DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
    DEBUG_PRINT(minute());
    DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
    DEBUG_PRINT(month());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINT(day());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINTLN(year());
    DEBUG_PRINTLN(dayOfWeek[weekday()]);
    showTime = false;
  }
  else
  {
    DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
  }
  clockUpdating = false;
}
void fastClear()
{
  lcd.setCursor(0, 0);
  lcd.print(F("                "));
  lcd.setCursor(0, 1);
  lcd.print(F("                "));
}
//
void updateClock()
{
  static unsigned long lastVeraGetTime;
  if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
  {
    DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(0));
    clockUpdating = true;
    gw.requestTime(receiveTime);
    lastVeraGetTime = millis();
  }
}
//
void saveDateToEEPROM(unsigned long theDate)
{
  DEBUG_PRINTLN(F("Saving Last Run date"));
  if (gw.loadState(0) != 0xFF)
  {
    gw.saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
  }
  //
  for (int i = 1; i < 5; i++)
  {
    gw.saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
  }
}
//
void goGetValveTimes()
{
  static unsigned long valveUpdateTime;
  static byte valveIndex = 1;
  if (millis() - valveUpdateTime >= 300000UL / NUMBER_OF_VALVES)// update each valve once every 5 mins (distributes the traffic)
  {
    DEBUG_PRINTLN(F("Calling for Valve Data..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(1)); //lcd.write(1);
    gw.request(valveIndex, V_VAR1);
    gw.request(valveIndex, V_VAR2);
    gw.request(valveIndex, V_VAR3);
    valveUpdateTime = millis();
    valveIndex++;
    if (valveIndex > NUMBER_OF_VALVES + 1)
    {
      valveIndex = 1;
    }
  }
}```

[petewill]

Hey Everyone,

I just made a follow up video to this irrigation controller that shows my logic I'm using to save water. It's pretty specific to my environment but hopefully you can use some of the ideas to save water in your environment. I have attached the logic I used in my PLEG device.

Pete

PLEG Irrigation.pdf

Automation to Adjust Irrigation Watering Time Based on Weather – 25:17
— Pete B

[epierre]

Hello,

looking at the project, I'm wondering why you propose 3.3V only, is this for the shift register and the screen ? Why not stay in 5V ?

[petewill]

@epierre Where did you see that I don't remember? Perhaps for the NRF radio?

[epierre]

@petewill it is here: http://www.mysensors.org/build/irrigation

it is hard to know the BOM from the page, so I was wondering why you would neeed the powering adaptation if you input 5V

[BulldogLowell]

@epierre

If you watch the video, you can see he's using the voltage regulator to supply power to the radio.

Are you getting ready to build?

[epierre]

@BulldogLowell said:

@epierre
Are you getting ready to build?

I've ordered the 8 switch, I have soil moisture, leaf moisture, ground humidity, rain gauge and found some evapotranspiration algorithm so I have all inputs and now need to have outputs in parallel of my rainbird scheduler (too dumb...)

So I'm ready to build as you say

[charlybrown]

@hek said:

Added your project to the main site togeter with @petewill excellent new video.

http://www.mysensors.org/build/irrigation

https://youtu.be/l4GPRTsuHkI
Excellent project.
Can you help me with the android code, to send instrucctions from my cell phone to Arduino? like on-off light , bomb, etc.

thanks for your time!
best regards.

[charlybrown]

Excellent work. I need help with android code. Anybody can help me with this?

thanks

[shemmozhipandian]

Hi,

I made the circuit, but later i realize it required vera controller to sync all the data. Is there other way or idea to send data to the built system.

[petewill]

@shemmozhipandian Sorry for the delayed reply. It does require a controller (like Vera) but there are free ones out there. Take a look here: http://www.mysensors.org/controller/

I know Domoticz is free and seems to be fairly popular here. There are others as well. If you find one you like you may want to write a quick post to check compatibility. I personally use Vera so I'm not sure how the others work.

[A Former User]

Hello Pete, thanks for your hard work on this. Superb!
I want to build a irrigation controller like your project but can't figure out hows the wiring. On the wiki an image is shown but I can't see what the connections are in this "virtual proto board"
Is there something clearer or like a pinout to pin list?
I'm using an Arduino Nano, so things will be something different.
Thank you very much.

[petewill]

@Sergio Jim (@BulldogLowell) posted some more details above but here is my fritzing project as well. Hopefully you can zoom in where you need to see more.

Fritzing Irrigation Controller Wiring.fzz

[A Former User]

Mmm... I finally assembled the device. But I'm having problems with it. It doesn't activate/deactivates the relays. I'm getting the power for the relay board from the nano itself. Could that be the problem?
Also, my domoticz doesn't receive the off signal from the controller. (doens't turn the light off) and sometimes throws some error telling that can't contact the node.
BTW I tried to contac Bulldogloweel without success

[petewill]

@Sergio said:

Mmm... I finally assembled the device. But I'm having problems with it. It doesn't activate/deactivates the relays. I'm getting the power for the relay board from the nano itself. Could that be the problem?

Yes, that is most likely the problem. Most of the relays I have used need more power than what the arduino can supply. Try feeding it more power (like from a phone charger).

Also, my domoticz doesn't receive the off signal from the controller. (doens't turn the light off) and sometimes throws some error telling that can't contact the node.

Check the serial monitor with debug enabled. Does this happen every time? It could be radio issues. Do you have a 4.7uf cap on the radio? Is it close enough to your gateway?

[fusion_man]

@BulldogLowell

I need to add a relay for a master valve. This will open when any zone valves open. I think it could be mapped to All On 0(1) but I am not sure how to accomplish this. I don't know the code for that or electrical connection. I also noticed we are about maxed out of data (99%) using ProMini. Any ideas?

[BulldogLowell]

If you are worried about Program Space you can turn off Serial debug to rid yourself of a bunch of overhead in the sketch. I am not using String class so there is PLENTY of RAM and I've been using this for a while with no stack corruption issues:

#define DEBUG_ON   // comment out to surpress serial monitor output

if you propose to turn ON the master valve when each valve is cycled on, then I believe all you need to do is add that valve to the bitmask (logical OR) each time you updateRelays().

void updateRelays(int value)
{
  if(value)
  {
    value |= 0b0000000010000000;  // master is the eighth relay, there are 7 controlled in this example (active HIGH in this example)
  }
  digitalWrite(latchPin, LOW);
  shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
  shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
  digitalWrite(latchPin, HIGH);
}

not tested

[fusion_man]

@BulldogLowell

By commenting out the DEBUG, it went from 99% to 63% used memory.
The modification to void updateRelays worked very nicely. I only wish the master control valve would remain ON during cycling through each valve (subjected to VALVE_RESET_TIME) as I am using it to control a chemical feed pump to prevent hydrogen proxide (30%) from entering my irrigation system.

Awesome job and I am very pleased with your design.
The only problem I had when building the controller was getting the LCD to communicate.
I added this comment to my program under Instructions.

• If your LCD is unresponsive, download sketch http://forum.arduino.cc/index.php?topic=128635.0 then check serial monitor for LCD address. Insert your address below.

[fusion_man]

@BulldogLowell

I ended up going a different approach. I modified the program so I could use Arduino digital pin6 as an output powering my master valve relay. I then added digitalWrite (masterValvePin, HIGH) where you have updateRelays(BITSHIFT_VALVE_NUMBER) to turn ON the valve. To turn off the valve I added a delay then digitalWrite (masterValvePin, LOW) to if (state == STAND_BY_ALL_OFF). This has tested perfectly for my situation.
The only thing missing from the Controller is the ability to add the RainBird rain sensor to the board. I think the way of achieving this is an input to my Vera controller.

[BulldogLowell]

@fusion_man

maybe we can add a rain sensor this season. It is a good idea to include it.

[fusion_man]

@BulldogLowell

I already did and it is up and running. I used A0 as the input for the rain sensor. I can see the rain sensor in Vera as a motion sensor. I didn't post the code as I didn't want to offend the designer. Being a newbie, I didn't know how to handle this update.

[BulldogLowell]

@fusion_man

why not just post your code? I'm sure the guy who wrote the original code won't mind, if you include his original notes and credits.

[Mark Jefford]

Quick question, semi also referenced on the openhab binding.

Looking to use this with Openhab, I have managed to get it to work with the serial gateway, however i don't see a way i can pass out any configuration of a valve time, i can however trigger valves with a runtime of 0 seconds.

Any ideas how i can amend this to either use a fixed runtime in the project (happy to run it in 1min increments trigged from openhab hydro sensor results)

[BulldogLowell]

@Mark-Jefford

In that case, I would just treat each zone as a separate relay/lamp and use Openhab to control the individual ON times... I think.

[johnecy]

can I use pin D6 instead ok pin D8 to control the shift register. I am making the controller on the easy/newbie pc board and there is nothing connected to pin D8 on this board.

[BulldogLowell]

@johnecy

const int latchPin = 8;

I think you should be OK to try that

[johnecy]

@BulldogLowell thanks for the reply i will post pictures when i get it finished

[Mark Jefford]

@BulldogLowell

Gave up with using openhab now using domoticz which is a lot nicer, forced it to hard coded run times by doing this:

else if (message.type == V_VAR1)
{
int variable1 = 5; // atoi(message.data);// RUN_ALL_ZONES time
DEBUG_PRINT(F("Recieved variable1 valve:"));
DEBUG_PRINT(i);
DEBUG_PRINT(F(" = "));
DEBUG_PRINTLN(variable1);
if (variable1 != allZoneTime[i])
{
allZoneTime[i] = variable1;

      zoneTimeUpdate = true;
    }
  }
  else if (message.type == V_VAR2)
  {
    int variable2 = 5; //atoi(message.data);// RUN_SINGLE_ZONE time
    DEBUG_PRINT(F("Recieved variable2 valve:"));
    DEBUG_PRINT(i);
    DEBUG_PRINT(F(" = "));
    DEBUG_PRINTLN(variable2);
    if (variable2 != valveSoloTime[i])
    {
      valveSoloTime[i] = variable2;
      zoneTimeUpdate = true;
    }```

one thing to note the shift register 0b0000000010000000 does not seem to work, will work out a plan around this as i need to run a 12 pump off the relay bank to draw water from the water butt.

[BulldogLowell]

@Mark-Jefford said:

one thing to note the shift register 0b0000000010000000 does not seem to work, will work out a plan around this as i need to run a 12 pump off the relay bank to draw water from the water butt.

Can you explain more? is there a bug?

[Mark Jefford]

@BulldogLowell
Hi!

Rather than using valve 8, i am using only a block of 4, but currently have a 2 channel for testing.

My reading into shift registers showed 0b0000000010000000 is 2x 8 bit outputs, B0-B7

tried configuing B0 and B7 to try and activate relay 1, was still seeing 5V on all pins apart from the output pin for the zone in use (EG zone 2 expecting Zone1 to alway be on)

or am i doing this completely wrong?

[BulldogLowell]

@Mark-Jefford

hmmm... are your relays ACTIVE HIGH (actuate wiht a 5V signal) or ACTIVE LOW (actuate when brought to ground) type?

[Mark Jefford]

@BulldogLowell

Oh, well this is strange, if i disconnect the pin to the relay, it does not activate when unpowered.

but from the shift register it is +5 when the zone is not active, and 0V when active, so i assume its an active low not active high by your example... surely removing the 5V feed to the relay pin should make it activate.. not sure whats going on there, some sort of black magic

My reading of shift registers has made my brain hurt.. do i need to reverse the 0000000010000000 for 1111111101111111?

[rechin304]

Dear all,

i have trying to make the irrigation controller to start all zones in same time and run for the specified. I'm using version for domoticz. Can you please help me out with hint of what i can change in the code ?
Another thing is that from domoticsz when i start a zone that zone start and previous is stopped but that status is not updated.

Thank you in advance.

P.S. I will post some pictures of the hardware build soon.

[BulldogLowell]

@rechin304

have you tried changing the eight to one?

#define NUMBER_OF_VALVES 8  // Change this to set your valve count up to 16.

trigger all your relays with the same output.

[rechin304]

Well, that's not the point.
I will have 4 zones that need different type of water needs. For example one zone will be with micro irrigation watering, another one with lawn sprinkler. i do not understand why not to start all zones at once and they will finish according to the time set and not to start one after other. Another thing is why to wait for a zone to finish when you trigger another one.

To start all valve at once when is trigger all zones i did change:

else if (state == RUN_ALL_ZONES)
  {
    if (lastValve != valveNumber)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
      valveNumber = 1;
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else

with

else if (state == RUN_ALL_ZONES)
  {
    if (lastValve != valveNumber)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(true), false); //to update domoticz
        }
      }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
      valveNumber = 1;
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(0); //all outputs will be on
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else