Door, Motion and Temperature Sensor

robosensor

@hek It seems that I did it. If this push request is correct, what I should patch? Development branch, master branch or both?

hek

Good!
You can create pull request on master (and I'll merge it to development later).

hek

@robosensor

Thanks and congrats! You've made your first contribution to the MySensors project. :)

CaptainZap

Guys, I had some free time tonight and tried to apply this fix... I ended up re-installing the arduino IDE + downloading the latest version, which now is 1.4.1 as opposed to the 1.4 that I used to have ?

Anyways I had to upgrade my ethernet gateway (ENC28J60) and it's no longer working now... any hints will be golden.
LE: I was too tired to check the sketch... I forgot to include the correct library and went to all debugging first, reset router config to default, but in the end I did notice the issue :) So I learned a valuable lesson, never work on this if it's late or you're tired.

CaptainZap

Hello guys,

I really need an expert's opinion on this because I'm experiencing some trouble... I've tried to include suggestions from all you guys, except the delay part, but so far it works partially... in my original code the temperature worked, and now it doesn't. The rest works ok, sensor and motion, so I would be grateful if anyone could take a look at my code and help me with it... I kind of need to get it in place soon, as I intend to leave my house for some time.

Thank you.

//This sketch is for Door & Motion & Temp Sensor


#include <MySensor.h>
#include <SPI.h>
#include <DallasTemperature.h>
#include <OneWire.h>
#include <Bounce2.h>

#define CLIENT_ID AUTO  // Sets MYSensors client id
#define RADIO_CH 76  // Sets MYSensors to use Radio Channel
#define TRIGGER	3	// used to connect motion sensor
#define BUTTON_PIN  4 // used to connect door/window sensor

//Temp Sensor bits
#define ONE_WIRE_BUS 14 // Pin where dallas sensor is connected
OneWire oneWire(ONE_WIRE_BUS);
DallasTemperature DallasSensors(&oneWire);
float lastTemperature ;
#define CHILD_ID_T1 3 //CHILD ID for temp


//Door/Window bits

#define CHILD_ID_D1 1 //CHILD ID for door/window

//Trigger Sensor Bits
#define CHILD_ID_S1 2 //CHILD ID for Motion sensor
boolean lastTripped = 0;

MySensor gw;

Bounce debouncer = Bounce(); 
int oldValue=-1;

// Change to V_LIGHT if you use S_LIGHT in presentation below
MyMessage msg(CHILD_ID_D1,V_TRIPPED);
MyMessage triggerMsg(CHILD_ID_S1,V_TRIPPED);
MyMessage tempMsg(CHILD_ID_T1,V_TEMP);

void setup()
{
	// Startup OneWire Temp Sensors
    DallasSensors.begin();
    DallasSensors.setWaitForConversion(false);

	// Initialize library and add callback for incoming messages
	 gw.begin(NULL, AUTO, true);
	
	// Send the sketch version information to the gateway and Controller
	gw.sendSketchInfo("Multi Sensor", "1.1");

	// Register all sensors to gw (they will be created as child devices)
	gw.present(CHILD_ID_D1, S_DOOR);
	gw.present(CHILD_ID_T1, S_TEMP);
	gw.present(CHILD_ID_S1, S_MOTION);

	// Setup the button
        pinMode(BUTTON_PIN,INPUT);
        // Activate internal pull-up
        digitalWrite(BUTTON_PIN,HIGH);
  
        // After setting up the button, setup debouncer
        debouncer.attach(BUTTON_PIN);
        debouncer.interval(5);
  
        // Register binary input sensor to gw (they will be created as child devices)
        // You can use S_DOOR, S_MOTION or S_LIGHT here depending on your usage. 
        // If S_LIGHT is used, remember to update variable type you send in. See "msg" above.
	
}


void loop()
{
	// Alway process incoming messages whenever possible
	gw.process();
	
	
	// Check for motion change value
		boolean tripped = digitalRead(TRIGGER) == HIGH; 

		if (lastTripped != tripped ) {
			gw.send(triggerMsg.set(tripped?"1":"0")); // Send new state and request ack back
			Serial.println("Tripped");
			lastTripped=tripped;
		}
		
	//  Check if digital input has changed and send in new value
                debouncer.update();
              // Get the update value
                int value = debouncer.read();
 
                if (value != oldValue) {
                    // Send in the new value
                     gw.send(msg.set(value==HIGH ? 1 : 0));
                     oldValue = value;
                }
                
    DallasSensors.requestTemperatures(); // no delay here
    gw.wait(750); // insert another value for non-12-bit resolution
    float tempC = DallasSensors.getTempCByIndex(1);
    
    // Only send data if temperature has changed and no error
    if (lastTemperature != tempC && tempC != -127.00) {
      
      // Send in the new temperature
      gw.send(tempMsg.set(tempC,1));
      lastTemperature=tempC;
                   }    		

}

BulldogLowell

@CaptainZap

what does the Serial output show during execution of the sketch?

CaptainZap

@BulldogLowell Unfortunately I don't have a way to test that yet... I'm uploading the sketch using an arduino uno, and I have no idea how to do that with it. I do have an FTDI serial adapter but is not picked up by the IDE, it was at some point but no longer... probably fake :|

m26872

I don't know what's the issue, but I'd still prefer a normal timing code instead of just the gw.wait(). The fetching of temperatures in every loop makes no sense to me.

CaptainZap

@m26872 If you have time, could you please tell me how to do that, I know you've posted a link a few post back but I didn't do much with it :(

robosensor

@CaptainZap You should not query dallas sensor temperature every 750 ms. This heats up sensor itself and quite useless.

Use something like this:

unsigned long SLEEP_TIME = 30000; // Sleep time between reports (in milliseconds)
unsigned long lastRefreshTime = 0;

void loop()
{
	gw.wait(100);
  
	boolean bNeedRefresh = (millis() - lastRefreshTime) > SLEEP_TIME;
	if (bNeedRefresh)
	{
		lastRefreshTime = millis();

		DallasSensors.requestTemperatures();
		gw.wait(750);
		float tempC = DallasSensors.getTempCByIndex(1);
		float difference = lastTemperature - tempC;
		if (tempC != -127.00 && abs(difference) > 0.5)
		{
			// Send in the new temperature
			gw.send(tempMsg.set(tempC, 1));
			lastTemperature = tempC;
		}
	}
}

CaptainZap

@robosensor Thanks so much, I highly appreciate your comments. Will test this tomorrow, and hopefully, soon share my hardware designs :D

CaptainZap

Just uploaded the new sketch to my nodes, one built on a pro mini, and one built on a nano (got one to view serial output), however both nodes have the same behavior when added to the Vera unit... the repeater node doesn't show up (is this somehow related to UI7 ?), and the weird thing is that temperature value is never populated.

Regarding the repeater, looking into the user_data output I can see that a repeater node is created, but it's not used as a parent device for the sensors... as all sensors have as parent the gateway. I'm using this version of the plugin :
https://github.com/mysensors/Vera/tree/UI7

This is the serial monitor output from the nano :

repeater started, id 13
send: 13-13-1-0 s=255,c=0,t=18,pt=0,l=5,st=ok:1.4.1
send: 13-13-1-0 s=255,c=3,t=6,pt=1,l=1,st=ok:1
send: 13-13-1-0 s=255,c=3,t=11,pt=0,l=12,st=ok:Multi Sensor
send: 13-13-1-0 s=255,c=3,t=12,pt=0,l=3,st=ok:1.1
send: 13-13-1-0 s=1,c=0,t=0,pt=0,l=0,st=ok:
send: 13-13-1-0 s=3,c=0,t=6,pt=0,l=0,st=ok:
send: 13-13-1-0 s=2,c=0,t=1,pt=0,l=0,st=ok:
send: 13-13-1-0 s=1,c=1,t=16,pt=2,l=2,st=ok:0

This is the updated sketch:

//This sketch is for Door & Motion & Temp Sensor
//rev3 - changed temp pin to 5 & temperature logic re-worked


#include <MySensor.h>
#include <SPI.h>
#include <DallasTemperature.h>
#include <OneWire.h>
#include <Bounce2.h>

#define CLIENT_ID AUTO  // Sets MYSensors client id
#define RADIO_CH 76  // Sets MYSensors to use Radio Channel
#define TRIGGER	3	// used to connect motion sensor
#define BUTTON_PIN  4 // used to connect door/window sensor

//Temp Sensor bits
#define ONE_WIRE_BUS 5 // Pin where dallas sensor is connected - on Rboard this is A0(D14)
OneWire oneWire(ONE_WIRE_BUS);
DallasTemperature DallasSensors(&oneWire);
float lastTemperature ;
#define CHILD_ID_T1 3 //CHILD ID for temp


//Door/Window bits

#define CHILD_ID_D1 1 //CHILD ID for door/window

//Trigger Sensor Bits
#define CHILD_ID_S1 2 //CHILD ID for Motion sensor
boolean lastTripped = 0;

unsigned long SLEEP_TIME = 30000; // Sleep time between reports (in milliseconds)
unsigned long lastRefreshTime = 0;

MySensor gw;

Bounce debouncer = Bounce(); 
int oldValue=-1;

// Change to V_LIGHT if you use S_LIGHT in presentation below
MyMessage msg(CHILD_ID_D1,V_TRIPPED);
MyMessage triggerMsg(CHILD_ID_S1,V_TRIPPED);
MyMessage tempMsg(CHILD_ID_T1,V_TEMP);

void setup()
{
	// Startup OneWire Temp Sensors
    DallasSensors.begin();
    DallasSensors.setWaitForConversion(false);

	// Initialize library and add callback for incoming messages
	 gw.begin(NULL, AUTO, true);
	
	// Send the sketch version information to the gateway and Controller
	gw.sendSketchInfo("Multi Sensor", "1.1");

	// Register all sensors to gw (they will be created as child devices)
	gw.present(CHILD_ID_D1, S_DOOR);
	gw.present(CHILD_ID_T1, S_TEMP);
	gw.present(CHILD_ID_S1, S_MOTION);

	// Setup the button
        pinMode(BUTTON_PIN,INPUT);
        // Activate internal pull-up
        digitalWrite(BUTTON_PIN,HIGH);
  
        // After setting up the button, setup debouncer
        debouncer.attach(BUTTON_PIN);
        debouncer.interval(5);
  
        // Register binary input sensor to gw (they will be created as child devices)
        // You can use S_DOOR, S_MOTION or S_LIGHT here depending on your usage. 
        // If S_LIGHT is used, remember to update variable type you send in. See "msg" above.
	
}


void loop()
{
	// Alway process incoming messages whenever possible
	gw.process();
	
	
	// Check for motion change value
		boolean tripped = digitalRead(TRIGGER) == HIGH; 

		if (lastTripped != tripped ) {
			gw.send(triggerMsg.set(tripped?"1":"0")); // Send new state and request ack back
			Serial.println("Tripped");
			lastTripped=tripped;
		}
		
	//  Check if digital input has changed and send in new value
                debouncer.update();
              // Get the update value
                int value = debouncer.read();
 
                if (value != oldValue) {
                    // Send in the new value
                     gw.send(msg.set(value==HIGH ? 1 : 0));
                     oldValue = value;
                }
                
    gw.wait(100);
  
    boolean bNeedRefresh = (millis() - lastRefreshTime) > SLEEP_TIME;
    if (bNeedRefresh)
    {
        lastRefreshTime = millis();

        DallasSensors.requestTemperatures();
        gw.wait(750);
        float tempC = DallasSensors.getTempCByIndex(1);
        float difference = lastTemperature - tempC;
        if (tempC != -127.00 && abs(difference) > 0.5)
        {
            // Send in the new temperature
            gw.send(tempMsg.set(tempC, 1));
            lastTemperature = tempC;
        }
    }  		

}

Any feedback will be appreciated. Thanks.

hek

All devices has the gateway as parent (Vera does not support a multi-level device hierarchy).

CaptainZap

Can anyone share their thoughts ? I've been running two identical nodes, with no temperature output for a few days now :(

Dwalt

@CaptainZap Did you delete the original devices from Vera after you changed the code? I had something similar happen when I rewrote a sketch to modify battery monitoring and Vera would not show the new data. I deleted the node and child devices and reincluded them from scratch and then it worked.

m26872

I think you have to redo inclusion of the sensors if you want them to use the repater in their routing. At least it looks like this when I setup my Vera and sensors.

CaptainZap

@Dwalt @m26872 Thanks for the feedback, I did do that on the Vera unit. I've even removed the plugin files and re-did everything. I even, and this is a bit extreme, cleared the eprom on the gateway and reflashed it. None of it worked, I really have no clue what to do next. I'm open to every suggestion :D

Dwalt

@CaptainZap It your sketch you have this line:
#define ONE_WIRE_BUS 14

What pin is your Dallas sensor connected to?

m26872

First make sure a pure repeater node is working. With only the gw.process() to run, it should be fast to enough catch any new inlusion before the gateway. With a proper range of course. Clear the sensors eeprom and Vera-device before reinclusion, but you should not need to do anything with the gateway.

CaptainZap

@Dwalt said:

@CaptainZap It your sketch you have this line:
#define ONE_WIRE_BUS 14

What pin is your Dallas sensor connected to?

One sensor is connected to A0(14) the other is connected to D5 as it can be seen in my last sketch. Temperature reporting worked on, in my original sketch, however the sketch wasn't perfect so I improved it based on feedback.

@m26872 The sensor is on a breadboard 5cm from the gateway, and I'm not sure about the repeater part...

Door, Motion and Temperature Sensor

18

11.7k

11.2k

113.1k