Dallas Temp failure to compile

[Boots33]

@tlpeter yes there seems to be a problem once you update the library. Even if you roll back the problem persists. If you want to use the MySensors Dallas temp sketch as it is then you need to manually replace the library with the older 3.7.2 and then it will work.

I have uploaded the library in zip format. @hek I hope that it is OK to upload zip files

0_1470911411126_DallasTemperature.zip

[Nca78]

error: 'int16_t DallasTemperature::millisToWaitForConversion(uint8_t)' is private

You are using an old version of the library, if you get the library from MySensors GitHub then the method is not private (like in the current version of the library you use) and it will compile.

[tlpeter]

Thanks, that works fine.
How come that i have an old library? i use the 2.0.0 version
Is this perhaps a known issue which will be fixed soon?

[tbowmo]

It's not related to mysensors core library.

Also, as mentioned before in this thread, the Dallas library that is in the arduino examples repository, is working.

Are you sure that you are using the right libraries?

[tlpeter]

I tihnk so, i used libraries that i was pointed too as they are moved.
All other sensors i have been playing with are working fine.

[Nca78]

@tlpeter it is because now the libraries which are not managed by MySensors project were moved to another repository. It means if you only updated MySensors, you kept the old libraries.

[tlpeter]

I removed everything and started from scratch and after that i copied the mysensors-master library.

[Nca78]

@tlpeter said:

I removed everything and started from scratch and after that i copied the mysensors-master library.

"removed everything" in MySensors directory ? That's not enough, as the third party libraries are in the libraries directory of Arduino

[tlpeter]

I uninstalled that too.
I really removed everything.
Uninstalled arduino and removed the folders in the program files folder and the my documents folder too.

[Honk]

why not put the function millisToWaitForConversion into the example.
I like to have the latest libary available for sensors. It can be loaded with the arduino studio.
Read the min wait time is pretty easy. it is just a switch case based on the datasheet.

// returns number of milliseconds to wait till conversion is complete (based on IC datasheet)
int16_t DallasTemperature::millisToWaitForConversion(uint8_t bitResolution)
{
    switch (bitResolution)
    {
    case 9:
        return 94;
    case 10:
        return 188;
    case 11:
        return 375;
    default:
        return 750;
    }
}

[tbowmo]

@tlpeter

Ok, so you are using a newer version of the DallasTemperature library, than the one that we have supplied in our MySensorsArduinoExamples. And yes, it seems that they have made millisToWaitForConversion() a private function there. Or someone has changed the library we included in our repository at some point in time, so it is made public.

There are 2 options, as I see it :)

1. Use the library that we have supplied in MySensorsArduinoExamples
2. Make a PR against the original library, found here, and make the millisToWaitForConversion() public, and get them to release a new version of the library.

:)

[mfalkvidd]

The millisToWaitForConversion has always been private in milesburton's library, so the answer is the latter: someone has changed the library we included in our repository at some point in time.

I found the answer in git:

commit e47e596075282b122ac5d266ec6ad5c60ca8c978
Author: Robo Print <roboprint@users.noreply.github.com>
Date:   Sat Jun 27 23:00:37 2015 +0200

    Make DallasTemperature::millisToWaitForConversion() publicly available

I agree with tbowmo's options.

[robosensor]

It's my code :scream:

I changed this method from private to public, this function is used to determine wait time needed for right non-blocking wait call. Seems like I should make PR to original library instead of modifying MYS copy.