[SOLVED] Node Sensor affecting local sensors on GW.
-
MySensors Lib version 2.1.1
I have a RFM69 Ethernet GW to witch I have also connected 4 relays with buttons. Like this:
/** * The MySensors Arduino library handles the wireless radio link and protocol * between your home built sensors/actuators and HA controller of choice. * The sensors forms a self healing radio network with optional repeaters. Each * repeater and gateway builds a routing tables in EEPROM which keeps track of the * network topology allowing messages to be routed to nodes. * * Created by Henrik Ekblad <henrik.ekblad@mysensors.org> * Copyright (C) 2013-2015 Sensnology AB * Full contributor list: https://github.com/mysensors/Arduino/graphs/contributors * * Documentation: http://www.mysensors.org * Support Forum: http://forum.mysensors.org * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * version 2 as published by the Free Software Foundation. * ******************************* * * REVISION HISTORY * Version 1.0 - Henrik EKblad * Contribution by a-lurker and Anticimex, * Contribution by Norbert Truchsess <norbert.truchsess@t-online.de> * Contribution by Tomas Hozza <thozza@gmail.com> * * * DESCRIPTION * The EthernetGateway sends data received from sensors to the ethernet link. * The gateway also accepts input on ethernet interface, which is then sent out to the radio network. * * The GW code is designed for Arduino 328p / 16MHz. ATmega168 does not have enough memory to run this program. * * LED purposes: * - To use the feature, uncomment WITH_LEDS_BLINKING in MyConfig.h * - RX (green) - blink fast on radio message recieved. In inclusion mode will blink fast only on presentation recieved * - TX (yellow) - blink fast on radio message transmitted. In inclusion mode will blink slowly * - ERR (red) - fast blink on error during transmission error or recieve crc error * * See http://www.mysensors.org/build/ethernet_gateway for wiring instructions. * */ // Enable debug prints to serial monitor //#define MY_DEBUG #define SN "EthGW/RFM69 Rele Button" #define SV "1.1" // Enable and select radio type attached //#define MY_RADIO_NRF24 #define MY_RADIO_RFM69 #define MY_RFM69_FREQUENCY RF69_433MHZ #define MY_IS_RFM69HW #define MY_RF69_SPI_CS 4 // Enable gateway ethernet module type #define MY_GATEWAY_W5100 // W5100 Ethernet module SPI enable (optional if using a shield/module that manages SPI_EN signal) //#define MY_W5100_SPI_EN 10 // Enable Soft SPI for NRF radio (note different radio wiring is required) // The W5100 ethernet module seems to have a hard time co-operate with // radio on the same spi bus. // Enable to UDP //#define MY_USE_UDP #define MY_IP_ADDRESS 192,168,1,100 // If this is disabled, DHCP is used to retrieve address // Renewal period if using DHCP //#define MY_IP_RENEWAL_INTERVAL 60000 // The port to keep open on node server mode / or port to contact in client mode #define MY_PORT 5003 // Controller ip address. Enables client mode (default is "server" mode). // Also enable this if MY_USE_UDP is used and you want sensor data sent somewhere. //#define MY_CONTROLLER_IP_ADDRESS 192, 168, 178, 254 // The MAC address can be anything you want but should be unique on your network. // Newer boards have a MAC address printed on the underside of the PCB, which you can (optionally) use. // Note that most of the Ardunio examples use "DEAD BEEF FEED" for the MAC address. #define MY_MAC_ADDRESS 0xDE, 0xAD, 0xBE, 0xEF, 0xED, 0xED // Flash leds on rx/tx/err //#define MY_LEDS_BLINKING_FEATURE // Set blinking period #define MY_DEFAULT_LED_BLINK_PERIOD 300 // Enable inclusion mode #define MY_INCLUSION_MODE_FEATURE // Enable Inclusion mode button on gateway //#define MY_INCLUSION_BUTTON_FEATURE // Set inclusion mode duration (in seconds) #define MY_INCLUSION_MODE_DURATION 60 // Digital pin used for inclusion mode button #define MY_INCLUSION_MODE_BUTTON_PIN 3 // Uncomment to override default HW configurations //#define MY_DEFAULT_ERR_LED_PIN 7 // Error led pin //#define MY_DEFAULT_RX_LED_PIN 8 // Receive led pin //#define MY_DEFAULT_TX_LED_PIN 9 // the PCB, on board LED #include <SPI.h> #if defined(MY_USE_UDP) #include <EthernetUdp.h> #endif #include <Ethernet.h> #include <MySensors.h> #include <Bounce2.h> #define RELAY_ON 0 // switch around for ACTIVE LOW / ACTIVE HIGH relay #define RELAY_OFF 1 // #define noRelays 4 //2-4 const int relayPin[] = {14, 15, 16, 17}; // switch around pins to your desire const int buttonPin[] = {7, 8, 5, 6}; // switch around pins to your desire class Relay // relay class, store all relevant data (equivalent to struct) { public: int buttonPin; // physical pin number of button int relayPin; // physical pin number of relay boolean relayState; // relay status (also stored in EEPROM) }; Relay Relays[noRelays]; Bounce debouncer[noRelays]; MyMessage msg[noRelays]; void setup() { wait(100); // Initialize Relays with corresponding buttons for (int i = 0; i < noRelays; i++) { Relays[i].buttonPin = buttonPin[i]; // assign physical pins Relays[i].relayPin = relayPin[i]; msg[i].sensor = i; // initialize messages msg[i].type = V_LIGHT; pinMode(Relays[i].buttonPin, INPUT_PULLUP); wait(100); pinMode(Relays[i].relayPin, OUTPUT); Relays[i].relayState = loadState(i); // retrieve last values from EEPROM digitalWrite(Relays[i].relayPin, Relays[i].relayState ? RELAY_ON : RELAY_OFF); // and set relays accordingly send(msg[i].set(Relays[i].relayState ? true : false)); // make controller aware of last status wait(50); debouncer[i] = Bounce(); // initialize debouncer debouncer[i].attach(buttonPin[i]); debouncer[i].interval(30); wait(50); } } void presentation() { // Send the sketch version information to the gateway and Controller sendSketchInfo(SN, SV); wait(100); for (int i = 0; i < noRelays; i++) present(i, S_LIGHT); // present sensor to gateway wait(100); } void loop() { for (byte i = 0; i < noRelays; i++) { if (debouncer[i].update()) { int value = debouncer[i].read(); if ( value == LOW) { Relays[i].relayState = !Relays[i].relayState; digitalWrite(Relays[i].relayPin, Relays[i].relayState ? RELAY_ON : RELAY_OFF); send(msg[i].set(Relays[i].relayState ? true : false)); // save sensor state in EEPROM (location == sensor number) saveState( i, Relays[i].relayState ); } } } //wait(20); } void receive(const MyMessage &message) { if (message.type == V_LIGHT) { if (message.sensor < noRelays) { // check if message is valid for relays..... previous line [[[ if (message.sensor <=noRelays){ ]]] Relays[message.sensor].relayState = message.getBool(); digitalWrite(Relays[message.sensor].relayPin, Relays[message.sensor].relayState ? RELAY_ON : RELAY_OFF); // and set relays accordingly saveState( message.sensor, Relays[message.sensor].relayState ); // save sensor state in EEPROM (location == sensor number) } } wait(20); }Now I added a node (Node 103) to the network with a similar setup:
/** The MySensors Arduino library handles the wireless radio link and protocol between your home built sensors/actuators and HA controller of choice. The sensors forms a self healing radio network with optional repeaters. Each repeater and gateway builds a routing tables in EEPROM which keeps track of the network topology allowing messages to be routed to nodes. Created by Henrik Ekblad <henrik.ekblad@mysensors.org> Copyright (C) 2013-2015 Sensnology AB Full contributor list: https://github.com/mysensors/Arduino/graphs/contributors Documentation: http://www.mysensors.org Support Forum: http://forum.mysensors.org This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License version 2 as published by the Free Software Foundation. ******************************* REVISION HISTORY Version 1.0 - Henrik Ekblad DESCRIPTION Example sketch showing how to control physical relays. This example will remember relay state after power failure. http://www.mysensors.org/build/relay */ // Enable debug prints to serial monitor //#define MY_DEBUG // Define a static node address, remove if you want auto address assignment #define MY_NODE_ID 103 // Enable and select radio type attached //#define MY_RADIO_NRF24 #define MY_RADIO_RFM69 #define MY_RFM69_FREQUENCY RF69_433MHZ #define SN "HAButtDoorLock" #define SV "1.0" #include <MySensors.h> #include <SPI.h> #include <Bounce2.h> #define RELAY_ON 1 // switch around for ACTIVE LOW / ACTIVE HIGH relay #define RELAY_OFF 0 // #define CHILD_ID_DOOR 4 // Id of the sensor child #define CHILD_ID_LOCK 5 // Id of the sensor child #define noRelays 4 //2-4 const int relayPin[] = {14, 16, 15, 17}; // switch around pins to your desire const int buttonPin[] = {7, 5, 6, 4}; // switch around pins to your desire #define DIGITAL_INPUT_DOOR 3 // The digital input you attached your motion sensor. #define DIGITAL_INPUT_LOCK 8 // The digital input you attached your motion sensor. //define what is on and off for the reed switches #define DOOR_CLOSED 0 #define DOOR_OPEN 1 #define DOOR_LOCKED 1 #define DOOR_UNLOCKED 0 class Relay // relay class, store all relevant data (equivalent to struct) { public: int buttonPin; // physical pin number of button int relayPin; // physical pin number of relay boolean relayState; // relay status (also stored in EEPROM) }; Relay Relays[noRelays]; Bounce debouncer[noRelays]; MyMessage msg[noRelays]; MyMessage msgDoor(CHILD_ID_DOOR, V_TRIPPED); MyMessage msgLock(CHILD_ID_LOCK, V_LOCK_STATUS); // Storage of old status int oldDoorValue=-1; int oldLockValue=-1; /**************************************************** * * Setup code * ****************************************************/ void setup() { wait(100); // Initialize Relays with corresponding buttons for (int i = 0; i < noRelays; i++) { Relays[i].buttonPin = buttonPin[i]; // assign physical pins Relays[i].relayPin = relayPin[i]; msg[i].sensor = i; // initialize messages msg[i].type = V_LIGHT; pinMode(Relays[i].buttonPin, INPUT_PULLUP); wait(100); pinMode(Relays[i].relayPin, OUTPUT); Relays[i].relayState = loadState(i); // retrieve last values from EEPROM digitalWrite(Relays[i].relayPin, Relays[i].relayState ? RELAY_ON : RELAY_OFF); // and set relays accordingly send(msg[i].set(Relays[i].relayState ? true : false)); // make controller aware of last status wait(50); debouncer[i] = Bounce(); // initialize debouncer debouncer[i].attach(buttonPin[i]); debouncer[i].interval(30); wait(50); } // Setup the door sensor pinMode(DIGITAL_INPUT_DOOR,INPUT); // Setup the interupt pin pinMode(DIGITAL_INPUT_LOCK,INPUT); // Setup the interupt pin //pinMode(DIGITAL_INPUT_INT,INPUT); // Activate internal pull-up digitalWrite(DIGITAL_INPUT_DOOR,HIGH); // Activate internal pull-up digitalWrite(DIGITAL_INPUT_LOCK,HIGH); // Activate internal pull-up //digitalWrite(DIGITAL_INPUT_INT,LOW); } void presentation() { // Send the sketch version information to the gateway and Controller sendSketchInfo(SN, SV); wait(100); for (int i = 0; i < noRelays; i++) present(i, S_LIGHT); // present sensor to gateway wait(100); present(CHILD_ID_DOOR, S_DOOR); present(CHILD_ID_LOCK, S_LOCK); } /*********************************************** * * Main loop function * ***********************************************/ void loop() { for (byte i = 0; i < noRelays; i++) { if (debouncer[i].update()) { int value = debouncer[i].read(); if ( value == LOW) { Relays[i].relayState = !Relays[i].relayState; digitalWrite(Relays[i].relayPin, Relays[i].relayState ? RELAY_ON : RELAY_OFF); send(msg[i].set(Relays[i].relayState ? true : false)); // save sensor state in EEPROM (location == sensor number) saveState( i, Relays[i].relayState ); } } } int DoorValue = digitalRead(DIGITAL_INPUT_DOOR); if (DoorValue != oldDoorValue) { // Send in the new value wait(300); send(msgDoor.set(DoorValue ? DOOR_OPEN : DOOR_CLOSED)); oldDoorValue = DoorValue; } wait(20); int LockValue = digitalRead(DIGITAL_INPUT_LOCK); if (LockValue != oldLockValue) { // Send in the new value wait(300); send(msgLock.set(LockValue ? DOOR_UNLOCKED : DOOR_LOCKED)); oldLockValue = LockValue; } wait(20); //wait(20); } void receive(const MyMessage &message) { if (message.type == V_LIGHT) { if (message.sensor < noRelays) { // check if message is valid for relays..... previous line [[[ if (message.sensor <=noRelays){ ]]] Relays[message.sensor].relayState = message.getBool(); digitalWrite(Relays[message.sensor].relayPin, Relays[message.sensor].relayState ? RELAY_ON : RELAY_OFF); // and set relays accordingly saveState( message.sensor, Relays[message.sensor].relayState ); // save sensor state in EEPROM (location == sensor number) } } wait(30); }The problem now is that when I push a button on the Node and the Node sends the new state to the GW the relays on the GW change state. So how do I need to change the "Receive" function on the GW to prevent this from happening?
Sorry that I don't have any communication logs from this since I did not expect any issues with it so I did not test it on the bench before installing it where is should be and now it is not so simple to get communication logs.
-
Not tested, but kind of a bet:
there seems to be also a "message.destination". So you could change the GW-code within the receive function to also ask whether the sensor is on the node ( && message.destination == 0) or anywhere else.
But that's just a workaround and may also be nevessary for repeater nodes...
-
@rejoe2 I saw the "message.destination" but is not the destination of the message sent by Node 103 always = 0 when it sends the new status to the controller? Is there any way to filter the received messages by the source?
-
@korttoma try message.sensor or message.sender
I am not sure how they differ
-
I guess that message.sensor is for the child sensors on the node and as you can see this is already used in the receive function on the GW.
The problem is that I'm using the same sensor IDs on both the remote Node and the GW.
One solution would be to change the sensor IDs on the GW and use message.sensor but I was trying to find another solution first and the message.sender looks like it might be what I'm looking for.
Thanks @mfalkvidd , I knew I could count on you to know something I have missed from the protocol API.I will try the following on the GW (seems to compile fine):
void receive(const MyMessage &message) { if (message.sender == 0) { if (message.type == V_LIGHT) { if (message.sensor < noRelays) { // check if message is valid for relays..... previous line [[[ if (message.sensor <=noRelays){ ]]] Relays[message.sensor].relayState = message.getBool(); digitalWrite(Relays[message.sensor].relayPin, Relays[message.sensor].relayState ? RELAY_ON : RELAY_OFF); // and set relays accordingly saveState( message.sensor, Relays[message.sensor].relayState ); // save sensor state in EEPROM (location == sensor number) } } } wait(20); }
-
I'm glad to confirm that using the filtering in my previous post solved my issue.
Now the relays on the GW only operate from controller commands an not from status updates from Node 103. Thanks again @mfalkvidd !
-
Great work @korttoma
Thanks for reporting back!
