Irrigation Controller (up to 16 valves with Shift Registers)

petewill

@Huczas Ah, missed that. I fixed it.

bsivley

I just finished building this but when I go to upload the code to my arduino i get this error

'byte clock [8]' redeclared as different kind of symbol

what does this mean ?

thanks

petewill

@bsivley Are you using the libraries from the MySensors github page (https://github.com/mysensors/MySensorsArduinoExamples/tree/master/libraries)? I just compiled it without any errors. What version of the Arduino IDE are you using? What version of MySensors are you using?

Andrej_AB

@petewill Hi, Please can you advise what version Arduino IDE you are using for this sketch?

rechin304

This post is deleted!

Andrej_AB

Hi, Maybe somebody can help me with this issue? Managed to upload code for irrigation controller with Arduino IDE 1.6.12 but can't pair with Vera controller.

petewill

@Andrej_AB I'm using 1.6.12 but I haven't changed my node to 2.0 yet.
What is the issue you are having with pairing? Do you see the presentation messages on your gateway? Do you have other nodes successfully paired with your Vera?

Andrej_AB

@petewill Hi, All my other nodes have successfully paired with Vera, but irrigation controller node can't pair with Vera, I have started inclusion mode on Vera, one minute passed 0 devices found.
Please see attached picture.
0_1480325874006_Vera inclusion.png

0_1480325904307_irrigation node.png

petewill

@Andrej_AB It looks like it's communicating ok because it's getting the time. Have you ever had a mysenors node #5 in your Vera previously and deleted it? Could it be that the Vera thinks it's already there? What happens if you clear your eeprom on your irrigation controller then manually assign a different ID and then try to pair it again?

Andrej_AB

@petewill said:

@Andrej_AB It looks like it's communicating ok because it's getting the time. Have you ever had a mysenors node #5 in your Vera previously and deleted it? Could it be that the Vera thinks it's already there? What happens if you clear your eeprom on your irrigation controller then manually assign a different ID and then try to pair it again?

Also thinking about it, eprom was cleaned and manually assigned new ID but still can't pair with Vera.
Today I tried upload sketch from My sensors library 1.5.4 and node was successfully paired with Vera, then tried again last sketch and again can't pair.

petewill

@Andrej_AB Can you post the full log from your sensor? The device is never getting presented in what you've posted so far. I don't have enough time to dig in to the code to know if this will help but can you try moving

void presentation()  
{ 
  sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    present(i, S_LIGHT);
  }
}

so it's above

void setup()

I still haven't updated my irrigation controller to 2.0 yet so I haven't tested any of the code.

Andrej_AB

@petewill Finally managed to pair node with Vera controller, many thanks to @petewill for assistance with this issue.

//
#define NUMBER_OF_VALVES 6  // Change this to set your valve count up to 16.
#define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
#define RADIO_ID 7  // Set this to fix your Radio ID or use Auto```

impertus

hey @petewill

finally i am done making the controller. but when i want to upload the code i get the error..


C:\Users\crame\Desktop\Vanding\Vanding.ino: In function 'void setup()':

Vanding:112: error: 'lcd' was not declared in this scope

   lcd.begin(16, 2); //(16 characters and 2 line display)

   ^

C:\Users\crame\Desktop\Vanding\Vanding.ino: In function 'void loop()':

Vanding:255: error: 'lcd' was not declared in this scope

       lcd.clear();

       ^

C:\Users\crame\Desktop\Vanding\Vanding.ino: In function 'void displayMenu()':

Vanding:388: error: 'lcd' was not declared in this scope

     lcd.clear();

     ^

Vanding:399: error: 'lcd' was not declared in this scope

     lcd.print(F("."));

     ^

C:\Users\crame\Desktop\Vanding\Vanding.ino: In function 'void updateDisplay()':

Vanding:589: error: 'lcd' was not declared in this scope

         lcd.setCursor(0, 0);

         ^

C:\Users\crame\Desktop\Vanding\Vanding.ino: In function 'void fastClear()':

Vanding:750: error: 'lcd' was not declared in this scope

   lcd.setCursor(0, 0);

   ^

C:\Users\crame\Desktop\Vanding\Vanding.ino: In function 'void updateClock()':

Vanding:762: error: 'lcd' was not declared in this scope

     lcd.setCursor(15, 0);

     ^

C:\Users\crame\Desktop\Vanding\Vanding.ino: In function 'void goGetValveTimes()':

Vanding:791: error: 'lcd' was not declared in this scope

     lcd.setCursor(15, 0);

     ^

exit status 1
'lcd' was not declared in this scope

do you have some help 4 me??

dbemowsk

@impertus Can you post your entire sketch?

dbemowsk

@impertus Those errors have to do with this line:


// Set the pins on the I2C chip used for LCD connections:
//                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27

This is where the declaration happens. If this is commented or fails, you will get the errors you described. Do you have the correct LCD libraries installed for this?

impertus

@dbemowsk i just copy/paste from the site.

witch library should i use?

i have added mysensors-master to IDE

edit i could see i have out comment the line. Now i get this error

Vanding:92: error: 'POSITIVE' was not declared in this scope

 LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27

                                                     ^

C:\Users\crame\Desktop\Vanding\Vanding.ino: In function 'void setup()':

Vanding:116: error: no matching function for call to 'LiquidCrystal_I2C::begin(int, int)'

   lcd.begin(16, 2); //(16 characters and 2 line display)

                  ^

C:\Users\crame\Desktop\Vanding\Vanding.ino:116:18: note: candidate is:

In file included from C:\Users\crame\Desktop\Vanding\Vanding.ino:1:0:

C:\Program Files (x86)\Arduino\libraries\Arduino-LiquidCrystal-I2C-library-master/LiquidCrystal_I2C.h:76:7: note: void LiquidCrystal_I2C::begin()

  void begin();

       ^

C:\Program Files (x86)\Arduino\libraries\Arduino-LiquidCrystal-I2C-library-master/LiquidCrystal_I2C.h:76:7: note:   candidate expects 0 arguments, 2 provided

exit status 1
'POSITIVE' was not declared in this scope

the sketch.

#include <LiquidCrystal_I2C.h>



// Enable debug prints
//#define MY_DEBUG

// Enable and select radio type attached
#define MY_RADIO_NRF24
//#define MY_RADIO_RFM69

//#define MY_NODE_ID 1  // Set this to fix your Radio ID or use Auto

#include <Wire.h>
#include <TimeLib.h>
#include <SPI.h>
#include <MySensors.h>
#include <LiquidCrystal.h>
#include <LiquidCrystal_I2C.h>


#define NUMBER_OF_VALVES 8  // Change this to set your valve count up to 16.
#define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state

#define SKETCH_NAME "MySprinkler"
#define SKETCH_VERSION "2.0"
//
#define CHILD_ID_SPRINKLER 0
//
#define ACTIVE_LOW // comment out this line if your relays are active high
//
#define DEBUG_ON   // comment out to supress serial monitor output
//
#ifdef ACTIVE_LOW
#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
#define ALL_VALVES_OFF 0xFFFF
#else
#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
#define ALL_VALVES_OFF 0U
#endif
//
#ifdef DEBUG_ON
#define DEBUG_PRINT(x)   Serial.print(x)
#define DEBUG_PRINTLN(x) Serial.println(x)
#else
#define DEBUG_PRINT(x)
#define DEBUG_PRINTLN(x)
#define SERIAL_START(x)
#endif
//
typedef enum {
  STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
}
SprinklerStates;
//
SprinklerStates state = STAND_BY_ALL_OFF;
SprinklerStates lastState;
byte menuState = 0;
unsigned long menuTimer;
byte countDownTime = 10;
//
int allZoneTime [NUMBER_OF_VALVES + 1];
int valveSoloTime [NUMBER_OF_VALVES + 1];
int valveNumber;
int lastValve;
unsigned long startMillis;
const int ledPin = 5;
const int waterButtonPin = 3;
bool buttonPushed = false;
bool showTime = true;
bool clockUpdating = false;
bool recentUpdate = true;
const char *dayOfWeek[] = {
  "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
};
// Name your Zones here or use Vera to edit them by adding a name in Variable3...
String valveNickName[17] = {
  "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
};
//
time_t lastTimeRun = 0;
//Setup Shift Register...
const int latchPin = 8;
const int clockPin = 4;
const int dataPin  = 7;
const int outputEnablePin = 6;
//
byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
// Set the pins on the I2C chip used for LCD connections:
//                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27
//
MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);

bool receivedInitialValue = false;
//
void setup()
{
  DEBUG_PRINTLN(F("Initialising..."));
  pinMode(latchPin, OUTPUT);
  pinMode(clockPin, OUTPUT);
  pinMode(dataPin, OUTPUT);
  pinMode(ledPin, OUTPUT);
  pinMode(outputEnablePin, OUTPUT);
  digitalWrite (outputEnablePin, LOW);
  pinMode(waterButtonPin, INPUT_PULLUP);
  //pinMode(waterButtonPin, INPUT);
  attachInterrupt(digitalPinToInterrupt(waterButtonPin), PushButton, RISING); //May need to change for your Arduino model
  digitalWrite (ledPin, HIGH);
  DEBUG_PRINTLN(F("Turning All Valves Off..."));
  updateRelays(ALL_VALVES_OFF);
  //delay(5000);
  lcd.begin(16, 2); //(16 characters and 2 line display)
  lcd.clear();
  lcd.backlight();
  lcd.createChar(0, clock);
  lcd.createChar(1, raindrop);
  //
  //check for saved date in EEPROM
  DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
  delay(500);
  if (loadState(0) == 0xFF) // EEPROM flag
  {
    DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
    for (int i = 0; i < 4 ; i++)
    {
      lastTimeRun = lastTimeRun << 8;
      lastTimeRun = lastTimeRun | loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
    }
  }

  DEBUG_PRINTLN(F("Sensor Presentation Complete"));
  //
  digitalWrite (ledPin, LOW);
  DEBUG_PRINTLN(F("Ready..."));
  //
  lcd.setCursor(0, 0);
  lcd.print(F(" Syncing Time  "));
  lcd.setCursor(15, 0);
  lcd.write(byte(0));
  lcd.setCursor(0, 1);
  int clockCounter = 0;
  while (timeStatus() == timeNotSet && clockCounter < 21)
  {
    requestTime();
    DEBUG_PRINTLN(F("Requesting time from Gateway:"));
    wait(1000);
    lcd.print(".");
    clockCounter++;
    if (clockCounter > 16)
    {
      DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
      lcd.clear();
      lcd.print(F("  Failed Clock  "));
      lcd.setCursor(0, 1);
      lcd.print(F(" Syncronization "));
      wait(2000);
      break;
    }
  }
  //
  lcd.clear();
  //Update valve data when first powered on
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    lcd.print(F(" Updating  "));
    lcd.setCursor(0, 1);
    lcd.print(F(" Valve Data: "));
    lcd.print(i);
    bool flashIcon = false;
    DEBUG_PRINT(F("Calling for Valve "));
    DEBUG_PRINT(i);
    DEBUG_PRINTLN(F(" Data..."));
    while (!receivedInitialValue)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      request(i, V_VAR1);
      wait(500);
    }
    receivedInitialValue = false;
    while (!receivedInitialValue)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      request(i, V_VAR2);
      wait(500);
    }
    receivedInitialValue = false;
    while (!receivedInitialValue)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      request(i, V_VAR3);
      wait(500);
    }
  }
  lcd.clear();
}


void presentation()  
{ 
  sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    present(i, S_LIGHT);
  }
}

//
void loop()
{
  updateClock();
  updateDisplay();
  goGetValveTimes();
  //
  if (buttonPushed)
  {
    menuTimer = millis();
    DEBUG_PRINTLN(F("Button Pressed"));
    if (state == STAND_BY_ALL_OFF)
    {
      state = ZONE_SELECT_MENU;
      menuState = 0;
    }
    else if (state == ZONE_SELECT_MENU)
    {
      menuState++;
      if (menuState > NUMBER_OF_VALVES)
      {
        menuState = 0;
      }
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
    buttonPushed = false;
  }
  if (state == STAND_BY_ALL_OFF)
  {
    slowToggleLED ();
    if (state != lastState)
    {
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed... all Zones off"));
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        wait(50);
        send(msg1valve.setSensor(i).set(false), false);
      }
      lcd.clear();
      lcd.setCursor(0,0);
      lcd.print(F("** Irrigation **"));
      lcd.setCursor(0,1);
      lcd.print(F("**   Halted   **"));
      wait(2000);
      lastValve = -1;
    }
  }
  //
  else if (state == RUN_ALL_ZONES)
  {
    if (lastValve != valveNumber)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          send(msg1valve.setSensor(i).set(false), false);
        }
      }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
      valveNumber = 1;
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      DEBUG_PRINTLN(F("Changing Valves..."));
      updateRelays(ALL_VALVES_OFF);
      startMillis = millis();
      valveNumber++;
      if (valveNumber > NUMBER_OF_VALVES)
      {
        state = CYCLE_COMPLETE;
        startMillis = millis();
        lastValve = -1;
        lastTimeRun = now();
        saveDateToEEPROM(lastTimeRun);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          send(msg1valve.setSensor(i).set(false), false);
        }
        DEBUG_PRINT(F("State = "));
        DEBUG_PRINTLN(state);
      }
    }
  }
  //
  else if (state == RUN_SINGLE_ZONE)
  {
    fastToggleLed();
    if (state != lastState)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          send(msg1valve.setSensor(i).set(false), false);
        }
      }
      DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
      DEBUG_PRINT(F("Zone: "));
      DEBUG_PRINTLN(valveNumber);
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      updateRelays(ALL_VALVES_OFF);
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        send(msg1valve.setSensor(i).set(false), false);
      }
      state = CYCLE_COMPLETE;
      startMillis = millis();
      DEBUG_PRINT(F("State = "));
      DEBUG_PRINTLN(state);
    }
    lastTimeRun = now();
  }
  else if (state == CYCLE_COMPLETE)
  {
    if (millis() - startMillis < 30000UL)
    {
      fastToggleLed();
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
  }
  else if (state == ZONE_SELECT_MENU)
  {
    displayMenu();
  }
  lastState = state;
}
//
void displayMenu(void)
{
  static byte lastMenuState = -1;
  static int lastSecond;
  if (menuState != lastMenuState)
  {
    lcd.clear();
    lcd.setCursor(0, 0);
    lcd.print(valveNickName[menuState]);
    lcd.setCursor(0, 1);
    lcd.print(F("Starting"));
    DEBUG_PRINT(valveNickName[menuState]);
    Serial.print(F(" Starting Shortly"));
  }
  int thisSecond = (millis() - menuTimer) / 1000UL;
  if (thisSecond != lastSecond && thisSecond < 8)
  {
    lcd.print(F("."));
    Serial.print(".");
  }
  lastSecond = thisSecond;
  if (millis() - menuTimer > 10000UL)
  {
    startMillis = millis();
    if (menuState == 0)
    {
      valveNumber = 1;
      state = RUN_ALL_ZONES;
    }
    else
    {
      valveNumber = menuState;
      state = RUN_SINGLE_ZONE;
    }
  }
  else
  {

  }
  lastMenuState = menuState;
}
//
void updateRelays(int value)
{
  digitalWrite(latchPin, LOW);
  shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
  shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
  digitalWrite(latchPin, HIGH);
}
//
void PushButton() //interrupt with debounce
{
  static unsigned long last_interrupt_time = 0;
  unsigned long interrupt_time = millis();
  if (interrupt_time - last_interrupt_time > 200)
  {
    buttonPushed = true;
  }
  last_interrupt_time = interrupt_time;
}
//
void fastToggleLed()
{
  static unsigned long fastLedTimer;
  if (millis() - fastLedTimer >= 100UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    fastLedTimer = millis ();
  }
}
//
void slowToggleLED ()
{
  static unsigned long slowLedTimer;
  if (millis() - slowLedTimer >= 1250UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    slowLedTimer = millis ();
  }
}
//
void receive(const MyMessage &message)
{
  bool zoneTimeUpdate = false;
  if (message.isAck())
  {
    DEBUG_PRINTLN(F("This is an ack from gateway"));
  }
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    if (message.sensor == i)
    {
      if (message.type == V_LIGHT)
      {
        int switchState = atoi(message.data);
        if (switchState == 0)
        {
          state = STAND_BY_ALL_OFF;
          DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
        }
        else
        {
          if (i == 0)
          {
            state = RUN_ALL_ZONES;
            valveNumber = 1;
            DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
          }
          else
          {
            state = RUN_SINGLE_ZONE;
            valveNumber = i;
            DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
            DEBUG_PRINTLN(i);
          }
        }
        startMillis = millis();
      }
      else if (message.type == V_VAR1)
      {
        int variable1 = atoi(message.data);// RUN_ALL_ZONES time
        DEBUG_PRINT(F("Recieved variable1 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable1);
        if (variable1 != allZoneTime[i])
        {
          allZoneTime[i] = variable1;

          zoneTimeUpdate = true;
        }
        receivedInitialValue = true;
      }
      else if (message.type == V_VAR2)
      {
        int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
        DEBUG_PRINT(F("Recieved variable2 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable2);
        if (variable2 != valveSoloTime[i])
        {
          valveSoloTime[i] = variable2;
          zoneTimeUpdate = true;
        }
        receivedInitialValue = true;
      }
      else if (message.type == V_VAR3)
      {
        String newMessage = String(message.data);
        if (newMessage.length() == 0) 
        {
          DEBUG_PRINT(F("No Name Recieved for zone "));
          DEBUG_PRINTLN(i);
          break;
        }
        if (newMessage.length() > 16)
        {
          newMessage.substring(0, 16);
        }
        valveNickName[i] = "";
        valveNickName[i] += newMessage;
        DEBUG_PRINT(F("Recieved new name for zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" and it is now called: "));
        DEBUG_PRINTLN(valveNickName[i]);
      }
      receivedInitialValue = true;
    }
  }
  if (zoneTimeUpdate)
  {
    //
    DEBUG_PRINTLN(F("New Zone Times Recieved..."));
    for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
    {
      if (i != 0)
      {
        DEBUG_PRINT(F("Zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" individual time: "));
        DEBUG_PRINT(valveSoloTime[i]);
        DEBUG_PRINT(F(" group time: "));
        DEBUG_PRINTLN(allZoneTime[i]);
        recentUpdate = true;
      }
    }
  }
  else
  {
    recentUpdate = false;
  }
}
//
void updateDisplay()
{
  static unsigned long lastUpdateTime;
  static bool displayToggle = false;
  //static byte toggleCounter = 0;
  static SprinklerStates lastDisplayState;
  if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
  {
    displayToggle = !displayToggle;
    switch (state) {
      case STAND_BY_ALL_OFF:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("  System Ready "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
          lcd.print(hourFormat12());
          lcd.print(minute() < 10 ? F(":0") : F(":"));
          lcd.print(minute());
          lcd.print(isAM() ? F("am") : F("pm"));
          lcd.print(month() < 10 ? F(" 0") : F(" "));
          lcd.print(month());
          lcd.print(day() < 10 ? F("/0") : F("/"));
          lcd.print(day());
          lcd.print(F("/"));
          lcd.print(year() % 100);
        }
        else
        {
          lcd.print(F("  Last Watered "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(dayOfWeek[weekday(lastTimeRun)]);
          lcd.setCursor(11, 1);
          lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
          lcd.print(month(lastTimeRun));
          lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/"));
          lcd.print(day(lastTimeRun));
        }
        break;
      case RUN_SINGLE_ZONE:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("Single Zone Mode"));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active"));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          if (valveSoloTime[valveNumber] == 0)
          {
            lcd.print(F(" No Valve Time "));
          }
          else
          {
            unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
            lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
            lcd.print(timeRemaining / 60);
            lcd.print("min");
            lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
            lcd.print(timeRemaining % 60);
            lcd.print("sec  ");
          }
        }
        break;
      case RUN_ALL_ZONES:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F(" All-Zone  Mode "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active "));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
          lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
          lcd.print(timeRemaining / 60);
          lcd.print("min");
          lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
          lcd.print(timeRemaining % 60);
          lcd.print("sec  ");
        }
        break;
      case CYCLE_COMPLETE:
        //
        if (displayToggle)
        {
          lcd.setCursor(0, 0);
          lcd.print(F(" Watering Cycle "));
          lcd.setCursor(0, 1);
          lcd.print(F("    Complete    "));
        }
        else
        {
          int totalTimeRan = 0;
          for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
          {
            totalTimeRan += allZoneTime[i];
          }
          lcd.setCursor(0, 0);
          lcd.print(F(" Total Time Run "));
          lcd.setCursor(0, 1);
          lcd.print(totalTimeRan < 10 ? "   0" : "   ");
          lcd.print(totalTimeRan);
          lcd.print(" Minutes   ");
        }
      default:
        // what of ZONE_SELECT_MENU?
        break;
    }
    lastUpdateTime = millis();
  }
  lastDisplayState = state;
}
void receiveTime(time_t newTime)
{
  DEBUG_PRINTLN(F("Time value received and updated..."));
  int lastSecond = second();
  int lastMinute = minute();
  int lastHour = hour();
  setTime(newTime);
  if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
  {
    DEBUG_PRINTLN(F("Clock updated...."));
    DEBUG_PRINT(F("Sensor's time currently set to:"));
    DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
    DEBUG_PRINT(hourFormat12());
    DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
    DEBUG_PRINT(minute());
    DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
    DEBUG_PRINT(month());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINT(day());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINTLN(year());
    DEBUG_PRINTLN(dayOfWeek[weekday()]);
    showTime = false;
  }
  else
  {
    DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
  }
  clockUpdating = false;
}
void fastClear()
{
  lcd.setCursor(0, 0);
  lcd.print(F("                "));
  lcd.setCursor(0, 1);
  lcd.print(F("                "));
}
//
void updateClock()
{
  static unsigned long lastVeraGetTime;
  if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
  {
    DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(0));
    clockUpdating = true;
    requestTime();
    lastVeraGetTime = millis();
  }
}
//
void saveDateToEEPROM(unsigned long theDate)
{
  DEBUG_PRINTLN(F("Saving Last Run date"));
  if (loadState(0) != 0xFF)
  {
    saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
  }
  //
  for (int i = 1; i < 5; i++)
  {
    saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
  }
}
//
void goGetValveTimes()
{
  static unsigned long valveUpdateTime;
  static byte valveIndex = 1;
  if (millis() - valveUpdateTime >= 300000UL / NUMBER_OF_VALVES)// update each valve once every 5 mins (distributes the traffic)
  {
    DEBUG_PRINTLN(F("Calling for Valve Data..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(1)); //lcd.write(1);
    request(valveIndex, V_VAR1);
    request(valveIndex, V_VAR2);
    request(valveIndex, V_VAR3);
    valveUpdateTime = millis();
    valveIndex++;
    if (valveIndex > NUMBER_OF_VALVES + 1)
    {
      valveIndex = 1;
    }
  }
}

TON RIJNAARD

Hello,

Can some one help me with a working sketch for Domoticz.
I have it a little working, only Domoticz give not the childs.
I get from the gate way the time and then is searching for the name from the zone.
If some one can give me a working sketch than i can see what is wrong.

Thanks in advance Ton

TON RIJNAARD

This post is deleted!

impertus

This post is deleted!

Gimlur

Hello,
first off all : thank you for your job.

I'm trying to make this sketch, but i have some problems.
Around the line 619 with V_VAR3
In the sensor console i have this

0 MCO:BGN:INIT REPEATER,CP=RNNRA--,VER=2.1.0
3 TSM:INIT
4 TSF:WUR:MS=0
11 TSM:INIT:TSP OK
13 TSF:SID:OK,ID=1
15 TSM:FPAR
51 TSF:MSG:SEND,1-1-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
144 TSF:MSG:READ,0-0-1,s=255,c=3,t=8,pt=1,l=1,sg=0:0
149 TSF:MSG:FPAR OK,ID=0,D=1
2058 TSM:FPAR:OK
2059 TSM:ID
2060 TSM:ID:OK
2062 TSM:UPL
2065 TSF:MSG:SEND,1-1-0-0,s=255,c=3,t=24,pt=1,l=1,sg=0,ft=0,st=OK:1
2072 TSF:MSG:READ,0-0-1,s=255,c=3,t=25,pt=1,l=1,sg=0:1
2077 TSF:MSG:PONG RECV,HP=1
2080 TSM:UPL:OK
2081 TSM:READY:ID=1,PAR=0,DIS=1
2086 TSF:MSG:SEND,1-1-0-0,s=255,c=3,t=15,pt=6,l=2,sg=0,ft=0,st=OK:0100
2096 TSF:MSG:READ,0-0-1,s=255,c=3,t=15,pt=6,l=2,sg=0:0100
2103 TSF:MSG:SEND,1-1-0-0,s=255,c=0,t=18,pt=0,l=5,sg=0,ft=0,st=OK:2.1.0
2111 TSF:MSG:SEND,1-1-0-0,s=255,c=3,t=6,pt=1,l=1,sg=0,ft=0,st=OK:0
2129 TSF:MSG:READ,0-0-1,s=255,c=3,t=6,pt=0,l=1,sg=0:M
2137 TSF:MSG:SEND,1-1-0-0,s=255,c=3,t=11,pt=0,l=11,sg=0,ft=0,st=OK:MySprinkler
2146 TSF:MSG:SEND,1-1-0-0,s=255,c=3,t=12,pt=0,l=3,sg=0,ft=0,st=OK:2.0
2154 TSF:MSG:SEND,1-1-0-0,s=0,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2161 TSF:MSG:SEND,1-1-0-0,s=1,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2168 TSF:MSG:SEND,1-1-0-0,s=2,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2177 TSF:MSG:SEND,1-1-0-0,s=3,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2184 TSF:MSG:SEND,1-1-0-0,s=4,c=0,t=3,pt=0,l=0,sg=0,ft=0,st=OK:
2190 MCO:REG:REQ
2193 TSF:MSG:SEND,1-1-0-0,s=255,c=3,t=26,pt=1,l=1,sg=0,ft=0,st=OK:2
2199 TSF:MSG:READ,0-0-1,s=255,c=3,t=27,pt=1,l=1,sg=0:1
2204 MCO:PIM:NODE REG=1
2207 MCO:BGN:STP
Initialisation...
Mise des Vannes sur Off...
Checking EEPROM for stored date:
Retreiving last run time from EEPROM...
Sensor Presentation Complete
Ready...
2864 TSF:MSG:SEND,1-1-0-0,s=255,c=3,t=1,pt=0,l=0,sg=0,ft=0,st=OK:
Requesting time from Gateway:
2882 TSF:MSG:READ,0-0-1,s=255,c=3,t=1,pt=0,l=10,sg=0:1484768469
Time value received and updated...
Horloge mise Ã  jour....
Sensor's time currently set to: 07:41pm
18/1/2017
Mercredi 
Calling for Valve 0 Data...
3902 TSF:MSG:SEND,1-1-0-0,s=0,c=2,t=24,pt=0,l=0,sg=0,ft=0,st=OK:
3913 TSF:MSG:READ,0-0-1,s=0,c=2,t=24,pt=0,l=0,sg=0:
Recieved variable1 valve:0 = 0
4410 TSF:MSG:SEND,1-1-0-0,s=0,c=2,t=25,pt=0,l=0,sg=0,ft=0,st=OK:
4431 TSF:MSG:READ,0-0-1,s=0,c=2,t=25,pt=0,l=0,sg=0:
Recieved variable2 valve:0 = 0
4919 TSF:MSG:SEND,1-1-0-0,s=0,c=2,t=26,pt=0,l=0,sg=0,ft=0,st=OK:
4939 TSF:MSG:READ,0-0-1,s=0,c=2,t=26,pt=0,l=0,sg=0:
No Name Recieved for zone 0
5428 TSF:MSG:SEND,1-1-0-0,s=0,c=2,t=26,pt=0,l=0,sg=0,ft=0,st=OK:
5447 TSF:MSG:READ,0-0-1,s=0,c=2,t=26,pt=0,l=0,sg=0:
No Name Recieved for zone 0

In my domoticz GW i have a node MySprinkler 2.0 with 6 childs : 0 to 4 S_LIGHT/S_BINARY, 255 REPREATER

It's seems that the communication between gateway and sensors failed with V_VAR3, V_VAR1 and V_VAR2 are ok.

Can somebody help me, please ?

EDIT : according to the instructions inside this skecth :

* Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
  the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
  you may use the defaulet zone names by leaving Variable3 blank.

I can't find any Variable in my domoticz Controller, only S_LIGHT childs of Sprinkler Node :

Where is my mistake ?

Gimlur

I reply to myself...
Like Huczas say before, you have to modify this Sketch for Domoticz.

Domoticz don't receive and manage V_VAR1, V_VAR2, V_VAR3, so you have to fixe them in code.

But i have another question :
is there a possibility to declare a supplementary sensor wich can manage this variables ?

tombstone

Hi I looking to do My 1st MySensors Project an hoping to use this one I have a 3.2" Nextion. Will it be hard to use a nextion as a Display. Will there be help so I can get it working as I think the nextion Display will be good .... with weather updates and maybe senses to tell if the plants has to much water or no water. but thats down the trake...

Paulb

Hi, this is my first MySensors project having been inspired to jump in after finding @petewill great Youtube video. Thanks to @BulldogLowell for the code. After much perseverance I have everything working... kinda'.
My last persistent issue is the system halting zone 2, ie, cycle starts and ~10 seconds in the irrigation is halted. This only happens for Zone 2 (pin 1 on the shift register). This issue only occurs when either starting Zone 2 singularly from the controller or as part of the All Zones from the controller - Zone 1 will complete, Zone 2 will start then stop after ~10 seconds. Zone 2 WILL complete fine when selected manually from the pushbutton. All Zones from the pushbutton or controller will both fail.
I've checked and re-checked solder joints, wire connections, put the 10k external pullup resistor in and swapped out shift registers with no luck so far.
Would appreciate any help to resolve. Thanks.

I am using Domoticz and @Huczas modified sketch.

/*

Arduino Multi-Zone Sprinkler Control

May 31, 2015

*** Version 2.0

*** Upgraded to http://MySensors.org version 1.4.1
*** Expanded for up to 16 Valves
*** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
*** Switch to bitshift method vs byte arrays
*** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
*** Added optional LCD display featuring remaining time, date last ran & current time
*** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively
*** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone)
*** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names)

Utilizing your Vera home automation controller and the MySensors.org gateway you can
control up to a sixteen zone irrigation system with only three digital pins.  This sketch
will create NUMBER_OF_VALVES + 1 devices on your Vera controller

This sketch features the following:

* Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.
* Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n)
  using Variable1 as the "ON" time in minutes in each of the vera devices created.
* Use the individual zone controller to activate a single zone.  This feature uses
  Variable2 as the "ON" time for each individual device/zone.
* Connect according to pinout below and uses Shift Registers as to allow the MySensors
  standard radio configuration and still leave available digital pins
* Turning on any zone will stop the current process and begin that particular process.
* Turning off any zone will stop the current process and turn off all zones.
* To push your new time intervals for your zones, simply change the variable on your Vera and
  your arduino will call to Vera once a minute and update accordingly.  Variables will also be
  requested when the device is first powered on.
* Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program
* LED status indicator

PARTS LIST:
Available from the MySensors store - http://www.mysensors.org/store/
* Relays (8 channel)
* Female Pin Header Connector Strip
* Prototype Universal Printed Circuit Boards (PCB)
* NRF24L01 Radio
* Arduino (I used a Pro Mini)
* FTDI USB to TTL Serial Adapter
* Capacitors (10uf and .1uf)
* 3.3v voltage regulator
* Resistors (270 & 10K)
* Female Dupont Cables
* 1602 LCD (with I2C Interface)
* LED
* Push button
* Shift Register (SN74HC595)
* 2 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 3 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 22-24 gauge wire or similar (I used Cat5/Cat6 cable)
* 18 gauge wire (for relay)
* Irrigation Power Supply (24-Volt/750 mA Transformer)


INSTRUCTIONS:

* A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI
* After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to
  A4 and A5) and relays, and load the sketch.
* Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
* Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
  the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
  you may use the defaulet zone names by leaving Variable3 blank.
* Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
* Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
  on the serial monitor.
* Your arduino should slow-flash, indicating that it is in ready mode.
* There are multiple debug serial prints that can be monitored to assure that it is operating properly.
* ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours

Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain
*/
//
#include <Wire.h>
#include <Time.h>
#include <MySensor.h>
#include <SPI.h>
#include <LiquidCrystal.h>
#include <LiquidCrystal_I2C.h>
//
#define NUMBER_OF_VALVES 5  // Change this to set your valve count up to 16.
#define VALVE_RESET_TIME 4500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
#define RADIO_ID AUTO  // Change this to fix your Radio ID or use Auto

#define SKETCH_NAME "MySprinkler Domoticz"
#define SKETCH_VERSION "2.0"
//
#define CHILD_ID_SPRINKLER 0
//
#define ACTIVE_LOW // comment out this line if your relays are active high
//
#define DEBUG_ON   // comment out to supress serial monitor output
//
#ifdef ACTIVE_LOW
#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
#define ALL_VALVES_OFF 0xFFFF
#else
#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
#define ALL_VALVES_OFF 0U
#endif
//
#ifdef DEBUG_ON
#define DEBUG_PRINT(x)   Serial.print(x)
#define DEBUG_PRINTLN(x) Serial.println(x)
#define SERIAL_START(x)  Serial.begin(x)
#else
#define DEBUG_PRINT(x)
#define DEBUG_PRINTLN(x)
#define SERIAL_START(x)
#endif
//
typedef enum {
  STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
}
SprinklerStates;
//
SprinklerStates state = STAND_BY_ALL_OFF;
SprinklerStates lastState;
byte menuState = 0;
unsigned long menuTimer;
byte countDownTime = 10;
//
int allZoneTime [NUMBER_OF_VALVES + 1]= {0, 1, 1, 1, 1, 1};     // Insert values in min, 0 = all zone (always 0) this is a 5 chan relay
int valveSoloTime [NUMBER_OF_VALVES + 1]= {0, 1, 1, 1, 1, 1};   // Insert values in min, 0 = all zone (always 0) this is a 5 chan relay
int valveNumber;
int lastValve;
unsigned long startMillis;
const int ledPin = 5;
const int waterButtonPin = 3;
boolean buttonPushed = false;
boolean showTime = true;
boolean clockUpdating = false;
boolean recentUpdate = true;
const char *dayOfWeek[] = {
  "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
};
// Name your Zones here or use Vera to edit them by adding a name in Variable3...
String valveNickName[17] = {
  "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
};
//
time_t lastTimeRun = 0;
//Setup Shift Register...
const int latchPin = 8;
const int clockPin = 4;
const int dataPin  = 7;
//extra for 1k resistor
//const int outputEnablePin = 6;
//end extra 1k
//
byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
// Set the pins on the I2C chip used for LCD connections:
//                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
LiquidCrystal_I2C lcd(0x27, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27
MySensor gw;
//
MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);
//
void setup()
{
  SERIAL_START(115200);
  DEBUG_PRINTLN(F("Initialising..."));
  pinMode(latchPin, OUTPUT);
  pinMode(clockPin, OUTPUT);
  pinMode(dataPin, OUTPUT);
  pinMode(ledPin, OUTPUT);
  //internal pullup use next line
  //pinMode(waterButtonPin, INPUT_PULLUP);
  //external pullup use next line
  pinMode(waterButtonPin, INPUT);
  attachInterrupt(1, PushButton, RISING); //May need to change for your Arduino model
  digitalWrite (ledPin, HIGH);
  DEBUG_PRINTLN(F("Turning All Valves Off..."));
  updateRelays(ALL_VALVES_OFF);
  //extra for 1k resistor
  //pinMode(outputEnablePin, OUTPUT);
  //digitalWrite (outputEnablePin, LOW);
  //end extra 1k  
  //delay(5000);
  //delay(5000);
  lcd.begin(16, 2); //(16 characters and 2 line display)
  lcd.clear();
  lcd.backlight();
  lcd.createChar(0, clock);
  lcd.createChar(1, raindrop);
  //
  //check for saved date in EEPROM
  DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
  delay(500);
  if (gw.loadState(0) == 0xFF); // EEPROM flag
  {
    DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
    for (int i = 0; i < 4 ; i++)
    {
      lastTimeRun = lastTimeRun << 8;
      lastTimeRun = lastTimeRun | gw.loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
    }
  }
  gw.begin(getVariables, RADIO_ID, false); // Change 'false' to 'true' to create a Radio repeating node
  gw.sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    gw.present(i, S_LIGHT);
  }
  DEBUG_PRINTLN(F("Sensor Presentation Complete"));
  //
  digitalWrite (ledPin, LOW);
  DEBUG_PRINTLN(F("Ready..."));
  //
  lcd.setCursor(0, 0);
  lcd.print(F(" Syncing Time  "));
  lcd.setCursor(15, 0);
  lcd.write(byte(0));
  lcd.setCursor(0, 1);
  int clockCounter = 0;
  while (timeStatus() == timeNotSet && clockCounter < 21)
  {
    gw.process();
    gw.requestTime(receiveTime);
    DEBUG_PRINTLN(F("Requesting time from Gateway:"));
    delay(1000);
    lcd.print(".");
    clockCounter++;
    if (clockCounter > 16)
    {
      DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
      lcd.clear();
      lcd.print(F("  Failed Clock  "));
      lcd.setCursor(0, 1);
      lcd.print(F(" Syncronization "));
      delay(2000);
      break;
    }
  }
  //
  lcd.clear();

  /*
  //Update valve data when first powered on
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    lcd.print(F(" Updating  "));
    lcd.setCursor(0, 1);
    lcd.print(F(" Valve Data: "));
    lcd.print(i);
    boolean flashIcon = false;
    DEBUG_PRINT(F("Calling for Valve "));
    DEBUG_PRINT(i);
    DEBUG_PRINTLN(F(" Data..."));
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR1);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR2);
      delay(100);
    }
    while (gw.process() == false)
    {
      lcd.setCursor(15, 0);
      flashIcon = !flashIcon;
      flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
      gw.request(i, V_VAR3);
      delay(100);
    }
  }
  */
  lcd.clear();
}
//
void loop()
{
  gw.process();
  updateClock();
  updateDisplay();
  //goGetValveTimes();
  //
  if (buttonPushed)
  {
    menuTimer = millis();
    DEBUG_PRINTLN(F("Button Pressed"));
    if (state == STAND_BY_ALL_OFF)
    {
      state = ZONE_SELECT_MENU;
      menuState = 0;
    }
    else if (state == ZONE_SELECT_MENU)
    {
      menuState++;
      if (menuState > NUMBER_OF_VALVES)
      {
        menuState = 0;
      }
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
    buttonPushed = false;
  }
  if (state == STAND_BY_ALL_OFF)
  {
    slowToggleLED ();
    if (state != lastState)
    {
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed... all Zones off"));
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        delay(50);
        gw.send(msg1valve.setSensor(i).set(false), false);
      }
      lcd.clear();
      lcd.setCursor(0,0);
      lcd.print(F("** Irrigation **"));
      lcd.setCursor(0,1);
      lcd.print(F("**   Halted   **"));
      delay(2000);
      lastValve = -1;
    }
  }
  //
  else if (state == RUN_ALL_ZONES)
  {
    if (lastValve != valveNumber)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
      valveNumber = 1;
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      DEBUG_PRINTLN(F("Changing Valves..."));
      updateRelays(ALL_VALVES_OFF);
      startMillis = millis();
      valveNumber++;
      if (valveNumber > NUMBER_OF_VALVES)
      {
        state = CYCLE_COMPLETE;
        startMillis = millis();
        lastValve = -1;
        lastTimeRun = now();
        saveDateToEEPROM(lastTimeRun);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
        DEBUG_PRINT(F("State = "));
        DEBUG_PRINTLN(state);
      }
    }
  }
  //
  else if (state == RUN_SINGLE_ZONE)
  {
    fastToggleLed();
    if (state != lastState)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          gw.send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          gw.send(msg1valve.setSensor(i).set(false), false);
        }
      }
      DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
      DEBUG_PRINT(F("Zone: "));
      DEBUG_PRINTLN(valveNumber);
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      updateRelays(ALL_VALVES_OFF);
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        gw.send(msg1valve.setSensor(i).set(false), false);
      }
      state = CYCLE_COMPLETE;
      startMillis = millis();
      DEBUG_PRINT(F("State = "));
      DEBUG_PRINTLN(state);
    }
    lastTimeRun = now();
  }
  else if (state == CYCLE_COMPLETE)
  {
    if (millis() - startMillis < 30000UL)
    {
      fastToggleLed();
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
  }
  else if (state = ZONE_SELECT_MENU)
  {
    displayMenu();
  }
  lastState = state;
}
//
void displayMenu(void)
{
  static byte lastMenuState = -1;
  static int lastSecond;
  if (menuState != lastMenuState)
  {
    lcd.clear();
    lcd.setCursor(0, 0);
    lcd.print(valveNickName[menuState]);
    lcd.setCursor(0, 1);
    lcd.print(F("Starting"));
    DEBUG_PRINT(valveNickName[menuState]);
    Serial.print(F(" Starting Shortly"));
  }
  int thisSecond = (millis() - menuTimer) / 1000UL;
  if (thisSecond != lastSecond && thisSecond < 8)
  {
    lcd.print(F("."));
    Serial.print(".");
  }
  lastSecond = thisSecond;
  if (millis() - menuTimer > 10000UL)
  {
    startMillis = millis();
    if (menuState == 0)
    {
      valveNumber = 1;
      state = RUN_ALL_ZONES;
    }
    else
    {
      valveNumber = menuState;
      state = RUN_SINGLE_ZONE;
    }
  }
  else
  {

  }
  lastMenuState = menuState;
}
//
void updateRelays(int value)
{
  digitalWrite(latchPin, LOW);
  shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
  shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
  digitalWrite(latchPin, HIGH);
}
//
void PushButton() //interrupt with debounce
{
  static unsigned long last_interrupt_time = 0;
  unsigned long interrupt_time = millis();
  if (interrupt_time - last_interrupt_time > 200)
  {
    buttonPushed = true;
  }
  last_interrupt_time = interrupt_time;
}
//
void fastToggleLed()
{
  static unsigned long fastLedTimer;
  if (millis() - fastLedTimer >= 100UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    fastLedTimer = millis ();
  }
}
//
void slowToggleLED ()
{
  static unsigned long slowLedTimer;
  if (millis() - slowLedTimer >= 1250UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    slowLedTimer = millis ();
  }
}
//
void getVariables(const MyMessage &message)
{
  boolean zoneTimeUpdate = false;
  if (message.isAck())
  {
    DEBUG_PRINTLN(F("This is an ack from gateway"));
  }
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    if (message.sensor == i)
    {
      if (message.type == V_LIGHT)
      {
        int switchState = atoi(message.data);
        if (switchState == 0)
        {
          state = STAND_BY_ALL_OFF;
          DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
        }
        else
        {
          if (i == 0)
          {
            state = RUN_ALL_ZONES;
            valveNumber = 1;
            DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
          }
          else
          {
            state = RUN_SINGLE_ZONE;
            valveNumber = i;
            DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
            DEBUG_PRINTLN(i);
          }
        }
        startMillis = millis();
      }
      else if (message.type == V_VAR1)
      {
        int variable1 = atoi(message.data);// RUN_ALL_ZONES time
        DEBUG_PRINT(F("Recieved variable1 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable1);
        if (variable1 != allZoneTime[i])
        {
          allZoneTime[i] = variable1;

          zoneTimeUpdate = true;
        }
      }
      else if (message.type == V_VAR2)
      {
        int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
        DEBUG_PRINT(F("Recieved variable2 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable2);
        if (variable2 != valveSoloTime[i])
        {
          valveSoloTime[i] = variable2;
          zoneTimeUpdate = true;
        }
      }
      else if (message.type == V_VAR3)
      {
        String newMessage = String(message.data);
        if (newMessage.length() == 0) 
        {
          DEBUG_PRINT(F("No Name Recieved for zone "));
          DEBUG_PRINTLN(i);
          break;
        }
        if (newMessage.length() > 16)
        {
          newMessage.substring(0, 16);
        }
        valveNickName[i] = "";
        valveNickName[i] += newMessage;
        DEBUG_PRINT(F("Recieved new name for zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" and it is now called: "));
        DEBUG_PRINTLN(valveNickName[i]);
      }
    }
  }
  if (zoneTimeUpdate)
  {
    //
    DEBUG_PRINTLN(F("New Zone Times Recieved..."));
    for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
    {
      if (i != 0)
      {
        DEBUG_PRINT(F("Zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" individual time: "));
        DEBUG_PRINT(valveSoloTime[i]);
        DEBUG_PRINT(F(" group time: "));
        DEBUG_PRINTLN(allZoneTime[i]);
        recentUpdate = true;
      }
    }
  }
  else
  {
    recentUpdate = false;
  }
}
//
void updateDisplay()
{
  static unsigned long lastUpdateTime;
  static boolean displayToggle = false;
  //static byte toggleCounter = 0;
  static SprinklerStates lastDisplayState;
  if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
  {
    displayToggle = !displayToggle;
    switch (state) {
      case STAND_BY_ALL_OFF:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("  System Ready "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
          lcd.print(hourFormat12());
          lcd.print(minute() < 10 ? F(":0") : F(":"));
          lcd.print(minute());
          lcd.print(isAM() ? F("am") : F("pm"));
          lcd.print(month() < 10 ? F(" 0") : F(" "));
          lcd.print(month());
          lcd.print(day() < 10 ? F("/0") : F("/"));
          lcd.print(day());
          lcd.print(F("/"));
          lcd.print(year() % 100);
        }
        else
        {
          lcd.print(F("  Last Watered "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(dayOfWeek[weekday(lastTimeRun)]);
          lcd.setCursor(11, 1);
          lcd.print(day(lastTimeRun) < 10 ? F("0") : F("/"));
          lcd.print(day(lastTimeRun));
          lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
          lcd.print(month(lastTimeRun));
          
        }
        break;
      case RUN_SINGLE_ZONE:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("Single Zone Mode"));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active"));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          if (valveSoloTime[valveNumber] == 0)
          {
            lcd.print(F(" No Valve Time "));
          }
          else
          {
            unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
            lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
            lcd.print(timeRemaining / 60);
            lcd.print("min");
            lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
            lcd.print(timeRemaining % 60);
            lcd.print("sec  ");
          }
        }
        break;
      case RUN_ALL_ZONES:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F(" All-Zone  Mode "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active "));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
          lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
          lcd.print(timeRemaining / 60);
          lcd.print("min");
          lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
          lcd.print(timeRemaining % 60);
          lcd.print("sec  ");
        }
        break;
      case CYCLE_COMPLETE:
        //
        if (displayToggle)
        {
          lcd.setCursor(0, 0);
          lcd.print(F(" Watering Cycle "));
          lcd.setCursor(0, 1);
          lcd.print(F("    Complete    "));
        }
        else
        {
          int totalTimeRan = 0;
          for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
          {
            totalTimeRan += allZoneTime[i];
          }
          lcd.setCursor(0, 0);
          lcd.print(F(" Total Time Run "));
          lcd.setCursor(0, 1);
          lcd.print(totalTimeRan < 10 ? "   0" : "   ");
          lcd.print(totalTimeRan);
          lcd.print(" Minutes   ");
        }
    }
    lastUpdateTime = millis();
  }
  lastDisplayState = state;
}
void receiveTime(time_t newTime)
{
  DEBUG_PRINTLN(F("Time value received and updated..."));
  int lastSecond = second();
  int lastMinute = minute();
  int lastHour = hour();
  setTime(newTime);
  if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
  {
    DEBUG_PRINTLN(F("Clock updated...."));
    DEBUG_PRINT(F("Sensor's time currently set to:"));
    DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
    DEBUG_PRINT(hourFormat12());
    DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
    DEBUG_PRINT(minute());
    DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
    DEBUG_PRINT(month());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINT(day());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINTLN(year());
    DEBUG_PRINTLN(dayOfWeek[weekday()]);
    showTime = false;
  }
  else
  {
    DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
  }
  clockUpdating = false;
}
void fastClear()
{
  lcd.setCursor(0, 0);
  lcd.print(F("                "));
  lcd.setCursor(0, 1);
  lcd.print(F("                "));
}
//
void updateClock()
{
  static unsigned long lastVeraGetTime;
  if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
  {
    DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(0));
    clockUpdating = true;
    gw.requestTime(receiveTime);
    lastVeraGetTime = millis();
  }
}
//
void saveDateToEEPROM(unsigned long theDate)
{
  DEBUG_PRINTLN(F("Saving Last Run date"));
  if (gw.loadState(0) != 0xFF)
  {
    gw.saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
  }
  //
  for (int i = 1; i < 5; i++)
  {
    gw.saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
  }
}
//
void goGetValveTimes()
{
  static unsigned long valveUpdateTime;
  static byte valveIndex = 1;
  if (millis() - valveUpdateTime >= 300000UL / NUMBER_OF_VALVES)// update each valve once every 5 mins (distributes the traffic)
  {
    DEBUG_PRINTLN(F("Calling for Valve Data..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(1)); //lcd.write(1);
    gw.request(valveIndex, V_VAR1);
    gw.request(valveIndex, V_VAR2);
    gw.request(valveIndex, V_VAR3);
    valveUpdateTime = millis();
    valveIndex++;
    if (valveIndex > NUMBER_OF_VALVES + 1)
    {
      valveIndex = 1;
    }
  }
}```

Paulb

@Paulb After more troubleshooting I finally narrowed down the problem to an external factor. It seems the old desk lamp I was using on my workbench interfered with the radio signal. It is a fluorescent tube which I understand can be quite 'noisy'. Replicated the conditions several times, stopped using the lamp - presto! everything works as it should.

pettib

Do anyone has a working solution to connect this project to a main valve who has to open when running the zones ?

gohan

Do you mean that you need to open a main valve while any of the others are open and close it whenever the others are all closed?

pettib

@gohan exactly what I meant.

dbemowsk

@pettib I started this project last summer but have not fully finished it. My setup has a pump start relay, which is essentially the same as a main valve control.

One way to do this is to connect one more data line to a relay and in your sketch, change it so that any time a zone is triggered, turn on the main valve data line. Shouldn't be that difficult to code.

I was originally planning to do this with hardware where I had diodes from each output of the shift register feeding to one central point which would be the main valve relay, but I had some trouble with that. Could have been that I was doing something wrong. None the less, the approach above should work without issue if programmed correctly.

gohan

You could make a function that recursively checks if any of the valves pin is high it sets the main valve pin HIGH, if all the valve pins are LOW then it sets the main valve pin LOW

johnecy

I have the irrigation controller all setup and working. I have one problem though as soon as I power it up with 5 volts for the pro mini sometimes one sometimes all the relays come on. If I am not home the water runs all day is there a programing change or a wire change I need to make to stop this. I was using the old wire diagram without the pull up on pin 13 of the 74hc I changed to the new version and added the lines off code but it still does not help.

gohan

Are you setting all pins to low during setup?

dbemowsk

So I had started this build going on a year ago but never finished it. That was before I found the easy newbie boards which is what I plan on using to resurrect this build. My question is, can this be built using a 3.3V pro mini, or should I be using a 5V one. I am just wondering if I need to set up my newbie board with a 3.3V regulator or not. My other question is on the resistors. I have a bunch of 1/8 watt resistors and was wondering if they would work or if I should go to 1/4 watt. I have all of the parts in my parts bin and with the newbie board it shouldn't take long to put it together, just need direction on those couple things.

gohan

It's hard to answer since you aren't providing many details like is it battery powered? What kind of valves are you using? What are you using those resistors for?

dbemowsk

@gohan Sorry, I am talking about the schematic for the irrigation controller in the build section of the site. That is why I posted the question here.

One other thing that I just noticed, and I will post this in the easy newbie board thread also for @sundberg84, I noticed that there is a change in the pins that are broken out on the header on the left side of the board. This is the board that I am using for the build, and I was going to point out here that the schematic below shows to connect D7 and D8 to the shift register, but the REV 8 board that I am using does not break out D8. After looking at the site on the new REV 9 boards, which I have a batch of, he doesn't break out D7 or D8.. The wiring of the pins is completely different between the REV 8 and REV 9 boards. The reason I mention this is that I was going to write something up here explaining the build with a newbie board, but I think I will hold off as it might be confusing to many depending what REV of the board people have.

Another thing that I just notices is on the schematic. I have a copy of the schematic that I printed last year when I started this build. There has since been a change. In the old schematic that I have it shows the output enable (OE) pin of the shift register grounded, where in the one below, it showsit connected to D6 through a 1K resistor. I can understand that the change is to give arduino control to the output enable line, but because in the other schematic it didn't show D6 connected, and I didn't have D8 broken out, I used D6 in it's place. I may need to rethink some of this. In any case, I will need to make some changes to the sketch prior to uploading it.
0_1496074195604_upload-c4616651-6dc5-47bb-a4c6-ff77a1936257

dbemowsk

OK, so I have this built this and have it mostly working with my Vera Plus. Below is a link to a video of a problem I am having.

http://www.dan.bemowski.info/videos/20170601_004213.mp4

So my sprinkler system has a pump start relay which gets turned on any time a valve is turned on. Because of this I made a slight hardware modification which thus required a software modification. For the hardware, I ended up using relay number 1 of my 8 channel relay board as my pump start relay control. This I have wired to pin A1. Relays 2 through 8 are connected to the shift register on Qb through Qh (outputs 2-8) skipping output 1. Because of this I had to change how the code defined which valve to start on. To do this, I changed the commented lines removing the (-1) on the bit shift. I made the assumption that in code, the relay numbers start with 0.

#ifdef ACTIVE_LOW
//#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber))
#define ALL_VALVES_OFF 0xFFFF
#else
//#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber))
#define ALL_VALVES_OFF 0U
#endif

Then I needed to define the pump start relay.

const int pumpStart = A1;

and then in setup I have this:

  pinMode(pumpStart, OUTPUT);
  digitalWrite (pumpStart, HIGH);

Lastly, to operate the pump start relay whenever a zone is triggered, this is the updateRelays() function:

void updateRelays(int value)
{
  if (value == ALL_VALVES_OFF) 
  {
    digitalWrite(pumpStart, HIGH);
  }
  else
  {
    digitalWrite(pumpStart, LOW);
  }
  digitalWrite(latchPin, LOW);
  shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
  shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
  digitalWrite(latchPin, HIGH);
}

All of this seems to work. When I trigger a zone, I see the pump start relay kick on as well as the triggered zone relay. The only problem I have is that the screen keeps cycling valve data: (1-4) on the screen, as can be seen in the video clip.

Here is my entire modified sketch that I have uploaded:

/*
MySprinkler for MySensors

Arduino Multi-Zone Sprinkler Control

May 31, 2015

*** Version 2.0

*** Upgraded to http://MySensors.org version 1.4.1
*** Expanded for up to 16 Valves
*** Setup for active low relay board or comment out #define ACTIVE_LOW to switch to active high
*** Switch to bitshift method vs byte arrays
*** Changed RUN_ALL_ZONES Vera device to 0 (was highest valve)
*** Added optional LCD display featuring remaining time, date last ran & current time
*** Features 'raindrop' and 'clock' icons which indicate sensor is updating valve data and clock respectively
*** Added single pushbutton menu to manually select which program to run (All Zones or a Single Zone)
*** Added option of naming your Zones programmatically or with Vera (V_VAR3 used to store names)

Utilizing your Vera home automation controller and the MySensors.org gateway you can
control up to a sixteen zone irrigation system with only three digital pins.  This sketch
will create NUMBER_OF_VALVES + 1 devices on your Vera controller

This sketch features the following:

* Allows you to cycle through All zones (RUN_ALL_ZONES) or individual zone (RUN_SINGLE_ZONE) control.
* Use the 0th controller to activate RUN_ALL_ZONES (each zone in numeric sequence 1 to n)
  using Variable1 as the "ON" time in minutes in each of the vera devices created.
* Use the individual zone controller to activate a single zone.  This feature uses
  Variable2 as the "ON" time for each individual device/zone.
* Connect according to pinout below and uses Shift Registers as to allow the MySensors
  standard radio configuration and still leave available digital pins
* Turning on any zone will stop the current process and begin that particular process.
* Turning off any zone will stop the current process and turn off all zones.
* To push your new time intervals for your zones, simply change the variable on your Vera and
  your arduino will call to Vera once a minute and update accordingly.  Variables will also be
  requested when the device is first powered on.
* Pushbutton activation to RUN_ALL_ZONES, RUN_SINGLE_ZONE or halt the current program
* LED status indicator

PARTS LIST:
Available from the MySensors store - http://www.mysensors.org/store/
* Relays (8 channel)
* Female Pin Header Connector Strip
* Prototype Universal Printed Circuit Boards (PCB)
* NRF24L01 Radio
* Arduino (I used a Pro Mini)
* FTDI USB to TTL Serial Adapter
* Capacitors (10uf and .1uf)
* 3.3v voltage regulator
* Resistors (270, 1K & 10K)
* Female Dupont Cables
* 1602 LCD (with I2C Interface)
* LED
* Push button
* Shift Register (SN74HC595)
* 2 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 3 Pole 5mm Pitch PCB Mount Screw Terminal Block
* 22-24 gauge wire or similar (I used Cat5/Cat6 cable)
* 18 gauge wire (for relay)
* Irrigation Power Supply (24-Volt/750 mA Transformer)


INSTRUCTIONS:

* A step-by-step setup video is available here: http://youtu.be/l4GPRTsuHkI
* After assembling your arduino, radio, decoupling capacitors, shift register(s), status LED, pushbutton LCD (I2C connected to
  A4 and A5) and relays, and load the sketch.
* Following the instructions at https://MySensors.org include the device to your MySensors Gateway.
* Verify that each new device has a Variable1, Variable2 and Variable3. Populate data accordingly with whole minutes for
  the RUN_ALL_ZONES routine (Variable1) and the RUN_SINGLE_ZONE routines (Variable 2).  The values entered for times may be zero and
  you may use the defaulet zone names by leaving Variable3 blank.
* Once you have entered values for each zone and each variable, save the settings by pressing the red save button on your Vera.
* Restart your arduino; verify the settings are loaded into your arduino with the serial monitor; the array will be printed
  on the serial monitor.
* Your arduino should slow-flash, indicating that it is in ready mode.
* There are multiple debug serial prints that can be monitored to assure that it is operating properly.
* ***THIS SHOULD NO LONGER BE NEEDED*** The standard MySensors library now works. https://bitbucket.org/fmalpartida/new-liquidcrystal/downloads for the I2C library, or use yours

Contributed by Jim (BulldogLowell@gmail.com) with much contribution from Pete (pete.will@mysensors.org) and is released to the public domain
*/
//

// Enable debug prints
#define MY_DEBUG

// Enable and select radio type attached
#define MY_RADIO_NRF24
//#define MY_RADIO_RFM69

//#define MY_NODE_ID 1  // Set this to fix your Radio ID or use Auto

#include <Wire.h>
#include <TimeLib.h>
#include <SPI.h>
#include <MySensors.h>
#include <LiquidCrystal.h>
#include <LiquidCrystal_I2C.h>


#define NUMBER_OF_VALVES 4  // Change this to set your valve count up to 16.
#define VALVE_RESET_TIME 7500UL   // Change this (in milliseconds) for the time you need your valves to hydraulically reset and change state
#define VALVE_TIMES_RELOAD 300000UL  // Change this (in milliseconds) for how often to update all valves data from the controller (Loops at value/number valves)
                                     // ie: 300000 for 8 valves produces requests 37.5seconds with all valves updated every 5mins 

#define SKETCH_NAME "MySprinkler"
#define SKETCH_VERSION "2.2"
//
#define CHILD_ID_SPRINKLER 0
//
#define ACTIVE_LOW // comment out this line if your relays are active high
//
#define DEBUG_ON   // comment out to supress serial monitor output
//
#ifdef ACTIVE_LOW
//#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber-1))
#define BITSHIFT_VALVE_NUMBER ~(1U << (valveNumber))
#define ALL_VALVES_OFF 0xFFFF
#else
//#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber-1))
#define BITSHIFT_VALVE_NUMBER (1U << (valveNumber))
#define ALL_VALVES_OFF 0U
#endif
//
#ifdef DEBUG_ON
#define DEBUG_PRINT(x)   Serial.print(x)
#define DEBUG_PRINTLN(x) Serial.println(x)
#else
#define DEBUG_PRINT(x)
#define DEBUG_PRINTLN(x)
#define SERIAL_START(x)
#endif
//
typedef enum {
  STAND_BY_ALL_OFF, RUN_SINGLE_ZONE, RUN_ALL_ZONES, CYCLE_COMPLETE, ZONE_SELECT_MENU
}
SprinklerStates;
//
SprinklerStates state = STAND_BY_ALL_OFF;
SprinklerStates lastState;
byte menuState = 0;
unsigned long menuTimer;
byte countDownTime = 10;
//
int allZoneTime [NUMBER_OF_VALVES + 1];
int valveSoloTime [NUMBER_OF_VALVES + 1];
int valveNumber;
int lastValve;
unsigned long startMillis;
const int ledPin = 5;
const int waterButtonPin = 3;
bool buttonPushed = false;
bool showTime = true;
bool clockUpdating = false;
bool recentUpdate = true;
int allVars[] = {V_VAR1, V_VAR2, V_VAR3};
const char *dayOfWeek[] = {
  "Null", "Sunday ", "Monday ", "Tuesday ", "Wednesday ", "Thursday ", "Friday ", "Saturday "
};
// Name your Zones here or use Vera to edit them by adding a name in Variable3...
String valveNickName[17] = {
  "All Zones", "Zone 1", "Zone 2", "Zone 3", "Zone 4", "Zone 5", "Zone 6", "Zone 7", "Zone 8", "Zone 9", "Zone 10", "Zone 11", "Zone 12", "Zone 13", "Zone 14", "Zone 15", "Zone 16"
};
//
time_t lastTimeRun = 0;
//Setup Shift Register...
const int latchPin = 6;
const int clockPin = 4;
const int dataPin  = 7;
const int outputEnablePin = A0;
const int pumpStart = A1;
//
byte clock[8] = {0x0, 0xe, 0x15, 0x17, 0x11, 0xe, 0x0}; // fetching time indicator
byte raindrop[8] = {0x4, 0x4, 0xA, 0xA, 0x11, 0xE, 0x0,}; // fetching Valve Data indicator
// Set the pins on the I2C chip used for LCD connections:
//                    addr, en,rw,rs,d4,d5,d6,d7,bl,blpol
LiquidCrystal_I2C lcd(0x3F, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE);  // Set the LCD I2C address to 0x27. Mine was actually 0x3F
//
MyMessage msg1valve(CHILD_ID_SPRINKLER, V_LIGHT);
MyMessage var1valve(CHILD_ID_SPRINKLER, V_VAR1);
MyMessage var2valve(CHILD_ID_SPRINKLER, V_VAR2);

bool receivedInitialValue = false;
bool inSetup = true;
//
void setup()
{
  DEBUG_PRINTLN(F("Initialising..."));
  pinMode(latchPin, OUTPUT);
  pinMode(clockPin, OUTPUT);
  pinMode(dataPin, OUTPUT);
  pinMode(ledPin, OUTPUT);
  pinMode(outputEnablePin, OUTPUT);
  digitalWrite (outputEnablePin, LOW);
  pinMode(ledPin, OUTPUT);
  pinMode(pumpStart, OUTPUT);
  digitalWrite (pumpStart, HIGH);
  pinMode(waterButtonPin, INPUT_PULLUP);
  //pinMode(waterButtonPin, INPUT);
  attachInterrupt(digitalPinToInterrupt(waterButtonPin), PushButton, RISING); //May need to change for your Arduino model
  digitalWrite (ledPin, HIGH);
  DEBUG_PRINTLN(F("Turning All Valves Off..."));
  updateRelays(ALL_VALVES_OFF);
  //delay(5000);
  lcd.begin(16, 2); //(16 characters and 2 line display)
  lcd.clear();
  lcd.backlight();
  lcd.createChar(0, clock);
  lcd.createChar(1, raindrop);
  //
  //check for saved date in EEPROM
  DEBUG_PRINTLN(F("Checking EEPROM for stored date:"));
  delay(500);
  if (loadState(0) == 0xFF) // EEPROM flag
  {
    DEBUG_PRINTLN(F("Retreiving last run time from EEPROM..."));
    for (int i = 0; i < 4 ; i++)
    {
      lastTimeRun = lastTimeRun << 8;
      lastTimeRun = lastTimeRun | loadState(i + 1); // assemble 4 bytes into an ussigned long epoch timestamp
    }
  }

  DEBUG_PRINTLN(F("Sensor Presentation Complete"));
  //
  digitalWrite (ledPin, LOW);
  DEBUG_PRINTLN(F("Ready..."));
  //
  lcd.setCursor(0, 0);
  lcd.print(F(" Syncing Time  "));
  lcd.setCursor(15, 0);
  lcd.write(byte(0));
  lcd.setCursor(0, 1);
  int clockCounter = 0;
  while (timeStatus() == timeNotSet && clockCounter < 21)
  {
    requestTime();
    DEBUG_PRINTLN(F("Requesting time from Gateway:"));
    wait(1000);
    lcd.print(".");
    clockCounter++;
    if (clockCounter > 16)
    {
      DEBUG_PRINTLN(F("Failed initial clock synchronization!"));
      lcd.clear();
      lcd.print(F("  Failed Clock  "));
      lcd.setCursor(0, 1);
      lcd.print(F(" Syncronization "));
      wait(2000);
      break;
    }
  }
  //
  //Update valve data when first powered on 
  for (byte i = 1; i <= NUMBER_OF_VALVES; i++)
  {
    lcd.clear();
    goGetValveTimes();
  }
  lcd.clear();
}


void presentation()  
{ 
  sendSketchInfo(SKETCH_NAME, SKETCH_VERSION);
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    present(i, S_LIGHT);
  }
}

//
void loop()
{
  updateClock();
  updateDisplay();
  goGetValveTimes();
  //
  if (buttonPushed)
  {
    menuTimer = millis();
    DEBUG_PRINTLN(F("Button Pressed"));
    if (state == STAND_BY_ALL_OFF)
    {
      state = ZONE_SELECT_MENU;
      menuState = 0;
    }
    else if (state == ZONE_SELECT_MENU)
    {
      menuState++;
      if (menuState > NUMBER_OF_VALVES)
      {
        menuState = 0;
      }
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
    buttonPushed = false;
  }
  if (state == STAND_BY_ALL_OFF)
  {
    slowToggleLED ();
    if (state != lastState)
    {
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed... all Zones off"));
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        wait(50);
        send(msg1valve.setSensor(i).set(false), false);
      }
      lcd.clear();
      lcd.setCursor(0,0);
      lcd.print(F("** Irrigation **"));
      lcd.setCursor(0,1);
      lcd.print(F("**   Halted   **"));
      wait(2000);
      lastValve = -1;
    }
  }
  //
  else if (state == RUN_ALL_ZONES)
  {
    if (lastValve != valveNumber)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          send(msg1valve.setSensor(i).set(false), false);
        }
        wait(50);
      }
    }
    lastValve = valveNumber;
    fastToggleLed();
    if (state != lastState)
    {
      valveNumber = 1;
      updateRelays(ALL_VALVES_OFF);
      DEBUG_PRINTLN(F("State Changed, Running All Zones..."));
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (allZoneTime[valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      DEBUG_PRINTLN(F("Changing Valves..."));
      updateRelays(ALL_VALVES_OFF);
      startMillis = millis();
      valveNumber++;
      if (valveNumber > NUMBER_OF_VALVES)
      {
        state = CYCLE_COMPLETE;
        startMillis = millis();
        lastValve = -1;
        lastTimeRun = now();
        saveDateToEEPROM(lastTimeRun);
        for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
        {
          send(msg1valve.setSensor(i).set(false), false);
          wait(50);
        }
        DEBUG_PRINT(F("State = "));
        DEBUG_PRINTLN(state);
      }
    }
  }
  //
  else if (state == RUN_SINGLE_ZONE)
  {
    fastToggleLed();
    if (state != lastState)
    {
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        if (i == 0 || i == valveNumber)
        {
          send(msg1valve.setSensor(i).set(true), false);
        }
        else
        {
          send(msg1valve.setSensor(i).set(false), false);
        }
        wait(50);
      }
      DEBUG_PRINTLN(F("State Changed, Single Zone Running..."));
      DEBUG_PRINT(F("Zone: "));
      DEBUG_PRINTLN(valveNumber);
    }
    unsigned long nowMillis = millis();
    if (nowMillis - startMillis < VALVE_RESET_TIME)
    {
      updateRelays(ALL_VALVES_OFF);
    }
    else if (nowMillis - startMillis < (valveSoloTime [valveNumber] * 60000UL))
    {
      updateRelays(BITSHIFT_VALVE_NUMBER);
    }
    else
    {
      updateRelays(ALL_VALVES_OFF);
      for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
      {
        send(msg1valve.setSensor(i).set(false), false);
      }
      state = CYCLE_COMPLETE;
      startMillis = millis();
      DEBUG_PRINT(F("State = "));
      DEBUG_PRINTLN(state);
    }
    lastTimeRun = now();
  }
  else if (state == CYCLE_COMPLETE)
  {
    if (millis() - startMillis < 30000UL)
    {
      fastToggleLed();
    }
    else
    {
      state = STAND_BY_ALL_OFF;
    }
  }
  if (state == ZONE_SELECT_MENU)
  {
    displayMenu();
  } 
  else 
  {
    lastState = state;
  }
}
//
void displayMenu(void)
{
  static byte lastMenuState = -1;
  static int lastSecond;
  if (menuState != lastMenuState)
  {
    lcd.clear();
    lcd.setCursor(0, 0);
    lcd.print(valveNickName[menuState]);
    lcd.setCursor(0, 1);
    lcd.print(F("Starting"));
    DEBUG_PRINT(valveNickName[menuState]);
    Serial.print(F(" Starting Shortly"));
  }
  int thisSecond = (millis() - menuTimer) / 1000UL;
  if (thisSecond != lastSecond && thisSecond < 8)
  {
    lcd.print(F("."));
    Serial.print(".");
  }
  lastSecond = thisSecond;
  if (millis() - menuTimer > 10000UL)
  {
    startMillis = millis();
    if (menuState == 0)
    {
      valveNumber = 1;
      state = RUN_ALL_ZONES;
    }
    else
    {
      valveNumber = menuState;
      state = RUN_SINGLE_ZONE;
    }
  }
  else
  {

  }
  lastMenuState = menuState;
}
//
void updateRelays(int value)
{
  if (value == ALL_VALVES_OFF) 
  {
    digitalWrite(pumpStart, HIGH);
  }
  else
  {
    digitalWrite(pumpStart, LOW);
  }
  digitalWrite(latchPin, LOW);
  shiftOut(dataPin, clockPin, MSBFIRST, highByte(value));
  shiftOut(dataPin, clockPin, MSBFIRST, lowByte(value));
  digitalWrite(latchPin, HIGH);
}
//
void PushButton() //interrupt with debounce
{
  static unsigned long last_interrupt_time = 0;
  unsigned long interrupt_time = millis();
  if (interrupt_time - last_interrupt_time > 200)
  {
    buttonPushed = true;
  }
  last_interrupt_time = interrupt_time;
}
//
void fastToggleLed()
{
  static unsigned long fastLedTimer;
  if (millis() - fastLedTimer >= 100UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    fastLedTimer = millis ();
  }
}
//
void slowToggleLED ()
{
  static unsigned long slowLedTimer;
  if (millis() - slowLedTimer >= 1250UL)
  {
    digitalWrite(ledPin, !digitalRead(ledPin));
    slowLedTimer = millis ();
  }
}
//
void receive(const MyMessage &message)
{
  bool zoneTimeUpdate = false;
  if (message.isAck())
  {
    DEBUG_PRINTLN(F("This is an ack from gateway"));
  }
  for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
  {
    if (message.sensor == i)
    {
      if (message.type == V_LIGHT)
      {
        int switchState = atoi(message.data);
        if (switchState == 0)
        {
          state = STAND_BY_ALL_OFF;
          DEBUG_PRINTLN(F("Recieved Instruction to Cancel..."));
        }
        else
        {
          if (i == 0)
          {
            state = RUN_ALL_ZONES;
            valveNumber = 1;
            DEBUG_PRINTLN(F("Recieved Instruction to Run All Zones..."));
          }
          else
          {
            state = RUN_SINGLE_ZONE;
            valveNumber = i;
            DEBUG_PRINT(F("Recieved Instruction to Activate Zone: "));
            DEBUG_PRINTLN(i);
          }
        }
        startMillis = millis();
      }
      else if (message.type == V_VAR1)
      {
        int variable1 = atoi(message.data);// RUN_ALL_ZONES time
        DEBUG_PRINT(F("Recieved variable1 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable1);
        if (variable1 != allZoneTime[i])
        {
          allZoneTime[i] = variable1;

          zoneTimeUpdate = true;
        }
        receivedInitialValue = true;
      }
      else if (message.type == V_VAR2)
      {
        int variable2 = atoi(message.data);// RUN_SINGLE_ZONE time
        DEBUG_PRINT(F("Recieved variable2 valve:"));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(variable2);
        if (variable2 != valveSoloTime[i])
        {
          valveSoloTime[i] = variable2;
          zoneTimeUpdate = true;
        }
        receivedInitialValue = true;
      }
      else if (message.type == V_VAR3)
      {
        String newMessage = String(message.data);
        if (newMessage.length() == 0) 
        {
          DEBUG_PRINT(F("No Name Recieved for zone "));
          DEBUG_PRINTLN(i);
          break;
        }
        if (newMessage.length() > 16)
        {
          newMessage.substring(0, 16);
        }
        valveNickName[i] = "";
        valveNickName[i] += newMessage;
        DEBUG_PRINT(F("Recieved variable3 valve: "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" = "));
        DEBUG_PRINTLN(valveNickName[i]);
      }
      receivedInitialValue = true;
    }
  }
  if (zoneTimeUpdate)
  {
    //
    DEBUG_PRINTLN(F("New Zone Times Recieved..."));
    for (byte i = 0; i <= NUMBER_OF_VALVES; i++)
    {
      if (i != 0)
      {
        DEBUG_PRINT(F("Zone "));
        DEBUG_PRINT(i);
        DEBUG_PRINT(F(" individual time: "));
        DEBUG_PRINT(valveSoloTime[i]);
        DEBUG_PRINT(F(" group time: "));
        DEBUG_PRINT(allZoneTime[i]);
        DEBUG_PRINT(F(" name: "));
        DEBUG_PRINTLN(valveNickName[i]);
        recentUpdate = true;
      }
    }
  }
  else
  {
    recentUpdate = false;
  }
}
//
void updateDisplay()
{
  static unsigned long lastUpdateTime;
  static bool displayToggle = false;
  //static byte toggleCounter = 0;
  static SprinklerStates lastDisplayState;
  if (state != lastDisplayState || millis() - lastUpdateTime >= 3000UL)
  {
    displayToggle = !displayToggle;
    switch (state) {
      case STAND_BY_ALL_OFF:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("  System Ready "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(hourFormat12() < 10 ? F(" ") : F(""));
          lcd.print(hourFormat12());
          lcd.print(minute() < 10 ? F(":0") : F(":"));
          lcd.print(minute());
          lcd.print(isAM() ? F("am") : F("pm"));
          lcd.print(month() < 10 ? F(" 0") : F(" "));
          lcd.print(month());
          lcd.print(day() < 10 ? F("/0") : F("/"));
          lcd.print(day());
          lcd.print(F("/"));
          lcd.print(year() % 100);
        }
        else
        {
          lcd.print(F("  Last Watered "));
          if (clockUpdating)
          {
            lcd.setCursor(15, 0);
            lcd.write(byte(0));
          }
          lcd.setCursor(0, 1);
          lcd.print(dayOfWeek[weekday(lastTimeRun)]);
          lcd.setCursor(11, 1);
          lcd.print(month(lastTimeRun) < 10 ? F(" ") : F(""));
          lcd.print(month(lastTimeRun));
          lcd.print(day(lastTimeRun) < 10 ? F("/0") : F("/"));
          lcd.print(day(lastTimeRun));
        }
        break;
      case RUN_SINGLE_ZONE:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F("Single Zone Mode"));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active"));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          if (valveSoloTime[valveNumber] == 0)
          {
            lcd.print(F(" No Valve Time "));
          }
          else
          {
            unsigned long timeRemaining = (valveSoloTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
            lcd.print(timeRemaining / 60 < 10 ? "   0" : "   ");
            lcd.print(timeRemaining / 60);
            lcd.print("min");
            lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
            lcd.print(timeRemaining % 60);
            lcd.print("sec  ");
          }
        }
        break;
      case RUN_ALL_ZONES:
        //
        fastClear();
        lcd.setCursor(0, 0);
        if (displayToggle)
        {
          lcd.print(F(" All-Zone  Mode "));
          lcd.setCursor(0, 1);
          lcd.print(F(" Zone:"));
          if (valveNumber < 10) lcd.print(F("0"));
          lcd.print(valveNumber);
          lcd.print(F(" Active "));
        }
        else
        {
          lcd.print(F(" Time Remaining "));
          lcd.setCursor(0, 1);
          int timeRemaining = (allZoneTime[valveNumber] * 60) - ((millis() - startMillis) / 1000);
          lcd.print((timeRemaining / 60) < 10 ? "   0" : "   ");
          lcd.print(timeRemaining / 60);
          lcd.print("min");
          lcd.print(timeRemaining % 60 < 10 ? " 0" : " ");
          lcd.print(timeRemaining % 60);
          lcd.print("sec  ");
        }
        break;
      case CYCLE_COMPLETE:
        //
        if (displayToggle)
        {
          lcd.setCursor(0, 0);
          lcd.print(F(" Watering Cycle "));
          lcd.setCursor(0, 1);
          lcd.print(F("    Complete    "));
        }
        else
        {
          int totalTimeRan = 0;
          for (int i = 1; i < NUMBER_OF_VALVES + 1; i++)
          {
            totalTimeRan += allZoneTime[i];
          }
          lcd.setCursor(0, 0);
          lcd.print(F(" Total Time Run "));
          lcd.setCursor(0, 1);
          lcd.print(totalTimeRan < 10 ? "   0" : "   ");
          lcd.print(totalTimeRan);
          lcd.print(" Minutes   ");
        }
      default:
        // what of ZONE_SELECT_MENU?
        break;
    }
    lastUpdateTime = millis();
  }
  lastDisplayState = state;
}
void receiveTime(time_t newTime)
{
  DEBUG_PRINTLN(F("Time value received and updated..."));
  int lastSecond = second();
  int lastMinute = minute();
  int lastHour = hour();
  setTime(newTime);
  if (((second() != lastSecond) || (minute() != lastMinute) || (hour() != lastHour)) || showTime)
  {
    DEBUG_PRINTLN(F("Clock updated...."));
    DEBUG_PRINT(F("Sensor's time currently set to:"));
    DEBUG_PRINT(hourFormat12() < 10 ? F(" 0") : F(" "));
    DEBUG_PRINT(hourFormat12());
    DEBUG_PRINT(minute() < 10 ? F(":0") : F(":"));
    DEBUG_PRINT(minute());
    DEBUG_PRINTLN(isAM() ? F("am") : F("pm"));
    DEBUG_PRINT(month());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINT(day());
    DEBUG_PRINT(F("/"));
    DEBUG_PRINTLN(year());
    DEBUG_PRINTLN(dayOfWeek[weekday()]);
    showTime = false;
  }
  else
  {
    DEBUG_PRINTLN(F("Sensor's time did NOT need adjustment greater than 1 second."));
  }
  clockUpdating = false;
}
void fastClear()
{
  lcd.setCursor(0, 0);
  lcd.print(F("                "));
  lcd.setCursor(0, 1);
  lcd.print(F("                "));
}
//
void updateClock()
{
  static unsigned long lastVeraGetTime;
  if (millis() - lastVeraGetTime >= 3600000UL) // updates clock time and gets zone times from vera once every hour
  {
    DEBUG_PRINTLN(F("Requesting time and valve data from Gateway..."));
    lcd.setCursor(15, 0);
    lcd.write(byte(0));
    clockUpdating = true;
    requestTime();
    lastVeraGetTime = millis();
  }
}
//
void saveDateToEEPROM(unsigned long theDate)
{
  DEBUG_PRINTLN(F("Saving Last Run date"));
  if (loadState(0) != 0xFF)
  {
    saveState(0, 0xFF); // EEPROM flag for last date saved stored in EEPROM (location zero)
  }
  //
  for (int i = 1; i < 5; i++)
  {
    saveState(5 - i, byte(theDate >> 8 * (i - 1))); // store epoch datestamp in 4 bytes of EEPROM starting in location one
  }
}
//
void goGetValveTimes()
{
  static unsigned long valveUpdateTime;
  static byte valveIndex = 1;
  if (inSetup || millis() - valveUpdateTime >= VALVE_TIMES_RELOAD / NUMBER_OF_VALVES) // update each valve once every 5 mins (distributes the traffic)
  {
    if (inSetup) {
      lcd.print(F(" Updating  "));
      lcd.setCursor(0, 1);
      lcd.print(F(" Valve Data: "));
      lcd.print(valveIndex);
    }
    bool flashIcon = false;
    DEBUG_PRINT(F("Calling for Valve "));
    DEBUG_PRINT(valveIndex);
    DEBUG_PRINTLN(F(" Data..."));
    for (int a = 0; a < (sizeof(allVars)/sizeof(int)); a++) {
      receivedInitialValue = false;
      byte timeout = 10;
      while (!receivedInitialValue && timeout > 0)
      {
        lcd.setCursor(15, 0);
        flashIcon = !flashIcon;
        flashIcon ? lcd.write(byte(1)) : lcd.print(F(" "));
        request(valveIndex, allVars[a]);
        wait(50);
        timeout--;
      }
    }
    valveUpdateTime = millis();
    valveIndex++;
    if (valveIndex > NUMBER_OF_VALVES)
    {
      valveIndex = 1;
    }
  }
}

As always, any help is appreciated.

BulldogLowell

@dbemowsk

what's happening in the Serial debug?

dbemowsk

I'll look later and report. Got company at the moment. The odd thing is that I can turn my zones on and they seem to run for the specified time just fine. It's only what I see on the display that is messed up.

Black Cat

I've just started playing with a Z-Uno and was looking at ways to use for a project like this.
I'm a believer in not re-inventing the wheel and it seem that all I would need to do is to delete the radio and re-code the sketch for the extra relays ( I have already built a 4 channel relay, it's just getting over the hurdle of learning about Shift Registers).
Do you think this is possible or would I be better just starting from scratch?

BulldogLowell

@Black-Cat said in Irrigation Controller (up to 16 valves with Shift Registers):

Z-Uno

wicked cool...

I'm in North America, so I have to stand by!

You you should be able to easily port this for use with Z-Uno...

BulldogLowell

@dbemowsk

yes, weird...

Topdawg2881

@dbemowsk
I had this same issue. What I did to fix the issue was I commented out in the void loop the line to goGetValveTimes. I then added the timeAlarms library and set a timer to get valve times once every five minutes. The section of code looks like this. Alarm.timerRepeat (300,goGetValveTimes);
I inserted that line as the last line of cade in the void setup

dbemowsk

Okay, so I was just looking over the code. I first did a search for "Valve Data:" as that was what was showing on the screen. I found that in the goGetValveTimes() method. According to the code, that is only supposed to show if the inSetup variable evaluates to true. I then searched on that variable, and in the code just before the setup() method, I see this:

bool inSetup = true;

But I don't see anywhere in the code where it sets that value to false. So every time the main loop() calls goGetValveTimes();, it is going to display that since inSetup never gets changed to false. At the very end of the setup routine I see this bit of code:

//
  //Update valve data when first powered on 
  for (byte i = 1; i <= NUMBER_OF_VALVES; i++)
  {
    lcd.clear();
    goGetValveTimes();
  }
  lcd.clear();

I think that it is just after that for loop, or after the lcd.clear(); that it is supposed to set inSetup to false. I have not tested this theory yet as I need to unmount my controller and open it up to push the new code to it, but I am pretty sure that this is the issue. That would explain why everything else with it appears to work normally.

I double checked with the example code on the build page to see if possibly I may have deleted something when doing my edits. Looking it over, I found the same thing. If you ask me, this looks to be a bug in the code and it should be fixed and updated.

Topdawg2881

@dbemowsk
I am in front of my computer and I have my controller in front of me and hooked up. Give me a couple minutes and I will run it. See what happens.

dbemowsk

I just made the change and tested it. That was definitely the problem. Works perfect now.

Not sure who can change the example code, but all that needs to be added is this:

//
  //Update valve data when first powered on 
  for (byte i = 1; i <= NUMBER_OF_VALVES; i++)
  {
    lcd.clear();
    goGetValveTimes();
  }
  lcd.clear();
  //Add this line
  inSetup = false;

Topdawg2881

@dbemowsk
You beat me too it. I added the same line in same location and it works perfect. Every so often I see the raindrop icon to show that it is pulling data to update the valve times.

dbemowsk

So it is definitely a confirmed bug. I ended up finding some old sample code from when I started this last year and this bit of code was actually in the setup method and not in goGetValveTimes:

      lcd.print(F(" Updating  "));
      lcd.setCursor(0, 1);
      lcd.print(F(" Valve Data: "));
      lcd.print(valveIndex);

So some time in the past year the sample code had been changed.

BulldogLowell

@dbemowsk

good to see you found it. I haven't looked at the code for two years, and mine is still working. (@petewill 's demo worked well too). there must have been some change that managed its way into the source

maybe look on GitHub and do a pull request if you the problem is there...

tombstone

Hi I just order all the parts that was listed. Do I need to read the 230 post or it's ok just watched the video.

dbemowsk

@tombstone You shouldn't need to read all the posts. Maybe just search the thread if you run into any snags. What kind of setup are you dropping this into? Do you currently have valves installed? Does your setup have a master valve or pump relay? Is it a standard 24V AC system?

tombstone

Ok I read it all. Just want to start with the basic then change to pH reader soil reader water reader rain detector.

tombstone

It's really hard to work out what's good post over bad post. Lol

tombstone

Its my 1st project and I have learnt alot but have got myself a snag and I am getting this....

Arduino: 1.8.3 (Windows 10), Board: "Arduino Pro or Pro Mini, ATmega328 (5V, 16 MHz)"

C:\Users\HTPC\Documents\Arduino\Irrigation_Controller_1\Irrigation_Controller_1..ino:82:21: fatal error: TimeLib.h: No such file or directory

#include <TimeLib.h>

compilation terminated.

exit status 1
Error compiling for board Arduino Pro or Pro Mini.

gohan

go to library manager and install Time library

tombstone

This post is deleted!

tombstone

This post is deleted!

tombstone

This post is deleted!

tombstone

This post is deleted!

tombstone

ok I almost there but my pro mini has just Analog 1 to 3. I say I have to change the coda were abouts...
I also have not setup up my Vera Controller as I see you have to pay...

Is there another one that is eazy as I have try some but can not get it to work. eg HomeGenie is download and on my pc but don't think its not to good. don't know how to find my pro mini. happy to chagaen to someing eazer to get me started thanks guys....

tombstone

Domoticz LOOKS GOOD
BUT new to all this

Black Cat

If you are looking for Software, try openhab.

You need to buy Vera, but the software is free.

tombstone

@Black-Cat thanks

tombstone

ok so when adding to Domoticz..
I go to hardware...
I name is..... test...
then choose.. MySensors Gateway with LAN interface....
Data Timeout: .... Disabled.....
Remote Address.... (I have tryed)....

IP Address, Subnet Mask, Default Gateway, Primary DNS, Secondary DNS.

(i try everythinbg I can think of and still not work)

Port: ... 5003
My pro min has the red light on and blink blue occassionally.

what I get from the Domoticz log is



2017-07-30 18:00:00.627 Error: MySensors: Can not connect to: 61.9.211.33:5003
2017-07-30 18:00:00.627 TCP: Connection problem (Unable to connect to specified IP/Port)
2017-07-30 18:00:00.627 TCP: Reconnecting in 30 seconds...
'''

tbowmo

@tombstone

What hardware are you using for the gateway? Arduino, Sensebender GW, ESP8266, is it wired or wireless?

Does it get an IP address from your router?

Can you successfully telnet to the above IP address on port 5003? (And what is the output)

Does the gateway send any logs to the serial port? If yes, then post them on the forum.

tombstone

@tbowmo
The hardware I'am using for the gateway is the Arduino pro mini and its wireless from the NRF24L01+ 2.4GHz Wireless Transceiver

I don't know if it is getting IP address from my router.

have not use telnet before (I have just youtube it and enabled it... all what i got from youtube was that you can send email lol cool)

Does the gateway send any logs to the serial port? If yes, then post them on the forum. (were do I get them logs the ones from Domoticz and below but not much info to go on)

Thanks

tbowmo

@tombstone

How is the promini connected to the device runnning domoticz?

To me it sounds like that you have the promini connected directly to your computer where domoticz is running, then you should add it as a serial gateway, and not ethernet gateway

If you haven't already done this, I suggest that you read about the mysensors network so you have a basic understanding on how mysensors works.

tombstone

@tbowmo
I have it runing both ways but with serial gateway there no errors but when going to setup there is no NODES.

2017-07-30 19:20:55.764 TCP: Connection problem (Unable to connect to specified IP/Port)
2017-07-30 19:20:55.766 TCP: Reconnecting in 30 seconds...
2017-07-30 19:21:26.035 TCP: Reconnecting...
2017-07-30 19:21:37.093 MySensors: TCP/IP Worker stopped...
2017-07-30 19:27:03.150 MySensors: Using serial port: COM4

tombstone

@tombstone

//#define MY_NODE_ID 1  // Set this to fix your Radio ID or use Auto

IS there someing I have missed with adding NODES???

tombstone

0 MCO:BGN:INIT NODE,CP=RNNNA--,VER=2.1.1
3 TSM:INIT
4 TSF:WUR:MS=0
11 TSM:INIT:TSP OK
13 TSM:FPAR
15 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
2022 !TSM:FPAR:NO REPLY
2024 TSM:FPAR
2026 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
4034 !TSM:FPAR:NO REPLY
4036 TSM:FPAR
4038 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
6046 !TSM:FPAR:NO REPLY
6048 TSM:FPAR
6050 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
8058 !TSM:FPAR:FAIL
8059 TSM:FAIL:CNT=1
8061 TSM:FAIL:PDT
18065 TSM:FAIL:RE-INIT
18067 TSM:INIT
18074 TSM:INIT:TSP OK
18076 TSM:FPAR
18078 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
20086 !TSM:FPAR:NO REPLY
20088 TSM:FPAR
20090 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
22099 !TSM:FPAR:NO REPLY
22102 TSM:FPAR
22104 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
24112 !TSM:FPAR:NO REPLY
24114 TSM:FPAR
24116 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
26124 !TSM:FPAR:FAIL
26125 TSM:FAIL:CNT=2
26127 TSM:FAIL:PDT
36130 TSM:FAIL:RE-INIT
36132 TSM:INIT
36140 TSM:INIT:TSP OK
36142 TSM:FPAR
36144 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
38152 !TSM:FPAR:NO REPLY
38154 TSM:FPAR
38156 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
40164 !TSM:FPAR:NO REPLY
40166 TSM:FPAR
40168 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
42176 !TSM:FPAR:NO REPLY
42178 TSM:FPAR
42180 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
44188 !TSM:FPAR:FAIL
44189 TSM:FAIL:CNT=3
44191 TSM:FAIL:PDT
54194 TSM:FAIL:RE-INIT
54196 TSM:INIT
54203 TSM:INIT:TSP OK
54205 TSM:FPAR
54207 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
56215 !TSM:FPAR:NO REPLY
56217 TSM:FPAR
56219 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
58227 !TSM:FPAR:NO REPLY
58229 TSM:FPAR
58231 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
60239 !TSM:FPAR:NO REPLY
60241 TSM:FPAR
60243 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
62252 !TSM:FPAR:FAIL
62254 TSM:FAIL:CNT=4
62255 TSM:FAIL:PDT
72258 TSM:FAIL:RE-INIT
72260 TSM:INIT
72267 TSM:INIT:TSP OK
72269 TSM:FPAR
72271 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
74280 !TSM:FPAR:NO REPLY
74283 TSM:FPAR
74285 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
76293 !TSM:FPAR:NO REPLY
76295 TSM:FPAR
76297 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
78305 !TSM:FPAR:NO REPLY
78307 TSM:FPAR
78309 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
80317 !TSM:FPAR:FAIL
80318 TSM:FAIL:CNT=5
80320 TSM:FAIL:PDT
90323 TSM:FAIL:RE-INIT
90326 TSM:INIT
90333 TSM:INIT:TSP OK
90335 TSM:FPAR
90337 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
92345 !TSM:FPAR:NO REPLY
92347 TSM:FPAR
92349 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
94357 !TSM:FPAR:NO REPLY
94359 TSM:FPAR
94361 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
96369 !TSM:FPAR:NO REPLY
96371 TSM:FPAR
96373 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
98381 !TSM:FPAR:FAIL
98383 TSM:FAIL:CNT=6
98384 TSM:FAIL:PDT
108387 TSM:FAIL:RE-INIT
108389 TSM:INIT
108396 TSM:INIT:TSP OK
108398 TSM:FPAR
108401 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
110408 !TSM:FPAR:NO REPLY
110410 TSM:FPAR
110413 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
112420 !TSM:FPAR:NO REPLY
112422 TSM:FPAR
112425 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
114433 !TSM:FPAR:NO REPLY
114435 TSM:FPAR
114438 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
116445 !TSM:FPAR:FAIL
116447 TSM:FAIL:CNT=7
116449 TSM:FAIL:PDT

This is my debug log. will like to know if there some thing I missed as I learning thanks

tbowmo

@tombstone

Just to be sure, you have one pro mini with NRF24 working as a gateway, connected to your computer?

And then you have one (or more) pro minis also with NRF24, acting as nodes?

gohan

@tombstone said in Irrigation Controller (up to 16 valves with Shift Registers):

@tombstone
//#define MY_NODE_ID 1  // Set this to fix your Radio ID or use Auto
IS there someing I have missed with adding NODES???

yuo need to uncomment that line

tbowmo

@gohan

Only if he won't use auto id assignment from domoticz.

tombstone

@tbowmo
I habe one pro mini with NRF24 and, connected to my computer. I have done everything from the video up too 22mins were I got stuck.

tombstone

@tbowmo
Do the debug log. Look normal.. don't know how to read.

0 MCO:BGN:INIT NODE,CP=RNNNA--,VER=2.1.1
3 TSM:INIT
4 TSF:WUR:MS=0
11 TSM:INIT:TSP OK
13 TSM:FPAR
15 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
2022 !TSM:FPAR:NO REPLY
2024 TSM:FPAR
2026 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
4034 !TSM:FPAR:NO REPLY
4036 TSM:FPAR
4038 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
6046 !TSM:FPAR:NO REPLY
6048 TSM:FPAR
6050 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
8058 !TSM:FPAR:FAIL
8059 TSM:FAIL:CNT=1
8061 TSM:FAIL:PDT
18065 TSM:FAIL:RE-INIT
18067 TSM:INIT
18074 TSM:INIT:TSP OK
18076 TSM:FPAR
18078 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
20086 !TSM:FPAR:NO REPLY
20088 TSM:FPAR
20090 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
22099 !TSM:FPAR:NO REPLY
22102 TSM:FPAR
22104 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
24112 !TSM:FPAR:NO REPLY
24114 TSM:FPAR
24116 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
26124 !TSM:FPAR:FAIL
26125 TSM:FAIL:CNT=2
26127 TSM:FAIL:PDT
36130 TSM:FAIL:RE-INIT
36132 TSM:INIT
36140 TSM:INIT:TSP OK
36142 TSM:FPAR
36144 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
38152 !TSM:FPAR:NO REPLY
38154 TSM:FPAR
38156 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
40164 !TSM:FPAR:NO REPLY
40166 TSM:FPAR
40168 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
42176 !TSM:FPAR:NO REPLY
42178 TSM:FPAR
42180 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
44188 !TSM:FPAR:FAIL
44189 TSM:FAIL:CNT=3
44191 TSM:FAIL:PDT
54194 TSM:FAIL:RE-INIT
54196 TSM:INIT
54203 TSM:INIT:TSP OK
54205 TSM:FPAR
54207 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
56215 !TSM:FPAR:NO REPLY
56217 TSM:FPAR
56219 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
58227 !TSM:FPAR:NO REPLY
58229 TSM:FPAR
58231 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
60239 !TSM:FPAR:NO REPLY
60241 TSM:FPAR
60243 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
62252 !TSM:FPAR:FAIL
62254 TSM:FAIL:CNT=4
62255 TSM:FAIL:PDT
72258 TSM:FAIL:RE-INIT
72260 TSM:INIT
72267 TSM:INIT:TSP OK
72269 TSM:FPAR
72271 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
74280 !TSM:FPAR:NO REPLY
74283 TSM:FPAR
74285 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
76293 !TSM:FPAR:NO REPLY
76295 TSM:FPAR
76297 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
78305 !TSM:FPAR:NO REPLY
78307 TSM:FPAR
78309 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
80317 !TSM:FPAR:FAIL
80318 TSM:FAIL:CNT=5
80320 TSM:FAIL:PDT
90323 TSM:FAIL:RE-INIT
90326 TSM:INIT
90333 TSM:INIT:TSP OK
90335 TSM:FPAR
90337 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
92345 !TSM:FPAR:NO REPLY
92347 TSM:FPAR
92349 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
94357 !TSM:FPAR:NO REPLY
94359 TSM:FPAR
94361 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
96369 !TSM:FPAR:NO REPLY
96371 TSM:FPAR
96373 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
98381 !TSM:FPAR:FAIL
98383 TSM:FAIL:CNT=6
98384 TSM:FAIL:PDT
108387 TSM:FAIL:RE-INIT
108389 TSM:INIT
108396 TSM:INIT:TSP OK
108398 TSM:FPAR
108401 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
110408 !TSM:FPAR:NO REPLY
110410 TSM:FPAR
110413 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
112420 !TSM:FPAR:NO REPLY
112422 TSM:FPAR
112425 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
114433 !TSM:FPAR:NO REPLY
114435 TSM:FPAR
114438 TSF:MSG:SEND,255-255-255-255,s=255,c=3,t=7,pt=0,l=0,sg=0,ft=0,st=OK:
116445 !TSM:FPAR:FAIL
116447 TSM:FAIL:CNT=7
116449 TSM:FAIL:PDT

there alot of failing

tbowmo

@tombstone

It seems that you have not read up on how mysensors works.. The purpose of mysensors is to create wireless sensors. To do this, we normally have a gateway connected to a computer running some kind of controller software.

Then we have sensor nodes that transmit (wireless) sensor data to the gateway which sends this to the controller software.

Again, please read up on how mysensors are designed, find more here https://www.mysensors.org/about

tombstone

@tbowmo
can you tell me if I got this wrong

The "brain" is my pro min
"The radio" is nRF24
the brain (promiin) get and sends info to the (Radio)
the controller (my PC that is running Domoticz)" gets and send info to the radio.
That's how I get it after reading

tbowmo

But how are the radio connected to your pc then? that needs an arduino as well.

To have a functional mysensors network, you usually have 2 (or more) arduino compatible boards. One of thar m running SerialGateway (or another suitable sketch) with NRF24 connected. This connect to the computer running domoticz

Then you have all the sensor nodes, they are also running on arduino compatible hardware (but separate to the gateway hardware), also with radio connected. THIS is running your sensor sketches, and communicates with the gateway arduino via the NRF24 radios.

When the gateway receives messages on the NRF24, it sends these via UART to the computer at which you are running domoticz (or any other suitable controller software).

gohan

@tbowmo according to the log nothing is assigning any ID

mfalkvidd

@gohan where do you see that? I can't see anything in the log about id assignment.

gohan

255-255-255-255 isn't it sent when asking for ID?

mfalkvidd

@gohan yes, but also when asking for parent (as indicated by TSM:FPAR). Id-related messages are indicated by TSM:ID.

tombstone

I feel so stupid thought the first video that Pete made serial gateway was just the wiring your your radio up for the irrigation.

Grubstake

@tbowmo said in Irrigation Controller (up to 16 valves with Shift Registers):

It seems that you have not read up on how mysensors works.. The purpose of mysensors is to create wireless sensors. To do this, we normally have a gateway connected to a computer running some kind of controller software.

Then we have sensor nodes that transmit (wireless) sensor data to the gateway which sends this to the controller software.

Again, please read up on how mysensors are designed, find more here https://www.mysensors.org/about

Hi Thomas,

You have hit on a point that I see over and over here, and that I shared with @tombstone for a long time before I was able to get a successful MySensors node working. (And I've worked with electronics and tech much of my life.)

Understanding the key components and how they fit together is essential for newcomers to MySensors, and is not very complex, but the information is widely scattered and completely missing from the the top level of the website. This discourages newcomers and creates endless questions on the forums as it is quite difficult to get anything working without many hours of reading and experimenting.

There is no obvious place on the website that explains the big picture as well as your last message! Newcomers to MySensors do not benefit from a clear simple picture of sensor nodes, gateways, and controllers and how they fit together.

The Getting Started page does not mention controllers at all. And it's NOT as easy as 1, 2, 3!
The Controller page does not describe the basic purpose of a controller, or how it connects to gateways and nodes. It's a useful advanced comparison of controller details, not beginner content.
The Build page mentions some of the key components but again not how they fit together. (Nor is it about 'building'.)
The Hardware doesn't really talk about the hardware.

(I'm sure there is much of this elsewhere on the website, but its not easy to find from the obvious links.)

It would be hugely helpful if Getting Started was an actual detailed overview of MySensors diagramming examples of complete end-to-end systems.

sensor->arduino+radio node---->arduino+radio gateway->controller (Domoticz etc).
sensor->gateware/node software->ESP8266 wifi->controller (no 'radio')
etc.

Gateways are difficult to understand at the beginning as there are so many different ones and the Gateway names don't help...some are named by a single transport protocol (i.e. MQTT) some for an interface (Serial) some for a hardware platform (ESP8266), etc. I'm sure this seems obvious to lifelong engineers/developers but not so much for regular hobby geeks like many hobbyists.

I'm impressed with the work that has gone into MySensors and am grateful for all the hard work by the many developers and users who have contributed to it. I don't mean my comments to be a complaint. Presenting technical systems to often less technical newcomer/users is a challenging area. Improving the first impression of the big picture to newcomers would be a huge move forward.

Tim

tombstone

@Grubstake
I was think of writing a post or making a video (like Pete) for the beginner's. Just an add-on of his work. Not saying his video are not good just saying I like to make more.... Aftrr I know how everything works. Not off on a good start but I get there.

gohan

@Grubstake I think you missed the page https://www.mysensors.org/about/network
IMHO mysensors made it "easy" to create a sensors network but it can't teach you the basics of arduino programming, I have already told many newbies that first they need to learn with the tutorials and simple exercises otherwise they would have no idea where to look for problems that they will face. Learning how to debug it's as hard as learning to program and in a complex environment like a sensors network it is very easy to get lost.

tombstone

@Grubstake still may have a pont if there's been overs. Not saying we right or your right. But learning is a difficult thing. So is teaching. That's good that we have lots of open source site and when we get stuck members step ins and give a hand.

tombstone

Thanks guys now I understand, felling stupid but it was like a mind blank as was thinking it worked another way.

Can some one point me to the a link (error sending switch command check device/hardware) this comes up when turning on lights on the irrigation controller.

I find this but it didn't makes sense. https://forum.mysensors.org/topic/2553/error-sending-switch-command-check-device-hardware

Sergio Rius

@tbowmo If I can give an opinion, if we want to reach the newcomers, we must start to think on a integrated solution for burning mcus without programming knowledge. I'm also a software architect and my father caught me on electronics, but this is a public project and will also reach people without knowledge.
NodeManager is a great jump on that direction and now we miss a small utility for computers.
And signing+encryption is a problem here.

Anticimex

@Sergio-Rius why is signing and encryption a problem? We have a simplified option that enables both using a single define. It can't be made simpler than that without making it enabled by default and then with a common PSK which is pointless. Although still only available in beta it will soon be released.
If you find that too complex, I am all ears for improvement suggestions.

Sergio Rius

@Anticimex Sorry, but I don't follow the development code on a day basis, I was not aware of this feature.
Anyways, a common psk will be like grease. Any psk would be better than no-one.

Let me explain: I was thinking on a small Pc program that you can select options (NodeManager) and then burn the chip by a click of a button. But also crossed my mind the possibility that a user, with a running secure network, wanted to get a sensebender gateway already programmed. It would be no use.

I was thinking on a way of "programming the crypto chip" separately from the cpu program. I don't know if it clearer now or I made it worse.

gohan

@Sergio-Rius there is also a project to integrate NodeManager with a web page to really mask all the code behind to the user.

Anticimex

@Sergio-Rius I am still a bit confused.
A default PSK would be the same for everyone so how is that better than no one?
Also, nrf24 radios have problem with full size payloads so enabling signing by default would give some users radio problems by default as well. It is not a problem with signing, it is a problem with the radio.

Anticimex

@Sergio-Rius the crypto chip (I prefer the term authentication chip as it does not do cryptography) is connected to the MCU so you need a program on the MCU to program the chip in one way or another. Lest you program the chip before soldering it to the board. And I think the personalization procedure (improved in beta) is documented and simplified enough so that having a separate pc program and do off board programming of the chip would be a far more complicated procedure for "non programmers".

gohan

@Anticimex I'd add that encryption and signing are more advanced features and should be dealt once newbies get used to the mysensors framework and after they get used to how to debug, otherwise it would also add too much complexity

Anticimex

@gohan it is, but it is documented enough so that it should be available to everyone. Obviously that implies people actually read the documentation

tombstone

Guys if you look I been on here for about a year so yes I been reading alot before I started to build. An been look at YouTube video about code and all this.
I have given up on this one for now and I got an pre build one from a another site he have an set by set with networks and so on. I be back later. After I get openhab and MQTT worked out. As I going to be using esp8266 and the MQTT.

Newzwaver

Hi

Having some issues with the sketch compiling, I am using the 1.84 arduino and the latest libraries 2.1.1 mysensors. I have not made any changes to the sketch at all. Debug is remarked out.

Any help or guidance would be greatly appreciated .

Arduino: 1.8.4 (Windows 10), Board: "Arduino Pro or Pro Mini, ATmega328P (5V, 16 MHz)"

In file included from C:\Users\Audrey\AppData\Local\Temp\arduino_modified_sketch_110779\IrrigationController.ino:95:0:

C:\Users\Audrey\Documents\Arduino\libraries\MySensors/MySensors.h:328:2: error: #error No forward link or gateway feature activated. This means nowhere to send messages! Pretty pointless.

#error No forward link or gateway feature activated. This means nowhere to send messages! Pretty pointless.

^

C:\Users\Audrey\AppData\Local\Temp\arduino_modified_sketch_110779\IrrigationController.ino:99:31: fatal error: LiquidCrystal_I2C.h: No such file or directory

#include <LiquidCrystal_I2C.h>

compilation terminated.

exit status 1
Error compiling for board Arduino Pro or Pro Mini.

This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

dbemowsk

@Newzwaver
First, the "error No forward link or gateway feature activated. This means nowhere to send messages! Pretty pointless."
this means that you most likely don't have a radio or other gateway connection type defined. Basically you need to tell it how it is going to communicate to your controller and/or other devices. You need to remove the // from one of the options.

/ Enable and select radio type attached
//#define MY_RADIO_NRF24
//#define MY_RADIO_RFM69
//#define MY_RS485

Next, do you have the LiquidCrystal library installed? If so, is it the correct one? My guess is that it isn't since it cannot find the LiquidCrystal_I2C.h file. You should get the one from GitHub. Start there and let us know what happens.

eric

Hello,

Has anybody succeeded in adapting Irrigation Controller to OpenHAB2?

Although a long time experienced programmer, I am new to domotic and begining to explore the subject. OpenHAB seems to be a nicely architectured software, and well documented. The bindings for MySensors define a number of devices types. Which one would be the best choice in that case? How could the Irrigation Controller sketch be adaptated? Is it possible to add V_VAR1..3 to light thing type?

Thank you for your help.

eric

I'm replying to myself. After reading OpenHAB doc, I managed to have all functionnalities working without changing the Irrigation Controller code.
I cannot put the whole howto here, but basically I created .things and .items files listed here. In addition, I installed the MySensor gateway on the same Raspberry Pi as OpenHAB, connected as an Ethernet gateway. I also installed MapDB persistence, as explained in the documentation.

/etc/openhab2/things/house.things

Bridge mysensors:bridge-eth:gateway [ ipAddress="127.0.0.1", tcpPort=5003, sendDelay=200 ] {
        light           all_zones       "Toutes zones"  [ nodeId=1, childId=0 ]
        rgbLight        zone1           "Zone 1"        [ nodeId=1, childId=1 ]
        rgbLight        zone2           "Zone 2"        [ nodeId=1, childId=2 ]
        rgbLight        zone3           "Zone 3"        [ nodeId=1, childId=3 ]
        rgbLight        zone4           "Zone 4"        [ nodeId=1, childId=4 ]
        rgbLight        zone5           "Zone 5"        [ nodeId=1, childId=5 ]
        rgbLight        zone6           "Zone 6"        [ nodeId=1, childId=6 ]
        rgbLight        zone7           "Zone 7"        [ nodeId=1, childId=7 ]
        rgbLight        zone8           "Zone 8"        [ nodeId=1, childId=8 ]
  }

/etc/openhab2/items/house.items

Group House
Group Irrigation        <water> (House)
Group AllZones          <water> (Irrigation)
Group Zone1             <water> (Irrigation)
Group Zone2             <water> (Irrigation)
Group Zone3             <water> (Irrigation)
Group Zone4             <water> (Irrigation)
Group Zone5             <water> (Irrigation)
Group Zone6             <water> (Irrigation)
Group Zone7             <water> (Irrigation)
Group Zone8             <water> (Irrigation)
Switch  zone0_s "On/Off"                (AllZones)      { channel="mysensors:light:gateway:all_zones:status" }
Switch  zone1_s "On/Off"                        (Zone1)         { channel="mysensors:rgbLight:gateway:zone1:status" }
Number  zone1_1 "Temps toutes zones [%d mn]"    (Zone1)         { channel="mysensors:rgbLight:gateway:zone1:var1" }
Number  zone1_2 "Temps individuel [%d mn]"      (Zone1)         { channel="mysensors:rgbLight:gateway:zone1:var2" }
String  zone1_3 "Nom [%s]"                      (Zone1)         { channel="mysensors:rgbLight:gateway:zone1:var3" }
Switch  zone2_s "On/Off"                        (Zone2)         { channel="mysensors:rgbLight:gateway:zone2:status" }
Number  zone2_1 "Temps toutes zones [%d mn]"    (Zone2)         { channel="mysensors:rgbLight:gateway:zone2:var1" }
Number  zone2_2 "Temps individuel [%d mn]"      (Zone2)         { channel="mysensors:rgbLight:gateway:zone2:var2" }
String  zone2_3 "Nom [%s]"                      (Zone2)         { channel="mysensors:rgbLight:gateway:zone2:var3" }
Switch  zone3_s "On/Off"                        (Zone3)         { channel="mysensors:rgbLight:gateway:zone3:status" }
Number  zone3_1 "Temps toutes zones [%d mn]"    (Zone3)         { channel="mysensors:rgbLight:gateway:zone3:var1" }
Number  zone3_2 "Temps individuel [%d mn]"      (Zone3)         { channel="mysensors:rgbLight:gateway:zone3:var2" }
String  zone3_3 "Nom [%s]"                      (Zone3)         { channel="mysensors:rgbLight:gateway:zone3:var3" }
Switch  zone4_s "On/Off"                        (Zone4)         { channel="mysensors:rgbLight:gateway:zone4:status" }
Number  zone4_1 "Temps toutes zones [%d mn]"    (Zone4)         { channel="mysensors:rgbLight:gateway:zone4:var1" }
Number  zone4_2 "Temps individuel [%d mn]"      (Zone4)         { channel="mysensors:rgbLight:gateway:zone4:var2" }
String  zone4_3 "Nom [%s]"                      (Zone4)         { channel="mysensors:rgbLight:gateway:zone4:var3" }
Switch  zone5_s "On/Off"                        (Zone5)         { channel="mysensors:rgbLight:gateway:zone5:status" }
Number  zone5_1 "Temps toutes zones [%d mn]"    (Zone5)         { channel="mysensors:rgbLight:gateway:zone5:var1" }
Number  zone5_2 "Temps individuel [%d mn]"      (Zone5)         { channel="mysensors:rgbLight:gateway:zone5:var2" }
String  zone5_3 "Nom [%s]"                      (Zone5)         { channel="mysensors:rgbLight:gateway:zone5:var3" }
Switch  zone6_s "On/Off"                        (Zone6)         { channel="mysensors:rgbLight:gateway:zone6:status" }
Number  zone6_1 "Temps toutes zones [%d mn]"    (Zone6)         { channel="mysensors:rgbLight:gateway:zone6:var1" }
Number  zone6_2 "Temps individuel [%d mn]"      (Zone6)         { channel="mysensors:rgbLight:gateway:zone6:var2" }
String  zone6_3 "Nom [%s]"                      (Zone6)         { channel="mysensors:rgbLight:gateway:zone6:var3" }
Switch  zone7_s "On/Off"                        (Zone7)         { channel="mysensors:rgbLight:gateway:zone7:status" }
Number  zone7_1 "Temps toutes zones [%d mn]"    (Zone7)         { channel="mysensors:rgbLight:gateway:zone7:var1" }
Number  zone7_2 "Temps individuel [%d mn]"      (Zone7)         { channel="mysensors:rgbLight:gateway:zone7:var2" }
String  zone7_3 "Nom [%s]"                      (Zone7)         { channel="mysensors:rgbLight:gateway:zone7:var3" }
Switch  zone8_s "On/Off"                        (Zone8)         { channel="mysensors:rgbLight:gateway:zone8:status" }
Number  zone8_1 "Temps toutes zones [%d mn]"    (Zone8)         { channel="mysensors:rgbLight:gateway:zone8:var1" }
Number  zone8_2 "Temps individuel [%d mn]"      (Zone8)         { channel="mysensors:rgbLight:gateway:zone8:var2" }
String  zone8_3 "Nom [%s]"

Note the "trick" is to use rgbLight item type instead of light item type, to have Var1..3 available. Look here: https://github.com/tobof/openhab2-addons/blob/MySensors_Binding/addons/binding/org.openhab.binding.mysensors/ESH-INF/thing/thing-types.xml

Now I have a fully fonctionnal Irrigation Controller, all integrated with OpenHAB

Spanners

Hi All,

Does anyone have a schematic/wiring diagram for this (especially the shift register)?

I may be too old, but the Fritzing image on the build page isn't clear to me.

Irrigation Controller (up to 16 valves with Shift Registers)

Suggested Topics

Welcome
Announcements • • hek

Auxiliary Loads and Mains Charger Controller for my Smart Mobile Home
My Project • • fsgraz

nRF24Doctor
My Project • power consumption diagnose transmission delays compare modules radio quality doctor range gateway location nrf24 radio • • Technovation

Water Meter or "How to get Home Assistant to send saved data to an Arduino"
My Project • • OldSurferDude

Powering ESP8266 / NRF24L01 repeater through USB (improvement)
My Project • • Kokosnoot

A low cost energy meter
My Project • • OldSurferDude

12
Online

11.4k
Users

11.1k
Topics

112.7k
Posts

Irrigation Controller (up to 16 valves with Shift Registers)

Suggested Topics

Welcome Announcements • • hek

Auxiliary Loads and Mains Charger Controller for my Smart Mobile Home My Project • • fsgraz

nRF24Doctor My Project • power consumption diagnose transmission delays compare modules radio quality doctor range gateway location nrf24 radio • • Technovation

Water Meter or "How to get Home Assistant to send saved data to an Arduino" My Project • • OldSurferDude

Powering ESP8266 / NRF24L01 repeater through USB (improvement) My Project • • Kokosnoot

A low cost energy meter My Project • • OldSurferDude

12Online

11.4kUsers

11.1kTopics

112.7kPosts

Welcome
Announcements • • hek

Auxiliary Loads and Mains Charger Controller for my Smart Mobile Home
My Project • • fsgraz

nRF24Doctor
My Project • power consumption diagnose transmission delays compare modules radio quality doctor range gateway location nrf24 radio • • Technovation

Water Meter or "How to get Home Assistant to send saved data to an Arduino"
My Project • • OldSurferDude

Powering ESP8266 / NRF24L01 repeater through USB (improvement)
My Project • • Kokosnoot

A low cost energy meter
My Project • • OldSurferDude

12
Online

11.4k
Users

11.1k
Topics

112.7k
Posts